| Message ID | cf380b972333d56858b10d6dd61b6033d3782fce.1690355367.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [XEN] xen: use parameter name 'mcs' in arch_do_multicall_call() | expand |
On 26.07.2023 09:22, Federico Serafini wrote: > Make function declaration and definition consistent using the same > parameter name ('mcs' do denote a pointer to an 'mc_state'). > This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations of an > object or function shall use the same names and type qualifiers". > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > --- > xen/arch/arm/traps.c | 4 ++-- > xen/include/xen/multicall.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) What about x86'es function? Jan
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index d1ef787638..eab2fcfc02 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1470,9 +1470,9 @@ static bool check_multicall_32bit_clean(struct multicall_entry *multi) return true; } -enum mc_disposition arch_do_multicall_call(struct mc_state *state) +enum mc_disposition arch_do_multicall_call(struct mc_state *mcs) { - struct multicall_entry *multi = &state->call; + struct multicall_entry *multi = &mcs->call; if ( multi->op >= ARRAY_SIZE(hypercall_args) ) { diff --git a/xen/include/xen/multicall.h b/xen/include/xen/multicall.h index ac8238660a..5bebeca7b2 100644 --- a/xen/include/xen/multicall.h +++ b/xen/include/xen/multicall.h @@ -25,6 +25,6 @@ enum mc_disposition { mc_continue, mc_exit, mc_preempt, -} arch_do_multicall_call(struct mc_state *mc); +} arch_do_multicall_call(struct mc_state *mcs); #endif /* __XEN_MULTICALL_H__ */
Make function declaration and definition consistent using the same parameter name ('mcs' do denote a pointer to an 'mc_state'). This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations of an object or function shall use the same names and type qualifiers". Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/arm/traps.c | 4 ++-- xen/include/xen/multicall.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)