| Message ID | dee7168f9ce2c52c8db0c4d5d48394550592756f.1698045505.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86: address some violations of MISRA C:2012 Rule 8.2 | expand |
On 23.10.2023 09:23, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Acked-by: Jan Beulich <jbeulich@suse.com> Albeit I can't resist to say that ... > --- a/xen/arch/x86/physdev.c > +++ b/xen/arch/x86/physdev.c > @@ -18,9 +18,9 @@ > #include <xsm/xsm.h> > #include <asm/p2m.h> > > -int physdev_map_pirq(domid_t, int type, int *index, int *pirq_p, > - struct msi_info *); > -int physdev_unmap_pirq(domid_t, int pirq); > +int physdev_map_pirq(domid_t domid, int type, int *index, int *pirq_p, > + struct msi_info *msi); > +int physdev_unmap_pirq(domid_t domid, int pirq); ... this is a good example where adding names to the so far unnamed parameters adds no new useful information at all, as their types were already sufficient to express all that needs expressing here. Jan
diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c index 2f1d955a96..47c4da0af7 100644 --- a/xen/arch/x86/physdev.c +++ b/xen/arch/x86/physdev.c @@ -18,9 +18,9 @@ #include <xsm/xsm.h> #include <asm/p2m.h> -int physdev_map_pirq(domid_t, int type, int *index, int *pirq_p, - struct msi_info *); -int physdev_unmap_pirq(domid_t, int pirq); +int physdev_map_pirq(domid_t domid, int type, int *index, int *pirq_p, + struct msi_info *msi); +int physdev_unmap_pirq(domid_t domid, int pirq); #include "x86_64/mmconfig.h"
Add missing parameter names. No functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/x86/physdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)