From patchwork Tue Sep 5 09:01:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13374397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21809C83F33 for ; Tue, 5 Sep 2023 09:02:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.595483.929057 (Exim 4.92) (envelope-from ) id 1qdRwg-0006zM-NQ; Tue, 05 Sep 2023 09:02:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 595483.929057; Tue, 05 Sep 2023 09:02:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qdRwg-0006zF-JM; Tue, 05 Sep 2023 09:02:02 +0000 Received: by outflank-mailman (input) for mailman id 595483; Tue, 05 Sep 2023 09:02:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qdRwf-0006y5-4O for xen-devel@lists.xenproject.org; Tue, 05 Sep 2023 09:02:01 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7e1b::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dec9b868-4bca-11ee-9b0d-b553b5be7939; Tue, 05 Sep 2023 11:01:59 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8675.eurprd04.prod.outlook.com (2603:10a6:20b:42a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.33; Tue, 5 Sep 2023 09:01:56 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654%6]) with mapi id 15.20.6745.030; Tue, 5 Sep 2023 09:01:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dec9b868-4bca-11ee-9b0d-b553b5be7939 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e/DvZ9Ff6MgIHaEYIQD6S55FXNEmefzgiOZKlg0+/8jhW1BK+ItR67oXP/9A5QJNtATL4Ivtl6FKEcTYkwzaqZmed8HQuo3Hhwig896/8xhJHPcgaCgWpbyuioE3BF+4NX3C8AJQprhPEQW/5QyorVkGTbh0nDst/WBeSLfpgQZXeebMNwDyZK/2gLQbDa8H+il9cgEW2LKAXYODYz1A/k3meLtHcrHbi+pSWk8lexvumxeR4GiCADXZxkvwtGQnhoqQEVvjxTQqc9Qxhivhclhzhvs4YoX3LPrPkBY51M/UsqpFbhZfVvY4qpsfAZPWhnCMD2CNzgDfJd+cGjVFqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xg5KCu1n8KLFrYWgLwAidW+Hx8AYR9obGKSxceilEMU=; b=SRpwakU61TJX/jKk8oktQUEsHc1Ofns39Bh5KRzZY5P98dOKi8yQIbRS6DyxHcJginMnxL7r5G5TBFnQ57CgrDiWd8999bD1YT8k34uzIMrkOywCpHPbfjbCMC3aRgsj3ymkdK1wdv7ChQHV3PtNSTykKxr0+3KA3fy4Vk4pG1gFRF97V5jSLJBUuiEZEn3vr3l6XX6NZSm6PmeiaXgkde3NwbDiI9Ow0KPyXARL7IjlMccjtiCeSep55wqHpRfrnb4aldGxuGS1Nfzuk6Lhrezha3JNZ/SKHJ/39smvoRYtF/3rUuKNZWVU7l42fGwzeNrp4LF6K8yOHEjRgXg9Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xg5KCu1n8KLFrYWgLwAidW+Hx8AYR9obGKSxceilEMU=; b=zn7xz/hIbF57iOEDB4wdcdxnrGj4Ze4OVM7i8uMYKrTe37LyRhwh5iPyM5vQ0SArvDC4A175k0i/rsx6aFpbBVAYmi3/mwkzyBx0woVWlFx1Ez2uKKkjHE9vawbd0JNcN5k1jsvSnn2XgaTqRdKN7v82mIBYgpq4X+dfohG3UxVAl4fzOh0RvDye4TYlxWIPah8O3m/BZyFLu/4Jo9J3Myzhoqnu0d4WE9ISQrXnHzC95LxGP3GZjd6+E9X/SY8ufg64UZy2CGVSr6sc7Km6G1HsrGRlB2ZDeN9Wy4NQwton1DolfoargCmsmQf/dSQEVmeCAlYiYbMiTcUEjsIZSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Sep 2023 11:01:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH] x86/PV: don't use access_ok() in set_debugreg() X-ClientProxiedBy: FR0P281CA0229.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b2::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8675:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b619ba4-2d44-4e0f-b5f0-08dbadeec152 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mgNJyMFnRwBtRs/wZjHO0Z/mfZFY2KuJzPbnvSjywTHgrnjUVlSp2gLLnpUJTGn0WNhZxo4Bhs+JzUZ81/WW1VPI5Q1N20UHaCUiMpCWZID5JE/9bCjUBuZF4X3Pk3Irk7phuFbKMhvzZ2+v3K1r2OojdCg4kPGrU49ump1xKlvzfQy9AC3D2GasIGkgyxlKbcEIEW7xSiagl4qIrQXLo4I2tJfcxGy3+4PIkspDE7p6LHcUUrvPr0HW9kEO7lA9CHI/PfjccNOog+ERdpRaFD2BZq5nqnYz6djIE1R2QyWWklmNPhl6bpmUvX2idFxGSDvMb6QZZavnoWNC2aqnNv5T/+mgn9SHNSRFCSxTqKUl2g6pW+xPdqQhEWvrrkkhX+85RkbQHpXrQIquCSniXQt944y+3JjKL96/F7dvoXzuqxe8IKMkNVmDsOAnJ2uBFpymWny5qyy+Nuld3xrA6xPw2sa7Z9UVGMsWkDB7b9rosJIQ1wzAC9XicfqX5szlPMv+RmStEa4Bfj9f1fdYU1xwJDYQ1hG2lU6nd7pEMozGXKb4KbOtjK1jchowFD81nRsOcqoLN+iTSAA/1NVyaJWaSoSakO9G0nGSoD7y8UWxKHhiWYZZHtmwrvOm60ulqP+PYG5VCveSd3xlE8hc0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(376002)(396003)(136003)(366004)(1800799009)(451199024)(186009)(31686004)(5660300002)(8936002)(316002)(6916009)(66556008)(66476007)(54906003)(36756003)(2906002)(66946007)(8676002)(4326008)(66899024)(41300700001)(6486002)(6506007)(26005)(6512007)(38100700002)(478600001)(6666004)(2616005)(83380400001)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ujhhgvbbeXtIuypY3KL3E31wP7Ho?= =?utf-8?q?/XjRcwsvxF0mX9HdBn29QjYpW24u8IkXkEsAotFQIACV1xkUBnyedMJH07sWn97xF?= =?utf-8?q?VNcYobzdz/6IMHagLmL0zJCy75nXcJOjww8GklkLWOO1kWuz/wpCqcoaDZfPgQ4n7?= =?utf-8?q?QZeFJnspcxLY9M98YnA2G7DkHLv66Hpiyfpa3befzUEw2z/vIAH3jKr1d3ifBIrBY?= =?utf-8?q?15HIdLBwuLuxghams47yK3tByDXTflLdGb+PWRAOTtsVbjzXYIivDNrcWWFQYOIK6?= =?utf-8?q?pHt9TgqV+pz4dvPH6OCzdBFHYxME/UEzr0kUAEnan19zi/SqkNOJv911lPeriTJMf?= =?utf-8?q?/N/5Aocj2Si60xjM1gzDx2zvWaNFbkklLHUAMd2t3XiKDgMCgyFzliY8hqus6QtAR?= =?utf-8?q?cq6sTvnObDW+YqSHUaNvQKPrQJ0BjP5pk8gGsIVT2zgayXb2AEglMXF1ucm8v8mck?= =?utf-8?q?5DcGXO0f4RRsQKXXBCrn3LM8Bb8XgvxENE8wE9BfVa4kQ3XfYleSQLnGpp7VjITkb?= =?utf-8?q?QwPQXF4t5JH7h99/f1Z2HcuddryXPplYY3u03U/gCTh42J2pBe1OgXKGzWjzQAzey?= =?utf-8?q?N2E1FTi5CIPpqetFmZpk/PKh+aNOccyPshUkTi4WZtZDnjjVHQ/XNg03pLYOS4HLF?= =?utf-8?q?ui4WPP4qq5zkubKrntDIBUmfBEf1omPLXfWtpRuXY4vs3VJPJtZ11nPRowWF4/23z?= =?utf-8?q?WqWw5Uq6a8P+ItpbcxEL0opi6x0CNRqOF3eY9Wg9KLPxPqnDiP3mFmgcLa0HNrRcN?= =?utf-8?q?KqYEb9CH2+2qoRCG/txP7FyVvAQM0kl5F13v4vboSV+ldllPfjOSkwgv6CXdKGzQe?= =?utf-8?q?P5OAKRy433LdyA9fVjmOZdq3QN8UYyu1fUa0eJEnUYEgJsFSjG+N9n19afiDJsbG0?= =?utf-8?q?n/Pi6QkKBLLcwNbUTc6Mtj9WOGlPp2Ztzjdatt/MuBLAiSFUKEOeEiqXJLu75IJPv?= =?utf-8?q?KBX8gJaE3LVeuSLAF/pzeLvc4y4Fv5vjR16y2pJfHs+KPg1KCVi87eQTFiA9/p7cy?= =?utf-8?q?yLdKwHxd8NGayrZsOBhCXYcxXil4fQu7xrLXB2ZX2QQXEtHDw4GclTEqBwx7kFkam?= =?utf-8?q?NpaGkzE/RlVpo1ipA9ODAN26BWegunrpLl1nkJ5B4cydR/SSpi/HK/ICLO8abmsm7?= =?utf-8?q?M0Frfzufn2T0QH3cEstFxZh7rkP6t6V/Drxs2gucJnQED70/vrw/OLwcVRponPyCf?= =?utf-8?q?8IcqSLhh+v2AyWfWfkBK3BLDy4f7lHxSM/tPSuTU+cRjqZJpw80z2a/kTjx6yQyXt?= =?utf-8?q?tJWnW2eH4bRUCAe3X/y8mDPd00Gqqk0K/Zd+kF62nJ37OJefFbZzUEeCaSUjkiIeD?= =?utf-8?q?EXxit8vJUzBgSwVa4MlS6asGhDS68mzAE5jWO4Rf3y6Sjr44EL+P2aTRyDfr1887g?= =?utf-8?q?1hlSVHmlbDUB9T8CSoNaVTcFlCwu0SkQn5Mtq/aUh1WazjiVJFTsX1rFaAgb7weIA?= =?utf-8?q?iC19hZcaN2l1uUTeaRjPXpS1hNzRkapYpClEqNeGNTpOV8pJvKdMhAWOr9896PLpe?= =?utf-8?q?uJTSTgbE2yST?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b619ba4-2d44-4e0f-b5f0-08dbadeec152 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2023 09:01:56.1904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iF19MxBjJ6BR/9XxlT+xOxJuc/VrBI+10ajHKrE4agrVoWc7LN9GyDquTcc2VVAKz2WUzxEFWRft7sBnW54Lpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8675 access_ok() is not be applicable here; we really only want a linear address check for breakpoint addresses, as putting those in debug register isn't going to result in actual memory accesses. Furthermore access_ok() assumes to be acting on current, which isn't the case here when called from arch_set_info_guest(). Note that access_ok() was too lax anyway for 32-bit domains. Signed-off-by: Jan Beulich --- The questionable use of sizeof(long) is left in place for the moment, as it's not clear how to best deal with the upper bound of breakpoint covered ranges: We'd like those to not cover Xen space. --- a/xen/arch/x86/pv/misc-hypercalls.c +++ b/xen/arch/x86/pv/misc-hypercalls.c @@ -60,7 +60,10 @@ long set_debugreg(struct vcpu *v, unsign switch ( reg ) { case 0 ... 3: - if ( !access_ok(value, sizeof(long)) ) + if ( is_pv_32bit_vcpu(v) + ? value + sizeof(long) > HYPERVISOR_COMPAT_VIRT_START(v->domain) + : value + sizeof(long) > (1UL << (VADDR_BITS - 1)) && + value < HYPERVISOR_VIRT_END ) return -EPERM; v->arch.dr[reg] = value;