From patchwork Thu Jan 19 05:24:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Goldstein X-Patchwork-Id: 9525177 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4BC0A6020B for ; Thu, 19 Jan 2017 05:26:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E74828652 for ; Thu, 19 Jan 2017 05:26:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 338F128659; Thu, 19 Jan 2017 05:26:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9E3E628657 for ; Thu, 19 Jan 2017 05:26:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cU5Cz-0003zX-ED; Thu, 19 Jan 2017 05:24:25 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cU5Cy-0003zK-9J for xen-devel@lists.xen.org; Thu, 19 Jan 2017 05:24:24 +0000 Received: from [85.158.137.68] by server-4.bemta-3.messagelabs.com id 40/38-01392-78D40885; Thu, 19 Jan 2017 05:24:23 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRWlGSWpSXmKPExsVyMfTqYd0234Y Ig2O/jS2WfFzM4sDocXT3b6YAxijWzLyk/IoE1ox1HRvZCyZxVXzc/JS5gfETRxcjF4eQwCRG iaeTLrCCOCwC+5klHl/Zyw7iSAgsY5X4ufs3cxcjJ5ATI9Hxei1Qgh3ILpPY6A0SFRJQkPg94 RATxKDlTBL7dqxkB0mwCWhIPPk1gw3EFhGQlrj2+TIjiM0sUCJxrXkGC4gtLGArMfVbH5jNIq Aq8WTpNSCbg4NXIE5i3xZviK3yEgvPH2ECsTkFUiU2bVrIDrE3ReLAzFfsuMQnMAotYGRYxah RnFpUllqka2Sgl1SUmZ5RkpuYmaNraGCsl5taXJyYnpqTmFSsl5yfu4kRGIb1DAyMOxibT/gd YpTkYFIS5bW3bIgQ4kvKT6nMSCzOiC8qzUktPsQow8GhJMHb4AOUEyxKTU+tSMvMAUYETFqCg 0dJhPcMSJq3uCAxtzgzHSJ1itGYo6fr9Esmjj27Lr9kEmLJy89LlRLntQQpFQApzSjNgxsEi9 RLjLJSwryMDAwMQjwFqUW5mSWo8q8YxTkYlYR5g0Gm8GTmlcDtewV0ChPQKVbK9SCnlCQipKQ aGNkPnOosVFj5s9zp1IEG3jpf2Sd5HDp254tOLWTVuCd1NNglcq2B0YVi3yVmtte+GTIfNlS9 O/fstek32gqXvC35/9pW4vWX2gd1IZwzLzsem3zHIvfli2kSD3NtlvD5rdedmFzIPfvDvSv5h zedexvb1zP1UtKvFv6vM8pntM5WfvrsQZtKMa8SS3FGoqEWc1FxIgA6K1TDzwIAAA== X-Env-Sender: cardoe@cardoe.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1484803461!64500417!1 X-Originating-IP: [209.85.213.195] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12908 invoked from network); 19 Jan 2017 05:24:22 -0000 Received: from mail-yb0-f195.google.com (HELO mail-yb0-f195.google.com) (209.85.213.195) by server-12.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 19 Jan 2017 05:24:22 -0000 Received: by mail-yb0-f195.google.com with SMTP id w194so1402399ybe.1 for ; Wed, 18 Jan 2017 21:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=JCZm26JEhDFfljNo55gPz5TwWqtXGK/1fTxV9JF4Y1g=; b=G1vAi6/jUyDHmakd7vvVIxplPw5oXPnJfoe5pMlgmMjpVzSeEynaO9LioVpMgbsoS+ Vufbzhsk9X9IDtHsjOb4abDAeh5jJQAF1zVFqdBoVPIq12GFCBgxcWtjyKwKpLEW+4/2 bMoA83jEyieb3ABwCQfWcMQf83KeUBAlbDxyc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=JCZm26JEhDFfljNo55gPz5TwWqtXGK/1fTxV9JF4Y1g=; b=Kyox1VjGAJNfLV5uhwsJgaClBrDqCLV83+554Ph6qY898adX2SWkzEp+8+55BVy8So 5nphli+nkGKQp1T5pSkQZyyMWkJMCOuut0nYkdamqrvjHph7sphulr6h3zIwczxfLw+x dyAWKQbVy3FHsRggmTspPKRZDYITU8dHFwDB2BANhjdWraIJT+VTOjs33z5OrDcbyOLx CM/5sM3wWVI7rgD2RojakwhLgOilYUBqojdtTX9bGMHnm4jZjnDHfl61Nat6jm/HQH4m m0uwcqlIa/moSeXF39P6WoJ16PWtT4sXJjJ80pe/D43wKwlTA1Ehf8vV6wmmGk7dYxYa cKPg== X-Gm-Message-State: AIkVDXL5DgqAl53vtii/19l238XRY63A+8prrpZgXtjRmKliwyW8n0T03UUj+hhxqJjKcA== X-Received: by 10.37.28.4 with SMTP id c4mr5152641ybc.115.1484803461500; Wed, 18 Jan 2017 21:24:21 -0800 (PST) Received: from swanson.attlocal.net (104-179-196-18.lightspeed.brhmal.sbcglobal.net. [104.179.196.18]) by smtp.gmail.com with ESMTPSA id a3sm1281164ywe.55.2017.01.18.21.24.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 18 Jan 2017 21:24:21 -0800 (PST) From: Doug Goldstein To: xen-devel@lists.xen.org Date: Wed, 18 Jan 2017 23:24:03 -0600 Message-Id: X-Mailer: git-send-email 2.10.2 In-Reply-To: References: In-Reply-To: References: Cc: Andrew Cooper , Doug Goldstein , Jan Beulich Subject: [Xen-devel] [PATCH v2 1/3] x86/mtrr: drop positive_have_wrcomb() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The only call to have_wrcomb() was always to the generic implementation. positive_have_wrcomb() was unused. Signed-off-by: Doug Goldstein Acked-by: Jan Beulich --- Retaining ACK from <57B480FD0200007800106B2B@prv-mh.provo.novell.com> --- --- xen/arch/x86/cpu/mtrr/generic.c | 5 ----- xen/arch/x86/cpu/mtrr/mtrr.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr/generic.c index b7d3293..8d4537a 100644 --- a/xen/arch/x86/cpu/mtrr/generic.c +++ b/xen/arch/x86/cpu/mtrr/generic.c @@ -557,11 +557,6 @@ static int generic_have_wrcomb(void) return (config & (1ULL << 10)); } -int positive_have_wrcomb(void) -{ - return 1; -} - /* generic structure... */ const struct mtrr_ops generic_mtrr_ops = { diff --git a/xen/arch/x86/cpu/mtrr/mtrr.h b/xen/arch/x86/cpu/mtrr/mtrr.h index 53d369d..ec168f9 100644 --- a/xen/arch/x86/cpu/mtrr/mtrr.h +++ b/xen/arch/x86/cpu/mtrr/mtrr.h @@ -31,8 +31,6 @@ extern int generic_validate_add_page(unsigned long base, unsigned long size, extern const struct mtrr_ops generic_mtrr_ops; -extern int positive_have_wrcomb(void); - /* library functions for processor-specific routines */ struct set_mtrr_context { unsigned long flags;