From patchwork Thu Jul 15 13:40:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kara X-Patchwork-Id: 12380159 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F8EC48BC2 for ; Thu, 15 Jul 2021 13:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8C3161279 for ; Thu, 15 Jul 2021 13:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237966AbhGONnk (ORCPT ); Thu, 15 Jul 2021 09:43:40 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:55712 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232933AbhGONn2 (ORCPT ); Thu, 15 Jul 2021 09:43:28 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 53C3822873; Thu, 15 Jul 2021 13:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1626356433; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lxjF3CK86ui5KcZJwykR/wqqB4lbFmoClZkkZRdrozc=; b=tg3bRjUxFItKFHpdlpE7B/m38hYOUzxOi4SEdeTQmthrsZCazil++ZvmKJzpyOKkxa7Dhw GPz+0MaE+S3TZVywYcmdwKfHbYS6Jw+ad4gbMeficIQHASlw+3ORkSwKTa71H3zBx4rQVh tXcfk1ZJUWn5TJ8ewREZOmXQLPql74c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1626356433; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lxjF3CK86ui5KcZJwykR/wqqB4lbFmoClZkkZRdrozc=; b=wTOMhpBplkuIlFDeRrsW7sXoii8oim3lBZ5jvccZLVOuhLfqyA4xuvPelqkeu7MA7G3qtt jB8dqyD+EqWNf9AQ== Received: from quack2.suse.cz (unknown [10.100.200.198]) by relay2.suse.de (Postfix) with ESMTP id 353C0A3B8D; Thu, 15 Jul 2021 13:40:33 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id F2BED1E0BF2; Thu, 15 Jul 2021 15:40:32 +0200 (CEST) From: Jan Kara To: Cc: , Christoph Hellwig , "Darrick J. Wong" , Ted Tso , Dave Chinner , Matthew Wilcox , , , linux-f2fs-devel@lists.sourceforge.net, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, Jan Kara Subject: [PATCH 0/14 v10] fs: Hole punch vs page cache filling races Date: Thu, 15 Jul 2021 15:40:10 +0200 Message-Id: <20210715133202.5975-1-jack@suse.cz> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5333; h=from:subject:message-id; bh=jCrTAGnr259IEeyAdWvovg97ESIubovJM4MlOpJvksM=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBg8Dq7Pd1N3dpzBZZXUe8nwWltlvGlPdzFYk/Lx8q9 pxoyqOaJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCYPA6uwAKCRCcnaoHP2RA2bTiB/ sFgFq1rmJVC0lYvYbWNvx359nYpqcc/f/xZ3cyvfKDtWDp1ZN+wTonGovtY+NHusgnP1HyPjIzHVO1 ZVzv6y9F7dKZjwzEoJrRoLCzZk+t2RywbqDD3SIhW9O5+arg1GomalCV19fbYsKSlK5INuu9fsuxr3 H/MAaDzp22g25nqlAvEBDtFb9siGQMhIREXhGoW6k2bisvXZVO8yTFkKabqmCs1YBKJjIm1/sJgU4f 3sGVPh/PAWItuW2w+ljKZHlqFc/321A+gEln8hAWnqg96fG3n9du1ZgPEUhptjDdViFbRLi1YVav4f rVXXywXhqZLTRnU/U1CObhJccDuMSK X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org Hello, here is another version of my patches to address races between hole punching and page cache filling functions for ext4 and other filesystems. The only change since the last time is a small cleanup applied to changes of filemap_fault() in patch 3/14 based on Christoph's & Darrick's feedback (thanks guys!). Darrick, Christoph, is the patch fine now? Out of all filesystem supporting hole punching, only GFS2 and OCFS2 remain unresolved. GFS2 people are working on their own solution (cluster locking is involved), OCFS2 has even bigger issues (maintainers informed, looking into it). Once this series lands, I'd like to actually make sure all calls to truncate_inode_pages() happen under mapping->invalidate_lock, add the assert and then we can also get rid of i_size checks in some places (truncate can use the same serialization scheme as hole punch). But that step is mostly a cleanup so I'd like to get these functional fixes in first. The series can be also pulled from: git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git hole_punch_fixes Changes since v9: * Cleaned up filemap_fault() to be more readable based on review feedback Changes since v8: * Rebased on top of 5.14-rc1 * Fixed up conflict in f2fs * Modified filemap_fault() to acquire invalidate lock only when creating page in the page cache or loading it from the disk * Added some reviewed-by's Changes since v7: * Rebased on top of 5.13-rc6 * Added some reviewed-by tags * Simplified xfs_isilocked() changes as Dave Chinner suggested * Minor documentation formulation improvements Changes since v6: * Added some reviewed-by tags * Added wrapper for taking invalidate_lock similar to inode_lock * Renamed wrappers for taking invalidate_lock for two inodes * Added xfs patch to make xfs_isilocked() work better even without lockdep * Some minor documentation fixes Changes since v5: * Added some reviewed-by tags * Added functions for locking two mappings and using them from XFS where needed * Some minor code style & comment fixes Changes since v4: * Rebased onto 5.13-rc1 * Removed shmfs conversion patches * Fixed up zonefs changelog * Fixed up XFS comments * Added patch fixing up definition of file_operations in Documentation/vfs/ * Updated documentation and comments to explain invalidate_lock is used also to prevent changes through memory mappings to existing pages for some VFS operations. Changes since v3: * Renamed and moved lock to struct address_space * Added conversions of tmpfs, ceph, cifs, fuse, f2fs * Fixed error handling path in filemap_read() * Removed .page_mkwrite() cleanup from the series for now Changes since v2: * Added documentation and comments regarding lock ordering and how the lock is supposed to be used * Added conversions of ext2, xfs, zonefs * Added patch removing i_mapping_sem protection from .page_mkwrite handlers Changes since v1: * Moved to using inode->i_mapping_sem instead of aops handler to acquire appropriate lock --- Motivation: Amir has reported [1] a that ext4 has a potential issues when reads can race with hole punching possibly exposing stale data from freed blocks or even corrupting filesystem when stale mapping data gets used for writeout. The problem is that during hole punching, new page cache pages can get instantiated and block mapping from the looked up in a punched range after truncate_inode_pages() has run but before the filesystem removes blocks from the file. In principle any filesystem implementing hole punching thus needs to implement a mechanism to block instantiating page cache pages during hole punching to avoid this race. This is further complicated by the fact that there are multiple places that can instantiate pages in page cache. We can have regular read(2) or page fault doing this but fadvise(2) or madvise(2) can also result in reading in page cache pages through force_page_cache_readahead(). There are couple of ways how to fix this. First way (currently implemented by XFS) is to protect read(2) and *advise(2) calls with i_rwsem so that they are serialized with hole punching. This is easy to do but as a result all reads would then be serialized with writes and thus mixed read-write workloads suffer heavily on ext4. Thus this series introduces inode->i_mapping_sem and uses it when creating new pages in the page cache and looking up their corresponding block mapping. We also replace EXT4_I(inode)->i_mmap_sem with this new rwsem which provides necessary serialization with hole punching for ext4. Honza [1] https://lore.kernel.org/linux-fsdevel/CAOQ4uxjQNmxqmtA_VbYW0Su9rKRk2zobJmahcyeaEVOFKVQ5dw@mail.gmail.com/ Previous versions: Link: https://lore.kernel.org/linux-fsdevel/20210208163918.7871-1-jack@suse.cz/ Link: https://lore.kernel.org/r/20210413105205.3093-1-jack@suse.cz Link: https://lore.kernel.org/r/20210423171010.12-1-jack@suse.cz Link: https://lore.kernel.org/r/20210512101639.22278-1-jack@suse.cz Link: https://lore.kernel.org/r/20210525125652.20457-1-jack@suse.cz Link: https://lore.kernel.org/r/20210607144631.8717-1-jack@suse.cz Link: http://lore.kernel.org/r/20210615090844.6045-1-jack@suse.cz # v8 Link: http://lore.kernel.org/r/20210712163901.29514-1-jack@suse.cz # v9