| Message ID | 20220809111708.92768-1-amir73il@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | xfs stable candidate patches for 5.10.y (from v5.15) | expand |
On Tue, Aug 09, 2022 at 01:17:04PM +0200, Amir Goldstein wrote: > Hi Darrick, > > This is a small update of simple backports from v5.15 that shouldn't be > too hard to review. > > I rather take "remove support for disabling quota accounting" to 5.10.y > even though it is not a proper bug fix, as a defensive measure and in > order to match the expefctations of fstests from diabling quota. I don't agree with making quotaoff a nop after 136 releases of the 5.10 series. Turning off quota accounting on a running system might be risky, but anyone who's using it in 5.10 most likely expects it to continue working, infrequent warts and all. > These backports survived the standard auto group soak for over 40 runs > on the 5 test configs. > > Please ACK. Patches 2-4 are straightforward fixes, so: Acked-by: Darrick J. Wong <djwong@kernel.org> --D > > Thanks, > Amir. > > Christoph Hellwig (1): > xfs: remove support for disabling quota accounting on a mounted file > system > > Darrick J. Wong (1): > xfs: only set IOMAP_F_SHARED when providing a srcmap to a write > > Dave Chinner (2): > mm: Add kvrealloc() > xfs: fix I_DONTCACHE > > fs/xfs/libxfs/xfs_trans_resv.c | 30 ----- > fs/xfs/libxfs/xfs_trans_resv.h | 2 - > fs/xfs/xfs_dquot_item.c | 134 ------------------ > fs/xfs/xfs_dquot_item.h | 17 --- > fs/xfs/xfs_icache.c | 3 +- > fs/xfs/xfs_iomap.c | 8 +- > fs/xfs/xfs_iops.c | 2 +- > fs/xfs/xfs_log_recover.c | 4 +- > fs/xfs/xfs_qm.c | 2 +- > fs/xfs/xfs_qm.h | 1 - > fs/xfs/xfs_qm_syscalls.c | 240 ++------------------------------- > fs/xfs/xfs_trans_dquot.c | 38 ------ > include/linux/mm.h | 2 + > mm/util.c | 15 +++ > 14 files changed, 40 insertions(+), 458 deletions(-) > > -- > 2.25.1 >
On Tue, Aug 9, 2022 at 6:28 PM Darrick J. Wong <djwong@kernel.org> wrote: > > On Tue, Aug 09, 2022 at 01:17:04PM +0200, Amir Goldstein wrote: > > Hi Darrick, > > > > This is a small update of simple backports from v5.15 that shouldn't be > > too hard to review. > > > > I rather take "remove support for disabling quota accounting" to 5.10.y > > even though it is not a proper bug fix, as a defensive measure and in > > order to match the expefctations of fstests from diabling quota. > > I don't agree with making quotaoff a nop after 136 releases of the 5.10 > series. Turning off quota accounting on a running system might be > risky, but anyone who's using it in 5.10 most likely expects it to > continue working, infrequent warts and all. > OK. > > These backports survived the standard auto group soak for over 40 runs > > on the 5 test configs. > > > > Please ACK. > > Patches 2-4 are straightforward fixes, so: > Acked-by: Darrick J. Wong <djwong@kernel.org> > Thanks, Amir.
Hi Darrick, This is a small update of simple backports from v5.15 that shouldn't be too hard to review. I rather take "remove support for disabling quota accounting" to 5.10.y even though it is not a proper bug fix, as a defensive measure and in order to match the expefctations of fstests from diabling quota. These backports survived the standard auto group soak for over 40 runs on the 5 test configs. Please ACK. Thanks, Amir. Christoph Hellwig (1): xfs: remove support for disabling quota accounting on a mounted file system Darrick J. Wong (1): xfs: only set IOMAP_F_SHARED when providing a srcmap to a write Dave Chinner (2): mm: Add kvrealloc() xfs: fix I_DONTCACHE fs/xfs/libxfs/xfs_trans_resv.c | 30 ----- fs/xfs/libxfs/xfs_trans_resv.h | 2 - fs/xfs/xfs_dquot_item.c | 134 ------------------ fs/xfs/xfs_dquot_item.h | 17 --- fs/xfs/xfs_icache.c | 3 +- fs/xfs/xfs_iomap.c | 8 +- fs/xfs/xfs_iops.c | 2 +- fs/xfs/xfs_log_recover.c | 4 +- fs/xfs/xfs_qm.c | 2 +- fs/xfs/xfs_qm.h | 1 - fs/xfs/xfs_qm_syscalls.c | 240 ++------------------------------- fs/xfs/xfs_trans_dquot.c | 38 ------ include/linux/mm.h | 2 + mm/util.c | 15 +++ 14 files changed, 40 insertions(+), 458 deletions(-)