From patchwork Thu Aug 31 14:17:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hou Tao X-Patchwork-Id: 9932301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9FF0960309 for ; Thu, 31 Aug 2017 14:12:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9351028514 for ; Thu, 31 Aug 2017 14:12:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 883D6285C9; Thu, 31 Aug 2017 14:12:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5343F28514 for ; Thu, 31 Aug 2017 14:12:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbdHaOMT (ORCPT ); Thu, 31 Aug 2017 10:12:19 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5083 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbdHaOMT (ORCPT ); Thu, 31 Aug 2017 10:12:19 -0400 Received: from 172.30.72.58 (EHLO DGGEMS407-HUB.china.huawei.com) ([172.30.72.58]) by dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id DGI69023; Thu, 31 Aug 2017 22:12:15 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.301.0; Thu, 31 Aug 2017 22:12:11 +0800 From: Hou Tao To: CC: , Subject: [PATCH v2] xfs: add online uevent for mount operation Date: Thu, 31 Aug 2017 22:17:10 +0800 Message-ID: <1504189030-18608-1-git-send-email-houtao1@huawei.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0203.59A8193F.0100, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: a692a10c526d9b3ea253eaf9b58ad9aa Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It will be useful if there is a corresponding online uevent after a XFS filesystem has been mounted. A typical usage of the uevent is setting the error configuration for a specific XFS filesystem or all XFS filesystems by using udevd. The following is an example of udevd rule which will shutdown any XFS filesystem after the filesystem gets any IO error: ACTION=="online", SUBSYSTEM=="xfs", DEVPATH=="/fs/xfs/*", \ RUN+="/bin/sh -c 'echo 0 > /sys%p/error/metadata/default/max_retries; \ echo 0 > /sys%p/error/metadata/EIO/max_retries; \ echo 0 > /sys%p/error/metadata/ENOSPC/max_retries; \ echo 0 > /sys%p/error/metadata/ENODEV/max_retries'" You also could apply an udevd rule to a specific XFS filesystem by UUID filtering: ACTION=="online", SUBSYSTEM=="xfs", \ ENV{UUID}=="8f789c27-391f-4bd7-b17d-9bcf2443dc9c", \ RUN+="/bin/sh -c 'echo 5 > /sys%p/error/metadata/EIO/max_retries'" Suggested-by: Dave Chinner Signed-off-by: Hou Tao --- v2: * add UUID property for mount uevent * add an udev example for UUID filtering v1: * http://www.spinics.net/lists/linux-xfs/msg09484.html --- fs/xfs/xfs_super.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 3a3812b4..6f8351c 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -70,6 +70,11 @@ static struct kset *xfs_kset; /* top-level xfs sysfs dir */ static struct xfs_kobj xfs_dbg_kobj; /* global debug sysfs attrs */ #endif +enum { + XFS_UEVENT_ENV_CNT = 2, + XFS_UEVENT_UUID_LEN = UUID_STRING_LEN + 6, +}; + /* * Table driven mount option parser. */ @@ -1530,6 +1535,28 @@ xfs_destroy_percpu_counters( percpu_counter_destroy(&mp->m_fdblocks); } +static void +xfs_fs_uevent( + struct xfs_mount *mp, + enum kobject_action action) +{ + int err; + char *envp[XFS_UEVENT_ENV_CNT]; + int i = 0; + + if (!uuid_is_null(&mp->m_super->s_uuid)) { + char uuid[XFS_UEVENT_UUID_LEN]; + + snprintf(uuid, sizeof(uuid), "UUID=%pUb", &mp->m_super->s_uuid); + envp[i++] = uuid; + } + envp[i] = NULL; + err = kobject_uevent_env(&mp->m_kobj.kobject, action, envp); + if (err) + xfs_notice(mp, "Sending XFS uevent %d got error %d", + action, err); +} + STATIC int xfs_fs_fill_super( struct super_block *sb, @@ -1667,6 +1694,8 @@ xfs_fs_fill_super( goto out_unmount; } + xfs_fs_uevent(mp, KOBJ_ONLINE); + return 0; out_filestream_unmount: