| Message ID | 20160819203207.GE8268@birch.djwong.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, Aug 19, 2016 at 01:32:07PM -0700, Darrick J. Wong wrote: > Since the kernel doesn't currently support the realtime rmapbt, > don't allow such filesystems to be mounted. Support will appear > in a future release. > Makes sense to me, you can add: Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > --- > fs/xfs/xfs_super.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 24ef83e..fd6be45 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1574,9 +1574,16 @@ xfs_fs_fill_super( > } > } > > - if (xfs_sb_version_hasrmapbt(&mp->m_sb)) > + if (xfs_sb_version_hasrmapbt(&mp->m_sb)) { > + if (mp->m_sb.sb_rblocks) { > + xfs_alert(mp, > + "EXPERIMENTAL reverse mapping btree not compatible with realtime device!"); > + error = -EINVAL; > + goto out_filestream_unmount; > + } > xfs_alert(mp, > "EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!"); > + } > > error = xfs_mountfs(mp); > if (error) > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 24ef83e..fd6be45 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1574,9 +1574,16 @@ xfs_fs_fill_super( } } - if (xfs_sb_version_hasrmapbt(&mp->m_sb)) + if (xfs_sb_version_hasrmapbt(&mp->m_sb)) { + if (mp->m_sb.sb_rblocks) { + xfs_alert(mp, + "EXPERIMENTAL reverse mapping btree not compatible with realtime device!"); + error = -EINVAL; + goto out_filestream_unmount; + } xfs_alert(mp, "EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!"); + } error = xfs_mountfs(mp); if (error)
Since the kernel doesn't currently support the realtime rmapbt, don't allow such filesystems to be mounted. Support will appear in a future release. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> --- fs/xfs/xfs_super.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)