From patchwork Sun Oct 16 06:18:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9485809 X-Mozilla-Keys: nonjunk Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on sandeen.net X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0 X-Spam-HP: BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_HI=-5,RP_MATCHES_RCVD=-0.1 X-Original-To: sandeen@sandeen.net Delivered-To: sandeen@sandeen.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by sandeen.net (Postfix) with ESMTP id 4BC07553042 for ; Sun, 16 Oct 2016 01:17:51 -0500 (CDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067AbcJPGSl (ORCPT ); Sun, 16 Oct 2016 02:18:41 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:41902 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbcJPGSk (ORCPT ); Sun, 16 Oct 2016 02:18:40 -0400 Received: from hch by bombadil.infradead.org with local (Exim 4.85_2 #1 (Red Hat Linux)) id 1bvemL-0004QW-J8; Sun, 16 Oct 2016 06:18:37 +0000 Date: Sat, 15 Oct 2016 23:18:37 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: david@fromorbit.com, eguan@redhat.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/3] misc: fix fallocate commands that need the unshare switch Message-ID: <20161016061837.GA12614@infradead.org> References: <147646876990.19627.5046740854955682441.stgit@birch.djwong.org> <147646878237.19627.11366131824882808123.stgit@birch.djwong.org> <20161015170303.GB11829@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161015170303.GB11829@infradead.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sat, Oct 15, 2016 at 10:03:03AM -0700, Christoph Hellwig wrote: > The poster child would be btrfs, and I would have added some output > here if btrfs support in xfstests wasn't completely broken at this > point. > > Well, added Ccs and some output anyway in this case.. Turns out the btrfs failure was my stupidity, sorry. I can reproduce the issue I was going to originally show (which was actually pointed out by Eric for a different fallocate flag check I wanted to add), here is the diff of the output files when running generic/156 on btrfs with your patch: So what we really need an enhanced falloc tester that checks that the tested subcommand is actually implemented on the given file system. (And we already need something like that for -k on NFS) --- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- tests/generic/156.out 2016-03-29 13:59:30.411720622 +0000 +++ /root/xfstests/results//generic/156.out.bad 2016-10-16 06:15:27.118776421 +0000 @@ -2,8 +2,13 @@ Create the original file blocks Create the reflink copies funshare part of a file +fallocate: Operation not supported funshare some of the copies +fallocate: Operation not supported +fallocate: Operation not supported funshare the rest of the files +fallocate: Operation not supported +fallocate: Operation not supported Rewrite the original file free blocks after reflinking is in range free blocks after nocow'ing some copies is in range