| Message ID | 20170629155256.3607-1-billodo@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Thu, Jun 29, 2017 at 10:52:56AM -0500, Bill O'Donnell wrote: > scan_ag mallocs memory that is potentially leaked. Add a free > to alleviate the potential leak. > > Fixes CoverityScan CID#1413772 (RESOURCE_LEAK) /me feels like the coverity tags he's seen tend to take the format of: Addresses-Coverity-ID: 1091173 or Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced") though to be honest I don't know that there's really a standard. <shrug> It probably ought to use one of the two more common formats, but maybe I can just ask Eric to prettyplease fix it on the way in. :) > Signed-off-by: Bill O'Donnell <billodo@redhat.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > spaceman/freesp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/spaceman/freesp.c b/spaceman/freesp.c > index 22aec821..367c95d1 100644 > --- a/spaceman/freesp.c > +++ b/spaceman/freesp.c > @@ -239,7 +239,9 @@ scan_ag( > printf(_("%10u %10llu %10llu\n"), agno, freeexts, > freeblks); > } > + free(fsmap); > } > + > static void > aglistadd( > char *a) > -- > 2.13.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/29/17 10:59 AM, Darrick J. Wong wrote: > On Thu, Jun 29, 2017 at 10:52:56AM -0500, Bill O'Donnell wrote: >> scan_ag mallocs memory that is potentially leaked. Add a free >> to alleviate the potential leak. >> >> Fixes CoverityScan CID#1413772 (RESOURCE_LEAK) > > /me feels like the coverity tags he's seen tend to take the format of: > > Addresses-Coverity-ID: 1091173 > or > Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced") > > though to be honest I don't know that there's really a standard. > > <shrug> It probably ought to use one of the two more common formats, but > maybe I can just ask Eric to prettyplease fix it on the way in. :) Agreed, will do. (there are a couple different formats already in the history, but best not to invent more as we go) :) -Eric > >> Signed-off-by: Bill O'Donnell <billodo@redhat.com> > > Looks ok, > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> > > --D > >> --- >> spaceman/freesp.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/spaceman/freesp.c b/spaceman/freesp.c >> index 22aec821..367c95d1 100644 >> --- a/spaceman/freesp.c >> +++ b/spaceman/freesp.c >> @@ -239,7 +239,9 @@ scan_ag( >> printf(_("%10u %10llu %10llu\n"), agno, freeexts, >> freeblks); >> } >> + free(fsmap); >> } >> + >> static void >> aglistadd( >> char *a) >> -- >> 2.13.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/spaceman/freesp.c b/spaceman/freesp.c index 22aec821..367c95d1 100644 --- a/spaceman/freesp.c +++ b/spaceman/freesp.c @@ -239,7 +239,9 @@ scan_ag( printf(_("%10u %10llu %10llu\n"), agno, freeexts, freeblks); } + free(fsmap); } + static void aglistadd( char *a)
scan_ag mallocs memory that is potentially leaked. Add a free to alleviate the potential leak. Fixes CoverityScan CID#1413772 (RESOURCE_LEAK) Signed-off-by: Bill O'Donnell <billodo@redhat.com> --- spaceman/freesp.c | 2 ++ 1 file changed, 2 insertions(+)