From patchwork Thu Jun 29 16:25:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 9817333 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7603F603F2 for ; Thu, 29 Jun 2017 16:25:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 698EE28749 for ; Thu, 29 Jun 2017 16:25:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5E39B2877C; Thu, 29 Jun 2017 16:25:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 119EA2877A for ; Thu, 29 Jun 2017 16:25:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbdF2QZi (ORCPT ); Thu, 29 Jun 2017 12:25:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47120 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbdF2QZh (ORCPT ); Thu, 29 Jun 2017 12:25:37 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B05ECC04B31B; Thu, 29 Jun 2017 16:25:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B05ECC04B31B Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=billodo@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B05ECC04B31B Received: from localhost.localdomain.com (ovpn-121-88.rdu2.redhat.com [10.10.121.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4FE057BB4A; Thu, 29 Jun 2017 16:25:31 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: sandeen@sandeen.net Subject: [PATCH] xfs_spaceman: close open file for error case in openfile() Date: Thu, 29 Jun 2017 11:25:30 -0500 Message-Id: <20170629162530.6023-1-billodo@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 29 Jun 2017 16:25:31 +0000 (UTC) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP openfile() fails to close the open file in one error case. Add close(fd) to correct the condition. Detected by CoverityScan, CID#1413770 (RESOURCE_LEAK) Signed-off-by: Bill O'Donnell Reviewed-by: Darrick J. Wong --- spaceman/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/spaceman/file.c b/spaceman/file.c index 4ab30900..4c13b4a8 100644 --- a/spaceman/file.c +++ b/spaceman/file.c @@ -79,6 +79,7 @@ openfile( if (!fsp) { fprintf(stderr, _("%s: cannot find mount point."), path); + close(fd); return -1; } memcpy(fs_path, fsp, sizeof(struct fs_path));