diff mbox

[2/2] common/xfs: add iomap_dio_actor() to the dmesg filter

Message ID 20170731042825.6250-2-eguan@redhat.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Eryu Guan July 31, 2017, 4:28 a.m. UTC
The warning in fs/iomap.c::iomap_dio_actor() could be triggered when
mixing dio and mmap I/O on the same sparse file. Several tests could
hit this warning now, like generic/095 generic/224 and generic/446.
So add this expected warning to whitelist too.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---
 common/xfs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Brian Foster Aug. 3, 2017, 11:54 a.m. UTC | #1
On Mon, Jul 31, 2017 at 12:28:25PM +0800, Eryu Guan wrote:
> The warning in fs/iomap.c::iomap_dio_actor() could be triggered when
> mixing dio and mmap I/O on the same sparse file. Several tests could
> hit this warning now, like generic/095 generic/224 and generic/446.
> So add this expected warning to whitelist too.
> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  common/xfs | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/common/xfs b/common/xfs
> index 47b4e1ba4b7f..4995f8ba8dd8 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -596,10 +596,12 @@ _filter_xfs_dmesg()
>  	local warn4="WARNING:.*fs/xfs/xfs_file\.c:.*xfs_file_aio_read.*"
>  	local warn5="WARNING:.*fs/iomap\.c:.*iomap_dio_rw.*"
>  	local warn6="WARNING:.*fs/xfs/xfs_aops\.c:.*__xfs_get_blocks.*"
> +	local warn7="WARNING:.*fs/iomap\.c:.*iomap_dio_actor.*"
>  	sed -e "s#$warn1#Intentional warnings in xfs_file_dio_aio_write#" \
>  	    -e "s#$warn2#Intentional warnings in xfs_file_dio_aio_read#" \
>  	    -e "s#$warn3#Intentional warnings in xfs_file_read_iter#" \
>  	    -e "s#$warn4#Intentional warnings in xfs_file_aio_read#" \
>  	    -e "s#$warn5#Intentional warnings in iomap_dio_rw#" \
> -	    -e "s#$warn6#Intentional warnings in __xfs_get_blocks#"
> +	    -e "s#$warn6#Intentional warnings in __xfs_get_blocks#" \
> +	    -e "s#$warn7#Intentional warnings in iomap_dio_actor#"
>  }
> -- 
> 2.13.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/common/xfs b/common/xfs
index 47b4e1ba4b7f..4995f8ba8dd8 100644
--- a/common/xfs
+++ b/common/xfs
@@ -596,10 +596,12 @@  _filter_xfs_dmesg()
 	local warn4="WARNING:.*fs/xfs/xfs_file\.c:.*xfs_file_aio_read.*"
 	local warn5="WARNING:.*fs/iomap\.c:.*iomap_dio_rw.*"
 	local warn6="WARNING:.*fs/xfs/xfs_aops\.c:.*__xfs_get_blocks.*"
+	local warn7="WARNING:.*fs/iomap\.c:.*iomap_dio_actor.*"
 	sed -e "s#$warn1#Intentional warnings in xfs_file_dio_aio_write#" \
 	    -e "s#$warn2#Intentional warnings in xfs_file_dio_aio_read#" \
 	    -e "s#$warn3#Intentional warnings in xfs_file_read_iter#" \
 	    -e "s#$warn4#Intentional warnings in xfs_file_aio_read#" \
 	    -e "s#$warn5#Intentional warnings in iomap_dio_rw#" \
-	    -e "s#$warn6#Intentional warnings in __xfs_get_blocks#"
+	    -e "s#$warn6#Intentional warnings in __xfs_get_blocks#" \
+	    -e "s#$warn7#Intentional warnings in iomap_dio_actor#"
 }