From patchwork Tue Sep 5 05:44:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chandan Rajendra X-Patchwork-Id: 9937853 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5C12C6038C for ; Tue, 5 Sep 2017 05:44:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4DBEF28886 for ; Tue, 5 Sep 2017 05:44:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 40C2828889; Tue, 5 Sep 2017 05:44:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B15F528886 for ; Tue, 5 Sep 2017 05:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750775AbdIEFoG (ORCPT ); Tue, 5 Sep 2017 01:44:06 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36053 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbdIEFoF (ORCPT ); Tue, 5 Sep 2017 01:44:05 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v855i5h7142992 for ; Tue, 5 Sep 2017 01:44:05 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2cs9f2e75d-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 05 Sep 2017 01:44:05 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Sep 2017 01:44:01 -0400 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 5 Sep 2017 01:43:59 -0400 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v855hx5I24379636; Tue, 5 Sep 2017 05:43:59 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2146B12403D; Tue, 5 Sep 2017 01:41:18 -0400 (EDT) Received: from localhost.in.ibm.com (unknown [9.124.35.231]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP id 290D9124035; Tue, 5 Sep 2017 01:41:16 -0400 (EDT) From: Chandan Rajendra To: linux-xfs@vger.kernel.org, sandeen@sandeen.net Cc: Chandan Rajendra Subject: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize Date: Tue, 5 Sep 2017 11:14:42 +0530 X-Mailer: git-send-email 2.9.5 X-TM-AS-GCONF: 00 x-cbid: 17090505-0040-0000-0000-0000039A726E X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007669; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000226; SDB=6.00912452; UDB=6.00457862; IPR=6.00692715; BA=6.00005572; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017009; XFM=3.00000015; UTC=2017-09-05 05:44:00 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17090505-0041-0000-0000-0000078EA65E Message-Id: <20170905054442.28615-1-chandan@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-09-05_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709050088 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set physical block size to PAGE_SIZE) now sets PAGE_SIZE as the default physical sector size of loop devices. On ppc64, this causes loop devices to have 64k as the physical sector size. With these changes, mkfs.xfs now prints error messages when filesystem blocksize (4k) is less than underlying device's physical sectorsize (64k). These messages (printed on stderr) now cause several xfstests to fail on ppc64 machine since xfstests' _filter_mkfs() isn't able to filter out stderr. Also, the messages themselves describe a possible sub-optimal setup. But the setup is still usable. Hence this commit removes the calls to fprintf() used to print the messages. Signed-off-by: Chandan Rajendra --- mkfs/xfs_mkfs.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index dfffae7..0bb3897 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -2011,12 +2011,6 @@ _("Minimum block size for CRC enabled filesystems is %d bytes.\n"), XFS_MIN_SECTORSIZE; if ((blocksize < sectorsize) && (blocksize >= ft.lsectorsize)) { - fprintf(stderr, -_("specified blocksize %d is less than device physical sector size %d\n"), - blocksize, ft.psectorsize); - fprintf(stderr, -_("switching to logical sector size %d\n"), - ft.lsectorsize); sectorsize = ft.lsectorsize ? ft.lsectorsize : XFS_MIN_SECTORSIZE; }