From patchwork Thu Nov 23 11:10:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eryu Guan X-Patchwork-Id: 10072649 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3219C6056E for ; Thu, 23 Nov 2017 11:11:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F69E29F95 for ; Thu, 23 Nov 2017 11:11:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 245AA29F96; Thu, 23 Nov 2017 11:11:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFA0329F93 for ; Thu, 23 Nov 2017 11:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbdKWLK4 (ORCPT ); Thu, 23 Nov 2017 06:10:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52928 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbdKWLKz (ORCPT ); Thu, 23 Nov 2017 06:10:55 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3009737E7A; Thu, 23 Nov 2017 11:10:55 +0000 (UTC) Received: from localhost (dhcp-12-147.nay.redhat.com [10.66.12.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC71B171F5; Thu, 23 Nov 2017 11:10:53 +0000 (UTC) From: Eryu Guan To: fstests@vger.kernel.org Cc: misono.tomohiro@jp.fujitsu.com, linux-xfs@vger.kernel.org, amir73il@gmail.com, Eryu Guan Subject: [PATCH v3 2/3] overlay/036: filter busy mount message Date: Thu, 23 Nov 2017 19:10:30 +0800 Message-Id: <20171123111031.6550-3-eguan@redhat.com> In-Reply-To: <20171123111031.6550-1-eguan@redhat.com> References: <20171123111031.6550-1-eguan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 23 Nov 2017 11:10:55 +0000 (UTC) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP util-linux v2.30 changed error message of a busy mount and caused overlay/036 to fail. e.g. - mount: is already mounted or busy + mount: : already mounted or mount point busy. Filter the mount output by a newly introduced _filter_busy_mount into a unified format. mount: device already mounted or mount point busy Signed-off-by: Eryu Guan --- v3: - filter out $SCRATCH_DEV/MNT too and use a consistent output - update regexp in sed as suggested by Amir common/filter | 12 ++++++++++++ tests/overlay/036 | 4 ++-- tests/overlay/036.out | 4 ++-- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/common/filter b/common/filter index 0d3875cc6cdc..a212c09aa138 100644 --- a/common/filter +++ b/common/filter @@ -423,6 +423,18 @@ _filter_error_mount() sed -e "s/mount:\(.*failed:\)/mount:/" | _filter_ending_dot } +# Similar to _filter_error_mount, filter a busy mount output. +# Turn both old (prior to util-linux v2.30) and new (v2.30 and later) format to +# a simple one. e.g. +# old: mount: is already mounted or busy +# new: mount: : already mounted or mount point busy. +# filtered: mount: device already mounted or mount point busy +_filter_busy_mount() +{ + sed -e "s/.*: .* already mounted or .* busy/mount: device already mounted or mount point busy/" | \ + _filter_ending_dot +} + _filter_od() { BLOCK_SIZE=$(_get_block_size $SCRATCH_MNT) diff --git a/tests/overlay/036 b/tests/overlay/036 index 544d4e4eaa87..e0c13ae88c92 100755 --- a/tests/overlay/036 +++ b/tests/overlay/036 @@ -103,12 +103,12 @@ _overlay_mount_dirs $lowerdir2 $upperdir2 $workdir \ # Try to mount another overlay with the same upperdir # with index=on - expect EBUSY _overlay_mount_dirs $lowerdir2 $upperdir $workdir2 \ - overlay2 $SCRATCH_MNT -oindex=on 2>&1 | _filter_scratch + overlay2 $SCRATCH_MNT -oindex=on 2>&1 | _filter_busy_mount # Try to mount another overlay with the same workdir # with index=on - expect EBUSY _overlay_mount_dirs $lowerdir2 $upperdir2 $workdir \ - overlay3 $SCRATCH_MNT -oindex=on 2>&1 | _filter_scratch + overlay3 $SCRATCH_MNT -oindex=on 2>&1 | _filter_busy_mount # success, all done diff --git a/tests/overlay/036.out b/tests/overlay/036.out index 51746114db1c..0d266f1b216e 100644 --- a/tests/overlay/036.out +++ b/tests/overlay/036.out @@ -1,3 +1,3 @@ QA output created by 036 -mount: overlay2 is already mounted or SCRATCH_MNT busy -mount: overlay3 is already mounted or SCRATCH_MNT busy +mount: device already mounted or mount point busy +mount: device already mounted or mount point busy