| Message ID | 20210104112952.328169-1-zlang@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | mkfs: fix wrong inobtcount usage error output | expand |
On 1/4/21 5:29 AM, Zorro Lang wrote: > When mkfs fails, it shows: > ... > /* metadata */ [-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,\n\ > inobtcnt=0|1,bigtime=0|1]\n\ > ... > > The "inobtcnt=0|1" is wrong usage, it must be inobtcount, there's not > an alias. To avoid misadvice, fix it. Good catch, thanks. (it's funny how we abbreviate some things and not others) > Signed-off-by: Zorro Lang <zlang@redhat.com> Reviewed-by: Eric Sandeen <sandeen@redhat.com> > --- > mkfs/xfs_mkfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > index 47acc127..0581843f 100644 > --- a/mkfs/xfs_mkfs.c > +++ b/mkfs/xfs_mkfs.c > @@ -928,7 +928,7 @@ usage( void ) > /* blocksize */ [-b size=num]\n\ > /* config file */ [-c options=xxx]\n\ > /* metadata */ [-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,\n\ > - inobtcnt=0|1,bigtime=0|1]\n\ > + inobtcount=0|1,bigtime=0|1]\n\ > /* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\ > (sunit=value,swidth=value|su=num,sw=num|noalign),\n\ > sectsize=num\n\ >
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index 47acc127..0581843f 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -928,7 +928,7 @@ usage( void ) /* blocksize */ [-b size=num]\n\ /* config file */ [-c options=xxx]\n\ /* metadata */ [-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,\n\ - inobtcnt=0|1,bigtime=0|1]\n\ + inobtcount=0|1,bigtime=0|1]\n\ /* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\ (sunit=value,swidth=value|su=num,sw=num|noalign),\n\ sectsize=num\n\
When mkfs fails, it shows: ... /* metadata */ [-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,\n\ inobtcnt=0|1,bigtime=0|1]\n\ ... The "inobtcnt=0|1" is wrong usage, it must be inobtcount, there's not an alias. To avoid misadvice, fix it. Signed-off-by: Zorro Lang <zlang@redhat.com> --- mkfs/xfs_mkfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)