| Message ID | 20210128071133.60335-27-chaitanya.kulkarni@wdc.com (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
| Series | block: introduce bio_new() | expand |
On Wed, Jan 27, 2021 at 11:11:25PM -0800, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Seems fine to me... Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/xfs_bio_io.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/xfs/xfs_bio_io.c b/fs/xfs/xfs_bio_io.c > index e2148f2d5d6b..e4644f22ebe6 100644 > --- a/fs/xfs/xfs_bio_io.c > +++ b/fs/xfs/xfs_bio_io.c > @@ -26,11 +26,8 @@ xfs_rw_bdev( > if (is_vmalloc && op == REQ_OP_WRITE) > flush_kernel_vmap_range(data, count); > > - bio = bio_alloc(GFP_KERNEL, bio_max_vecs(left)); > - bio_set_dev(bio, bdev); > - bio->bi_iter.bi_sector = sector; > - bio->bi_opf = op | REQ_META | REQ_SYNC; > - > + bio = bio_new(bdev, sector, op, REQ_META | REQ_SYNC, bio_max_vecs(left), > + GFP_KERNEL); > do { > struct page *page = kmem_to_page(data); > unsigned int off = offset_in_page(data); > -- > 2.22.1 >
diff --git a/fs/xfs/xfs_bio_io.c b/fs/xfs/xfs_bio_io.c index e2148f2d5d6b..e4644f22ebe6 100644 --- a/fs/xfs/xfs_bio_io.c +++ b/fs/xfs/xfs_bio_io.c @@ -26,11 +26,8 @@ xfs_rw_bdev( if (is_vmalloc && op == REQ_OP_WRITE) flush_kernel_vmap_range(data, count); - bio = bio_alloc(GFP_KERNEL, bio_max_vecs(left)); - bio_set_dev(bio, bdev); - bio->bi_iter.bi_sector = sector; - bio->bi_opf = op | REQ_META | REQ_SYNC; - + bio = bio_new(bdev, sector, op, REQ_META | REQ_SYNC, bio_max_vecs(left), + GFP_KERNEL); do { struct page *page = kmem_to_page(data); unsigned int off = offset_in_page(data);
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> --- fs/xfs/xfs_bio_io.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)