| Message ID | 20230526073336.344543-2-mcgrof@kernel.org (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
| Series | block: simplify with PAGE_SECTORS_SHIFT | expand |
On Fri, May 26, 2023 at 12:33:32AM -0700, Luis Chamberlain wrote: > This ensures no other users pop up by mistake easily and provides > us a with an easy vehicle to do the same with other routines should > we need it later. I don't see how this is related to the rest of the seris. I also don't think it's a good idea. The APIs isn't deprecated per se. It just should not be called by drivers. The right thing would be an interface like EXPORT_SYMBOL_GPL_FOR(bdev_disk_changed, loop.ko, CONFIG_BLK_DEV_LOOP); EXPORT_SYMBOL_GPL_FOR(bdev_disk_changed, dasd_mod.ko, CONFIG_DASD); with the modulo code enforcing that no one but the module this is explicitly exorted for can use the symbol.
On Fri, May 26, 2023 at 01:13:14AM -0700, Christoph Hellwig wrote: > On Fri, May 26, 2023 at 12:33:32AM -0700, Luis Chamberlain wrote: > > This ensures no other users pop up by mistake easily and provides > > us a with an easy vehicle to do the same with other routines should > > we need it later. > > I don't see how this is related to the rest of the seris. Jessh, sorry it is too late here and that was a typo that the commit went into the series. I'll go sleep now. This I just had queued as a reminder for the new annotation for deprecated symbols to be used in some situations. Please ignore this patch. Luis
diff --git a/block/partitions/core.c b/block/partitions/core.c index 49e0496ff23c..6f18444be4fe 100644 --- a/block/partitions/core.c +++ b/block/partitions/core.c @@ -690,11 +690,7 @@ int bdev_disk_changed(struct gendisk *disk, bool invalidate) return ret; } -/* - * Only exported for loop and dasd for historic reasons. Don't use in new - * code! - */ -EXPORT_SYMBOL_GPL(bdev_disk_changed); +EXPORT_SYMBOL_NS_GPL(bdev_disk_changed, BLOCK_DEPRECATED); void *read_part_sector(struct parsed_partitions *state, sector_t n, Sector *p) { diff --git a/drivers/block/loop.c b/drivers/block/loop.c index bc31bb7072a2..50aa5b4c0c56 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -37,6 +37,8 @@ #include <linux/spinlock.h> #include <uapi/linux/loop.h> +MODULE_IMPORT_NS(BLOCK_DEPRECATED); + /* Possible states of device */ enum { Lo_unbound, diff --git a/drivers/s390/block/dasd_genhd.c b/drivers/s390/block/dasd_genhd.c index 998a961e1704..5ea244aec534 100644 --- a/drivers/s390/block/dasd_genhd.c +++ b/drivers/s390/block/dasd_genhd.c @@ -25,6 +25,8 @@ #include "dasd_int.h" +MODULE_IMPORT_NS(BLOCK_DEPRECATED); + static unsigned int queue_depth = 32; static unsigned int nr_hw_queues = 4;
This ensures no other users pop up by mistake easily and provides us a with an easy vehicle to do the same with other routines should we need it later. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- block/partitions/core.c | 6 +----- drivers/block/loop.c | 2 ++ drivers/s390/block/dasd_genhd.c | 2 ++ 3 files changed, 5 insertions(+), 5 deletions(-)