| Message ID | 20240611030203.1719072-5-mcgrof@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | fstests: add some new LBS inspired tests | expand |
On Mon, Jun 10, 2024 at 08:02:01PM -0700, Luis Chamberlain wrote: > Using findmnt -S debugfs arguments does not really output anything on > debian, and is not needed, fix that. AH, right, -S filter the "source" column in /proc/mounts. That's unimportant for fstests, because we really just want to know that the *fstype* is debugfs, which is what -o FSTYPE does. Ignoring my previous questions on this matter, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > Fixes: 8e8fb3da709e ("fstests: fix _require_debugfs and call it properly") > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > --- > common/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/rc b/common/rc > index 18ad25662d5c..30beef4e5c02 100644 > --- a/common/rc > +++ b/common/rc > @@ -3025,7 +3025,7 @@ _require_debugfs() > local type > > if [ -d "$DEBUGFS_MNT" ];then > - type=$(findmnt -rncv -T $DEBUGFS_MNT -S debugfs -o FSTYPE) > + type=$(findmnt -rncv -T $DEBUGFS_MNT -o FSTYPE) > [ "$type" = "debugfs" ] && return 0 > fi > > -- > 2.43.0 > >
On Mon, Jun 10, 2024 at 08:02:01PM -0700, Luis Chamberlain wrote: > Using findmnt -S debugfs arguments does not really output anything on > debian, and is not needed, fix that. > > Fixes: 8e8fb3da709e ("fstests: fix _require_debugfs and call it properly") > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > --- Thanks for fixing it. Reviewed-by: Zorro Lang <zlang@redhat.com> > common/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/rc b/common/rc > index 18ad25662d5c..30beef4e5c02 100644 > --- a/common/rc > +++ b/common/rc > @@ -3025,7 +3025,7 @@ _require_debugfs() > local type > > if [ -d "$DEBUGFS_MNT" ];then > - type=$(findmnt -rncv -T $DEBUGFS_MNT -S debugfs -o FSTYPE) > + type=$(findmnt -rncv -T $DEBUGFS_MNT -o FSTYPE) > [ "$type" = "debugfs" ] && return 0 > fi > > -- > 2.43.0 > >
diff --git a/common/rc b/common/rc index 18ad25662d5c..30beef4e5c02 100644 --- a/common/rc +++ b/common/rc @@ -3025,7 +3025,7 @@ _require_debugfs() local type if [ -d "$DEBUGFS_MNT" ];then - type=$(findmnt -rncv -T $DEBUGFS_MNT -S debugfs -o FSTYPE) + type=$(findmnt -rncv -T $DEBUGFS_MNT -o FSTYPE) [ "$type" = "debugfs" ] && return 0 fi
Using findmnt -S debugfs arguments does not really output anything on debian, and is not needed, fix that. Fixes: 8e8fb3da709e ("fstests: fix _require_debugfs and call it properly") Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)