From patchwork Thu Jun 13 21:09:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13697475 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 883DF146A8A for ; Thu, 13 Jun 2024 21:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313596; cv=none; b=Ce5L0efiWRm5ejGru/2fEfPIMiF5L79/P5xEJcj8G8cU3e8f1vtlFCZg5yrVikoxWmtjdhcdvsnM3XgxUsQHb3TiuHK+IrXtM8JOerE08Q8+DOCM57nWoCJpOMhnjTduz6LPoT6eJ84Ef/SizjthUMaxNscHgoD3/ToU3tjsErw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313596; c=relaxed/simple; bh=bOUOYj1yJWVfslyu9pCNZsN+CqdeAchG298E4ENLkPY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E1b9Wtya6g5CVtOMb70AOA6dLRzXHkxlzCdox9J5eqX8fZrrEAlD9wwHZ1LCkX3+fghoAl5JYItJNtJk8JX5fJJkvWAk+QrdqEJwXc4eHqNOMBlFZWHWlC1jNpFCZdaHuhtouC6eFNDtQxb4jL+/oBbdQXRibyuBhiyQFJBG0TM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bh9ooRJ8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bh9ooRJ8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718313592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jk9BFaIBdnRuur/DRp9Mi6o2SQFE0p2XyV62LiyPpE4=; b=Bh9ooRJ8z54MwqM2kwkm7Axbp091ptcC8wdrP08V+uNekhY4+1jQ2VnDaBuMdwXQ5DFovY rOLRJjSBML/RLHwrO7rY8t3JG1NoDgeSA8UGRXTXYQ+cKi2yUA3+tI5293HqE4MAET++Ph SPxvS3ULixQo2iT7++ymms9ghPz5T/c= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-FeVufd7dM16eScmIATa7wQ-1; Thu, 13 Jun 2024 17:19:50 -0400 X-MC-Unique: FeVufd7dM16eScmIATa7wQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 729C51956088 for ; Thu, 13 Jun 2024 21:19:49 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 752D71956056; Thu, 13 Jun 2024 21:19:48 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH v2 1/4] mkfs.xfs: avoid potential overflowing expression in xfs_mkfs.c Date: Thu, 13 Jun 2024 16:09:15 -0500 Message-ID: <20240613211933.1169581-2-bodonnel@redhat.com> In-Reply-To: <20240613211933.1169581-1-bodonnel@redhat.com> References: <20240613211933.1169581-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Cast max_tx_bytes to uint64_t to avoid overflowing expression in calc_concurrency_logblocks(). Coverity-id: 1596603 Signed-off-by: Bill O'Donnell Reviewed-by: Darrick J. Wong --- mkfs/xfs_mkfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index f4a9bf20..2f801dd4 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -3678,7 +3678,7 @@ calc_concurrency_logblocks( * without blocking for space. Increase the figure by 50% so that * background threads can also run. */ - log_bytes = max_tx_bytes * 3 * cli->log_concurrency / 2; + log_bytes = (uint64_t)max_tx_bytes * 3 * cli->log_concurrency / 2; new_logblocks = min(XFS_MAX_LOG_BYTES >> cfg->blocklog, log_bytes >> cfg->blocklog);