| Message ID | 20241127063503.2200005-2-leo.lilong@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v5,1/2] iomap: fix zero padding data issue in concurrent append writes | expand |
On Wed, Nov 27, 2024 at 02:35:03PM +0800, Long Li wrote: > Use already initialized local variables 'offset' and 'size' instead > of accessing ioend members directly in xfs_setfilesize() call. > > This is just a code cleanup with no functional changes. > > Signed-off-by: Long Li <leo.lilong@huawei.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> Pretty straightforward cleanup there, Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > v4->v5: No changes > fs/xfs/xfs_aops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c > index 559a3a577097..67877c36ed11 100644 > --- a/fs/xfs/xfs_aops.c > +++ b/fs/xfs/xfs_aops.c > @@ -131,7 +131,7 @@ xfs_end_ioend( > error = xfs_iomap_write_unwritten(ip, offset, size, false); > > if (!error && xfs_ioend_is_append(ioend)) > - error = xfs_setfilesize(ip, ioend->io_offset, ioend->io_size); > + error = xfs_setfilesize(ip, offset, size); > done: > iomap_finish_ioends(ioend, error); > memalloc_nofs_restore(nofs_flag); > -- > 2.39.2 >
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 559a3a577097..67877c36ed11 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -131,7 +131,7 @@ xfs_end_ioend( error = xfs_iomap_write_unwritten(ip, offset, size, false); if (!error && xfs_ioend_is_append(ioend)) - error = xfs_setfilesize(ip, ioend->io_offset, ioend->io_size); + error = xfs_setfilesize(ip, offset, size); done: iomap_finish_ioends(ioend, error); memalloc_nofs_restore(nofs_flag);