diff mbox series

[v2,7/7] release.sh: use git-contributors to --cc contributors

Message ID 20250122-update-release-v2-7-d01529db3aa5@kernel.org (mailing list archive)
State New
Headers show
Series Update release.sh | expand

Commit Message

Andrey Albershteyn Jan. 22, 2025, 3:01 p.m. UTC
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
 release.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Darrick J. Wong Jan. 28, 2025, 6:01 p.m. UTC | #1
On Wed, Jan 22, 2025 at 04:01:33PM +0100, Andrey Albershteyn wrote:
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
> ---
>  release.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/release.sh b/release.sh
> index 723806beb05761da06d971460ee15c97d2d0d5b1..e5ae3a8f2f1c601c2e8803b9d899712b567fbbfe 100755
> --- a/release.sh
> +++ b/release.sh
> @@ -166,5 +166,6 @@ echo "Done. Please remember to push out tags and the branch."
>  printf "\tgit push origin v${version} master\n"
>  if [ -n "$LAST_HEAD" ]; then
>  	echo "Command to send ANNOUNCE email"
> -	printf "\tneomutt -H $mail_file\n"
> +	cc="$(./tools/git-contributors.py $LAST_HEAD.. --delimiter ' -c ')"

You could also do:

Cc: $(./tools/git-contributors.py $LAST_HEAD.. --delimiter ' ')

in the mail_file generation, right after you generate the To: line,
which would eliminate the user having to do a messy cut and paste of a
very long command line:

	neomutt -H /tmp/fubar -c root@localhost -c postmaster@localhost -c ...

something like this:

cat << EOF > $mail_file
To: linux-xfs@vger.kernel.org
Cc: $(./tools/git-contributors.py $LAST_HEAD.. --delimiter ' ')
Subject: [ANNOUNCE] xfsprogs $(git describe --abbrev=0) released

Hi folks,
ENDL

--D

> +	printf "\tneomutt -H $mail_file -c $cc\n"
>  fi
> 
> -- 
> 2.47.0
> 
>
diff mbox series

Patch

diff --git a/release.sh b/release.sh
index 723806beb05761da06d971460ee15c97d2d0d5b1..e5ae3a8f2f1c601c2e8803b9d899712b567fbbfe 100755
--- a/release.sh
+++ b/release.sh
@@ -166,5 +166,6 @@  echo "Done. Please remember to push out tags and the branch."
 printf "\tgit push origin v${version} master\n"
 if [ -n "$LAST_HEAD" ]; then
 	echo "Command to send ANNOUNCE email"
-	printf "\tneomutt -H $mail_file\n"
+	cc="$(./tools/git-contributors.py $LAST_HEAD.. --delimiter ' -c ')"
+	printf "\tneomutt -H $mail_file -c $cc\n"
 fi