From patchwork Sun Nov 11 01:21:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 10677463 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 460DB109C for ; Sun, 11 Nov 2018 01:21:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3599B2BC2A for ; Sun, 11 Nov 2018 01:21:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 261A52BC45; Sun, 11 Nov 2018 01:21:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E4FB2BC2A for ; Sun, 11 Nov 2018 01:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbeKKLIt (ORCPT ); Sun, 11 Nov 2018 06:08:49 -0500 Received: from smtprelay0183.hostedemail.com ([216.40.44.183]:49434 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726478AbeKKLIt (ORCPT ); Sun, 11 Nov 2018 06:08:49 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 394C6180A8CBF; Sun, 11 Nov 2018 01:21:52 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: roll88_2d43c84fc043d X-Filterd-Recvd-Size: 1509 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Sun, 11 Nov 2018 01:21:50 +0000 (UTC) Message-ID: <7302f4a13c1cbf62b07f636878ce25fcca84b6c4.camel@perches.com> Subject: [PATCH] xfs: Remove noinline from #define STATIC From: Joe Perches To: "Darrick J. Wong" , Christoph Hellwig Cc: linux-xfs@vger.kernel.org, LKML Date: Sat, 10 Nov 2018 17:21:49 -0800 User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Reduce total object size quite a bit (~32KB) and presumably improve performance at the same time. Total object size old vs new (x86-64 defconfig with xfs) text data bss dec hex filename - 959351 165573 632 1125556 112cb4 (TOTALS) (old) + 924683 165669 632 1090984 10a5a8 (TOTALS) (new) Signed-off-by: Joe Perches --- fs/xfs/xfs_linux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h index edbd5a210df2..f33c8b626bca 100644 --- a/fs/xfs/xfs_linux.h +++ b/fs/xfs/xfs_linux.h @@ -242,7 +242,7 @@ static inline uint64_t howmany_64(uint64_t x, uint32_t y) #endif /* XFS_WARN */ #endif /* DEBUG */ -#define STATIC static noinline +#define STATIC static #ifdef CONFIG_XFS_RT