| Message ID | YtVCOtQ7PCRfjXY6@kili (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | xfs: delete unnecessary NULL checks | expand |
On Mon, Jul 18, 2022 at 02:21:30PM +0300, Dan Carpenter wrote: > These NULL check are no long needed after commit 2ed5b09b3e8f ("xfs: > make inode attribute forks a permanent part of struct xfs_inode"). > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Looks correct, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/libxfs/xfs_inode_fork.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_inode_fork.c b/fs/xfs/libxfs/xfs_inode_fork.c > index 7c34184448e6..fa699f3792bf 100644 > --- a/fs/xfs/libxfs/xfs_inode_fork.c > +++ b/fs/xfs/libxfs/xfs_inode_fork.c > @@ -724,8 +724,7 @@ xfs_ifork_verify_local_attr( > > if (fa) { > xfs_inode_verifier_error(ip, -EFSCORRUPTED, "attr fork", > - ifp ? ifp->if_u1.if_data : NULL, > - ifp ? ifp->if_bytes : 0, fa); > + ifp->if_u1.if_data, ifp->if_bytes, fa); > return -EFSCORRUPTED; > } > > -- > 2.35.1 >
diff --git a/fs/xfs/libxfs/xfs_inode_fork.c b/fs/xfs/libxfs/xfs_inode_fork.c index 7c34184448e6..fa699f3792bf 100644 --- a/fs/xfs/libxfs/xfs_inode_fork.c +++ b/fs/xfs/libxfs/xfs_inode_fork.c @@ -724,8 +724,7 @@ xfs_ifork_verify_local_attr( if (fa) { xfs_inode_verifier_error(ip, -EFSCORRUPTED, "attr fork", - ifp ? ifp->if_u1.if_data : NULL, - ifp ? ifp->if_bytes : 0, fa); + ifp->if_u1.if_data, ifp->if_bytes, fa); return -EFSCORRUPTED; }
These NULL check are no long needed after commit 2ed5b09b3e8f ("xfs: make inode attribute forks a permanent part of struct xfs_inode"). Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- fs/xfs/libxfs/xfs_inode_fork.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)