[v5,2/3] common/rc: Add a new _require_scratch_extsize helper function

Commit Message

Nirjhar Roy Nov. 27, 2024, 4:28 a.m. UTC

_require_scratch_extsize helper function will be used in the
the next patch to make the test run only on filesystems with
extsize support.

Reviewed-by: "Darrick J. Wong" <[e-mail]>
Reviewed-by: Christoph Hellwig <[e-mail]>
Reviewed-by: Ojaswin Mujoo <[e-mail]>
Signed-off-by: Nirjhar Roy <[e-mail]>
---
 common/rc | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Ritesh Harjani (IBM) Nov. 27, 2024, 5:06 a.m. UTC | #1

Nirjhar Roy <[e-mail]> writes:

> _require_scratch_extsize helper function will be used in the
> the next patch to make the test run only on filesystems with
> extsize support.
>

Sure. Thanks for addressing the review comments.
The patch looks good to me. Please feel free to add -

Reviewed-by: Ritesh Harjani (IBM) <[e-mail]>

Nirjhar Roy Nov. 27, 2024, 5:11 a.m. UTC | #2

On 11/27/24 10:36, Ritesh Harjani (IBM) wrote:
> Nirjhar Roy <[e-mail]> writes:
>
>> _require_scratch_extsize helper function will be used in the
>> the next patch to make the test run only on filesystems with
>> extsize support.
>>
> Sure. Thanks for addressing the review comments.
> The patch looks good to me. Please feel free to add -
>
> Reviewed-by: Ritesh Harjani (IBM) <[e-mail]>
Thank you.

Patch

diff --git a/common/rc b/common/rc
index f94bee5e..e6c6047d 100644
--- a/common/rc
+++ b/common/rc
@@ -48,6 +48,23 @@  _test_fsxattr_xflag()
 	grep -q "fsxattr.xflags.*\[.*$2.*\]" <($XFS_IO_PROG -c "stat -v" "$1")
 }
 
+# This test requires extsize support on the  filesystem
+_require_scratch_extsize()
+{
+	_require_scratch
+	_require_xfs_io_command "extsize"
+	_scratch_mkfs > /dev/null
+	_scratch_mount
+	local filename=$SCRATCH_MNT/$RANDOM
+	local blksz=$(_get_block_size $SCRATCH_MNT)
+	local extsz=$(( blksz*2 ))
+	local res=$($XFS_IO_PROG -c "open -f $filename" -c "extsize $extsz" \
+		-c "extsize")
+	_scratch_unmount
+	grep -q "\[$extsz\] $filename" <(echo $res) || \
+		_notrun "this test requires extsize support on the filesystem"
+}
+
 # Write a byte into a range of a file
 _pwrite_byte() {
 	local pattern="$1"