From patchwork Wed Aug 22 15:18:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10573009 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A276E5A4 for ; Wed, 22 Aug 2018 15:18:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FEA82B8A3 for ; Wed, 22 Aug 2018 15:18:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8336D2B8A5; Wed, 22 Aug 2018 15:18:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EC6742B8A3 for ; Wed, 22 Aug 2018 15:18:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B33A89D7C; Wed, 22 Aug 2018 15:18:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0609.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::609]) by gabe.freedesktop.org (Postfix) with ESMTPS id 21D0F89D7C for ; Wed, 22 Aug 2018 15:18:46 +0000 (UTC) Received: from e114479-lin.cambridge.arm.com (217.140.106.49) by HE1PR0802MB2554.eurprd08.prod.outlook.com (2603:10a6:3:e1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1059.22; Wed, 22 Aug 2018 15:18:41 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH v2] drm/malidp: Fix writeback in NV12 Date: Wed, 22 Aug 2018 16:18:19 +0100 Message-Id: <20180822151819.19684-1-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-Originating-IP: [217.140.106.49] X-ClientProxiedBy: CWLP265CA0089.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:50::29) To HE1PR0802MB2554.eurprd08.prod.outlook.com (2603:10a6:3:e1::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3384a7a-a827-4ef0-1fee-08d608428ba5 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:HE1PR0802MB2554; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2554; 3:69eJhnLRPtlJSws7QG3FOoN7S57vjZRWnY37ITiL6o6VQxeUuc5Nli2RKD0o8sTQH0DTiBhB2UmC2woWiohTuaCWEQzcy/VVtLfVMiGcxjXeDBimBbNPmJ21wVTnQ5nsIidk8HeOctgB5mKMO1bqMEKEzD2ycV9xnvG1S5hg6uq7tIq5d7LvZcxkJMXDRN4w+I7c45OHw8aw0BLUxOe4nSb6aCFyzJxkHpWJLZeGLae0KPugOFtjo5Yql/8MNpAJ; 25:rdV1VrkRtWQWLBzLCs4WlzoUpSWi8y7jt0jWW2SQGJLF32VeHjry9zHWLopCIKdfRaJfJtyAObRkIJOQ0KfQxd/tXiCd8WllTmP0GWWaaxzVMJB0tlsjw8ZFLxMswDWXFW/ggH2/sQ3gla6+fxBICSd6Dbyw1+RhyUO3iE0QarU7ZyD51prbPGia00JuYnEQv46ZlIu7pGpj/7DMShS6Yn47G9vMFzcswXEPq1CqfTYUbIl/VYwEBGnj+acvYg4Oy3Q+8F+VJmwJLLG+XWmSbkD8Ytm8s5lR5JqkEOrmhsWqmmlEbnc+X0Ps2mGFhzJbfYjGqUWBzCcJ+cJ4FZOHlQ==; 31:W61BSbqYPg7XWwQnj9bvYS7tUD1z7k3HdOuL5uQ6t3H7GG3qNKuu5yr85KbS5QMtV+kFl0cJ0heb05EYPmhZJd6nZoM7dPA7uGEslr5exVieKsmYDc7EQMB01pAmMhlpRHJqk2GaNied2yCmy4LXvKi+4SlEGPVJqLmG15wH74f5G54Y3JGHFUWjVUrUkIsCvNfGhCKyyC0ti877mPGhgGAzjUhLK+9yC1XN6A7pfHU= X-MS-TrafficTypeDiagnostic: HE1PR0802MB2554: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2554; 20:mmVNGFUjrOh7vRdwdqGL+ouITaoEzEp9OONU6GJkTpyN9FelZhFdwqD9sVI71Mf2XzG+qjM+KKp1J+naNoqE5UjTp6Ai8DmT1e559ObYkGoPRKHul3kF9csJ/8QVXVQwWkubPWqrAk2KFuOHeLhEZ5XhFXXNifTlODMSvIfuujX8RBxlYKWsum5/h6mrAME9gNqbNrYEps7PLaX5GORCyq88oKP6yDHXswxJkgYBJ3E3bsHl9ehstrvLBWz5DEk5On5vba/erVz/Z+yEFHBYUQZXw3ZcR/r7x/3q++VRcc7gzejTxkZXhHVTahq9rZb3LIXcUsJmJUrYR/6I1k0eqw==; 4:5VGXAhp1rSDg59SYgxgekXu6GEhMRF2ZOF5Ye3vfjFwPF48wYvITNmJmagI/Az47xlI/zJnTLxcWqYKK9T3JcaoR6MV5dMPmxl7M7TwzWGN+h+lUm2jMmfnYaH68SG8EGRVP1xV7v6Qcmfp5f/ydRtk7OqrwtRyFVxfpjNqPi9D5FtZHl/caI9cXpdfW8/Cf5X1D91veIF7p1Yt40AocwCGa5iHkeU5UusO/hxM+8vhBTrKlbg8/92BkNBQ2hLan2Hd5V+i7bZc3OKjTIDTTjPD+2MyiWc/DYD2QwmQRexdRFswutOMTWRj+V3iFkDWkJiqkwXkhelnBmj1JdSnpt8/R6bF9cUhXrrz0JiXgDC0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(217544274631240); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699016); SRVR:HE1PR0802MB2554; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0802MB2554; X-Forefront-PRVS: 0772E5DAD5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(376002)(366004)(39860400002)(136003)(199004)(189003)(486006)(7696005)(2616005)(106356001)(6666003)(956004)(476003)(105586002)(86362001)(48376002)(50466002)(51416003)(575784001)(52116002)(8676002)(3846002)(81166006)(68736007)(4326008)(25786009)(6116002)(5660300001)(81156014)(305945005)(7736002)(1076002)(478600001)(26005)(36756003)(186003)(53936002)(50226002)(6486002)(6306002)(72206003)(16586007)(2906002)(386003)(47776003)(97736004)(316002)(16526019)(966005)(8936002)(66066001)(6346003)(309714004); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0802MB2554; H:e114479-lin.cambridge.arm.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0802MB2554; 23:AslAm+IVTk/Nq+np086OsUKwIzEMwgYiw3lnrA7?= wKCtyf+mrqeGtYNRLceX8TAD2JvxC1BzH3jXEpnPvrz7I6/VOa9aC1bt5dFf2uXGHWZSuK/W/LJR2WVjajq4DCfpE4KWeotOI7I4jevoRY2u0ALIo6+I538opZNLGP4j879WBFTdulA8kod+3ChspGKZhTMLZaQNfjV1fDm3sBEhAYWaaO+riz70mOM8L69NDR4kGTUEgM63kSGLDPEXZdORLRSsac1AQyOQHuOvUDpJq31LljGKfXL17fsBEgvqUO1jUeUDFBLqKSFhpXCWN2Y4aj4glKv/U6CV1Ytsg0tt7MBuWiJNLDvdTIE5u8AyKuZdZc3oXFzH4+BKZiYrFMMCPYXxGUXHMaqaf186EXm+MoHnPChEqWZaueqYJZ6N/FzMWBOeavG2h3TCZq5UYbmqx+Gqg3ACVjZQ4mXf7ESt9yhV5mKES1eIXDLq/ln5XF/3vnh8HRHbXR7sF8eBCZWOZKFiRCzDp8GFq2N7iHSAAmuhi5p1P0UCGBx7rxWMmXK4muTaAja4KaM6jmNbKsnlUMvCNp4Y0HSYEpF7kPN8VcE550wQO1v5vRC2YkkIOQIHIU6aYgC+T+5oEhFIr7iL3B/ctcJrYsQmwDKO+O5KECD7QEIfVh0MGPGaIblhhMDJBqB7ACrBMs5SI1SaelsH1X4amxGbd8gKUZYzwHupiF5x8taTvQVwOziV0qayUwrpTrL8G+xYMbJfU6USpbqjE///Hve+5/EGzmxb+/15bq8jTcRBQ3tdS1jDbJTsamSjtZotXt41QW8qcTYvT9QggczAnp78ejWxQ5gmgWnH/og5O6xgsnOapdeVP56fTsQy3RTaYyxY1tFeBvSbWYPd5TGzKNGoOI+O7m7Kl3QYln8hGtj4qd0hMHBPbJhvMahwhwkHBwKBu7MHl3roBwQ0cYPUiwG5daDQRxT+6oUbXJjld/EB9KyX9MrNwBiBwjXjInyddREtx/KzKgo5vlB2tvcJ3vjCHwTnCjoWPJ3jwpyWYWPtEby+O0TA9LDbXaEINcc1JqPrbXGp7O7y4UufjyTTCl3oJU/rTAMWDZK81sEKNmKZ+AgQ0VP6OKvmSjlO1iEH9Ye3c/7z5PL7wVCBK1JGljWFTAvcPVcvplLd3LwWRTrw/Grs/lJHWhitmf1TL14kuT6PEyKtvJaSnAOEt X-Microsoft-Antispam-Message-Info: vNTOqw7kR6nbx4vG/MGZQ5jrApvmxzo+SBq/KackE+8HJyzEzGMemTYzscX+mTOl8RPn4AUCukj1e4FkUo5e6vy6d+AyM8UjihTidA3RuqWqkHf6YDhAaF0L3gwtM6Pd2O7MNkVlp6hclBpu4dgV9/4ZRJbyU15YS49I0iGOL8+Jvf3fe8NGed8IwmtS9h9KVIsd26ffCh39EGXzP7kOUsjfISxcHcg3205OwsHZpW5hxmxnjdkqEs15le0T+B0+J4Rfgt5EDunlC7ju2Msb9HBR6qvUG7HKpD8giUAeszB9dHq5p3qTdj6qJRzyt5wMssa70NWlp5j9u3imPACDTs0cInckDP8i7xI2YHKK5/k= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2554; 6:6WJoIUX7IYFofxYt9bHKYGYloCiSHwKBDhoIBs39cvApSB2ffWswVwBacHu2+0vKu/vH6ub6G327hKRbxH3drptP+ItfJ910JJ3vtWkHw5cdEmsPN4Vlt/8KoSnhJ/oHwFfS+Q4Cc+tM0Gw2oDeFoWqY1NfxmVYElDuDTNOZXdQN95D84o/8IgscZxcY9csgMakBrh2I2AT0UVe0XCw7Vl+H79KY9Q6aKVV1VIfRFbL6BQrM1HDudcnL8fe56LkX6rRO6IoGv78WTL22IaIoRSRDlJ289RthLGU8TUUqsrROHO5RjkdTKaqIaZIvztSS7fvW2DeuCDJlFfsS14ANmJlbigiHFNMyoqXCaMVX5bcR9gZ3shTEaMNmwmYu3zdVeIjhHsC9BW+ZFeC28w/z50logP3Hy8nciYGn2TWWVCeM90VsNfn+xwPtEb/CBhSmHZ8ZTmLlOIx0fcBcTbjIFQ==; 5:HEzB+yEE/QT+fX/p/VZkFq6v5GY5UkA8pIIfLAsXMLj+ThVQtzbfDkIbh9ml1SpxQ9g9AEaexHpVaRU8WSbfiIo0/mfg+V5Z637hlwfwFvAeu62w2Nge1+tUaDbUZGP4CVQZLrBFLkt91cf+xqGLFAvy2yJQbX9WPaOcIkqm6h4=; 7:/NiX/6f22zlcyg5gs6z6eIo9bNryKZsklBJMRtmtUOiETUIH9WY+CnER7k5kWrxdOOdn172xxuGlrB5Q8r1hm96djnj7Uglx0DtdZYzKwZrB5CYLfmNym7/ah4KSSK/emaNba4089Hc6kQqNniuabIfxHRLRzh15kwE/gQSW0sdJB3QdYASMZEhbt8ooTMjlylDjWPlZ2i9KFuRILXspr33LJW9AyEVe29WDz/ctN6qlY5AWjvQhPOubtZ1IBOd3 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2018 15:18:41.7677 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3384a7a-a827-4ef0-1fee-08d608428ba5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2554 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Alexandru Gheorghe Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP When we want to writeback to memory in NV12 format we need to program the RGB2YUV coefficients. Currently, we don't program the coefficients and NV12 doesn't work at all. This patchset fixes that by programming a sane default(bt709, limited range) as rgb2yuv coefficients. In the long run, probably we need to think of a way for userspace to be able to program that, but for now I think this is better than not working at all or not advertising NV12 as a supported format for memwrite. Changes since v1: - Write the rgb2yuv coefficients only once, since we don't change them at all, just write them the first time NV12 is programmed, suggested by Brian Starkey, here [1] [1] https://lists.freedesktop.org/archives/dri-devel/2018-August/186819.html Signed-off-by: Alexandru Gheorghe Acked-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_hw.c | 25 +++++++++++++++++++++++-- drivers/gpu/drm/arm/malidp_hw.h | 3 ++- drivers/gpu/drm/arm/malidp_mw.c | 25 +++++++++++++++++++++---- drivers/gpu/drm/arm/malidp_regs.h | 2 ++ 4 files changed, 48 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c index c94a4422e0e9..2781e462c1ed 100644 --- a/drivers/gpu/drm/arm/malidp_hw.c +++ b/drivers/gpu/drm/arm/malidp_hw.c @@ -384,7 +384,8 @@ static long malidp500_se_calc_mclk(struct malidp_hw_device *hwdev, static int malidp500_enable_memwrite(struct malidp_hw_device *hwdev, dma_addr_t *addrs, s32 *pitches, - int num_planes, u16 w, u16 h, u32 fmt_id) + int num_planes, u16 w, u16 h, u32 fmt_id, + const s16 *rgb2yuv_coeffs) { u32 base = MALIDP500_SE_MEMWRITE_BASE; u32 de_base = malidp_get_block_base(hwdev, MALIDP_DE_BLOCK); @@ -416,6 +417,16 @@ static int malidp500_enable_memwrite(struct malidp_hw_device *hwdev, malidp_hw_write(hwdev, MALIDP_DE_H_ACTIVE(w) | MALIDP_DE_V_ACTIVE(h), MALIDP500_SE_MEMWRITE_OUT_SIZE); + + if (rgb2yuv_coeffs) { + int i; + + for (i = 0; i < MALIDP_COLORADJ_NUM_COEFFS; i++) { + malidp_hw_write(hwdev, rgb2yuv_coeffs[i], + MALIDP500_SE_RGB_YUV_COEFFS + i * 4); + } + } + malidp_hw_setbits(hwdev, MALIDP_SE_MEMWRITE_EN, MALIDP500_SE_CONTROL); return 0; @@ -658,7 +669,8 @@ static long malidp550_se_calc_mclk(struct malidp_hw_device *hwdev, static int malidp550_enable_memwrite(struct malidp_hw_device *hwdev, dma_addr_t *addrs, s32 *pitches, - int num_planes, u16 w, u16 h, u32 fmt_id) + int num_planes, u16 w, u16 h, u32 fmt_id, + const s16 *rgb2yuv_coeffs) { u32 base = MALIDP550_SE_MEMWRITE_BASE; u32 de_base = malidp_get_block_base(hwdev, MALIDP_DE_BLOCK); @@ -689,6 +701,15 @@ static int malidp550_enable_memwrite(struct malidp_hw_device *hwdev, malidp_hw_setbits(hwdev, MALIDP550_SE_MEMWRITE_ONESHOT | MALIDP_SE_MEMWRITE_EN, MALIDP550_SE_CONTROL); + if (rgb2yuv_coeffs) { + int i; + + for (i = 0; i < MALIDP_COLORADJ_NUM_COEFFS; i++) { + malidp_hw_write(hwdev, rgb2yuv_coeffs[i], + MALIDP550_SE_RGB_YUV_COEFFS + i * 4); + } + } + return 0; } diff --git a/drivers/gpu/drm/arm/malidp_hw.h b/drivers/gpu/drm/arm/malidp_hw.h index ad2e96915d44..9fc94c08190f 100644 --- a/drivers/gpu/drm/arm/malidp_hw.h +++ b/drivers/gpu/drm/arm/malidp_hw.h @@ -191,7 +191,8 @@ struct malidp_hw { * @param fmt_id - internal format ID of output buffer */ int (*enable_memwrite)(struct malidp_hw_device *hwdev, dma_addr_t *addrs, - s32 *pitches, int num_planes, u16 w, u16 h, u32 fmt_id); + s32 *pitches, int num_planes, u16 w, u16 h, u32 fmt_id, + const s16 *rgb2yuv_coeffs); /* * Disable the writing to memory of the next frame's content. diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c index cfd718e7e97c..429a11e6473b 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -26,6 +26,8 @@ struct malidp_mw_connector_state { s32 pitches[2]; u8 format; u8 n_planes; + bool rgb2yuv_initialized; + const s16 *rgb2yuv_coeffs; }; static int malidp_mw_connector_get_modes(struct drm_connector *connector) @@ -84,7 +86,7 @@ static void malidp_mw_connector_destroy(struct drm_connector *connector) static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { - struct malidp_mw_connector_state *mw_state; + struct malidp_mw_connector_state *mw_state, *mw_current_state; if (WARN_ON(!connector->state)) return NULL; @@ -93,7 +95,10 @@ malidp_mw_connector_duplicate_state(struct drm_connector *connector) if (!mw_state) return NULL; - /* No need to preserve any of our driver-local data */ + mw_current_state = to_mw_state(connector->state); + mw_state->rgb2yuv_coeffs = mw_current_state->rgb2yuv_coeffs; + mw_state->rgb2yuv_initialized = mw_current_state->rgb2yuv_initialized; + __drm_atomic_helper_connector_duplicate_state(connector, &mw_state->base); return &mw_state->base; @@ -108,6 +113,13 @@ static const struct drm_connector_funcs malidp_mw_connector_funcs = { .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, }; +static const s16 rgb2yuv_coeffs_bt709_limited[MALIDP_COLORADJ_NUM_COEFFS] = { + 47, 157, 16, + -26, -87, 112, + 112, -102, -10, + 16, 128, 128 +}; + static int malidp_mw_encoder_atomic_check(struct drm_encoder *encoder, struct drm_crtc_state *crtc_state, @@ -157,6 +169,9 @@ malidp_mw_encoder_atomic_check(struct drm_encoder *encoder, } mw_state->n_planes = n_planes; + if (fb->format->is_yuv) + mw_state->rgb2yuv_coeffs = rgb2yuv_coeffs_bt709_limited; + return 0; } @@ -239,10 +254,12 @@ void malidp_mw_atomic_commit(struct drm_device *drm, drm_writeback_queue_job(mw_conn, conn_state->writeback_job); conn_state->writeback_job = NULL; - hwdev->hw->enable_memwrite(hwdev, mw_state->addrs, mw_state->pitches, mw_state->n_planes, - fb->width, fb->height, mw_state->format); + fb->width, fb->height, mw_state->format, + !mw_state->rgb2yuv_initialized ? + mw_state->rgb2yuv_coeffs : NULL); + mw_state->rgb2yuv_initialized = !!mw_state->rgb2yuv_coeffs; } else { DRM_DEV_DEBUG_DRIVER(drm->dev, "Disable memwrite\n"); hwdev->hw->disable_memwrite(hwdev); diff --git a/drivers/gpu/drm/arm/malidp_regs.h b/drivers/gpu/drm/arm/malidp_regs.h index 3579d36b2a71..6ffe849774f2 100644 --- a/drivers/gpu/drm/arm/malidp_regs.h +++ b/drivers/gpu/drm/arm/malidp_regs.h @@ -205,6 +205,7 @@ #define MALIDP500_SE_BASE 0x00c00 #define MALIDP500_SE_CONTROL 0x00c0c #define MALIDP500_SE_MEMWRITE_OUT_SIZE 0x00c2c +#define MALIDP500_SE_RGB_YUV_COEFFS 0x00C74 #define MALIDP500_SE_MEMWRITE_BASE 0x00e00 #define MALIDP500_DC_IRQ_BASE 0x00f00 #define MALIDP500_CONFIG_VALID 0x00f00 @@ -238,6 +239,7 @@ #define MALIDP550_SE_CONTROL 0x08010 #define MALIDP550_SE_MEMWRITE_ONESHOT (1 << 7) #define MALIDP550_SE_MEMWRITE_OUT_SIZE 0x08030 +#define MALIDP550_SE_RGB_YUV_COEFFS 0x08078 #define MALIDP550_SE_MEMWRITE_BASE 0x08100 #define MALIDP550_DC_BASE 0x0c000 #define MALIDP550_DC_CONTROL 0x0c010