From patchwork Wed Apr 17 03:15:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kailang X-Patchwork-Id: 10904409 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8326F161F for ; Wed, 17 Apr 2019 03:17:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D6C228A00 for ; Wed, 17 Apr 2019 03:17:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4C57228A14; Wed, 17 Apr 2019 03:17:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3AFDB28A00 for ; Wed, 17 Apr 2019 03:17:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 98C2C85F; Wed, 17 Apr 2019 05:16:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 98C2C85F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1555471022; bh=Tj1hM6UaWLs3MX0soDmsqQYGjC4c29NmAkEiV3LOQMs=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=ppSoCh/gUHObwfK0N2SKGmMoBpsG3IaKKFtNwwqFPMw3NTatPf6fech4DhpDlthpg h582a86UoTw3pBv5i5/sVlvUN9g22AciIC6lLX5RUxBT36n0BaNFoFivsSC6JTwpXj 0Yh6jKt8d5Scwvsz1sEk9IdvjzZsb9anQBlyH+jI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 224AEF896EA; Wed, 17 Apr 2019 05:16:12 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7B850F89616; Wed, 17 Apr 2019 05:16:09 +0200 (CEST) Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 21973F89616 for ; Wed, 17 Apr 2019 05:16:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 21973F89616 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID x3H3Ftjl013763, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtitcasv02.realtek.com.tw[172.21.6.19]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id x3H3Ftjl013763 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 17 Apr 2019 11:15:55 +0800 Received: from RTITMBSVM07.realtek.com.tw ([fe80::a512:a803:bf1e:b23]) by RTITCASV02.realtek.com.tw ([::1]) with mapi id 14.03.0439.000; Wed, 17 Apr 2019 11:15:55 +0800 From: Kailang To: "Takashi Iwai (tiwai@suse.de)" Thread-Topic: EAPD trun on time Thread-Index: AdT0ytP6oA8qEjL2SseRL0Zre5PoOg== Date: Wed, 17 Apr 2019 03:15:54 +0000 Message-ID: <6FAB7C47BCF00940BB0999A99BE3547A18DBBD24@RTITMBSVM07.realtek.com.tw> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.22.105.152] MIME-Version: 1.0 Cc: " \(alsa-devel@alsa-project.org\)" Subject: [alsa-devel] EAPD trun on time X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi Takashi, Our AE told me, that EAPD turn on timing which need to set pin out first. It's the safe application. It could avoid pop noise via speaker. So, could I do the modify as below patch. BR, Kailang Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 810479766090..efcd21b8e0d7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -804,9 +804,8 @@ static int alc_init(struct hda_codec *codec) spec->init_hook(codec); alc_fix_pll(codec); - alc_auto_init_amp(codec, spec->init_amp); - snd_hda_gen_init(codec); + alc_auto_init_amp(codec, spec->init_amp); snd_hda_apply_fixup(codec, HDA_FIXUP_ACT_INIT); _______________________________________________