From patchwork Wed May 8 03:11:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Murphy Zhou X-Patchwork-Id: 10934143 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 325D51390 for ; Wed, 8 May 2019 03:11:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1751B2899E for ; Wed, 8 May 2019 03:11:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0A46E289C2; Wed, 8 May 2019 03:11:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F5AF2899E for ; Wed, 8 May 2019 03:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726576AbfEHDLv (ORCPT ); Tue, 7 May 2019 23:11:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36196 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726371AbfEHDLv (ORCPT ); Tue, 7 May 2019 23:11:51 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC6B83082E0F; Wed, 8 May 2019 03:11:50 +0000 (UTC) Received: from localhost (dhcp-12-130.nay.redhat.com [10.66.12.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E20960123; Wed, 8 May 2019 03:11:50 +0000 (UTC) From: Murphy Zhou To: fstests@vger.kernel.org Cc: darrick.wong@oracle.com, Murphy Zhou Subject: [PATCH] generic/532: do not break golden silence if attributes_mask is 0 Date: Wed, 8 May 2019 11:11:44 +0800 Message-Id: <20190508031144.17895-1-xzhou@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 08 May 2019 03:11:51 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If the filesystem does not support STATX_ATTR, like NFS, setting both attributes and attributes_mask to 0 seems the right thing to do. attributes_mask can be 0 only if attributes is also 0. This situation is covered by the "&" check in the next line. Signed-off-by: Murphy Zhou Reviewed-by: Darrick J. Wong --- tests/generic/532 | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/generic/532 b/tests/generic/532 index ac8b7a89..3f8afa4a 100755 --- a/tests/generic/532 +++ b/tests/generic/532 @@ -44,7 +44,6 @@ check_statx_attributes() echo "MASK:$mask:ATTRS:$attrs:" >> $seqres.full test -z "$mask" && _notrun "xfs_io statx command does not support attributes_mask" - test $(( mask )) -eq 0 && echo "attributes mask is zero" test $(( attrs & ~(mask) )) -ne 0 && echo "attributes $attrs do not appear in mask $mask" }