From patchwork Sat May 18 21:27:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949089 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7CE601398 for ; Sat, 18 May 2019 21:28:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60EF028541 for ; Sat, 18 May 2019 21:28:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 529972857D; Sat, 18 May 2019 21:28:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8710928541 for ; Sat, 18 May 2019 21:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729493AbfERV2L (ORCPT ); Sat, 18 May 2019 17:28:11 -0400 Received: from sauhun.de ([88.99.104.3]:35766 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727600AbfERV2K (ORCPT ); Sat, 18 May 2019 17:28:10 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 7CC142C0590; Sat, 18 May 2019 23:28:08 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 01/46] watchdog: make watchdog_deferred_registration_add() void Date: Sat, 18 May 2019 23:27:16 +0200 Message-Id: <20190518212801.31010-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It cannot fail, so no return value needed. Signed-off-by: Wolfram Sang --- drivers/watchdog/watchdog_core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c index 62be9e52a4de..9fd096af0cc5 100644 --- a/drivers/watchdog/watchdog_core.c +++ b/drivers/watchdog/watchdog_core.c @@ -60,11 +60,10 @@ static DEFINE_MUTEX(wtd_deferred_reg_mutex); static LIST_HEAD(wtd_deferred_reg_list); static bool wtd_deferred_reg_done; -static int watchdog_deferred_registration_add(struct watchdog_device *wdd) +static void watchdog_deferred_registration_add(struct watchdog_device *wdd) { list_add_tail(&wdd->deferred, &wtd_deferred_reg_list); - return 0; } static void watchdog_deferred_registration_del(struct watchdog_device *wdd) @@ -265,13 +264,13 @@ static int __watchdog_register_device(struct watchdog_device *wdd) int watchdog_register_device(struct watchdog_device *wdd) { - int ret; + int ret = 0; mutex_lock(&wtd_deferred_reg_mutex); if (wtd_deferred_reg_done) ret = __watchdog_register_device(wdd); else - ret = watchdog_deferred_registration_add(wdd); + watchdog_deferred_registration_add(wdd); mutex_unlock(&wtd_deferred_reg_mutex); return ret; } From patchwork Sat May 18 21:27:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949097 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0E46F17EE for ; Sat, 18 May 2019 21:28:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF60928564 for ; Sat, 18 May 2019 21:28:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DB3F328574; Sat, 18 May 2019 21:28:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A724C28564 for ; Sat, 18 May 2019 21:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727600AbfERV2L (ORCPT ); Sat, 18 May 2019 17:28:11 -0400 Received: from sauhun.de ([88.99.104.3]:35780 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728435AbfERV2K (ORCPT ); Sat, 18 May 2019 17:28:10 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 135652C059D; Sat, 18 May 2019 23:28:09 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 02/46] watchdog: let core print error message when registering device fails Date: Sat, 18 May 2019 23:27:17 +0200 Message-Id: <20190518212801.31010-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP So we can remove boilerplate code from drivers. Signed-off-by: Wolfram Sang --- drivers/watchdog/watchdog_core.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c index 9fd096af0cc5..cf3247224a6e 100644 --- a/drivers/watchdog/watchdog_core.c +++ b/drivers/watchdog/watchdog_core.c @@ -264,6 +264,7 @@ static int __watchdog_register_device(struct watchdog_device *wdd) int watchdog_register_device(struct watchdog_device *wdd) { + const char *dev_str; int ret = 0; mutex_lock(&wtd_deferred_reg_mutex); @@ -272,6 +273,14 @@ int watchdog_register_device(struct watchdog_device *wdd) else watchdog_deferred_registration_add(wdd); mutex_unlock(&wtd_deferred_reg_mutex); + + if (ret) { + dev_str = wdd->parent ? dev_name(wdd->parent) : + (const char *)wdd->info->identity; + pr_err("%s: failed to register watchdog device (err = %d)\n", + dev_str, ret); + } + return ret; } EXPORT_SYMBOL_GPL(watchdog_register_device); From patchwork Sat May 18 21:27:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949091 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 98FAC17DF for ; Sat, 18 May 2019 21:28:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B1E528541 for ; Sat, 18 May 2019 21:28:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7FCBB2857D; Sat, 18 May 2019 21:28:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7DDD28567 for ; Sat, 18 May 2019 21:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728435AbfERV2L (ORCPT ); Sat, 18 May 2019 17:28:11 -0400 Received: from sauhun.de ([88.99.104.3]:35782 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729196AbfERV2L (ORCPT ); Sat, 18 May 2019 17:28:11 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 9442C2C05C1; Sat, 18 May 2019 23:28:09 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Joel Stanley , Andrew Jeffery Subject: [PATCH 03/46] watchdog: aspeed_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:18 +0200 Message-Id: <20190518212801.31010-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang Reviewed-by: Andrew Jeffery --- drivers/watchdog/aspeed_wdt.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c index 34117745c65f..3ad2558a6de0 100644 --- a/drivers/watchdog/aspeed_wdt.c +++ b/drivers/watchdog/aspeed_wdt.c @@ -313,13 +313,7 @@ static int aspeed_wdt_probe(struct platform_device *pdev) if (status & WDT_TIMEOUT_STATUS_BOOT_SECONDARY) wdt->wdd.bootstatus = WDIOF_CARDRESET; - ret = devm_watchdog_register_device(dev, &wdt->wdd); - if (ret) { - dev_err(dev, "failed to register\n"); - return ret; - } - - return 0; + return devm_watchdog_register_device(dev, &wdt->wdd); } static struct platform_driver aspeed_watchdog_driver = { From patchwork Sat May 18 21:27:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949093 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B53CE6C5 for ; Sat, 18 May 2019 21:28:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A664F28541 for ; Sat, 18 May 2019 21:28:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9298E2857E; Sat, 18 May 2019 21:28:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CD8028573 for ; Sat, 18 May 2019 21:28:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729554AbfERV2L (ORCPT ); Sat, 18 May 2019 17:28:11 -0400 Received: from sauhun.de ([88.99.104.3]:35810 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729427AbfERV2L (ORCPT ); Sat, 18 May 2019 17:28:11 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 228532C05DB; Sat, 18 May 2019 23:28:10 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Subject: [PATCH 04/46] watchdog: bcm2835_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:19 +0200 Message-Id: <20190518212801.31010-5-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/bcm2835_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c index 560c1c54c177..027a36c40ab3 100644 --- a/drivers/watchdog/bcm2835_wdt.c +++ b/drivers/watchdog/bcm2835_wdt.c @@ -202,10 +202,8 @@ static int bcm2835_wdt_probe(struct platform_device *pdev) watchdog_stop_on_reboot(&bcm2835_wdt_wdd); err = devm_watchdog_register_device(dev, &bcm2835_wdt_wdd); - if (err) { - dev_err(dev, "Failed to register watchdog device"); + if (err) return err; - } if (pm_power_off == NULL) { pm_power_off = bcm2835_power_off; From patchwork Sat May 18 21:27:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 44A1E1921 for ; Sat, 18 May 2019 21:28:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 364F72856F for ; Sat, 18 May 2019 21:28:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2A9CB28573; Sat, 18 May 2019 21:28:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D851E2856F for ; Sat, 18 May 2019 21:28:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729561AbfERV2M (ORCPT ); Sat, 18 May 2019 17:28:12 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729535AbfERV2M (ORCPT ); Sat, 18 May 2019 17:28:12 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id A3BD72C060D; Sat, 18 May 2019 23:28:10 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 05/46] watchdog: bcm7038_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:20 +0200 Message-Id: <20190518212801.31010-6-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/bcm7038_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/bcm7038_wdt.c b/drivers/watchdog/bcm7038_wdt.c index d3d88f6703d7..979caa18d3c8 100644 --- a/drivers/watchdog/bcm7038_wdt.c +++ b/drivers/watchdog/bcm7038_wdt.c @@ -159,10 +159,8 @@ static int bcm7038_wdt_probe(struct platform_device *pdev) watchdog_stop_on_reboot(&wdt->wdd); watchdog_stop_on_unregister(&wdt->wdd); err = devm_watchdog_register_device(dev, &wdt->wdd); - if (err) { - dev_err(dev, "Failed to register watchdog device\n"); + if (err) return err; - } dev_info(dev, "Registered BCM7038 Watchdog\n"); From patchwork Sat May 18 21:27:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F1641398 for ; Sat, 18 May 2019 21:28:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F72928541 for ; Sat, 18 May 2019 21:28:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7395E2856F; Sat, 18 May 2019 21:28:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A08428541 for ; Sat, 18 May 2019 21:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729562AbfERV2M (ORCPT ); Sat, 18 May 2019 17:28:12 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728283AbfERV2M (ORCPT ); Sat, 18 May 2019 17:28:12 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 3189A2C0636; Sat, 18 May 2019 23:28:11 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Subject: [PATCH 06/46] watchdog: bcm_kona_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:21 +0200 Message-Id: <20190518212801.31010-7-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/bcm_kona_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/bcm_kona_wdt.c b/drivers/watchdog/bcm_kona_wdt.c index e2ad44816359..a3e280840a27 100644 --- a/drivers/watchdog/bcm_kona_wdt.c +++ b/drivers/watchdog/bcm_kona_wdt.c @@ -307,10 +307,8 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev) watchdog_stop_on_reboot(&bcm_kona_wdt_wdd); watchdog_stop_on_unregister(&bcm_kona_wdt_wdd); ret = devm_watchdog_register_device(dev, &bcm_kona_wdt_wdd); - if (ret) { - dev_err(dev, "Failed to register watchdog device"); + if (ret) return ret; - } bcm_kona_wdt_debug_init(pdev); dev_dbg(dev, "Broadcom Kona Watchdog Timer"); From patchwork Sat May 18 21:27:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949103 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 112126C5 for ; Sat, 18 May 2019 21:28:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 00B7B28541 for ; Sat, 18 May 2019 21:28:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E936D2856F; Sat, 18 May 2019 21:28:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A324328541 for ; Sat, 18 May 2019 21:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729568AbfERV2N (ORCPT ); Sat, 18 May 2019 17:28:13 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729427AbfERV2N (ORCPT ); Sat, 18 May 2019 17:28:13 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id B25AD2C051A; Sat, 18 May 2019 23:28:11 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 07/46] watchdog: cadence_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:22 +0200 Message-Id: <20190518212801.31010-8-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/cadence_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c index a22f2d431a35..f8d4e91d0383 100644 --- a/drivers/watchdog/cadence_wdt.c +++ b/drivers/watchdog/cadence_wdt.c @@ -363,10 +363,8 @@ static int cdns_wdt_probe(struct platform_device *pdev) watchdog_stop_on_reboot(cdns_wdt_device); watchdog_stop_on_unregister(cdns_wdt_device); ret = devm_watchdog_register_device(dev, cdns_wdt_device); - if (ret) { - dev_err(dev, "Failed to register wdt device\n"); + if (ret) return ret; - } platform_set_drvdata(pdev, wdt); dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n", From patchwork Sat May 18 21:27:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 851D91398 for ; Sat, 18 May 2019 21:28:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75A4A28541 for ; Sat, 18 May 2019 21:28:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 69EF328567; Sat, 18 May 2019 21:28:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23F5A28564 for ; Sat, 18 May 2019 21:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729578AbfERV2N (ORCPT ); Sat, 18 May 2019 17:28:13 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729535AbfERV2N (ORCPT ); Sat, 18 May 2019 17:28:13 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 410142C0665; Sat, 18 May 2019 23:28:12 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Support Opensource , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 08/46] watchdog: da9052_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:23 +0200 Message-Id: <20190518212801.31010-9-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang Acked-by: Steve Twiss --- drivers/watchdog/da9052_wdt.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c index a2feef1ff307..d708c091bf1b 100644 --- a/drivers/watchdog/da9052_wdt.c +++ b/drivers/watchdog/da9052_wdt.c @@ -176,14 +176,7 @@ static int da9052_wdt_probe(struct platform_device *pdev) return ret; } - ret = devm_watchdog_register_device(dev, &driver_data->wdt); - if (ret != 0) { - dev_err(da9052->dev, "watchdog_register_device() failed: %d\n", - ret); - return ret; - } - - return ret; + return devm_watchdog_register_device(dev, &driver_data->wdt); } static struct platform_driver da9052_wdt_driver = { From patchwork Sat May 18 21:27:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949109 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D9BAC17DF for ; Sat, 18 May 2019 21:28:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C932728541 for ; Sat, 18 May 2019 21:28:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BD44D28564; Sat, 18 May 2019 21:28:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A0062856F for ; Sat, 18 May 2019 21:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729582AbfERV2O (ORCPT ); Sat, 18 May 2019 17:28:14 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728283AbfERV2O (ORCPT ); Sat, 18 May 2019 17:28:14 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id C2DF12C077A; Sat, 18 May 2019 23:28:12 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Support Opensource , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 09/46] watchdog: da9062_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:24 +0200 Message-Id: <20190518212801.31010-10-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang Acked-by: Steve Twiss --- drivers/watchdog/da9062_wdt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c index aac749cfaccb..e149e66a6ea9 100644 --- a/drivers/watchdog/da9062_wdt.c +++ b/drivers/watchdog/da9062_wdt.c @@ -214,11 +214,8 @@ static int da9062_wdt_probe(struct platform_device *pdev) watchdog_set_drvdata(&wdt->wdtdev, wdt); ret = devm_watchdog_register_device(dev, &wdt->wdtdev); - if (ret < 0) { - dev_err(wdt->hw->dev, - "watchdog registration failed (%d)\n", ret); + if (ret < 0) return ret; - } return da9062_wdt_ping(&wdt->wdtdev); } From patchwork Sat May 18 21:27:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949111 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 799291398 for ; Sat, 18 May 2019 21:28:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6980928541 for ; Sat, 18 May 2019 21:28:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5BED128567; Sat, 18 May 2019 21:28:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3C2828541 for ; Sat, 18 May 2019 21:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729588AbfERV2O (ORCPT ); Sat, 18 May 2019 17:28:14 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729427AbfERV2O (ORCPT ); Sat, 18 May 2019 17:28:14 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 50A022C077B; Sat, 18 May 2019 23:28:13 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 10/46] watchdog: davinci_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:25 +0200 Message-Id: <20190518212801.31010-11-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/davinci_wdt.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c index 7b2ee35b5ffd..49a81c32a1b7 100644 --- a/drivers/watchdog/davinci_wdt.c +++ b/drivers/watchdog/davinci_wdt.c @@ -247,13 +247,7 @@ static int davinci_wdt_probe(struct platform_device *pdev) if (IS_ERR(davinci_wdt->base)) return PTR_ERR(davinci_wdt->base); - ret = devm_watchdog_register_device(dev, wdd); - if (ret) { - dev_err(dev, "cannot register watchdog device\n"); - return ret; - } - - return 0; + return devm_watchdog_register_device(dev, wdd); } static const struct of_device_id davinci_wdt_of_match[] = { From patchwork Sat May 18 21:27:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949113 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 308F96C5 for ; Sat, 18 May 2019 21:28:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2187E28564 for ; Sat, 18 May 2019 21:28:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1614D28567; Sat, 18 May 2019 21:28:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C611628541 for ; Sat, 18 May 2019 21:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729600AbfERV2P (ORCPT ); Sat, 18 May 2019 17:28:15 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729535AbfERV2P (ORCPT ); Sat, 18 May 2019 17:28:15 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id D37742C077C; Sat, 18 May 2019 23:28:13 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Baruch Siach Subject: [PATCH 11/46] watchdog: digicolor_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:26 +0200 Message-Id: <20190518212801.31010-12-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/digicolor_wdt.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c index 8af6e9a67d0d..33cda95bd238 100644 --- a/drivers/watchdog/digicolor_wdt.c +++ b/drivers/watchdog/digicolor_wdt.c @@ -141,13 +141,7 @@ static int dc_wdt_probe(struct platform_device *pdev) watchdog_set_restart_priority(&dc_wdt_wdd, 128); watchdog_init_timeout(&dc_wdt_wdd, timeout, dev); watchdog_stop_on_reboot(&dc_wdt_wdd); - ret = devm_watchdog_register_device(dev, &dc_wdt_wdd); - if (ret) { - dev_err(dev, "Failed to register watchdog device"); - return ret; - } - - return 0; + return devm_watchdog_register_device(dev, &dc_wdt_wdd); } static const struct of_device_id dc_wdt_of_match[] = { From patchwork Sat May 18 21:27:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949115 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8023E17DF for ; Sat, 18 May 2019 21:28:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70D0428541 for ; Sat, 18 May 2019 21:28:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 652FE28567; Sat, 18 May 2019 21:28:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20D7828541 for ; Sat, 18 May 2019 21:28:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729602AbfERV2P (ORCPT ); Sat, 18 May 2019 17:28:15 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729583AbfERV2P (ORCPT ); Sat, 18 May 2019 17:28:15 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 614712C07A9; Sat, 18 May 2019 23:28:14 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 12/46] watchdog: ftwdt010_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:27 +0200 Message-Id: <20190518212801.31010-13-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/ftwdt010_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/ftwdt010_wdt.c b/drivers/watchdog/ftwdt010_wdt.c index 9ea0e56fa7ee..c0b081c6fbda 100644 --- a/drivers/watchdog/ftwdt010_wdt.c +++ b/drivers/watchdog/ftwdt010_wdt.c @@ -168,10 +168,8 @@ static int ftwdt010_wdt_probe(struct platform_device *pdev) } ret = devm_watchdog_register_device(dev, &gwdt->wdd); - if (ret) { - dev_err(dev, "failed to register watchdog\n"); + if (ret) return ret; - } /* Set up platform driver data */ platform_set_drvdata(pdev, gwdt); From patchwork Sat May 18 21:27:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949117 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E56751398 for ; Sat, 18 May 2019 21:28:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6DB328541 for ; Sat, 18 May 2019 21:28:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CB5E228567; Sat, 18 May 2019 21:28:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 83C5528541 for ; Sat, 18 May 2019 21:28:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729583AbfERV2Q (ORCPT ); Sat, 18 May 2019 17:28:16 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729597AbfERV2Q (ORCPT ); Sat, 18 May 2019 17:28:16 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id E352E2C07F4; Sat, 18 May 2019 23:28:14 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Jerry Hoemann , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 13/46] watchdog: hpwdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:28 +0200 Message-Id: <20190518212801.31010-14-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang Reviewed-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index db1bf6f546ae..e0ebfba50aab 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -321,10 +321,8 @@ static int hpwdt_init_one(struct pci_dev *dev, hpwdt_dev.parent = &dev->dev; retval = watchdog_register_device(&hpwdt_dev); - if (retval < 0) { - dev_err(&dev->dev, "watchdog register failed: %d.\n", retval); + if (retval < 0) goto error_wd_register; - } dev_info(&dev->dev, "HPE Watchdog Timer Driver: Version: %s\n", HPWDT_VERSION); From patchwork Sat May 18 21:27:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949121 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6887D17DF for ; Sat, 18 May 2019 21:28:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A87B28571 for ; Sat, 18 May 2019 21:28:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4CD7328564; Sat, 18 May 2019 21:28:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 043F628564 for ; Sat, 18 May 2019 21:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729607AbfERV2Q (ORCPT ); Sat, 18 May 2019 17:28:16 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729535AbfERV2Q (ORCPT ); Sat, 18 May 2019 17:28:16 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 6EEBA2C0827; Sat, 18 May 2019 23:28:15 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 14/46] watchdog: i6300esb: drop warning after registering device Date: Sat, 18 May 2019 23:27:29 +0200 Message-Id: <20190518212801.31010-15-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/i6300esb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/watchdog/i6300esb.c b/drivers/watchdog/i6300esb.c index 17941c03996b..53c39cc2141a 100644 --- a/drivers/watchdog/i6300esb.c +++ b/drivers/watchdog/i6300esb.c @@ -319,11 +319,8 @@ static int esb_probe(struct pci_dev *pdev, /* Register the watchdog so that userspace has access to it */ ret = watchdog_register_device(&edev->wdd); - if (ret != 0) { - dev_err(&pdev->dev, - "cannot register watchdog device (err=%d)\n", ret); + if (ret != 0) goto err_unmap; - } dev_info(&pdev->dev, "initialized. heartbeat=%d sec (nowayout=%d)\n", edev->wdd.timeout, nowayout); From patchwork Sat May 18 21:27:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949123 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 81C781398 for ; Sat, 18 May 2019 21:28:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7334228567 for ; Sat, 18 May 2019 21:28:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 67D0628574; Sat, 18 May 2019 21:28:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23AF528567 for ; Sat, 18 May 2019 21:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729609AbfERV2R (ORCPT ); Sat, 18 May 2019 17:28:17 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728283AbfERV2R (ORCPT ); Sat, 18 May 2019 17:28:17 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id F120B2C0928; Sat, 18 May 2019 23:28:15 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 15/46] watchdog: ie6xx_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:30 +0200 Message-Id: <20190518212801.31010-16-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/ie6xx_wdt.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/watchdog/ie6xx_wdt.c b/drivers/watchdog/ie6xx_wdt.c index 8de9fb1ed371..334c098b36b6 100644 --- a/drivers/watchdog/ie6xx_wdt.c +++ b/drivers/watchdog/ie6xx_wdt.c @@ -269,12 +269,8 @@ static int ie6xx_wdt_probe(struct platform_device *pdev) ie6xx_wdt_debugfs_init(); ret = watchdog_register_device(&ie6xx_wdt_dev); - if (ret) { - dev_err(&pdev->dev, - "Watchdog timer: cannot register device (err =%d)\n", - ret); + if (ret) goto misc_register_error; - } return 0; From patchwork Sat May 18 21:27:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949125 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C95A21880 for ; Sat, 18 May 2019 21:28:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA8B328564 for ; Sat, 18 May 2019 21:28:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AEEA82856F; Sat, 18 May 2019 21:28:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6CC1628564 for ; Sat, 18 May 2019 21:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729618AbfERV2S (ORCPT ); Sat, 18 May 2019 17:28:18 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729597AbfERV2R (ORCPT ); Sat, 18 May 2019 17:28:17 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 818D32C0963; Sat, 18 May 2019 23:28:16 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: [PATCH 16/46] watchdog: imx2_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:31 +0200 Message-Id: <20190518212801.31010-17-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/imx2_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c index a606005dd65f..32af3974e6bb 100644 --- a/drivers/watchdog/imx2_wdt.c +++ b/drivers/watchdog/imx2_wdt.c @@ -316,10 +316,8 @@ static int __init imx2_wdt_probe(struct platform_device *pdev) regmap_write(wdev->regmap, IMX2_WDT_WMCR, 0); ret = watchdog_register_device(wdog); - if (ret) { - dev_err(&pdev->dev, "cannot register watchdog device\n"); + if (ret) goto disable_clk; - } dev_info(&pdev->dev, "timeout %d sec (nowayout=%d)\n", wdog->timeout, nowayout); From patchwork Sat May 18 21:27:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949129 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BD2771398 for ; Sat, 18 May 2019 21:28:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE55B28541 for ; Sat, 18 May 2019 21:28:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A2D862856F; Sat, 18 May 2019 21:28:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E24628541 for ; Sat, 18 May 2019 21:28:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729619AbfERV2S (ORCPT ); Sat, 18 May 2019 17:28:18 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729535AbfERV2S (ORCPT ); Sat, 18 May 2019 17:28:18 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 103BF2C2356; Sat, 18 May 2019 23:28:17 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: [PATCH 17/46] watchdog: imx_sc_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:32 +0200 Message-Id: <20190518212801.31010-18-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/imx_sc_wdt.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/watchdog/imx_sc_wdt.c b/drivers/watchdog/imx_sc_wdt.c index 49848b66186c..847aa1c3b5c2 100644 --- a/drivers/watchdog/imx_sc_wdt.c +++ b/drivers/watchdog/imx_sc_wdt.c @@ -122,13 +122,7 @@ static int imx_sc_wdt_probe(struct platform_device *pdev) watchdog_stop_on_reboot(imx_sc_wdd); watchdog_stop_on_unregister(imx_sc_wdd); - ret = devm_watchdog_register_device(dev, imx_sc_wdd); - if (ret) { - dev_err(dev, "Failed to register watchdog device\n"); - return ret; - } - - return 0; + return devm_watchdog_register_device(dev, imx_sc_wdd); } static int __maybe_unused imx_sc_wdt_suspend(struct device *dev) From patchwork Sat May 18 21:27:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949131 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DCE196C5 for ; Sat, 18 May 2019 21:28:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD58028564 for ; Sat, 18 May 2019 21:28:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C19F128541; Sat, 18 May 2019 21:28:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E3AB28564 for ; Sat, 18 May 2019 21:28:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729535AbfERV2S (ORCPT ); Sat, 18 May 2019 17:28:18 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729427AbfERV2S (ORCPT ); Sat, 18 May 2019 17:28:18 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 8FE902C2686; Sat, 18 May 2019 23:28:17 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 18/46] watchdog: intel-mid_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:33 +0200 Message-Id: <20190518212801.31010-19-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/intel-mid_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c index 6cf7cc1ff615..821e041a4f01 100644 --- a/drivers/watchdog/intel-mid_wdt.c +++ b/drivers/watchdog/intel-mid_wdt.c @@ -164,10 +164,8 @@ static int mid_wdt_probe(struct platform_device *pdev) set_bit(WDOG_HW_RUNNING, &wdt_dev->status); ret = devm_watchdog_register_device(dev, wdt_dev); - if (ret) { - dev_err(dev, "error registering watchdog device\n"); + if (ret) return ret; - } dev_info(dev, "Intel MID watchdog device probed\n"); From patchwork Sat May 18 21:27:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949133 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB8056C5 for ; Sat, 18 May 2019 21:28:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B7A6228541 for ; Sat, 18 May 2019 21:28:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ABF0928567; Sat, 18 May 2019 21:28:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 52A3228541 for ; Sat, 18 May 2019 21:28:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729633AbfERV2T (ORCPT ); Sat, 18 May 2019 17:28:19 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729597AbfERV2T (ORCPT ); Sat, 18 May 2019 17:28:19 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 1FD2F2C2704; Sat, 18 May 2019 23:28:18 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 19/46] watchdog: jz4740_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:34 +0200 Message-Id: <20190518212801.31010-20-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/jz4740_wdt.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c index d1bc7cbd4f2b..857b950b6391 100644 --- a/drivers/watchdog/jz4740_wdt.c +++ b/drivers/watchdog/jz4740_wdt.c @@ -196,11 +196,7 @@ static int jz4740_wdt_probe(struct platform_device *pdev) return PTR_ERR(drvdata->rtc_clk); } - ret = devm_watchdog_register_device(dev, &drvdata->wdt); - if (ret < 0) - return ret; - - return 0; + return devm_watchdog_register_device(dev, &drvdata->wdt); } static struct platform_driver jz4740_wdt_driver = { From patchwork Sat May 18 21:27:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949135 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 39AFF17DF for ; Sat, 18 May 2019 21:28:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 29C5128541 for ; Sat, 18 May 2019 21:28:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1E97E28567; Sat, 18 May 2019 21:28:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE9BE28541 for ; Sat, 18 May 2019 21:28:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729597AbfERV2U (ORCPT ); Sat, 18 May 2019 17:28:20 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729427AbfERV2T (ORCPT ); Sat, 18 May 2019 17:28:19 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id A1C572C270A; Sat, 18 May 2019 23:28:18 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Keguang Zhang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 20/46] watchdog: loongson1_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:35 +0200 Message-Id: <20190518212801.31010-21-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/loongson1_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/loongson1_wdt.c b/drivers/watchdog/loongson1_wdt.c index d8075e2affa7..62909c8de7d4 100644 --- a/drivers/watchdog/loongson1_wdt.c +++ b/drivers/watchdog/loongson1_wdt.c @@ -136,10 +136,8 @@ static int ls1x_wdt_probe(struct platform_device *pdev) watchdog_set_drvdata(ls1x_wdt, drvdata); err = devm_watchdog_register_device(dev, &drvdata->wdt); - if (err) { - dev_err(dev, "failed to register watchdog device\n"); + if (err) return err; - } platform_set_drvdata(pdev, drvdata); From patchwork Sat May 18 21:27:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949137 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9438B1398 for ; Sat, 18 May 2019 21:28:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 84D7628541 for ; Sat, 18 May 2019 21:28:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 796AD28564; Sat, 18 May 2019 21:28:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 358E52856F for ; Sat, 18 May 2019 21:28:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729427AbfERV2U (ORCPT ); Sat, 18 May 2019 17:28:20 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729620AbfERV2U (ORCPT ); Sat, 18 May 2019 17:28:20 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 2F87F2C2761; Sat, 18 May 2019 23:28:19 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 21/46] watchdog: max77620_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:36 +0200 Message-Id: <20190518212801.31010-22-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/max77620_wdt.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/watchdog/max77620_wdt.c b/drivers/watchdog/max77620_wdt.c index 3ca6b9337932..21e0f118cb86 100644 --- a/drivers/watchdog/max77620_wdt.c +++ b/drivers/watchdog/max77620_wdt.c @@ -185,13 +185,7 @@ static int max77620_wdt_probe(struct platform_device *pdev) watchdog_set_drvdata(wdt_dev, wdt); watchdog_stop_on_unregister(wdt_dev); - ret = devm_watchdog_register_device(dev, wdt_dev); - if (ret < 0) { - dev_err(dev, "watchdog registration failed: %d\n", ret); - return ret; - } - - return 0; + return devm_watchdog_register_device(dev, wdt_dev); } static const struct platform_device_id max77620_wdt_devtype[] = { From patchwork Sat May 18 21:27:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949139 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F2A017DF for ; Sat, 18 May 2019 21:28:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F6E328541 for ; Sat, 18 May 2019 21:28:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0428B28567; Sat, 18 May 2019 21:28:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B606328541 for ; Sat, 18 May 2019 21:28:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729651AbfERV2V (ORCPT ); Sat, 18 May 2019 17:28:21 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729647AbfERV2U (ORCPT ); Sat, 18 May 2019 17:28:20 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id B031F2C27DA; Sat, 18 May 2019 23:28:19 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Tomas Winkler , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 22/46] watchdog: mei_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:37 +0200 Message-Id: <20190518212801.31010-23-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/mei_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c index 8023cf28657a..099f6305039d 100644 --- a/drivers/watchdog/mei_wdt.c +++ b/drivers/watchdog/mei_wdt.c @@ -384,10 +384,8 @@ static int mei_wdt_register(struct mei_wdt *wdt) watchdog_stop_on_reboot(&wdt->wdd); ret = watchdog_register_device(&wdt->wdd); - if (ret) { - dev_err(dev, "unable to register watchdog device = %d.\n", ret); + if (ret) watchdog_set_drvdata(&wdt->wdd, NULL); - } wdt->state = MEI_WDT_IDLE; From patchwork Sat May 18 21:27:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949141 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BEED36C5 for ; Sat, 18 May 2019 21:28:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE96F28541 for ; Sat, 18 May 2019 21:28:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A32B428567; Sat, 18 May 2019 21:28:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 623F928541 for ; Sat, 18 May 2019 21:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729653AbfERV2V (ORCPT ); Sat, 18 May 2019 17:28:21 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729650AbfERV2V (ORCPT ); Sat, 18 May 2019 17:28:21 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 3B3CB2C2868; Sat, 18 May 2019 23:28:20 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Johannes Thumshirn , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 23/46] watchdog: mena21_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:38 +0200 Message-Id: <20190518212801.31010-24-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/mena21_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/mena21_wdt.c b/drivers/watchdog/mena21_wdt.c index e9ca4e0e25dc..99d2359d5a8a 100644 --- a/drivers/watchdog/mena21_wdt.c +++ b/drivers/watchdog/mena21_wdt.c @@ -190,10 +190,8 @@ static int a21_wdt_probe(struct platform_device *pdev) dev_set_drvdata(dev, drv); ret = devm_watchdog_register_device(dev, &a21_wdt); - if (ret) { - dev_err(dev, "Cannot register watchdog device\n"); + if (ret) return ret; - } dev_info(dev, "MEN A21 watchdog timer driver enabled\n"); From patchwork Sat May 18 21:27:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949143 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F08917DF for ; Sat, 18 May 2019 21:28:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FB1B28541 for ; Sat, 18 May 2019 21:28:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0409F28564; Sat, 18 May 2019 21:28:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B2C4C2856F for ; Sat, 18 May 2019 21:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729655AbfERV2W (ORCPT ); Sat, 18 May 2019 17:28:22 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729620AbfERV2W (ORCPT ); Sat, 18 May 2019 17:28:22 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id BBF6B2C28E9; Sat, 18 May 2019 23:28:20 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Andreas Werner , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 24/46] watchdog: menf21bmc_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:39 +0200 Message-Id: <20190518212801.31010-25-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/menf21bmc_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/menf21bmc_wdt.c b/drivers/watchdog/menf21bmc_wdt.c index b1dbff553cdc..ab9b20c9608f 100644 --- a/drivers/watchdog/menf21bmc_wdt.c +++ b/drivers/watchdog/menf21bmc_wdt.c @@ -156,10 +156,8 @@ static int menf21bmc_wdt_probe(struct platform_device *pdev) } ret = devm_watchdog_register_device(dev, &drv_data->wdt); - if (ret) { - dev_err(dev, "failed to register Watchdog device\n"); + if (ret) return ret; - } dev_info(dev, "MEN 14F021P00 BMC Watchdog device enabled\n"); From patchwork Sat May 18 21:27:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949145 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 742306C5 for ; Sat, 18 May 2019 21:28:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6464528541 for ; Sat, 18 May 2019 21:28:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 58E4A28564; Sat, 18 May 2019 21:28:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 156422856F for ; Sat, 18 May 2019 21:28:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729658AbfERV2W (ORCPT ); Sat, 18 May 2019 17:28:22 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729647AbfERV2W (ORCPT ); Sat, 18 May 2019 17:28:22 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 48DD12C2958; Sat, 18 May 2019 23:28:21 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 25/46] watchdog: mpc8xxx_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:40 +0200 Message-Id: <20190518212801.31010-26-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/mpc8xxx_wdt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/watchdog/mpc8xxx_wdt.c b/drivers/watchdog/mpc8xxx_wdt.c index 9b6d6a5a27ad..cfe7b42aef97 100644 --- a/drivers/watchdog/mpc8xxx_wdt.c +++ b/drivers/watchdog/mpc8xxx_wdt.c @@ -205,11 +205,8 @@ static int mpc8xxx_wdt_probe(struct platform_device *ofdev) ddata->wdd.timeout = ddata->wdd.min_timeout; ret = devm_watchdog_register_device(dev, &ddata->wdd); - if (ret) { - dev_err(dev, "cannot register watchdog device (err=%d)\n", - ret); + if (ret) return ret; - } dev_info(dev, "WDT driver for MPC8xxx initialized. mode:%s timeout=%d sec\n", From patchwork Sat May 18 21:27:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949147 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8E87D6C5 for ; Sat, 18 May 2019 21:28:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80D7328567 for ; Sat, 18 May 2019 21:28:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 75A732856F; Sat, 18 May 2019 21:28:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C4BF28541 for ; Sat, 18 May 2019 21:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729666AbfERV2X (ORCPT ); Sat, 18 May 2019 17:28:23 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729650AbfERV2X (ORCPT ); Sat, 18 May 2019 17:28:23 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id C99FC2C2F34; Sat, 18 May 2019 23:28:21 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 26/46] watchdog: ni903x_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:41 +0200 Message-Id: <20190518212801.31010-27-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/ni903x_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/ni903x_wdt.c b/drivers/watchdog/ni903x_wdt.c index fbc1df86c6cc..77eaab326c60 100644 --- a/drivers/watchdog/ni903x_wdt.c +++ b/drivers/watchdog/ni903x_wdt.c @@ -220,10 +220,8 @@ static int ni903x_acpi_add(struct acpi_device *device) watchdog_init_timeout(wdd, timeout, dev); ret = watchdog_register_device(wdd); - if (ret) { - dev_err(dev, "failed to register watchdog\n"); + if (ret) return ret; - } /* Switch from boot mode to user mode */ outb(NIWD_CONTROL_RESET | NIWD_CONTROL_MODE, From patchwork Sat May 18 21:27:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949149 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A90B017DF for ; Sat, 18 May 2019 21:28:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9895628541 for ; Sat, 18 May 2019 21:28:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D6BE28573; Sat, 18 May 2019 21:28:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C5CD28564 for ; Sat, 18 May 2019 21:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729650AbfERV2X (ORCPT ); Sat, 18 May 2019 17:28:23 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729620AbfERV2X (ORCPT ); Sat, 18 May 2019 17:28:23 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 5669C2C308C; Sat, 18 May 2019 23:28:22 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 27/46] watchdog: nic7018_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:42 +0200 Message-Id: <20190518212801.31010-28-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/nic7018_wdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/nic7018_wdt.c b/drivers/watchdog/nic7018_wdt.c index 82843abe38f8..ee208695d080 100644 --- a/drivers/watchdog/nic7018_wdt.c +++ b/drivers/watchdog/nic7018_wdt.c @@ -219,7 +219,6 @@ static int nic7018_probe(struct platform_device *pdev) ret = watchdog_register_device(wdd); if (ret) { outb(LOCK, wdt->io_base + WDT_REG_LOCK); - dev_err(dev, "failed to register watchdog\n"); return ret; } From patchwork Sat May 18 21:27:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949151 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 655751398 for ; Sat, 18 May 2019 21:28:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56F4028541 for ; Sat, 18 May 2019 21:28:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4BAAC2856F; Sat, 18 May 2019 21:28:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A21D28541 for ; Sat, 18 May 2019 21:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729674AbfERV2Y (ORCPT ); Sat, 18 May 2019 17:28:24 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729647AbfERV2Y (ORCPT ); Sat, 18 May 2019 17:28:24 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id DA76A2C3112; Sat, 18 May 2019 23:28:22 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 28/46] watchdog: npcm_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:43 +0200 Message-Id: <20190518212801.31010-29-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/npcm_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/npcm_wdt.c b/drivers/watchdog/npcm_wdt.c index 9d6c1689b12c..9c773c3d6d5d 100644 --- a/drivers/watchdog/npcm_wdt.c +++ b/drivers/watchdog/npcm_wdt.c @@ -220,10 +220,8 @@ static int npcm_wdt_probe(struct platform_device *pdev) return ret; ret = devm_watchdog_register_device(dev, &wdt->wdd); - if (ret) { - dev_err(dev, "failed to register watchdog\n"); + if (ret) return ret; - } dev_info(dev, "NPCM watchdog driver enabled\n"); From patchwork Sat May 18 21:27:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949153 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A4DD517DF for ; Sat, 18 May 2019 21:28:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9536028541 for ; Sat, 18 May 2019 21:28:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 89B7828567; Sat, 18 May 2019 21:28:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 47C4128564 for ; Sat, 18 May 2019 21:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729647AbfERV2Z (ORCPT ); Sat, 18 May 2019 17:28:25 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729671AbfERV2Y (ORCPT ); Sat, 18 May 2019 17:28:24 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 688962C3115; Sat, 18 May 2019 23:28:23 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Michal Simek Subject: [PATCH 29/46] watchdog: of_xilinx_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:44 +0200 Message-Id: <20190518212801.31010-30-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang Acked-by: Michal Simek --- drivers/watchdog/of_xilinx_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c index 03786992b701..7fe4f7c3f7ce 100644 --- a/drivers/watchdog/of_xilinx_wdt.c +++ b/drivers/watchdog/of_xilinx_wdt.c @@ -238,10 +238,8 @@ static int xwdt_probe(struct platform_device *pdev) } rc = devm_watchdog_register_device(dev, xilinx_wdt_wdd); - if (rc) { - dev_err(dev, "Cannot register watchdog (err=%d)\n", rc); + if (rc) return rc; - } clk_disable(xdev->clk); From patchwork Sat May 18 21:27:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949155 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 960156C5 for ; Sat, 18 May 2019 21:28:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 85D5C28541 for ; Sat, 18 May 2019 21:28:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A92F28567; Sat, 18 May 2019 21:28:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C13828541 for ; Sat, 18 May 2019 21:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729682AbfERV2Z (ORCPT ); Sat, 18 May 2019 17:28:25 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729620AbfERV2Z (ORCPT ); Sat, 18 May 2019 17:28:25 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id E8FD62C3119; Sat, 18 May 2019 23:28:23 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 30/46] watchdog: pic32-dmt: drop warning after registering device Date: Sat, 18 May 2019 23:27:45 +0200 Message-Id: <20190518212801.31010-31-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/pic32-dmt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/pic32-dmt.c b/drivers/watchdog/pic32-dmt.c index 9a3c53e03c60..b0041a527bc3 100644 --- a/drivers/watchdog/pic32-dmt.c +++ b/drivers/watchdog/pic32-dmt.c @@ -216,10 +216,8 @@ static int pic32_dmt_probe(struct platform_device *pdev) watchdog_set_drvdata(wdd, dmt); ret = devm_watchdog_register_device(dev, wdd); - if (ret) { - dev_err(dev, "watchdog register failed, err %d\n", ret); + if (ret) return ret; - } platform_set_drvdata(pdev, wdd); return 0; From patchwork Sat May 18 21:27:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949157 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 233B017DF for ; Sat, 18 May 2019 21:28:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 134E128541 for ; Sat, 18 May 2019 21:28:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 080BE28567; Sat, 18 May 2019 21:28:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B7A6C28541 for ; Sat, 18 May 2019 21:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729620AbfERV20 (ORCPT ); Sat, 18 May 2019 17:28:26 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729675AbfERV2Z (ORCPT ); Sat, 18 May 2019 17:28:25 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 76CDC2C3536; Sat, 18 May 2019 23:28:24 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 31/46] watchdog: pic32-wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:46 +0200 Message-Id: <20190518212801.31010-32-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/pic32-wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/pic32-wdt.c b/drivers/watchdog/pic32-wdt.c index 540500940cc0..d2f4780852c7 100644 --- a/drivers/watchdog/pic32-wdt.c +++ b/drivers/watchdog/pic32-wdt.c @@ -225,10 +225,8 @@ static int pic32_wdt_drv_probe(struct platform_device *pdev) watchdog_set_drvdata(wdd, wdt); ret = devm_watchdog_register_device(dev, wdd); - if (ret) { - dev_err(dev, "watchdog register failed, err %d\n", ret); + if (ret) return ret; - } platform_set_drvdata(pdev, wdd); From patchwork Sat May 18 21:27:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949159 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3A0B1398 for ; Sat, 18 May 2019 21:28:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C3D2B28541 for ; Sat, 18 May 2019 21:28:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B86CB28567; Sat, 18 May 2019 21:28:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7421728541 for ; Sat, 18 May 2019 21:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729678AbfERV20 (ORCPT ); Sat, 18 May 2019 17:28:26 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729671AbfERV20 (ORCPT ); Sat, 18 May 2019 17:28:26 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 057E22C353A; Sat, 18 May 2019 23:28:25 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Vladimir Zapolskiy , Sylvain Lemieux , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 32/46] watchdog: pnx4008_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:47 +0200 Message-Id: <20190518212801.31010-33-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang Acked-by: Sylvain Lemieux --- drivers/watchdog/pnx4008_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c index d9e03544aeae..124b1c66dc29 100644 --- a/drivers/watchdog/pnx4008_wdt.c +++ b/drivers/watchdog/pnx4008_wdt.c @@ -221,10 +221,8 @@ static int pnx4008_wdt_probe(struct platform_device *pdev) set_bit(WDOG_HW_RUNNING, &pnx4008_wdd.status); ret = devm_watchdog_register_device(dev, &pnx4008_wdd); - if (ret < 0) { - dev_err(dev, "cannot register watchdog device\n"); + if (ret < 0) return ret; - } dev_info(dev, "heartbeat %d sec\n", pnx4008_wdd.timeout); From patchwork Sat May 18 21:27:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949161 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 54E6717DF for ; Sat, 18 May 2019 21:28:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 459E928541 for ; Sat, 18 May 2019 21:28:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 39EDA28567; Sat, 18 May 2019 21:28:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DCE0E28541 for ; Sat, 18 May 2019 21:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729692AbfERV21 (ORCPT ); Sat, 18 May 2019 17:28:27 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729687AbfERV20 (ORCPT ); Sat, 18 May 2019 17:28:26 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 8902F2C3559; Sat, 18 May 2019 23:28:25 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Andy Gross , David Brown , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 33/46] watchdog: qcom-wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:48 +0200 Message-Id: <20190518212801.31010-34-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/qcom-wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c index 6d29c33b1316..aa750d8e5045 100644 --- a/drivers/watchdog/qcom-wdt.c +++ b/drivers/watchdog/qcom-wdt.c @@ -232,10 +232,8 @@ static int qcom_wdt_probe(struct platform_device *pdev) watchdog_init_timeout(&wdt->wdd, 0, dev); ret = devm_watchdog_register_device(dev, &wdt->wdd); - if (ret) { - dev_err(dev, "failed to register watchdog\n"); + if (ret) return ret; - } platform_set_drvdata(pdev, wdt); return 0; From patchwork Sat May 18 21:27:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949163 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 23E876C5 for ; Sat, 18 May 2019 21:28:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 14FDC28541 for ; Sat, 18 May 2019 21:28:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0963828567; Sat, 18 May 2019 21:28:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B97D528541 for ; Sat, 18 May 2019 21:28:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729687AbfERV21 (ORCPT ); Sat, 18 May 2019 17:28:27 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729675AbfERV21 (ORCPT ); Sat, 18 May 2019 17:28:27 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 160E52C35BF; Sat, 18 May 2019 23:28:26 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 34/46] watchdog: rave-sp-wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:49 +0200 Message-Id: <20190518212801.31010-35-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/rave-sp-wdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/rave-sp-wdt.c b/drivers/watchdog/rave-sp-wdt.c index 35db173252f9..2c95615b6354 100644 --- a/drivers/watchdog/rave-sp-wdt.c +++ b/drivers/watchdog/rave-sp-wdt.c @@ -310,7 +310,6 @@ static int rave_sp_wdt_probe(struct platform_device *pdev) ret = devm_watchdog_register_device(dev, wdd); if (ret) { - dev_err(dev, "Failed to register watchdog device\n"); rave_sp_wdt_stop(wdd); return ret; } From patchwork Sat May 18 21:27:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949165 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B356A17DF for ; Sat, 18 May 2019 21:28:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A2A3428541 for ; Sat, 18 May 2019 21:28:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9728028567; Sat, 18 May 2019 21:28:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 43E7C28541 for ; Sat, 18 May 2019 21:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729696AbfERV22 (ORCPT ); Sat, 18 May 2019 17:28:28 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729690AbfERV21 (ORCPT ); Sat, 18 May 2019 17:28:27 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 981862C360B; Sat, 18 May 2019 23:28:26 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Kukjin Kim , Krzysztof Kozlowski , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 35/46] watchdog: s3c2410_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:50 +0200 Message-Id: <20190518212801.31010-36-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/s3c2410_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 4267b9e8734b..5a6d048b6647 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -615,10 +615,8 @@ static int s3c2410wdt_probe(struct platform_device *pdev) wdt->wdt_device.parent = dev; ret = watchdog_register_device(&wdt->wdt_device); - if (ret) { - dev_err(dev, "cannot register watchdog (%d)\n", ret); + if (ret) goto err_cpufreq; - } ret = s3c2410wdt_mask_and_disable_reset(wdt, false); if (ret < 0) From patchwork Sat May 18 21:27:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949167 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0DC8D6C5 for ; Sat, 18 May 2019 21:28:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F264A2856F for ; Sat, 18 May 2019 21:28:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6B2528567; Sat, 18 May 2019 21:28:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A321428571 for ; Sat, 18 May 2019 21:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729708AbfERV23 (ORCPT ); Sat, 18 May 2019 17:28:29 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729671AbfERV22 (ORCPT ); Sat, 18 May 2019 17:28:28 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 2642B2C0590; Sat, 18 May 2019 23:28:27 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 36/46] watchdog: sama5d4_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:51 +0200 Message-Id: <20190518212801.31010-37-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang Acked-by: Alexandre Belloni --- drivers/watchdog/sama5d4_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c index 111695223aae..5adcb047cb94 100644 --- a/drivers/watchdog/sama5d4_wdt.c +++ b/drivers/watchdog/sama5d4_wdt.c @@ -260,10 +260,8 @@ static int sama5d4_wdt_probe(struct platform_device *pdev) watchdog_stop_on_unregister(wdd); ret = devm_watchdog_register_device(dev, wdd); - if (ret) { - dev_err(dev, "failed to register watchdog device\n"); + if (ret) return ret; - } platform_set_drvdata(pdev, wdt); From patchwork Sat May 18 21:27:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949169 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 34E5817EE for ; Sat, 18 May 2019 21:28:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 260651FFBD for ; Sat, 18 May 2019 21:28:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1A48F28571; Sat, 18 May 2019 21:28:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C736128541 for ; Sat, 18 May 2019 21:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729671AbfERV23 (ORCPT ); Sat, 18 May 2019 17:28:29 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729675AbfERV22 (ORCPT ); Sat, 18 May 2019 17:28:28 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id AA0B92C059D; Sat, 18 May 2019 23:28:27 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 37/46] watchdog: sp5100_tco: drop warning after registering device Date: Sat, 18 May 2019 23:27:52 +0200 Message-Id: <20190518212801.31010-38-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/sp5100_tco.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c index 553735b256e2..820b6dc3aa95 100644 --- a/drivers/watchdog/sp5100_tco.c +++ b/drivers/watchdog/sp5100_tco.c @@ -406,10 +406,8 @@ static int sp5100_tco_probe(struct platform_device *pdev) return ret; ret = devm_watchdog_register_device(dev, wdd); - if (ret) { - dev_err(dev, "cannot register watchdog device (err=%d)\n", ret); + if (ret) return ret; - } /* Show module parameters */ dev_info(dev, "initialized. heartbeat=%d sec (nowayout=%d)\n", From patchwork Sat May 18 21:27:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949171 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6604C17DF for ; Sat, 18 May 2019 21:28:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56B2C1FFBD for ; Sat, 18 May 2019 21:28:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B1C928541; Sat, 18 May 2019 21:28:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE59928564 for ; Sat, 18 May 2019 21:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729675AbfERV23 (ORCPT ); Sat, 18 May 2019 17:28:29 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729693AbfERV23 (ORCPT ); Sat, 18 May 2019 17:28:29 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 3A8BF2C36A9; Sat, 18 May 2019 23:28:28 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 38/46] watchdog: sp805_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:53 +0200 Message-Id: <20190518212801.31010-39-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/sp805_wdt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c index 072986d461b7..53e04926a7b2 100644 --- a/drivers/watchdog/sp805_wdt.c +++ b/drivers/watchdog/sp805_wdt.c @@ -288,11 +288,8 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id) } ret = watchdog_register_device(&wdt->wdd); - if (ret) { - dev_err(&adev->dev, "watchdog_register_device() failed: %d\n", - ret); + if (ret) goto err; - } amba_set_drvdata(adev, wdt); dev_info(&adev->dev, "registration successful\n"); From patchwork Sat May 18 21:27:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C81776C5 for ; Sat, 18 May 2019 21:28:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B94861FFBD for ; Sat, 18 May 2019 21:28:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ADE2228564; Sat, 18 May 2019 21:28:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6966328541 for ; Sat, 18 May 2019 21:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729715AbfERV2a (ORCPT ); Sat, 18 May 2019 17:28:30 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729690AbfERV2a (ORCPT ); Sat, 18 May 2019 17:28:30 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id BB1A52C3740; Sat, 18 May 2019 23:28:28 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Orson Zhai , Baolin Wang , Chunyan Zhang Subject: [PATCH 39/46] watchdog: sprd_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:54 +0200 Message-Id: <20190518212801.31010-40-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang Reviewed-by: Baolin Wang --- drivers/watchdog/sprd_wdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/sprd_wdt.c b/drivers/watchdog/sprd_wdt.c index 14874e9b207b..b049981de3f3 100644 --- a/drivers/watchdog/sprd_wdt.c +++ b/drivers/watchdog/sprd_wdt.c @@ -328,7 +328,6 @@ static int sprd_wdt_probe(struct platform_device *pdev) ret = devm_watchdog_register_device(dev, &wdt->wdd); if (ret) { sprd_wdt_disable(wdt); - dev_err(dev, "failed to register watchdog\n"); return ret; } platform_set_drvdata(pdev, wdt); From patchwork Sat May 18 21:27:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949175 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4337A17DF for ; Sat, 18 May 2019 21:28:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3386C1FFBD for ; Sat, 18 May 2019 21:28:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 27E1528564; Sat, 18 May 2019 21:28:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D89EE1FFBD for ; Sat, 18 May 2019 21:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729717AbfERV2a (ORCPT ); Sat, 18 May 2019 17:28:30 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729709AbfERV2a (ORCPT ); Sat, 18 May 2019 17:28:30 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 48DC92C374E; Sat, 18 May 2019 23:28:29 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Patrice Chotard , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 40/46] watchdog: st_lpc_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:55 +0200 Message-Id: <20190518212801.31010-41-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/st_lpc_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c index 7a90184eb950..14ab6559c748 100644 --- a/drivers/watchdog/st_lpc_wdt.c +++ b/drivers/watchdog/st_lpc_wdt.c @@ -228,10 +228,8 @@ static int st_wdog_probe(struct platform_device *pdev) return ret; ret = devm_watchdog_register_device(dev, &st_wdog_dev); - if (ret) { - dev_err(dev, "Unable to register watchdog\n"); + if (ret) return ret; - } st_wdog_setup(st_wdog, true); From patchwork Sat May 18 21:27:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949177 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CA4F11398 for ; Sat, 18 May 2019 21:28:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB86A1FFBD for ; Sat, 18 May 2019 21:28:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AFC9628564; Sat, 18 May 2019 21:28:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C0BB1FFBD for ; Sat, 18 May 2019 21:28:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729718AbfERV2b (ORCPT ); Sat, 18 May 2019 17:28:31 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729693AbfERV2b (ORCPT ); Sat, 18 May 2019 17:28:31 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id CA4692C5DC5; Sat, 18 May 2019 23:28:29 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Maxime Coquelin , Alexandre Torgue Subject: [PATCH 41/46] watchdog: stm32_iwdg: drop warning after registering device Date: Sat, 18 May 2019 23:27:56 +0200 Message-Id: <20190518212801.31010-42-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/stm32_iwdg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index d569a3634d9b..a3a329011a06 100644 --- a/drivers/watchdog/stm32_iwdg.c +++ b/drivers/watchdog/stm32_iwdg.c @@ -263,10 +263,8 @@ static int stm32_iwdg_probe(struct platform_device *pdev) watchdog_init_timeout(wdd, 0, dev); ret = devm_watchdog_register_device(dev, wdd); - if (ret) { - dev_err(dev, "failed to register watchdog device\n"); + if (ret) return ret; - } platform_set_drvdata(pdev, wdt); From patchwork Sat May 18 21:27:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949179 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 561FD17DF for ; Sat, 18 May 2019 21:28:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 465891FFBD for ; Sat, 18 May 2019 21:28:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3ADEF28564; Sat, 18 May 2019 21:28:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DABD71FFBD for ; Sat, 18 May 2019 21:28:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729693AbfERV2b (ORCPT ); Sat, 18 May 2019 17:28:31 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729690AbfERV2b (ORCPT ); Sat, 18 May 2019 17:28:31 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 58B4A2C65C7; Sat, 18 May 2019 23:28:30 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Maxime Coquelin , Alexandre Torgue Subject: [PATCH 42/46] watchdog: stmp3xxx_rtc_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:57 +0200 Message-Id: <20190518212801.31010-43-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/stmp3xxx_rtc_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/stmp3xxx_rtc_wdt.c b/drivers/watchdog/stmp3xxx_rtc_wdt.c index 671f4ba7b4ed..7caf3aa71c6a 100644 --- a/drivers/watchdog/stmp3xxx_rtc_wdt.c +++ b/drivers/watchdog/stmp3xxx_rtc_wdt.c @@ -98,10 +98,8 @@ static int stmp3xxx_wdt_probe(struct platform_device *pdev) stmp3xxx_wdd.parent = dev; ret = devm_watchdog_register_device(dev, &stmp3xxx_wdd); - if (ret < 0) { - dev_err(dev, "cannot register watchdog device\n"); + if (ret < 0) return ret; - } if (register_reboot_notifier(&wdt_notifier)) dev_warn(dev, "cannot register reboot notifier\n"); From patchwork Sat May 18 21:27:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949181 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DFD356C5 for ; Sat, 18 May 2019 21:28:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D08B11FFBD for ; Sat, 18 May 2019 21:28:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C4D4928564; Sat, 18 May 2019 21:28:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 840061FFBD for ; Sat, 18 May 2019 21:28:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729720AbfERV2c (ORCPT ); Sat, 18 May 2019 17:28:32 -0400 Received: from sauhun.de ([88.99.104.3]:35844 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729709AbfERV2c (ORCPT ); Sat, 18 May 2019 17:28:32 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id D97382C6EF1; Sat, 18 May 2019 23:28:30 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck , Thierry Reding , Jonathan Hunter Subject: [PATCH 43/46] watchdog: tegra_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:58 +0200 Message-Id: <20190518212801.31010-44-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/tegra_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/tegra_wdt.c b/drivers/watchdog/tegra_wdt.c index a58b000acc4f..dfe06e506cad 100644 --- a/drivers/watchdog/tegra_wdt.c +++ b/drivers/watchdog/tegra_wdt.c @@ -219,10 +219,8 @@ static int tegra_wdt_probe(struct platform_device *pdev) watchdog_stop_on_unregister(wdd); ret = devm_watchdog_register_device(dev, wdd); - if (ret) { - dev_err(dev, "failed to register watchdog device\n"); + if (ret) return ret; - } platform_set_drvdata(pdev, wdt); From patchwork Sat May 18 21:27:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949183 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6380417DF for ; Sat, 18 May 2019 21:28:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 547E41FFBD for ; Sat, 18 May 2019 21:28:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 489DC28564; Sat, 18 May 2019 21:28:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 041981FFBD for ; Sat, 18 May 2019 21:28:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729709AbfERV2c (ORCPT ); Sat, 18 May 2019 17:28:32 -0400 Received: from sauhun.de ([88.99.104.3]:35850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729719AbfERV2c (ORCPT ); Sat, 18 May 2019 17:28:32 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 680542C7716; Sat, 18 May 2019 23:28:31 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 44/46] watchdog: ts4800_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:27:59 +0200 Message-Id: <20190518212801.31010-45-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/ts4800_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/ts4800_wdt.c b/drivers/watchdog/ts4800_wdt.c index 9dc6d7f45806..c137ad2bd5c3 100644 --- a/drivers/watchdog/ts4800_wdt.c +++ b/drivers/watchdog/ts4800_wdt.c @@ -171,10 +171,8 @@ static int ts4800_wdt_probe(struct platform_device *pdev) ts4800_wdt_stop(wdd); ret = devm_watchdog_register_device(dev, wdd); - if (ret) { - dev_err(dev, "failed to register watchdog device\n"); + if (ret) return ret; - } platform_set_drvdata(pdev, wdt); From patchwork Sat May 18 21:28:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949185 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EDFDF6C5 for ; Sat, 18 May 2019 21:28:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DEF051FFBD for ; Sat, 18 May 2019 21:28:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D36F828564; Sat, 18 May 2019 21:28:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 887731FFBD for ; Sat, 18 May 2019 21:28:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729719AbfERV2d (ORCPT ); Sat, 18 May 2019 17:28:33 -0400 Received: from sauhun.de ([88.99.104.3]:35834 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729690AbfERV2d (ORCPT ); Sat, 18 May 2019 17:28:33 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id E81CA2C775D; Sat, 18 May 2019 23:28:31 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 45/46] watchdog: wm831x_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:28:00 +0200 Message-Id: <20190518212801.31010-46-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/wm831x_wdt.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/watchdog/wm831x_wdt.c b/drivers/watchdog/wm831x_wdt.c index 9b6565a3fab4..030ce240620d 100644 --- a/drivers/watchdog/wm831x_wdt.c +++ b/drivers/watchdog/wm831x_wdt.c @@ -267,14 +267,7 @@ static int wm831x_wdt_probe(struct platform_device *pdev) } } - ret = devm_watchdog_register_device(dev, &driver_data->wdt); - if (ret != 0) { - dev_err(wm831x->dev, "watchdog_register_device() failed: %d\n", - ret); - return ret; - } - - return 0; + return devm_watchdog_register_device(dev, &driver_data->wdt); } static struct platform_driver wm831x_wdt_driver = { From patchwork Sat May 18 21:28:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10949187 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7ACD41398 for ; Sat, 18 May 2019 21:28:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F7BF28541 for ; Sat, 18 May 2019 21:28:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5403628567; Sat, 18 May 2019 21:28:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10D1B28541 for ; Sat, 18 May 2019 21:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729690AbfERV2d (ORCPT ); Sat, 18 May 2019 17:28:33 -0400 Received: from sauhun.de ([88.99.104.3]:35826 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727926AbfERV2d (ORCPT ); Sat, 18 May 2019 17:28:33 -0400 Received: from localhost (p5486CE4C.dip0.t-ipconnect.de [84.134.206.76]) by pokefinder.org (Postfix) with ESMTPSA id 74AAD2C7769; Sat, 18 May 2019 23:28:32 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Cc: Wolfram Sang , Wim Van Sebroeck , Guenter Roeck Subject: [PATCH 46/46] watchdog: xen_wdt: drop warning after registering device Date: Sat, 18 May 2019 23:28:01 +0200 Message-Id: <20190518212801.31010-47-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> References: <20190518212801.31010-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Signed-off-by: Wolfram Sang --- drivers/watchdog/xen_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/xen_wdt.c b/drivers/watchdog/xen_wdt.c index 25a1af5e1787..5cd943c895db 100644 --- a/drivers/watchdog/xen_wdt.c +++ b/drivers/watchdog/xen_wdt.c @@ -142,10 +142,8 @@ static int xen_wdt_probe(struct platform_device *pdev) watchdog_stop_on_unregister(&xen_wdt_dev); ret = devm_watchdog_register_device(dev, &xen_wdt_dev); - if (ret) { - dev_err(dev, "cannot register watchdog device (%d)\n", ret); + if (ret) return ret; - } dev_info(dev, "initialized (timeout=%ds, nowayout=%d)\n", xen_wdt_dev.timeout, nowayout);