From patchwork Wed May 22 15:46:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 10956145 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D91313AD for ; Wed, 22 May 2019 15:48:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EFE120134 for ; Wed, 22 May 2019 15:48:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7373D288C6; Wed, 22 May 2019 15:48:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UPPERCASE_50_75 autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2149128C1E for ; Wed, 22 May 2019 15:48:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02FD889B3B; Wed, 22 May 2019 15:48:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D1E489B3B for ; Wed, 22 May 2019 15:48:29 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id j187so5028258wma.1 for ; Wed, 22 May 2019 08:48:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4ymCN4zK26ZTUFCEXX7eQSW+kelBNJC5uXfNvBUA89w=; b=jmtSKRfGHjdqiYDtPJScn4QaG4tWvlRcDiH7ndsaJC/j7zi20Uo0/cA+SqkDgS8sr4 sa2Zo18fkmh7f3WSIU3v1MYAp1BWMOIuEkIoSnQgjjiZ5g9e+3MmkqqdGkwN3lYaeUDa m6Z/Oz2yyKAPwUUX2Ptb+1Z/I1MFUrWNv5Ez4vnxMexNJODUkiW0imSYgS9zZ0Yi7vsZ xZPkunPZ7+xZr57x/Lx01THByWM6VKqtFOmBHBl4IFMrmNC0yes2MBf+TKhBDunnF2pt XF3NQ2Cpwn4rAnee43za5FPHoL/AeIfW4rb4pn0OdiF6Cxdz/Psf8L06FM6MJkChKXSs T9AQ== X-Gm-Message-State: APjAAAXQJIpxjcbJYCdyYZZ6NT3oTDbIZ2Pa1OhASBFfrfFeclBEN3EV Ono7uZrcAlmfSxJ3+J1DxfAaSszr X-Google-Smtp-Source: APXvYqzs7YHIDcZN4IrAo88L1Gs+cRh/lgeCh5bjQJtVA479VVwk4p4HXw1ftnCxMsHoHR99X76uVA== X-Received: by 2002:a1c:6a0e:: with SMTP id f14mr1642875wmc.69.1558540107798; Wed, 22 May 2019 08:48:27 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id t6sm12567117wmt.34.2019.05.22.08.48.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 08:48:27 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/4] drm/tegra: remove irrelevant DRM_UNLOCKED flag Date: Wed, 22 May 2019 16:46:59 +0100 Message-Id: <20190522154702.16269-1-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4ymCN4zK26ZTUFCEXX7eQSW+kelBNJC5uXfNvBUA89w=; b=SFk/HRAUYcYrwCMhsQ2edNdvV5hwj+tm2jzDiidQKYpQ7PC6R3+2qJ6oihdSnqcAR5 1N7zPNgIENz0Xa7mggkJ9pMW5U+leJ9FwbRm/ZuOf82rpKimd9LKqoE4Sey3atnhhtGH sgAYV8IDrSRwA//5yQ7YSMQeM2Hfdx8cC2XyUhoLMjcVbLLmZrPAiyaxDVDQZNgn7r4A dc5cv2fEPpkTY4wqXBc1BstyU6YwlQSwaEXsqERVK7MBXPT4rHoVMvHuMs7djKFPdmLA /VoeiSotnElK/vtb6xVFXGfRCD/eEkP1kn9AGBofejsYnXrngE6nq27zBuGj8/smPEcx fK2Q== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Thierry Reding , kernel@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov DRM_UNLOCKED doesn't do anything for non-legacy drivers. Remove it. Cc: Thierry Reding Cc: linux-tegra@vger.kernel.org Cc: Daniel Vetter Signed-off-by: Emil Velikov Acked-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 0c5f1e6a0446..8836c113b392 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -891,33 +891,33 @@ static int tegra_gem_get_flags(struct drm_device *drm, void *data, static const struct drm_ioctl_desc tegra_drm_ioctls[] = { #ifdef CONFIG_DRM_TEGRA_STAGING DRM_IOCTL_DEF_DRV(TEGRA_GEM_CREATE, tegra_gem_create, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_GEM_MMAP, tegra_gem_mmap, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_SYNCPT_READ, tegra_syncpt_read, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_SYNCPT_INCR, tegra_syncpt_incr, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_SYNCPT_WAIT, tegra_syncpt_wait, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_OPEN_CHANNEL, tegra_open_channel, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_CLOSE_CHANNEL, tegra_close_channel, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_GET_SYNCPT, tegra_get_syncpt, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_SUBMIT, tegra_submit, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_GET_SYNCPT_BASE, tegra_get_syncpt_base, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_GEM_SET_TILING, tegra_gem_set_tiling, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_GEM_GET_TILING, tegra_gem_get_tiling, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_GEM_SET_FLAGS, tegra_gem_set_flags, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(TEGRA_GEM_GET_FLAGS, tegra_gem_get_flags, - DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_RENDER_ALLOW), #endif }; From patchwork Wed May 22 15:47:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 10956149 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 87F5516C1 for ; Wed, 22 May 2019 15:48:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76ABD28C20 for ; Wed, 22 May 2019 15:48:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5FF7228C2A; Wed, 22 May 2019 15:48:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UPPERCASE_50_75 autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 006A828C20 for ; Wed, 22 May 2019 15:48:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF79989BC0; Wed, 22 May 2019 15:48:33 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E73A89B3B for ; Wed, 22 May 2019 15:48:30 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id t7so2564957wrr.10 for ; Wed, 22 May 2019 08:48:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9HdYLKK0O8zjOHfMRuMEVNbPOEm50SE48I5+273koG8=; b=Rq6jW5DbqjqEcEZg4nQCtWWXYqv2sb3nuQCTZcOxBm+oY/m2fJPddEc+msHVciAnyr F2cJ1v1iC6uTZ3pU7HbCi4pQUSmtwQzmtENt841jw1yJwVfjQuulREDYcBIIWwFt6o6D k/okc0GBzlYrjRsIN69/5H/1WAlmbyyxg4z6O7I0npHfMOfvGIQaS/nYWrZum3tc+kJA cqTdjhIHDIyzIKNUWihigdy0cb5HjJ6NfUpBCsRe5OXEFNxxtdzAYBQKVnu8EeeBp2HI NrN3S+KhPwvpBZceOsRwD4mRjQQOkxWsV8k+l8B5zGzEoWMaqhgAvfs7HcedIAwlinW+ RDyA== X-Gm-Message-State: APjAAAWbdaG1Gn074DhFpgKZzN6saoVM6xpY9/UnSq4VJ/dLUvLQvlkI drPzX/0mcI8YWy0E7SLioTUoP7Hk X-Google-Smtp-Source: APXvYqx+GEqSOJqjBnC9BXRRYx6UPpWcOzmT01LzSkVy5hVoMVJDeCL9b2emaAiGhtMaZis22UyUkg== X-Received: by 2002:adf:dcd1:: with SMTP id x17mr3385668wrm.98.1558540108661; Wed, 22 May 2019 08:48:28 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id t6sm12567117wmt.34.2019.05.22.08.48.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 08:48:28 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/4] drm/virtio: remove irrelevant DRM_UNLOCKED flag Date: Wed, 22 May 2019 16:47:00 +0100 Message-Id: <20190522154702.16269-2-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190522154702.16269-1-emil.l.velikov@gmail.com> References: <20190522154702.16269-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9HdYLKK0O8zjOHfMRuMEVNbPOEm50SE48I5+273koG8=; b=ZKWtwQxWXNKG+BRGWu0z+IbLQtzSOqMDS65LRAExdT6WgmgSk84/yRn4ULVDS/nvYn zeFzFvXKb0+ct67BOLz9x6OjuGLDtOzNgfe3txW2K6e/snXiiKsek+S7QhBzUcQQnQ8O RQOMS0QZlsiSZdzpkEk6/6QddP96yQQ6jQEu9YdqpSprULL4ZQ9n0yAh6PeF+f30kG/4 Mh99tBtzUACFKmWwjgk8c2g4qm6LqjpQJV/w7r+Z/rXtodHz5TvGZYbjjk9KAR/T8hta b0VdINsz9acDZpqI2PSVc+7kGLiusRW+DqYAV15H//0/vi97x2x/Q+duNWQTPLoBqSvD xXMw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel@collabora.com, Gerd Hoffmann , virtualization@lists.linux-foundation.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov DRM_UNLOCKED doesn't do anything for non-legacy drivers. Remove it. Cc: David Airlie Cc: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org Cc: Daniel Vetter Signed-off-by: Emil Velikov --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c index 949a264985fc..b7f9dfe61d1c 100644 --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c @@ -553,34 +553,34 @@ static int virtio_gpu_get_caps_ioctl(struct drm_device *dev, struct drm_ioctl_desc virtio_gpu_ioctls[DRM_VIRTIO_NUM_IOCTLS] = { DRM_IOCTL_DEF_DRV(VIRTGPU_MAP, virtio_gpu_map_ioctl, - DRM_AUTH | DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_AUTH | DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(VIRTGPU_EXECBUFFER, virtio_gpu_execbuffer_ioctl, - DRM_AUTH | DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_AUTH | DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(VIRTGPU_GETPARAM, virtio_gpu_getparam_ioctl, - DRM_AUTH | DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_AUTH | DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(VIRTGPU_RESOURCE_CREATE, virtio_gpu_resource_create_ioctl, - DRM_AUTH | DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_AUTH | DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(VIRTGPU_RESOURCE_INFO, virtio_gpu_resource_info_ioctl, - DRM_AUTH | DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_AUTH | DRM_RENDER_ALLOW), /* make transfer async to the main ring? - no sure, can we * thread these in the underlying GL */ DRM_IOCTL_DEF_DRV(VIRTGPU_TRANSFER_FROM_HOST, virtio_gpu_transfer_from_host_ioctl, - DRM_AUTH | DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_AUTH | DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(VIRTGPU_TRANSFER_TO_HOST, virtio_gpu_transfer_to_host_ioctl, - DRM_AUTH | DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_AUTH | DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(VIRTGPU_WAIT, virtio_gpu_wait_ioctl, - DRM_AUTH | DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_AUTH | DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(VIRTGPU_GET_CAPS, virtio_gpu_get_caps_ioctl, - DRM_AUTH | DRM_UNLOCKED | DRM_RENDER_ALLOW), + DRM_AUTH | DRM_RENDER_ALLOW), }; From patchwork Wed May 22 15:47:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 10956151 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7135613AD for ; Wed, 22 May 2019 15:48:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 612CF288E8 for ; Wed, 22 May 2019 15:48:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5599228C1F; Wed, 22 May 2019 15:48:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2563528C1A for ; Wed, 22 May 2019 15:48:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EB6389BBE; Wed, 22 May 2019 15:48:33 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16AFD89B70; Wed, 22 May 2019 15:48:31 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id g12so2858295wro.8; Wed, 22 May 2019 08:48:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vg2EX9j0rvlBkEXHkaqvO5uQm91D2PP9LChxb8DR3ic=; b=hdHlVG3C4+SBk3WmYszdInOP8Ne1UyfJeG9Xw1+/f5vqG/BKUTdWL8SuhAT3eIO6eA vllzVdXG+bnPrUBOaJSXxhnsUoPHZCe9ZQiV2DTrhSlcRPu6pIP6uKTgQaD1UcFGEB9V fnUSuWrtqQUd03Lt9bP220mqJNyUJbIkpNV0axrtY+kDjjKAYV0UgVBs8HsFoIiCQSSY w9SNc5I0mNAGRh3+puaKjeggLf+Ur/7vrz+8uvqgoMaKCcJhIDlx+P89mannfxQHlDWd D+p6B2MzKb7H0dXxFNsQwrtW1l9ePBcBK55+rkubX0EFiMgdGAZDKVS1n7AGyqRWbCc8 l4rw== X-Gm-Message-State: APjAAAWIfXXdw4lAK8j9NJg5mdyT/YLw7OHNU2LHm/82tGQrPtVJGQyu roaUW7/Ksyu7mdFChVBCTRq7QmuI X-Google-Smtp-Source: APXvYqxRfqkx+5eFxeuNI/WF7vvQearHUCtTScWr0fJasuyce+E6HM5xC5wroxovI067TtQho/T0jQ== X-Received: by 2002:adf:ec0b:: with SMTP id x11mr6751997wrn.88.1558540109594; Wed, 22 May 2019 08:48:29 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id t6sm12567117wmt.34.2019.05.22.08.48.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 08:48:29 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 3/4] drm/i915: remove irrelevant DRM_UNLOCKED flag Date: Wed, 22 May 2019 16:47:01 +0100 Message-Id: <20190522154702.16269-3-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190522154702.16269-1-emil.l.velikov@gmail.com> References: <20190522154702.16269-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vg2EX9j0rvlBkEXHkaqvO5uQm91D2PP9LChxb8DR3ic=; b=ei2YxqS3vNOVW0KedhVWgnJGhEqfp1cyZ51qLA1C175AlxKXyPaaIh7tw58j5/COyR Gshk06xDTY8MEAlhfOCTjUVRSrUUiaSrw6DfoexXWq98/NBn+xCY+s3RK7tadfPc33pk MtR0WH+XVQ7jZ7Yn/CYhgAbhpCyyXIz3yqSz8V1Y76nfb9jiSaeJz/SOdTluM1hRnIYg CF0Ogvn4MC1zM2L59lsLtN55ZPg+oqdHs6900WUewhMMshptJzzfIoi+nzfH0nGzdpE1 ydZsaD28gXQYXy9xzpPS1OKZIpGgP6mtLcUhHVogX8nbtLiD6UzjrQC1FaMoM76gmgi1 jXdg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, kernel@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov DRM_UNLOCKED doesn't do anything for non-legacy drivers. Remove it. Cc: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter Signed-off-by: Emil Velikov Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 1ad88e6d7c04..a18c155cff88 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -3145,9 +3145,9 @@ static const struct drm_ioctl_desc i915_ioctls[] = { DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_GETPARAM, i915_gem_context_getparam_ioctl, DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_SETPARAM, i915_gem_context_setparam_ioctl, DRM_RENDER_ALLOW), DRM_IOCTL_DEF_DRV(I915_PERF_OPEN, i915_perf_open_ioctl, DRM_RENDER_ALLOW), - DRM_IOCTL_DEF_DRV(I915_PERF_ADD_CONFIG, i915_perf_add_config_ioctl, DRM_UNLOCKED|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF_DRV(I915_PERF_REMOVE_CONFIG, i915_perf_remove_config_ioctl, DRM_UNLOCKED|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF_DRV(I915_QUERY, i915_query_ioctl, DRM_UNLOCKED|DRM_RENDER_ALLOW), + DRM_IOCTL_DEF_DRV(I915_PERF_ADD_CONFIG, i915_perf_add_config_ioctl, DRM_RENDER_ALLOW), + DRM_IOCTL_DEF_DRV(I915_PERF_REMOVE_CONFIG, i915_perf_remove_config_ioctl, DRM_RENDER_ALLOW), + DRM_IOCTL_DEF_DRV(I915_QUERY, i915_query_ioctl, DRM_RENDER_ALLOW), }; static struct drm_driver driver = { From patchwork Wed May 22 15:47:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 10956153 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DF96216C1 for ; Wed, 22 May 2019 15:48:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D13DB28925 for ; Wed, 22 May 2019 15:48:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C5DCC28C1F; Wed, 22 May 2019 15:48:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4116928925 for ; Wed, 22 May 2019 15:48:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DF3189BF6; Wed, 22 May 2019 15:48:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0682789BBE for ; Wed, 22 May 2019 15:48:32 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id m3so2875514wrv.2 for ; Wed, 22 May 2019 08:48:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dgKnb+ZMAHPqo6jMH0ZRWvWPrzNuLtMxTP5x4mydrM8=; b=f9t0VhCSH8EYnks+KAjRs4IZssKxhGH2H3gTMvauURQ24PcJk6XXvbjUVsIbxhjluA YN/TR5K6/HuV3g7ZOM/xtsLoYIYlWVk4b4rqyAeDOdo+4FxFUr2Zk9jjJ9EnQLhsEruH DyUlvP8hlcpxqiS/FK5nwf+so5J6m35KPErn2AhWXdY/MnvuvTAxFhqCIi3tHx/5Q4AQ nQHJvtGluWqbUgqtwRfToSRQEfWinArKGCB6bHOK/p/d5s3K/KcWhiXJZDcAxZQGBOao BN6+kHdMyE9qVFqauOwIcCsA6+OUPkWh/NfrarBSTZoJAKckJ7RR8P57k6GPisXJB5bc BgeA== X-Gm-Message-State: APjAAAU/uSjDaDCT0Fs4st1ALTxekuv5BZ5ePndHsCrN4U9q9zAemhPb jSLtY6NE5qrH+wUi+WBGx0JuklrM X-Google-Smtp-Source: APXvYqx8HI+IZhhKjevA7awIPqbHQcCeXf2djysEOqMBFtegldOzcbbsJcAtx96/yLFrNIydc/KRww== X-Received: by 2002:adf:d088:: with SMTP id y8mr18602094wrh.286.1558540110418; Wed, 22 May 2019 08:48:30 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id t6sm12567117wmt.34.2019.05.22.08.48.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 08:48:29 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 4/4] drm/TODO: add a task to kill DRM_UNLOCKED Date: Wed, 22 May 2019 16:47:02 +0100 Message-Id: <20190522154702.16269-4-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190522154702.16269-1-emil.l.velikov@gmail.com> References: <20190522154702.16269-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dgKnb+ZMAHPqo6jMH0ZRWvWPrzNuLtMxTP5x4mydrM8=; b=SCj0bAWmdFdQ2Mw/RtMDceep46w8/2vWhqVYDeUhXpwoKr/qNB0g8bJO8QAXFzfdN6 3yBiWMt1sQJi1XFVTxVzN6HVrOA+vSxONYbtDeY1jHIlHapmsP+uGzElwmjEBzCAz+Im WFnDUysk3sXdfPV4LN+yWqJjf40yYJ+djqCGwWw4TMuSxgyQzuTZ/iHNq2M570E2YHAB BJ9AhySshIRjyZyXpytEXgyYKpcnOJ9+1negcNWkJthMQEaGQ5zXUSpUo85Nd/2DdxIt re1daW05IKscvAywPiq8kY1uwWralrF7nD8g/9xwTKNn2DjshznyzG+9ReDguMnOaRkn gk2w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov Should minimise the copy/paste mistakes, fixed with previous patches. Cc: Daniel Vetter Signed-off-by: Emil Velikov Reviewed-by: Daniel Vetter --- Daniel, not 100% sold on the idea. That plus listing you as a contact point ;-) What do you thing? Emil --- Documentation/gpu/todo.rst | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 66f05f4e469f..9e67d125f2fd 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -397,6 +397,25 @@ Some of these date from the very introduction of KMS in 2008 ... end, for which we could add drm_*_cleanup_kfree(). And then there's the (for historical reasons) misnamed drm_primary_helper_destroy() function. +Use DRM_LOCKED instead of DRM_UNLOCKED +-------------------------------------- + +DRM_UNLOCKED is a remainder from the legacy DRM drivers. Seemingly drivers get +tricked by it and it ends up in the driver private ioctls. + +Today no more legacy drivers are allowed and most core DRM ioctls are unlocked. + +Introduce DRM_LOCKED, use it to annotate only the relevant ioctls and kill the +old DRM_UNLOCKED. + +Patch series should be split as follows: + - Patch 1: drm: add the new DRM_LOCKED flag and honour it + - Patch 2: drm: convert core ioctls from DRM_UNLOCKED to DRM_LOCKED + - Patch 3-...: drm/driverX: convert driver ioctls from ... + - Patch X: drm: remove no longer used DRM_UNLOCKED, drop todo item + +Contact: Emil Velikov, Daniel Vetter + Better Testing ==============