From patchwork Mon May 27 13:35:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 10963087 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF3581390 for ; Mon, 27 May 2019 13:36:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AD19021FAD for ; Mon, 27 May 2019 13:36:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A0A7F2899C; Mon, 27 May 2019 13:36:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 47AE721FAD for ; Mon, 27 May 2019 13:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=XfXiLKoiJBGhOLOv8mEFIqYc2BE2m6DDrvuol+IQHhw=; b=EGx YLSrwWXLXAOosQNPQIQ3PpQsah2W9ZS3av3yBVl/yHsBK1C10KbQ+xeLd+PLPibgD7Bldc4mcI5sd KOcA8kQctOgEl15CHECuuJHQrLmKFDSFXhIGeETjl/lAbyTcOQ5l+KOzK0D65y6rEkYrl+ZoFvrIV 5/OaA7lDOq32Gxxg+FZ+9bKT+NSdybtVp9r3CgfTV3EmWLdaEBR9RrnIgSvIKLhUnkSvjbaJv8V9F sSK7XsuSGai/7oP9AdKPL0jrc+rWgQuJ5CXmWJznsH76nPucP55Ph+Y2LsSNu3/Ueguln7AF6mBvY HY/wXHYgT0CAEUjsdTzIJ/ZMWuTB1xw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVFnQ-0001n6-Fw; Mon, 27 May 2019 13:36:12 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVFnO-0001mZ-EL for ath11k@lists.infradead.org; Mon, 27 May 2019 13:36:11 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8018D6077A; Mon, 27 May 2019 13:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558964169; bh=mzP5sHGtAzxMnB3lFT+tTSQO9rvXHxmNOWq+907WqiQ=; h=From:To:Cc:Subject:Date:From; b=H3/6sZSZd3Yob+6YkH3qNCDVSovKM2S9lkBLLTFXa/w0+iLH/TY1rCmQO5Tl7RINu MgCrhk2GBbPZPDLl0JUz0XPzhKYyisQUbqcidRRLEvUlTLQkagskkojFudy2e8hdPY M7VBdpd1axCGgMYuWpA9dJCEprzqK5gp2ZXsTe9U= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4518560312; Mon, 27 May 2019 13:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558964169; bh=mzP5sHGtAzxMnB3lFT+tTSQO9rvXHxmNOWq+907WqiQ=; h=From:To:Cc:Subject:Date:From; b=H3/6sZSZd3Yob+6YkH3qNCDVSovKM2S9lkBLLTFXa/w0+iLH/TY1rCmQO5Tl7RINu MgCrhk2GBbPZPDLl0JUz0XPzhKYyisQUbqcidRRLEvUlTLQkagskkojFudy2e8hdPY M7VBdpd1axCGgMYuWpA9dJCEprzqK5gp2ZXsTe9U= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4518560312 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: Fix invalid dma address access in hal rx Date: Mon, 27 May 2019 19:05:39 +0530 Message-Id: <1558964139-13399-1-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190527_063610_496559_F2571BF5 X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP ath11k_hal_rx_buf_addr_info_get() populating the MSB of the dma address from the info0 member, which is invalid. It has to populate the MSB from info1 member. Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/hal_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/hal_rx.c b/drivers/net/wireless/ath/ath11k/hal_rx.c index 6eb47d9..c37340f 100644 --- a/drivers/net/wireless/ath/ath11k/hal_rx.c +++ b/drivers/net/wireless/ath/ath11k/hal_rx.c @@ -286,7 +286,7 @@ void ath11k_hal_rx_buf_addr_info_get(void *desc, dma_addr_t *paddr, struct buffer_addr *binfo = (struct buffer_addr *)desc; *paddr = - (((u64)FIELD_GET(BUFFER_ADDR_INFO1_ADDR, binfo->info0)) << 32) | + (((u64)FIELD_GET(BUFFER_ADDR_INFO1_ADDR, binfo->info1)) << 32) | FIELD_GET(BUFFER_ADDR_INFO0_ADDR, binfo->info0); *cookie = FIELD_GET(BUFFER_ADDR_INFO1_SW_COOKIE, binfo->info1); *rbm = FIELD_GET(BUFFER_ADDR_INFO1_RET_BUF_MGR, binfo->info1);