From patchwork Fri May 31 23:47:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 10971113 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E946613AD for ; Fri, 31 May 2019 23:47:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6A5428BC5 for ; Fri, 31 May 2019 23:47:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA59028C62; Fri, 31 May 2019 23:47:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D56BE28BC5 for ; Fri, 31 May 2019 23:47:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbfEaXrn (ORCPT ); Fri, 31 May 2019 19:47:43 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38004 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbfEaXrn (ORCPT ); Fri, 31 May 2019 19:47:43 -0400 Received: by mail-pg1-f193.google.com with SMTP id v11so4865396pgl.5 for ; Fri, 31 May 2019 16:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=ssV0Kpewe7V3chVlIn07ylhgai93WBPa5K6GWFW9pK0=; b=KJ5xKl0XkK8xfSoBs9VmPUFTbT54EICRlFJivsuzwebkNtDKFLpUJ33geHMGddH7UH w3/MSstmwv9OMEBmDvvAlz1PjL2KsWSQJHNz4YGtCW2XkY4w1BKyppCHkuVQueq27kZC YBk1ZnXq3eQ0jMl/xfEzp9CmLylDUKjriMFmFqHmtnsfsd5HGaG+99WRKOzoRk26ELoa ldQGi8ZpGKWb/FOJC5WK8Acwf7ncsDk5BGS/15OlF53A5pKJbzfCSJvmCT93tEgh4JU/ F63DyhyYh74DbsKVd6VMOO2ByF1G6bzz4HfyClQ4JMt2gyIEZLlz7ofSUKYACjEHk5He BvPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ssV0Kpewe7V3chVlIn07ylhgai93WBPa5K6GWFW9pK0=; b=io2Bz7aPeb2BX14JVoiNrGAPd0JPdoheOVe2z70mba+Z+tgFded/SQs9FRAwzdynE8 Z0/2E2QGxvVcbxe/ojXrKdWwxldggC4zDP6o/UNW51qmlzQB4KF3exUATWUR1LzRajj5 RPcBTUobSzZMTRNh/e5YDdpRH+MQe3NeE6uCVoRCz07H0okcBax/OunHZwQSuulJw50p ZSJjyIm6P2E+Nuy9yA2VBjAg4840/J7US9FkAUQ/irYFUfg2/BFfDCRx6N1cLA0pEV76 6V8gn5K6DfZ7CGWzjO91z1fd07p8+cm349Rv12tLg9IzrCllBZNM7YejsoHTKEj+04rB BFmw== X-Gm-Message-State: APjAAAVmtKYjQpcq3is5Ka+pxjTqJUIk/cT+BcOk1441ogbG5csDbr3p qoxtbT/nkzsr2obcKg7USSvfEw== X-Google-Smtp-Source: APXvYqwtjTiDatBn5Vb3SL+i2YrV0hy4eHkglHMR/DHW3QZBNEZU4xtufJ4SoM5+3ahLS9OihXpixg== X-Received: by 2002:a62:e90b:: with SMTP id j11mr13195158pfh.88.1559346462171; Fri, 31 May 2019 16:47:42 -0700 (PDT) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id y191sm7056843pfb.179.2019.05.31.16.47.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 16:47:41 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Andy Gross , David Brown , Bjorn Andersson , Amit Pundir , Rob Herring , Mark Rutland , Sebastian Reichel , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: [RFC][PATCH 1/2] dt-bindings: power: reset: qcom: Add qcom,pm8998-pon compatability line Date: Fri, 31 May 2019 23:47:33 +0000 Message-Id: <20190531234734.102842-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Update bindings to support for qcom,pm8998-pon which uses gen2 pon Cc: Andy Gross Cc: David Brown Cc: Bjorn Andersson Cc: Amit Pundir Cc: Rob Herring Cc: Mark Rutland Cc: Sebastian Reichel Cc: linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: John Stultz Reviewed-by: Bjorn Andersson --- Documentation/devicetree/bindings/power/reset/qcom,pon.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt index 5705f575862d..0c0dc3a1e693 100644 --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt @@ -9,6 +9,7 @@ Required Properties: -compatible: Must be one of: "qcom,pm8916-pon" "qcom,pms405-pon" + "qcom,pm8998-pon" -reg: Specifies the physical address of the pon register From patchwork Fri May 31 23:47:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 10971115 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C69014C0 for ; Fri, 31 May 2019 23:47:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B79B28BC5 for ; Fri, 31 May 2019 23:47:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F99128C62; Fri, 31 May 2019 23:47:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAF2F28BC5 for ; Fri, 31 May 2019 23:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726634AbfEaXru (ORCPT ); Fri, 31 May 2019 19:47:50 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45254 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726828AbfEaXro (ORCPT ); Fri, 31 May 2019 19:47:44 -0400 Received: by mail-pg1-f194.google.com with SMTP id w34so4846143pga.12 for ; Fri, 31 May 2019 16:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Xt6/4+wEKiWtFL2dtOEhVMVadBdWF2iE7jN+ABlj+7w=; b=LV3JljYIRpW8saWBIJ4KRfsILfhBVVqe7dSepvgV6YpX/7rp9RwVGYJpXloE2liJsQ n5ozpVzBBaStN1xvWSn1tNxVMYwgiSoaOGdjrgW3eLlk3dlAQZTd0ciSEGHGIciz9HSz TLx1B4gCB8OWQDvQvlTQPsfr12gf+4vO2S9s9BXqftNWcSTcVO/qrIGVjCqreLoApKiq MW6czC6dBVBytHaHNbzmnSfeuQZQxC58GNvJaku92zkd3ve1lAWpoliB9zytXJ9SiKS2 BvQpbNaM9IYEpsfMcZt4x2MRtPG5oo77wi0OS46154SJWojVuHc2O2V8noz4yhZdx/2s 8kwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Xt6/4+wEKiWtFL2dtOEhVMVadBdWF2iE7jN+ABlj+7w=; b=ilS24lk1dgtcG1lo+vcBaiiOMQzgDvB7S+yguiN0GwpzXM3sjeBDlu+CGA86TKIKQK +hO+CDHelXoOZpfBJAaHRfyONsJ9dr19r19SB1sbKxCe6MJdcvRvwF/oexnQDNcRAwAD 2NQZS5bSw79lv7lLDBZpEQUF3D9uG8r+x+I/YW56HtQ35Pha9UP9UNwN+R5xzGz3ypQ+ FwtdOQIcT40QbMv/IMOFQQQJPqqCRPpA7jjl6f4oTFz2qWJExTdig3VOROvnfdDPWt40 EHcewfH+LMba6jnvaC30c7h6d5RYAjcs06Cout6B3Jraq/mOYU8dgBcwb2sEJSN6aIlF 7JnA== X-Gm-Message-State: APjAAAWktiOFOv1z8VVT/hzlvpkWYhJxLAMizrfP6J9jTZpRe4AI38ev mCkvyQYx7++Uum0JNz1rpcBoDQ== X-Google-Smtp-Source: APXvYqzr+AoHprjP8ts3wc4y0LIgd/T0gtnPdfKjniQJ+Grqlo/2X9FmKDtLb0saCt3OnKkgzRJbsA== X-Received: by 2002:a17:90a:fa15:: with SMTP id cm21mr12525364pjb.122.1559346463481; Fri, 31 May 2019 16:47:43 -0700 (PDT) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id y191sm7056843pfb.179.2019.05.31.16.47.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 16:47:42 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Andy Gross , David Brown , Bjorn Andersson , Amit Pundir , Rob Herring , Mark Rutland , Sebastian Reichel , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: [RFC][PATCH 2/2] reset: qcom-pon: Add support for gen2 pon Date: Fri, 31 May 2019 23:47:34 +0000 Message-Id: <20190531234734.102842-2-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190531234734.102842-1-john.stultz@linaro.org> References: <20190531234734.102842-1-john.stultz@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add support for gen2 pon register so "reboot bootloader" can work on pixel3 and db845. Cc: Andy Gross Cc: David Brown Cc: Bjorn Andersson Cc: Amit Pundir Cc: Rob Herring Cc: Mark Rutland Cc: Sebastian Reichel Cc: linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: John Stultz Reviewed-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +- drivers/power/reset/qcom-pon.c | 15 ++++++++++++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi index d3ca35a940fb..051a52df80f9 100644 --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi @@ -39,7 +39,7 @@ #size-cells = <0>; pm8998_pon: pon@800 { - compatible = "qcom,pm8916-pon"; + compatible = "qcom,pm8998-pon"; reg = <0x800>; mode-bootloader = <0x2>; diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c index 3fa1642d4c54..d0336a1612a4 100644 --- a/drivers/power/reset/qcom-pon.c +++ b/drivers/power/reset/qcom-pon.c @@ -14,11 +14,15 @@ #define PON_SOFT_RB_SPARE 0x8f +#define GEN1_REASON_SHIFT 2 +#define GEN2_REASON_SHIFT 1 + struct pm8916_pon { struct device *dev; struct regmap *regmap; u32 baseaddr; struct reboot_mode_driver reboot_mode; + long reason_shift; }; static int pm8916_reboot_mode_write(struct reboot_mode_driver *reboot, @@ -30,15 +34,18 @@ static int pm8916_reboot_mode_write(struct reboot_mode_driver *reboot, ret = regmap_update_bits(pon->regmap, pon->baseaddr + PON_SOFT_RB_SPARE, - 0xfc, magic << 2); + 0xfc, magic << pon->reason_shift); if (ret < 0) dev_err(pon->dev, "update reboot mode bits failed\n"); return ret; } +static const struct of_device_id pm8916_pon_id_table[]; + static int pm8916_pon_probe(struct platform_device *pdev) { + const struct of_device_id *match; struct pm8916_pon *pon; int error; @@ -60,6 +67,7 @@ static int pm8916_pon_probe(struct platform_device *pdev) return error; pon->reboot_mode.dev = &pdev->dev; + pon->reason_shift = of_device_get_match_data(&pdev->dev); pon->reboot_mode.write = pm8916_reboot_mode_write; error = devm_reboot_mode_register(&pdev->dev, &pon->reboot_mode); if (error) { @@ -73,8 +81,9 @@ static int pm8916_pon_probe(struct platform_device *pdev) } static const struct of_device_id pm8916_pon_id_table[] = { - { .compatible = "qcom,pm8916-pon" }, - { .compatible = "qcom,pms405-pon" }, + { .compatible = "qcom,pm8916-pon", .data = (void *)GEN1_REASON_SHIFT }, + { .compatible = "qcom,pms405-pon", .data = (void *)GEN1_REASON_SHIFT }, + { .compatible = "qcom,pm8998-pon", .data = (void *)GEN2_REASON_SHIFT }, { } }; MODULE_DEVICE_TABLE(of, pm8916_pon_id_table);