From patchwork Tue Jun 4 11:37:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maharaja Kennadyrajan X-Patchwork-Id: 10974783 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 522B014B6 for ; Tue, 4 Jun 2019 11:36:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40AF3285E0 for ; Tue, 4 Jun 2019 11:36:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3529D28685; Tue, 4 Jun 2019 11:36:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D88D0285E0 for ; Tue, 4 Jun 2019 11:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=LUIUC4NhEFwwJLPLilBeqZ9pxQoT3aLN855J1eMIThg=; b=pV3 xCj2HQbN78filkcqZ7jTUfQlHwt/3MjoO8lfhd2NyZZsO1tDJKNxMgwZfW4O2Ts9cpurmwHbNbPlT YV8v20blLhSMwWeWXTHdzFqq7FdiC6lqxq0f+tQ5l0pYYLO+mXHBLkPO0PQAGUYidgSIURogjHSBc dGeu6gvBCoupF4qB/m+kpGQcKzm9sZ2Pew4FXgO0/eLcN/oyWMJaV4sIiU++Q/rELjRuY7Osu5qwp pPqfNPatC4PfkuhDdWJmZqBHYZOLFF8sQ79Mwho9sFhxGzSsfkojWooGsZuSDGtrlLqX5wyKRH12/ qxKXpZXEzUg+0CvHyHuypCO9h0YjmGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY7jW-0002cM-OU; Tue, 04 Jun 2019 11:36:02 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY7jU-0002c3-Ah for ath11k@lists.infradead.org; Tue, 04 Jun 2019 11:36:01 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5E5EA60E57; Tue, 4 Jun 2019 11:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559648159; bh=Mfr0zlSAij3iS4hAqmd6miYJruOEUUgyuTbU+CLcb0M=; h=From:To:Cc:Subject:Date:From; b=m48yzpsRJWhX+E3JErxyfXeBiO6XdBVbkHrceseKNgEB2lcmm8hKgZhaZ0Ybjz/8d rbADGYXMAjQHQ5PxjiUSacAaZ/irzWblG3i2+Ncho9lW/6AecUpbEHn/EzlBeU/FJP 08JW32qRwzkfNX5UrIgrN7/CwKXAJBBoeu2kwIYU= Received: from che-swdbs-01.qca.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mkenna@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 85512609D4; Tue, 4 Jun 2019 11:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559648158; bh=Mfr0zlSAij3iS4hAqmd6miYJruOEUUgyuTbU+CLcb0M=; h=From:To:Cc:Subject:Date:From; b=VSEozvlmfU7aOfC50ZAyWFA72YKLAZtbaccu/vvbMvmAlFLX5yh85DuAQltnLrVsU nWL0aQPNv17ZmWqRcPldKDohI9vOctmHvhr64nUTi2d0foAps2u7+2XTjunr8GcEzP /i0GxFTI36HotJZcXGIwhX3GQvw8d4vkMZ1HQJXo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 85512609D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mkenna@codeaurora.org From: Maharaja Kennadyrajan To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate Date: Tue, 4 Jun 2019 17:07:19 +0530 Message-Id: <1559648239-16220-1-git-send-email-mkenna@codeaurora.org> X-Mailer: git-send-email 1.7.9.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_043600_404669_EECDAEDD X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maharaja Kennadyrajan MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The rate mask value is changed from 0xff to oxffff (u8 to u32) in the firmware for the legacy fixed rate and peer fixed rate setting in the set bitrate command. Hence this patch is fixing the same in the driver. Signed-off-by: Maharaja Kennadyrajan --- drivers/net/wireless/ath/ath11k/mac.c | 6 +++--- drivers/net/wireless/ath/ath11k/wmi.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index cb0de8e2aa60..f490d7ccc2e2 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -4454,7 +4454,7 @@ static int ath11k_mac_get_single_legacy_rate(struct ath11k *ar, enum nl80211_band band, const struct cfg80211_bitrate_mask *mask, - u8 *rate, u8 *nss) + u32 *rate, u8 *nss) { int rate_idx; u16 bitrate; @@ -4484,7 +4484,7 @@ ath11k_mac_get_single_legacy_rate(struct ath11k *ar, } static int ath11k_mac_set_fixed_rate_params(struct ath11k_vif *arvif, - u8 rate, u8 nss, u8 sgi, u8 ldpc) + u32 rate, u8 nss, u8 sgi, u8 ldpc) { struct ath11k *ar = arvif->ar; u32 vdev_param; @@ -4584,7 +4584,7 @@ ath11k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, enum nl80211_band band; const u8 *ht_mcs_mask; const u16 *vht_mcs_mask; - u8 rate; + u32 rate; u8 nss; u8 sgi; u8 ldpc; diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h index 366a136e53ac..fe89f761ccc3 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.h +++ b/drivers/net/wireless/ath/ath11k/wmi.h @@ -4926,7 +4926,7 @@ enum wmi_ap_ps_peer_param { #define WMI_CIPHER_AES_GMAC 0xa /* Value to disable fixed rate setting */ -#define WMI_FIXED_RATE_NONE (0xff) +#define WMI_FIXED_RATE_NONE (0xffff) #define ATH11K_RC_VERSION_OFFSET 28 #define ATH11K_RC_PREAMBLE_OFFSET 8