From patchwork Fri Jun 7 01:29:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagi Grimberg X-Patchwork-Id: 10980655 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9662017D2 for ; Fri, 7 Jun 2019 01:29:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C8C628ADA for ; Fri, 7 Jun 2019 01:29:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5ED2728ADD; Fri, 7 Jun 2019 01:29:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2FFD28ADA for ; Fri, 7 Jun 2019 01:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727373AbfFGB3Q (ORCPT ); Thu, 6 Jun 2019 21:29:16 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:55652 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725784AbfFGB3Q (ORCPT ); Thu, 6 Jun 2019 21:29:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3Tnu2w88r2Wsr1gVBC/+k0Ht7BIugEAnn7bgyFEtnAg=; b=ZVtw/07ZzaKlmoUzquUHsG+ya mby8lrKhzLOoVVChsTcvhe0Cy2KlRRMJ/rBvTslG1BxSLV5lj353ajSUF9B7sxZPb8WQSNwXzByrS G8fAccflUpr8ur6ftP382GaVVsr59SysBTtzjLs6x6YIUpdmJ8hIGaTJei18NaVryxudxHvLuAuND uSCjcdA8nUTQBrN3lS8gjhfs/WLpS6ZgIGXmYl0iPsywMLKu5DX9+XVsroeBdndEKZveiQbaQGkr7 i84PRLZ1EOxLbLh3j8PEIA6IwHfCkKtwt1ZzFWMBD4M1k63+cvf2XpPR1He9pGEAXHlCEFDSNpANR kaO0pCXEg==; Received: from [2600:1700:65a0:78e0:514:7862:1503:8e4d] (helo=sagi-Latitude-E7470.lbits) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hZ3gx-0006Zg-EH; Fri, 07 Jun 2019 01:29:15 +0000 From: Sagi Grimberg To: linux-rdma@vger.kernel.org, Jason Gunthorpe Cc: linux-scsi@vger.kernel.org, Christoph Hellwig , Jens Axboe Subject: [PATCH v2] iser: explicitly set shost max_segment_size if non virtual boundary devices Date: Thu, 6 Jun 2019 18:29:14 -0700 Message-Id: <20190607012914.2328-1-sagi@grimberg.me> X-Mailer: git-send-email 2.17.1 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP if the rdma device supports sg gaps, we don't need to set a virtual boundary but we then need to explicitly set the max_segment_size, otherwise scsi takes BLK_MAX_SEGMENT_SIZE and sets it using dma_set_max_seg_size() and this affects all the rdma device consumers. Fix it by setting shost max_segment_size according to the device capability if SG_GAPS are not supported. Reported-by: Jason Gunthorpe Suggested-by: Christoph Hellwig Signed-off-by: Sagi Grimberg --- Changes from v1: - set max_segment_size only for non virtual boundary devices drivers/infiniband/ulp/iser/iscsi_iser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c index 841b66397a57..a3a4b956bbb9 100644 --- a/drivers/infiniband/ulp/iser/iscsi_iser.c +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c @@ -653,7 +653,9 @@ iscsi_iser_session_create(struct iscsi_endpoint *ep, SHOST_DIX_GUARD_CRC); } - if (!(ib_dev->attrs.device_cap_flags & IB_DEVICE_SG_GAPS_REG)) + if (ib_dev->attrs.device_cap_flags & IB_DEVICE_SG_GAPS_REG) + shost->max_segment_size = ib_dma_max_seg_size(ib_dev); + else shost->virt_boundary_mask = ~MASK_4K; if (iscsi_host_add(shost, ib_dev->dev.parent)) {