From patchwork Fri Jun 7 05:27:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Skeggs X-Patchwork-Id: 10980781 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 50EFA14B6 for ; Fri, 7 Jun 2019 05:28:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 370C628AF9 for ; Fri, 7 Jun 2019 05:28:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2970028B0D; Fri, 7 Jun 2019 05:28:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CFB9B28AF9 for ; Fri, 7 Jun 2019 05:28:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B404899A5; Fri, 7 Jun 2019 05:28:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AE52899A5 for ; Fri, 7 Jun 2019 05:28:10 +0000 (UTC) Received: by mail-vs1-xe2b.google.com with SMTP id l125so437042vsl.13 for ; Thu, 06 Jun 2019 22:28:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=iBW2OuAV7uevFBFjXasz5IIwXGZVvR4pnR6aaTk59OI=; b=EkDPC6yyiOBrNFPFXZXJNAduuAOsZ2hslG+CXMkdHoVBJQpdDWE6VSY9ezWkj5s6/q EZtmnbkMWNkJJBjxy2UtY1lKytHMhRI+G/bfrsFUppWLJ3mwB2vL3AuzJKjiojZPrjYm Y315Sd25XaKvDMiy/QD9ZMu0c68Bx9zGIG/5NboqTYFS0IIOpZrFvMmWTcGHlG8Q1I/3 5N/nQ5NVNpsVna/JJedenNGwhOUMDX2ObJVB6vUEDdS8gMauIdMuCpwrm80VVJTnofes QT854se9RihjtVCEbhjI2PZBAAuWlxi/LqScSkMqOqdgPdrdpF9aOb7VJNywvl4334Aj vG0Q== X-Gm-Message-State: APjAAAXlei7Ur4+Y1QBASYXgzi4tcj6GyFuqOLhnGx1rlHIhqjgt0ckP d6BAZHAea2g9HWbnd4i3A4b6F3uNPWPjyd5ubco= X-Google-Smtp-Source: APXvYqwBM///a/XtVGsboE6yOB5vvzE2+l99fr2oO+QYiHdDuwohSH748gByieMYyUZJSqZyEv4zTSUIYrmhwqZ4pcI= X-Received: by 2002:a67:fd91:: with SMTP id k17mr12943865vsq.121.1559885289131; Thu, 06 Jun 2019 22:28:09 -0700 (PDT) MIME-Version: 1.0 From: Ben Skeggs Date: Fri, 7 Jun 2019 15:27:58 +1000 Message-ID: Subject: nouveau-fixes 5.2 To: Dave Airlie , ML dri-devel X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=iBW2OuAV7uevFBFjXasz5IIwXGZVvR4pnR6aaTk59OI=; b=njLpiveeyW6xhu+MGpe92opQUd4zEJzIBMQSXd9oDbujkN135+E51KkezOXruEsdBV 9glF5ERabhHImhz1oz/XrkofSbBu1gx5HEt2GnmiESsTkZGjjW1rHYH18xjYHjVBrkZD f2gDx6BMfBOayRbp0FreZtoOG1XyDm0/49AHM/IUaF/F7CgPg5HEUfXC7ZEZOAzZgxfU FkoPzJiJdpzNp5KAIRl4via+itF0XZQpLHVtfPTGsPiTIf5oc9KHY1mIPU09gM/aLd1S nmTH5BLZHLJOMqbVgqaJ5xig3CvoKWuYa9+d+QtZaO8ohctF+z33r8CLpYq97w+tkXMf NX8g== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hey Dave, This is a bit more than I'd like to be pushing at this point in a cycle, but it's a fairly important issue. There's been numerous reports of more recent GP10[2467] boards failing to load, and I've worked with NVIDIA FW engineers and tracked this down to the FW we've been using not properly supporting the boards in question. I've pushed an update to linux-firmware with the new FW version, which unfortunately contains API changes vs the older firmware. This series teaches the ACR subsystem inside nouveau enough to be able to deal with supporting multiple incompatible FW revisions, and adds support to the relevant chipsets for loading the newer FW revision, if it's available. Thanks, Ben. The following changes since commit c4a52d669690423ee3c99d8eda1e69cd0821fcad: drm/nouveau: fix duplication of nv50_head_atom struct (2019-05-14 16:58:06 +1000) are available in the Git repository at: git://github.com/skeggsb/linux linux-5.2 for you to fetch changes up to ab4bec16d4bc21e7b500e519c90e82b063c0df15: drm/nouveau/secboot/gp10[2467]: support newer FW to fix SEC2 failures on some boards (2019-06-07 15:13:58 +1000) ---------------------------------------------------------------- Ben Skeggs (6): drm/nouveau/core: pass subdev into nvkm_firmware_get, rather than device drm/nouveau/core: support versioned firmware loading drm/nouveau/secboot: pass max supported FW version to LS load funcs drm/nouveau/secboot: split out FW version-specific LS function pointers drm/nouveau/secboot: enable loading of versioned LS PMU/SEC2 ACR msgqueue FW drm/nouveau/secboot/gp10[2467]: support newer FW to fix SEC2 failures on some boards .../gpu/drm/nouveau/include/nvkm/core/firmware.h | 16 +++---- drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 33 +++++++++++-- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 4 +- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr.c | 2 +- .../gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 56 ++++++++++++++++------ .../gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.h | 22 ++++++--- .../gpu/drm/nouveau/nvkm/subdev/secboot/acr_r361.c | 50 +++++++++++++++---- .../gpu/drm/nouveau/nvkm/subdev/secboot/acr_r361.h | 3 +- .../gpu/drm/nouveau/nvkm/subdev/secboot/acr_r367.c | 33 +++++++++---- .../gpu/drm/nouveau/nvkm/subdev/secboot/acr_r370.c | 36 +++++++++++--- .../gpu/drm/nouveau/nvkm/subdev/secboot/acr_r370.h | 1 + .../gpu/drm/nouveau/nvkm/subdev/secboot/acr_r375.c | 12 ++++- .../gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 12 +++-- .../drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 22 +++++---- .../nvkm/subdev/secboot/ls_ucode_msgqueue.c | 38 ++++++++------- 15 files changed, 242 insertions(+), 98 deletions(-)