From patchwork Fri Jun 7 10:46:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ayan Halder X-Patchwork-Id: 10981377 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4433E1515 for ; Fri, 7 Jun 2019 10:47:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3252E28B51 for ; Fri, 7 Jun 2019 10:47:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 267A228B53; Fri, 7 Jun 2019 10:47:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CAFC028B51 for ; Fri, 7 Jun 2019 10:47:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E10A89C48; Fri, 7 Jun 2019 10:47:03 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60048.outbound.protection.outlook.com [40.107.6.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7ABE689C48 for ; Fri, 7 Jun 2019 10:47:02 +0000 (UTC) Received: from AM0PR08MB4226.eurprd08.prod.outlook.com (20.179.36.17) by AM0PR08MB3748.eurprd08.prod.outlook.com (20.178.21.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.12; Fri, 7 Jun 2019 10:46:46 +0000 Received: from AM0PR08MB4226.eurprd08.prod.outlook.com ([fe80::bc0c:5148:629e:1a31]) by AM0PR08MB4226.eurprd08.prod.outlook.com ([fe80::bc0c:5148:629e:1a31%6]) with mapi id 15.20.1965.011; Fri, 7 Jun 2019 10:46:46 +0000 From: Ayan Halder To: Ayan Halder , "james qian wang (Arm Technology China)" , Liviu Dudau , Brian Starkey , "daniel@ffwll.ch" , "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH] drm/komeda: Avoid using DRIVER_IRQ_SHARED Thread-Topic: [PATCH] drm/komeda: Avoid using DRIVER_IRQ_SHARED Thread-Index: AQHVHR5MdDQKN6RFT0aBT7A4OfORUg== Date: Fri, 7 Jun 2019 10:46:45 +0000 Message-ID: <20190607104629.28791-1-ayan.halder@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::25) To AM0PR08MB4226.eurprd08.prod.outlook.com (2603:10a6:208:147::17) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.21.0 x-originating-ip: [217.140.106.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 48e9b71b-2e03-41ca-ab9c-08d6eb356ee4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB3748; x-ms-traffictypediagnostic: AM0PR08MB3748: nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:115; x-forefront-prvs: 0061C35778 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(396003)(346002)(376002)(39850400004)(199004)(189003)(81156014)(81166006)(8676002)(6512007)(4326008)(53936002)(36756003)(25786009)(8936002)(5660300002)(72206003)(6436002)(14454004)(102836004)(186003)(6486002)(26005)(2201001)(256004)(86362001)(5024004)(305945005)(7736002)(6506007)(14444005)(66066001)(386003)(66556008)(64756008)(66946007)(73956011)(66476007)(66446008)(68736007)(2906002)(44832011)(6116002)(2501003)(3846002)(316002)(486006)(110136005)(478600001)(2616005)(1076003)(476003)(71200400001)(71190400001)(50226002)(52116002)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3748; H:AM0PR08MB4226.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: UeVtXO5LsWjONiGucui/Lrkn/ByL12sHOWmfCNvG7UUVk2lSzJ+fb5PFExC4S+O8XQhh9akjjKnR/uc4S0fPItcyvPoEZ1wr0e3Sc7TJq2K9ttOV+oFALXJrSFt1uFE5E2sUDVi+FfNu9c4NYaKjeVcwkue6TqoR9U3Rw+tlwSwHCdunlmX8IlYnBkJKCifNabxvWOQ+sz0ZDEBk5h27EUf8PQ9hVXJzvTFaaRGrUYImeqvu/noEYxL5MHRkapcgpMrXeYKkUB6B0l75T6kFOGu79MAIWKY9avzBuUcJWKrg3Czu5BvajIW72luUyE/EnOG6JLFXn6CJA5F7bDvnpnJONDv5XP0QJ+biP7fXrR7gMwO6fJM3GLAKkGBPll/xDiCIaR4kFPkUVJueDQkL6HF5ZjfWCA5bPHGt4fhyk1E= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48e9b71b-2e03-41ca-ab9c-08d6eb356ee4 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2019 10:46:45.9380 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ayan.Halder@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3748 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+vwSFftsmnqIyChyg7ecvR/7CX3UXEeeSf5QwBkSCJg=; b=xlwqQael+zlaM1aysWjIY33KMUcg9MPfdVbiTtZrugIpUu9cBxL3JrzRybnkgLvmYg8CSKeZtriROKY1ZZxT9odPAb6v7pBx/4XrwbqDqGTH5LH3ks3xr5Lqv2nPU2ExKCJMYP8tkYZn9PLViuVQtr4GQiAU3x4kv9chNy4w3Ks= X-Mailman-Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ayan.Halder@arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP With reference to mainline commit (1ff494813bafa127ecba1160262ba39b2fdde7ba), DRIVER_IRQ_SHARED is to be used only by legacy drivers. Further, drm_irq_install() ignores this flag altogether. One needs to use devm_request_irq() instead, with IRQF_SHARED to create a shared interrupt handler. Signed-off-by: Ayan Kumar halder --- drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c index 86f6542afb40..7b5cde14e3ba 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -194,7 +194,9 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev) drm_mode_config_reset(drm); - err = drm_irq_install(drm, mdev->irq); + err = devm_request_irq(drm->dev, mdev->irq, + komeda_kms_driver.irq_handler, IRQF_SHARED, + drm->driver->name, drm); if (err) goto cleanup_mode_config;