From patchwork Sat Jul 21 19:09:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539091 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F3325A6E8 for ; Sun, 22 Jul 2018 00:57:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9EF7528925 for ; Sat, 21 Jul 2018 19:11:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 91B2F2893D; Sat, 21 Jul 2018 19:11:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0EEE428925 for ; Sat, 21 Jul 2018 19:11:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728364AbeGUUFC (ORCPT ); Sat, 21 Jul 2018 16:05:02 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:40700 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUFB (ORCPT ); Sat, 21 Jul 2018 16:05:01 -0400 Received: by mail-wr1-f68.google.com with SMTP id t6-v6so14119759wrn.7; Sat, 21 Jul 2018 12:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rhCfgoM7pHxyUL+b1AT2trWpZrz6IBzdErHmsi71GfY=; b=ZL5VwlfUh6LZ0Y0P8Jc/3vCaaOsNrgFqNyJWt2mIgUEqgRmkwg1/sI9VE3sJ03uwz6 8ZPbXaMqYCI70FN28T1egh3I3VSsXOTLBbrxUbtf4LKtJhY6ANbUni8Oc1CxCF/8nJNG lLmp7f6x05Ql/M5KpTE773YGpJsoWohbew92TWSHP5P3cpCz43K/qJp/kjX0ynPojpbE W7eCR9fr/ROcK6qBRITeIRLUBdFr2Uor1wR8n335/wKDSvn1AzL1nsA2GDBMk6/+AJR8 oSiozxJPCaEZrNRRV1BtjxbUAD9bzjRUx1A5ggLPdksChlGjsEr46/1ULhoBUcvSRjRB AGHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rhCfgoM7pHxyUL+b1AT2trWpZrz6IBzdErHmsi71GfY=; b=r9VcWVtfnFUHAAc8V4d2R3tZRZYSvt34lc9Lal0lUb9UjdLFgIn8M+2ke0/RYGgbWV PkmSDu92UWJRAe9elLP+WvrMVI48e1Nu3Q54LpeK5saHeWw/OMSoyZqG027fvCrxXtyf O0/ZkT+vD3q9odGnwISikXvqJ5TuINdDe02xkDH3kzvfDukPSsGzZW4XFZV3VOtPc4VQ wu0TkQO9gsUhXNZHe8fJK6YuzAJh4rIbq7gh83jng+PyIEuFf433T6S6nMs6Kh0P9sPa 04YJ+PJDnSk+WGmjZ3Hd8mc3M/5ExAgEs73JHpH9gfIqNMciNlvoV1B/8EAp94vs65VZ 4a+w== X-Gm-Message-State: AOUpUlH/Ascsc/KY3MpjfMM/Oc73UEPlv8Pw7JFn2w+1anuCSpSW+R1B v2oWd9jRyTJ29nFknVelXSI= X-Google-Smtp-Source: AAOMgpeYt//6GpDpF30p1UXHiayMT28UcAJqcvbH1xFJ9JS+jAnidC40NigYdh/SQkcMwIWXyQ7m1g== X-Received: by 2002:adf:f188:: with SMTP id h8-v6mr4776571wro.214.1532200273892; Sat, 21 Jul 2018 12:11:13 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.11.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:11:13 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/11] touchscreen: ft5x06: Use octal permissions Date: Sun, 22 Jul 2018 00:39:52 +0530 Message-Id: <20180721191029.25658-11-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using octal permissions '0644'. +static EDT_ATTR(gain, S_IWUSR | S_IRUGO, WORK_REGISTER_GAIN, WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using octal permissions '0644'. +static EDT_ATTR(offset, S_IWUSR | S_IRUGO, WORK_REGISTER_OFFSET, WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using octal permissions '0644'. +static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REGISTER_THRESHOLD, WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using octal permissions '0644'. +static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE, WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. + debugfs_create_u16("num_x", S_IRUSR, tsdata->debug_dir, &tsdata->num_x); WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. + debugfs_create_u16("num_y", S_IRUSR, tsdata->debug_dir, &tsdata->num_y); WARNING: Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. + debugfs_create_file("mode", S_IRUSR | S_IWUSR, WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. + debugfs_create_file("raw_data", S_IRUSR, Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/edt-ft5x06.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 1e18ca0d1b4e..ea4026682e79 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -479,16 +479,16 @@ static ssize_t edt_ft5x06_setting_store(struct device *dev, } /* m06, m09: range 0-31, m12: range 0-5 */ -static EDT_ATTR(gain, S_IWUSR | S_IRUGO, WORK_REGISTER_GAIN, +static EDT_ATTR(gain, 0644, WORK_REGISTER_GAIN, M09_REGISTER_GAIN, 0, 31); /* m06, m09: range 0-31, m12: range 0-16 */ -static EDT_ATTR(offset, S_IWUSR | S_IRUGO, WORK_REGISTER_OFFSET, +static EDT_ATTR(offset, 0644, WORK_REGISTER_OFFSET, M09_REGISTER_OFFSET, 0, 31); /* m06: range 20 to 80, m09: range 0 to 30, m12: range 1 to 255... */ -static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REGISTER_THRESHOLD, +static EDT_ATTR(threshold, 0644, WORK_REGISTER_THRESHOLD, M09_REGISTER_THRESHOLD, 0, 255); /* m06: range 3 to 14, m12: (0x64: 100Hz) */ -static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE, +static EDT_ATTR(report_rate, 0644, WORK_REGISTER_REPORT_RATE, NO_REGISTER, 0, 255); static struct attribute *edt_ft5x06_attrs[] = { @@ -739,12 +739,12 @@ edt_ft5x06_ts_prepare_debugfs(struct edt_ft5x06_ts_data *tsdata, if (!tsdata->debug_dir) return; - debugfs_create_u16("num_x", S_IRUSR, tsdata->debug_dir, &tsdata->num_x); - debugfs_create_u16("num_y", S_IRUSR, tsdata->debug_dir, &tsdata->num_y); + debugfs_create_u16("num_x", 0400, tsdata->debug_dir, &tsdata->num_x); + debugfs_create_u16("num_y", 0400, tsdata->debug_dir, &tsdata->num_y); - debugfs_create_file("mode", S_IRUSR | S_IWUSR, + debugfs_create_file("mode", 0600, tsdata->debug_dir, tsdata, &debugfs_mode_fops); - debugfs_create_file("raw_data", S_IRUSR, + debugfs_create_file("raw_data", 0400, tsdata->debug_dir, tsdata, &debugfs_raw_data_fops); } From patchwork Sat Jul 21 19:09:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539089 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 00796A6EB for ; Sun, 22 Jul 2018 00:57:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CBE2288DA for ; Sat, 21 Jul 2018 19:10:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1EBC4288F7; Sat, 21 Jul 2018 19:10:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA94D288DA for ; Sat, 21 Jul 2018 19:10:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727973AbeGUUES (ORCPT ); Sat, 21 Jul 2018 16:04:18 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:43121 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUES (ORCPT ); Sat, 21 Jul 2018 16:04:18 -0400 Received: by mail-wr1-f67.google.com with SMTP id b15-v6so14124849wrv.10; Sat, 21 Jul 2018 12:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=GCrPruLhZuUTGlT9o6hYH6/BFwQHXTby7KIZNp0S4WE=; b=o/CtUiGL8gGI4hDKHSuJqwdqHQEkUztP7ep2Whm2dS2k+6DQn8j31ZrY8zfQ1j4TmN mFwpFEthd14QApID1DJytrsH9K1zWhTlVn8mA0HhETvgpc+Kubb0TFWa6hilAVgMnSs1 aBWQe2TqpOfL01dQcB4nYxdSIXO6nn31/qvlM8zZT6x2ZqSK6VyKnnAdgRCPuAzMXZG0 p9v9pf9ekGlMsyBE36MGO+x3o/KzxX1r4c6QQpSNrXdDMEvtNIFGRerVxcgXP2ZY9Mac vTFt1a0trjOUhCUq3gfjmEiZ4ERkqkZjjDuxWGorpDJ4et4NGkXb/WXB66e+23NEfYSZ rnpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GCrPruLhZuUTGlT9o6hYH6/BFwQHXTby7KIZNp0S4WE=; b=TbYkS9WD1/ulBT+sLct/qvTO2H6NO7O+9Xs2CUflOqCHsnYgzF5wspchN8Ar/P98Rp IYJB4kPgWwXW5VoYiBGBSPQj8ydDSsvgDBUOo5APdMEWDGOXTS2dzCRKuwZ0KJl5+lIg pGkEwE4DZi+GNlSnalco1ZITpSFHIADS0mp4/iw25kUMxArr5e2DBBPzhVv1BOBT8g3x rMlIAQ6RRNwzu7EulqezggvveMQ6wRHRZN63+toMZ/qjqohXp0DPjHjD7Rm0Rwxhz7aq MHR4AwKjcKFEigPS4nZ12oEzsLfzJGHJbAgo558NKpQJk4sKAz+cY4lN3vB1Lhiw8idh rBSQ== X-Gm-Message-State: AOUpUlHEAks8xoZ9Eo+yBZdIjkvIW8CFMio8pIPzI+O5IqPLY98mArK6 DTuSshLOpn7mTNwlpsu38nE= X-Google-Smtp-Source: AAOMgpdkWDEwrhB56K1nJ7MCnz9u7egVvruqKYZ2qDCEPxid/wNCHhBimurqchk9TEWZHLyYrDkT8w== X-Received: by 2002:adf:fb92:: with SMTP id a18-v6mr4312299wrr.278.1532200230629; Sat, 21 Jul 2018 12:10:30 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.10.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:10:30 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Michael Hennerich , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/11] touchscreen: ad7877: Use octal permissions Date: Sun, 22 Jul 2018 00:39:42 +0530 Message-Id: <20180721191029.25658-1-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/ad7877.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c index 5cfe477ec992..4b4a9d84195e 100644 --- a/drivers/input/touchscreen/ad7877.c +++ b/drivers/input/touchscreen/ad7877.c @@ -461,7 +461,7 @@ name ## _show(struct device *dev, struct device_attribute *attr, char *buf) \ return v; \ return sprintf(buf, "%u\n", (unsigned) v); \ } \ -static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); +static DEVICE_ATTR(name, 0444, name ## _show, NULL); SHOW(aux1) SHOW(aux2) From patchwork Sat Jul 21 19:09:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539097 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0858AA6F6 for ; Sun, 22 Jul 2018 00:57:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E1E628952 for ; Sat, 21 Jul 2018 19:11:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 82D5328AC2; Sat, 21 Jul 2018 19:11:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 749E628952 for ; Sat, 21 Jul 2018 19:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728166AbeGUUEW (ORCPT ); Sat, 21 Jul 2018 16:04:22 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34618 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEW (ORCPT ); Sat, 21 Jul 2018 16:04:22 -0400 Received: by mail-wr1-f66.google.com with SMTP id c13-v6so14137956wrt.1; Sat, 21 Jul 2018 12:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cs0oJnLo2LfTemgdMwNzfJPIk8MN9r2ly9dw0G7v5ts=; b=Z0XelieA39SlDImtmOwEoL3K30qD6KgKX4I6m+UfwymTBb7pZra8V6jZvzzgBjXFoK XV9mcJcDdLg0OefChXGvvtMHkpVXOwlyvQaKXeItg2WkiwVsCWOY+Qwnt6UsJYXmENqT PVYKTLVBBVmGXvjL3JCTvT/POl48J7BW6O79NsBUmLVyF3YP7fsEHP1lJPQ9zIEr1U/c hp8sEygpNLy03L1s3juW/BYsRauMF2cH/QlrF0fl8ppYF1GkFxu+BFAt1ewVtrDCCRq7 dnX3BiBMk1GvF7CmgpNtznO7Zk//93k2x7lVV8S4FYmKPhI4l7qHiNJ7FDDR+1QloD1V Xa4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cs0oJnLo2LfTemgdMwNzfJPIk8MN9r2ly9dw0G7v5ts=; b=b9fPKKSTX4TIWv/tleh25BN8KB6hAl+ZoVNsTjRyskCZnsXVmJWkVih/s2YoUHp+ZD Y5gsxlo9sRODrYxl8kG7+wPjYjVgdPd/uz6CKqLZY28X3WiyrDdefsj5yF35OCmkEXCE TmY0Op8dXaHO0nNHRhtT8jg7Zo3bb0O3jk5TwA9ynL7ab9OlGic/OxFQojS1455+a8oX 8LgjFeu5+6py0U0H/Ptcd8/9GYxsj8P+VNvuXBKdivbqHUwC+XPDWiICk2KIzr6LzI5+ FKGyEsQhtoS4FO1r0EM23ekvODcRxe83ZyaG4kIQuYcIs3bFmVTbFgfj9Wl/vSCglhjR w8wg== X-Gm-Message-State: AOUpUlGBaszEEkHuUnEKKaSgSjF2Ac/yBrV9HXBpkS4IpqLRs1NpD2Xz yGmBansmQtaN2ryz3jy2iQM= X-Google-Smtp-Source: AAOMgpfGXgEpDzd9R1NzI+A00aoxc1Y07iOV9RnHmHUkv/UfZRW/4SkRPs+SIKVT32A5njvcjU38Jw== X-Received: by 2002:adf:99ea:: with SMTP id y97-v6mr4391317wrb.215.1532200234328; Sat, 21 Jul 2018 12:10:34 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.10.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:10:33 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/11] touchscreen: ad7846: Use octal permissions Date: Sun, 22 Jul 2018 00:39:43 +0530 Message-Id: <20180721191029.25658-2-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(pen_down, S_IRUGO, ads7846_pen_down_show, NULL); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/ads7846.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index a2f45aefce08..7c07de0802de 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c @@ -431,7 +431,7 @@ name ## _show(struct device *dev, struct device_attribute *attr, char *buf) \ return v; \ return sprintf(buf, "%u\n", adjust(ts, v)); \ } \ -static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); +static DEVICE_ATTR(name, 0444, name ## _show, NULL); /* Sysfs conventions report temperatures in millidegrees Celsius. @@ -561,7 +561,7 @@ static ssize_t ads7846_pen_down_show(struct device *dev, return sprintf(buf, "%u\n", ts->pendown); } -static DEVICE_ATTR(pen_down, S_IRUGO, ads7846_pen_down_show, NULL); +static DEVICE_ATTR(pen_down, 0444, ads7846_pen_down_show, NULL); static ssize_t ads7846_disable_show(struct device *dev, struct device_attribute *attr, char *buf) From patchwork Sat Jul 21 19:09:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539087 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 036DDA6EC for ; Sun, 22 Jul 2018 00:57:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D8CF3288EA for ; Sat, 21 Jul 2018 19:10:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CD39028901; Sat, 21 Jul 2018 19:10:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9C24288EA for ; Sat, 21 Jul 2018 19:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728274AbeGUUEY (ORCPT ); Sat, 21 Jul 2018 16:04:24 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41389 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEY (ORCPT ); Sat, 21 Jul 2018 16:04:24 -0400 Received: by mail-wr1-f65.google.com with SMTP id j5-v6so14117685wrr.8; Sat, 21 Jul 2018 12:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vyjd9FGJMy0+TxbD7vXkSRtycDBsk85CQ0K4UBHKE3I=; b=b13ghsMwCn49x6zIuqIF7fwHWATRXhwNTG76khSpodNpCrKknq7olHeXdYg8tY6Jeb 7Vs3Bjq5lNJxMiMkbliAh/O0fr+pulHiFAAXaN+BUPPjao28Rpst5UuRxtKiU+A1/WtC CUafuylOV66+XqSfUauqB0N6JR4X33RbyzLIus0lR0h8sVbHsygGORmQKIO3gg5JePqf 08SvhpLAQE1o2BO7SJowvd8+nr7TuPxtH7kOkfaQAFBosLg2uFQ8IU1B8TclXQJcAdBK CJNu8/u8zZVfUXz/jNsOwfX6QWWsjhUJD0377Etd0i2iyU6t6/n/kyaZesAnuaVQmXDL VJPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vyjd9FGJMy0+TxbD7vXkSRtycDBsk85CQ0K4UBHKE3I=; b=WO5AsFpxS6PfEFFw9jclQ/FGWDngIcyW9MiwQyJgZRIsmRiKDsnrOY6DoFldL4IO4t SBAZQBGBvBENXnAiGGG7Stfy1w2jYmfaI0Dt0337RpV3sqS4LQlyDcKNl180Df6h6GF6 8cFXeen/adO3v+wcdIhW4kwaa5pR894GZlB54H9Yi61X0d7QhvFOuEseKUZnWNj/I+vq PW4UwmJkXQZIPtkL6vVYwFOauhrgTEDF7qWoIHQ517O3LVDU31eaiaLdbAGojP8I+/9R sR/CrjKoQuytkym1IKhgV8/u0ti44oCLo0MDRW4gndY0Y8eDaRUgH2zmv0E6qJiiHp1N F9pQ== X-Gm-Message-State: AOUpUlHpqVLv9SUr6zSUWCnQ8v7Mq5tM4fehv5OnyxnA1s0hXD9ZL+Qs H80+MZWxU8+Q4OvSJF6/+bg= X-Google-Smtp-Source: AAOMgpcYljecTMm9MRpmiuhdCgDAqKG7T6aCGjGkXUIQ04qhobkNHhmdu5Sj3mVKcNePm2vkL+kiuw== X-Received: by 2002:adf:b519:: with SMTP id a25-v6mr4775766wrd.273.1532200236390; Sat, 21 Jul 2018 12:10:36 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.10.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:10:35 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Nick Dyer , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/11] touchscreen: amtel: Use octal permissions Date: Sun, 22 Jul 2018 00:39:44 +0530 Message-Id: <20180721191029.25658-3-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(fw_version, S_IRUGO, mxt_fw_version_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(hw_version, S_IRUGO, mxt_hw_version_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(object, S_IRUGO, mxt_object_show, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mxt_update_fw_store); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 54fe190fd4bc..5202a8244f1d 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2892,10 +2892,10 @@ static ssize_t mxt_update_fw_store(struct device *dev, return count; } -static DEVICE_ATTR(fw_version, S_IRUGO, mxt_fw_version_show, NULL); -static DEVICE_ATTR(hw_version, S_IRUGO, mxt_hw_version_show, NULL); -static DEVICE_ATTR(object, S_IRUGO, mxt_object_show, NULL); -static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mxt_update_fw_store); +static DEVICE_ATTR(fw_version, 0444, mxt_fw_version_show, NULL); +static DEVICE_ATTR(hw_version, 0444, mxt_hw_version_show, NULL); +static DEVICE_ATTR(object, 0444, mxt_object_show, NULL); +static DEVICE_ATTR(update_fw, 0200, NULL, mxt_update_fw_store); static struct attribute *mxt_attrs[] = { &dev_attr_fw_version.attr, From patchwork Sat Jul 21 19:09:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10538979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 96E58A665 for ; Sun, 22 Jul 2018 00:57:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBA03288F7 for ; Sat, 21 Jul 2018 19:10:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BD65228919; Sat, 21 Jul 2018 19:10:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 66CF7288F7 for ; Sat, 21 Jul 2018 19:10:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728277AbeGUUE3 (ORCPT ); Sat, 21 Jul 2018 16:04:29 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44607 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUE3 (ORCPT ); Sat, 21 Jul 2018 16:04:29 -0400 Received: by mail-wr1-f68.google.com with SMTP id r16-v6so14098076wrt.11; Sat, 21 Jul 2018 12:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cQnpQ5ukIwhaXpqaMQiYbTqwtfXwfw7nbJ/+Aug88sk=; b=IfrCPhuwMPV/ySeuyoxkn4RKROasvdUJ6EFsbIDmtHJPXIxNWABCdFfA/PlfEsPmNy IOeqc7Dbk2nejKCxuRWUcv0vXpOR4hrDNH6nyBUa//NiH3zlvWjuKASHXGED2xpRGyU8 Fj0PohWCBpSqpDyVyimHO6NcCXEKvX6wCN8hZoNN0W9Mt5yIxfIb/vKMBYbIintkSUgZ y1DTfd4MaS/lmRVBJ0T+/Mb8rNOo0uZHXjDJJMVEaITucI8SnvpGxE00/pzlXSJkP+sq LQoaT+8mnMp7WwfNCo9LgQDuVd6BjcVcw2sh3LrssM60t9INzZFcm9nYT1wUQaMsVi0o a23Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cQnpQ5ukIwhaXpqaMQiYbTqwtfXwfw7nbJ/+Aug88sk=; b=nvx7092eMAVeR3B8DmizZMe4QTAvjBO/ghbr/eaCEh2GqSavHfXOTK3u6phjtbzsxd KgYfRxOJnQCWDckG2/H13DEVnqDfmEa5/C7p1cb8NXIPEHE8t9fR7/et2VicbvxLNUHf wj/g0UwWR7vsFyrfQ7m5PRZCfhjIoy9jHZ0NgX1bNPZuywMOBOnIlJ8modUDgbpJfPwv tk4OuYIMGOpU3izZw0LrYZSoNSXG6ExC+6arCl32G5mRsJavtmItK8tXlX1t5c3VjbBz gJhWaG2prwctylg2J4UbFuC4T4Z7VwBC+XyewaztcIXBPHOn98EV5C3aiyJuOTkD2GLu cv9g== X-Gm-Message-State: AOUpUlEfNLaGqZxpve7Fjt8vL99saVQDvhFU8a08SbTfiqTsrWMHk+DU jMnhTKTWHUI+vux/BPvKWt58rJJSYxBrdzZAZ7Y= X-Google-Smtp-Source: AAOMgpdGgOkUqFNs910D/Gwd1byNXl1T0kP16LTG0VnQUD1tTYFy2H4lF2tzY6rlwXzh8rI5AjxA/Q== X-Received: by 2002:adf:8481:: with SMTP id 1-v6mr4679308wrg.34.1532200241841; Sat, 21 Jul 2018 12:10:41 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.10.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:10:41 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , Greg Kroah-Hartman , Guenter Roeck , Joe Perches , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/11] touchscreen: elants: Use octal permissions Date: Sun, 22 Jul 2018 00:39:45 +0530 Message-Id: <20180721191029.25658-4-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw) WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. + .dattr = __ATTR(_field, S_IRUGO, \ Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/elants_i2c.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index d21ca39b0fdb..9717b7c3bb6f 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -1000,8 +1000,8 @@ static ssize_t show_iap_mode(struct device *dev, } static DEVICE_ATTR_WO(calibrate); -static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); -static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw); +static DEVICE_ATTR(iap_mode, 0444, show_iap_mode, NULL); +static DEVICE_ATTR(update_fw, 0200, NULL, write_update_fw); struct elants_version_attribute { struct device_attribute dattr; @@ -1016,7 +1016,7 @@ struct elants_version_attribute { __ELANTS_FIELD_SIZE(_field)) #define ELANTS_VERSION_ATTR(_field) \ struct elants_version_attribute elants_ver_attr_##_field = { \ - .dattr = __ATTR(_field, S_IRUGO, \ + .dattr = __ATTR(_field, 0444, \ elants_version_attribute_show, NULL), \ .field_offset = offsetof(struct elants_data, _field), \ .field_size = __ELANTS_VERIFY_SIZE(_field), \ From patchwork Sat Jul 21 19:09:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10538983 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9AC9CA66F for ; Sun, 22 Jul 2018 00:57:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6593428942 for ; Sat, 21 Jul 2018 19:11:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 59F0E28952; Sat, 21 Jul 2018 19:11:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1419E28942 for ; Sat, 21 Jul 2018 19:11:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728351AbeGUUEe (ORCPT ); Sat, 21 Jul 2018 16:04:34 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34628 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEe (ORCPT ); Sat, 21 Jul 2018 16:04:34 -0400 Received: by mail-wr1-f68.google.com with SMTP id c13-v6so14138197wrt.1; Sat, 21 Jul 2018 12:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ymlCkC7UtcvznfbwfCWP7nAOLsnaf7ommwT//m37oPw=; b=ZzOu5TTIfh0/jPIUpSv6nLOHQetPSBw/zoIc2R7nfpquZO6ZGjUocLpAErPzl2Xv2z F9voG9rO5FLvRjM4Mo2jvT1g8Ml6Hm9LdBqgGiYFetdBFoKeNWBRhCPqZkNSAeEy/G9d 9odUjZQ5BQxH2ROl3fsoCflPpVlaDiPeXFGSXE6P0nJGNhyiHmDuZJvdw3pQId7Apizw PjrdY9luSQVW2q4sPebsiZ7At6ZbZjcRvMjMqMvdOysIsz/nmpc7ttGTdih+AhraGBre 0vDJK8JoGbGYaqFnSVXhVCeKOKuY0OLKHaVTEt4y5I/YW9/RgcpygSSdQcao5nvujb9k KcLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ymlCkC7UtcvznfbwfCWP7nAOLsnaf7ommwT//m37oPw=; b=KOWQ/jxj1LpTg4fTLin8YMMnPZGhDqI66ISnZWCedcn5X3UJ+3uUCtDu//sYq4eaUB tEg3EGt8UYpSz6ZTwvl9sZwz3PIabXn4Ie0iO7JIc5UElM+qDxmIYDbQ+VkwpPrX8nGP sVewFoBJV1biIqeyV+oLopsNNEBogl7/WdugsulZ3D93whwIGSk8aCq9mRj/U/SYUAfX 8ARrq3ahn8DokYmnrebpjlbtTg3SE8eZy9XP67kBB7VupwQFnMl8e/D+c5nTlCXe4avs xlkIu9Ke7P9Z/DIdVBZQ0UcHjP8WcxLwAG2WSoIHeCS6D3p+kbdHqNWH1wJ9PlVTsTOZ sMyQ== X-Gm-Message-State: AOUpUlF/rSwJO8tw5uHozJG4MHCs0wnQiCWf68mnxdh/gleYaQJKubGd ZUy0XY4Y/lBLyUTJGpEllxE= X-Google-Smtp-Source: AAOMgpfH0Gb2wkcottbFEhhX56dnkKU4VI7qTpqbkKVLizj0Yq5aqaOYDRxoQWhk/8WrdZ9XsDxiPQ== X-Received: by 2002:adf:e14a:: with SMTP id f10-v6mr4321555wri.42.1532200246949; Sat, 21 Jul 2018 12:10:46 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.10.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:10:46 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/11] touchscreen: ili210x: Use octal permissions Date: Sun, 22 Jul 2018 00:39:46 +0530 Message-Id: <20180721191029.25658-5-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(calibrate, S_IWUSR, NULL, ili210x_calibrate); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/ili210x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c index 6f76eeedf465..07526a6f2cb7 100644 --- a/drivers/input/touchscreen/ili210x.c +++ b/drivers/input/touchscreen/ili210x.c @@ -169,7 +169,7 @@ static ssize_t ili210x_calibrate(struct device *dev, return count; } -static DEVICE_ATTR(calibrate, S_IWUSR, NULL, ili210x_calibrate); +static DEVICE_ATTR(calibrate, 0200, NULL, ili210x_calibrate); static struct attribute *ili210x_attributes[] = { &dev_attr_calibrate.attr, From patchwork Sat Jul 21 19:09:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539031 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B84E6A694 for ; Sun, 22 Jul 2018 00:57:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C8E22894E for ; Sat, 21 Jul 2018 19:11:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10BED28950; Sat, 21 Jul 2018 19:11:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B82E028942 for ; Sat, 21 Jul 2018 19:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728398AbeGUUEk (ORCPT ); Sat, 21 Jul 2018 16:04:40 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:46725 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEj (ORCPT ); Sat, 21 Jul 2018 16:04:39 -0400 Received: by mail-wr1-f68.google.com with SMTP id s11-v6so14098166wra.13; Sat, 21 Jul 2018 12:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kN9n0PrhQwGth982mv27AcZIZq4LowLYQ8bufArZCyY=; b=cMoePVApHMX+ORL5ec/As+Aw479/lxyxs24N/6DhqJzVH8dz4N8VL4YEf9JFXmvz/9 JpY6n5VkZyxfubwswCcVFxb5wEo1YxrxE/pNFzW8NZ3fIfgh2Lw9Qh1CNdXrmkFGSZGi bPPFyQcisD5NeS64+RmzCDnytMTHDR2tu/oClWF1QeUdZNV4oqdykhNMyWEXIUTJwIZ9 kDOyWwI7GCdqNfl6Htqh9ccoMp0viFa1MnU+ZEhr/BBJU6jEUzxpVZK3JFr1EIc0dGV0 0TV/xLYY7SDjJ8oTvRYpaPUm0S9+B8Pc5tE+iSlR3OMQjAf+Sc5s48Ss+fmNDbavxOPM rOlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kN9n0PrhQwGth982mv27AcZIZq4LowLYQ8bufArZCyY=; b=qUlAjE415ZlOMBo4UVAF/UHqQnu16UH3nntyQtGwOmMNYSeewKgRWVQThOm/cReF6W MAcDs2nYous6p2jCYWnfOxEXqjOlpLhw7bKWB/kfQ39hoC8h7WvvHf49zUSR1dnwV/Xv CSeet0AagtrDYFm61RuRZ5tNrL4XOLBS20PTFzjn05LxyoWPHAWjOtLHABbN9v2QIv8j 8iuO/+eazgnkm3vRaaF6/cAG9e0DO0hz8V3FY0tQyEYyQ5cV0AN7S5hVOw3FdIqTljdX mnH69+aHWugjvvJX57CIPZSkqVyLMod+P0UtBIHYgndEg91xuV1cx6De2pIAjRJYQIgL pUrQ== X-Gm-Message-State: AOUpUlH/LML2U7M0lFOTJpJjB6omYjwlb0ZDWpZls8KhhFANh43DgtPJ dzytYCOChjWN58SemjyXnLo= X-Google-Smtp-Source: AAOMgpckP4WIJGdrvjBOIxV2cm4oPZgm5hk722bQ8UuHccnOGuCW8lKdx3olWTk+hJBuZtD70Canlw== X-Received: by 2002:adf:96b2:: with SMTP id u47-v6mr4609547wrb.204.1532200252355; Sat, 21 Jul 2018 12:10:52 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.10.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:10:51 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/11] touchscreen: mc13783: Use octal permissions Date: Sun, 22 Jul 2018 00:39:47 +0530 Message-Id: <20180721191029.25658-6-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. +module_param(sample_tolerance, uint, S_IRUGO | S_IWUSR); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/mc13783_ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchscreen/mc13783_ts.c index ef64f36c5ffc..4e33349f101e 100644 --- a/drivers/input/touchscreen/mc13783_ts.c +++ b/drivers/input/touchscreen/mc13783_ts.c @@ -25,9 +25,9 @@ #define DEFAULT_SAMPLE_TOLERANCE 300 static unsigned int sample_tolerance = DEFAULT_SAMPLE_TOLERANCE; -module_param(sample_tolerance, uint, S_IRUGO | S_IWUSR); +module_param(sample_tolerance, uint, 0644); MODULE_PARM_DESC(sample_tolerance, - "If the minimal and maximal value read out for one axis (out " + "If the minimal and maximum value read out for one axis (out " "of three) differ by this value (default: " __stringify(DEFAULT_SAMPLE_TOLERANCE) ") or more, the reading " "is supposed to be wrong and is discarded. Set to 0 to " From patchwork Sat Jul 21 19:09:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 065DDA6F5 for ; Sun, 22 Jul 2018 00:57:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B3FD728901 for ; Sat, 21 Jul 2018 19:11:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A800228925; Sat, 21 Jul 2018 19:11:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4ADDB28901 for ; Sat, 21 Jul 2018 19:11:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728517AbeGUUEn (ORCPT ); Sat, 21 Jul 2018 16:04:43 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:46727 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEn (ORCPT ); Sat, 21 Jul 2018 16:04:43 -0400 Received: by mail-wr1-f68.google.com with SMTP id s11-v6so14098238wra.13; Sat, 21 Jul 2018 12:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lTo2MlEG2+LXPVqtHWbj85T6ZaBnPlWK9eJyQLqBpgI=; b=rIsGJzuQwzrjCEsHX+ZuyNH4AjeucEs3XX7febsA2713nisDzEv6gu8gW+CYtK/8z7 yEMm+jCexdo9mlFblPuYkCcU/rOB5O/a6QX1Q0c5UiCRuldG3Tw/ze57KT9Ycb93t4dE hlwO9grP+W237UDakawlfXDRs9Tbo4OGLgRFUS5cuf4yisuwxgxWI4HmaiKB3KYeY+e2 NvZ15FxwvtDN7eoylTY9OpNGAnZFGYqgmIOkJIbFd0zsvLMNWY2AuzE7Dr15gtfkpc00 Sr+WEQ+6bK/vLqjijrv6V4b+IqmXxbXca4TxztSnwDWXcZtIT1KzyvDqhcgaVu5Hytyu Wl6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lTo2MlEG2+LXPVqtHWbj85T6ZaBnPlWK9eJyQLqBpgI=; b=TV58ooWZl1LdTVAIVzDTWl/gTGDhSCh4NcotWUaLqMHNnIeckJC0SLnQUttjwSOLKy bdN6mnSsfGcPX/IJ2EktffrlgPBBNk8WU6iRyg/x5s8IZ8eJ8naOp0V3rKLpgfatiO9f JYqhg7/QSMg0Qd7pIYX98xO0B+qfpIK/BBDp8Nqbhis7sDp2Id7d9c3Z0Tj62u1obfmt /oC7WBwE4ZhQZChCifCcr9R3XjStEOd5SIUrJzStkTtnx25RmYGYsQ3zgIk7VFhJBG0k E3/rUIRCkEM8oejwftjh4NPVnJX2oU2s/vgxmIxby5J2SH4sqU3xaot60rhbWeXxCjpE 8ODw== X-Gm-Message-State: AOUpUlF4wyK562Via12Y2fqbMxadQnSVwzcqSysq22I8ll5hbXYfNnRv H6GJxc3ou9g4iCLubgvVpwg= X-Google-Smtp-Source: AAOMgpeQvGu5QkeuTZbP9wPzz5DpP6Wd9CdCBICYblRvf++mHhxgW/uo4sXSpqWWK3iZMcTBYk9yGg== X-Received: by 2002:adf:ab14:: with SMTP id q20-v6mr4372572wrc.239.1532200255668; Sat, 21 Jul 2018 12:10:55 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.10.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:10:55 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Sangwon Jee , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/11] touchscreen: melfas: Use octal permissions Date: Sun, 22 Jul 2018 00:39:48 +0530 Message-Id: <20180721191029.25658-7-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mip4_sysfs_fw_update); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(fw_version, S_IRUGO, mip4_sysfs_read_fw_version, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(hw_version, S_IRUGO, mip4_sysfs_read_hw_version, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(product_id, S_IRUGO, mip4_sysfs_read_product_id, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(ic_name, S_IRUGO, mip4_sysfs_read_ic_name, NULL); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/melfas_mip4.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index 430a2bc5f7ca..f7fd940e61ea 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -1332,7 +1332,7 @@ static ssize_t mip4_sysfs_fw_update(struct device *dev, return count; } -static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mip4_sysfs_fw_update); +static DEVICE_ATTR(update_fw, 0200, NULL, mip4_sysfs_fw_update); static ssize_t mip4_sysfs_read_fw_version(struct device *dev, struct device_attribute *attr, @@ -1354,7 +1354,7 @@ static ssize_t mip4_sysfs_read_fw_version(struct device *dev, return count; } -static DEVICE_ATTR(fw_version, S_IRUGO, mip4_sysfs_read_fw_version, NULL); +static DEVICE_ATTR(fw_version, 0444, mip4_sysfs_read_fw_version, NULL); static ssize_t mip4_sysfs_read_hw_version(struct device *dev, struct device_attribute *attr, @@ -1379,7 +1379,7 @@ static ssize_t mip4_sysfs_read_hw_version(struct device *dev, return count; } -static DEVICE_ATTR(hw_version, S_IRUGO, mip4_sysfs_read_hw_version, NULL); +static DEVICE_ATTR(hw_version, 0444, mip4_sysfs_read_hw_version, NULL); static ssize_t mip4_sysfs_read_product_id(struct device *dev, struct device_attribute *attr, @@ -1398,7 +1398,7 @@ static ssize_t mip4_sysfs_read_product_id(struct device *dev, return count; } -static DEVICE_ATTR(product_id, S_IRUGO, mip4_sysfs_read_product_id, NULL); +static DEVICE_ATTR(product_id, 0444, mip4_sysfs_read_product_id, NULL); static ssize_t mip4_sysfs_read_ic_name(struct device *dev, struct device_attribute *attr, @@ -1418,7 +1418,7 @@ static ssize_t mip4_sysfs_read_ic_name(struct device *dev, return count; } -static DEVICE_ATTR(ic_name, S_IRUGO, mip4_sysfs_read_ic_name, NULL); +static DEVICE_ATTR(ic_name, 0444, mip4_sysfs_read_ic_name, NULL); static struct attribute *mip4_attrs[] = { &dev_attr_fw_version.attr, From patchwork Sat Jul 21 19:09:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06554A6F3 for ; Sun, 22 Jul 2018 00:57:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FF6528919 for ; Sat, 21 Jul 2018 19:11:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 548C22892E; Sat, 21 Jul 2018 19:11:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F1BD328919 for ; Sat, 21 Jul 2018 19:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728596AbeGUUEt (ORCPT ); Sat, 21 Jul 2018 16:04:49 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:39886 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEs (ORCPT ); Sat, 21 Jul 2018 16:04:48 -0400 Received: by mail-wm0-f68.google.com with SMTP id h20-v6so12643840wmb.4; Sat, 21 Jul 2018 12:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7uafs0jiKUh7lUwZ0AA5KAIpK1U6UC7U/ESXulHGeeE=; b=UCxbVxA9XUsECyLTFuTq2VBRqvpftTYDG6X7u3GTSYQ/nvdJiKsclpIJI8U+n2fwuX 9OUL8DLakUHyjIEySJaL6ex+nXjdwyJUT51NIvNgsg6GY4YwZaIW3suWxQvh6ZDALKOs kk3MzrLHI1IsxYrOv+bfZtakeCdhWs8jOCCpyUwI7obXGPsflNnakBtqqWpqm4tzlDgr bHH9XmDOAJLAvg0mcCu8YWAygemF2yatcO0MyKhBRLevx4GDMlXYdN/LCscr+hw/eZpB t7FLCyYwmghKLG72vik6WUZ3BfemTcjgFeHCmbOiX/NJ0CuPSRMOzJG8rMs2K1g5xl4t qcrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7uafs0jiKUh7lUwZ0AA5KAIpK1U6UC7U/ESXulHGeeE=; b=NSp/R1khHvXCTMCURDl8knDnMXAqRdJjtRFeTOvQHOqGvIzyIgaEf9zhOE2yA6ghmN Xo6fIODpFfqJhScUkdSuMmo2PWhTCKJAcZjUKpAth0PvrsTCvYYztQfUH4XuvTDS8/oo 4KzytvGPJgsApAhiqirGH9FIZvOmZIyYC+bUvdM7dt+Fgq8yARLl0cRFd4RIYkaASmig cfmiSX97aSee1qX91LtepBFwukXwshrCeibDT3xHzsA4c5in8OyKAar6JnKhw5z1R0o9 ii1ILKif1hnpp5DWbWa7bXhC+O7qE2/kk/4hFVvq4k9H7Z0pdgEMFg1+nlb1LZQNoPE3 ME8A== X-Gm-Message-State: AOUpUlFXrZY6fUYEXyq1+YPFZR1d7+W8oZgBf/K9NfvgNd8VpM0MpqGv 5bwVj3Kpk/oMvifAc9fZ1Rc= X-Google-Smtp-Source: AAOMgpeM8oPALGjAEHEHZoTGQZiCqa56MPAT3IOzLG49IXtl9hWY8np3p+YyvhaSTJ5Db2y1OGgPXQ== X-Received: by 2002:a1c:b157:: with SMTP id a84-v6mr3856952wmf.18.1532200261143; Sat, 21 Jul 2018 12:11:01 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.11.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:11:00 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , Jeffrey Lin , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/11] touchscreen: raydium_ts: Use octal permissions Date: Sun, 22 Jul 2018 00:39:49 +0530 Message-Id: <20180721191029.25658-8-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(fw_version, S_IRUGO, raydium_i2c_fw_ver_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(hw_version, S_IRUGO, raydium_i2c_hw_ver_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(boot_mode, S_IRUGO, raydium_i2c_boot_mode_show, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, raydium_i2c_update_fw_store); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(calibrate, S_IWUSR, NULL, raydium_i2c_calibrate_store); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/raydium_i2c_ts.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c index d1c09e6a2cb6..eddbb51e55dd 100644 --- a/drivers/input/touchscreen/raydium_i2c_ts.c +++ b/drivers/input/touchscreen/raydium_i2c_ts.c @@ -934,9 +934,9 @@ static ssize_t raydium_i2c_calibrate_store(struct device *dev, return error ?: count; } -static DEVICE_ATTR(fw_version, S_IRUGO, raydium_i2c_fw_ver_show, NULL); -static DEVICE_ATTR(hw_version, S_IRUGO, raydium_i2c_hw_ver_show, NULL); -static DEVICE_ATTR(boot_mode, S_IRUGO, raydium_i2c_boot_mode_show, NULL); +static DEVICE_ATTR(fw_version, 0444, raydium_i2c_fw_ver_show, NULL); +static DEVICE_ATTR(hw_version, 0444, raydium_i2c_hw_ver_show, NULL); +static DEVICE_ATTR(boot_mode, 0444, raydium_i2c_boot_mode_show, NULL); static DEVICE_ATTR(update_fw, S_IWUSR, NULL, raydium_i2c_update_fw_store); static DEVICE_ATTR(calibrate, S_IWUSR, NULL, raydium_i2c_calibrate_store); From patchwork Sat Jul 21 19:09:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10538981 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A2763A679 for ; Sun, 22 Jul 2018 00:57:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8743B2893D for ; Sat, 21 Jul 2018 19:11:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7AD872894E; Sat, 21 Jul 2018 19:11:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 29DDE2893D for ; Sat, 21 Jul 2018 19:11:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728830AbeGUUEz (ORCPT ); Sat, 21 Jul 2018 16:04:55 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35490 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEy (ORCPT ); Sat, 21 Jul 2018 16:04:54 -0400 Received: by mail-wm0-f65.google.com with SMTP id o18-v6so1273590wmc.0; Sat, 21 Jul 2018 12:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4VpnKFelclX0L+FoN8Y1vffLYVvjqWXQc+YzeGv9LVc=; b=bqUporAVlBxRBSYi7r6TtsnQcAJaU+njB+W4uuonkT/jYOd7GpfbkHlaJ963DI0E3I km7ikReXskT753OYZym+k4cSO4DnI1WUdxC4IqtfJ0QL7Vrl8cipixdLwk6XflVacRWH 07SEciW6r0U92neWi2hURVv1RvhH2Q2TQlFrOWPHXf95Kirtn3ooPGjaS3+yT4UsGoXp G4Tye+GfHJpoSaLvgo7tUI1lgkwoO8v5AxXpZXNr7EIRCh8AVuCvY0TyxhBMjjd+Xh6x B9HFy4ErcIWfqX3dG/hXQ+mfRBj6dMXyRe2b74HZv8EgYtUVD8/Y1p1Yj2sMPAZxLqZY 5RfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4VpnKFelclX0L+FoN8Y1vffLYVvjqWXQc+YzeGv9LVc=; b=l+gKFkhU9pntavUROLaPI6XsThYoHgF4EsfOw+1OpD391mn35dkqkCEyjfuS3bpwTs /c7w4yZz6MH76Y5VavK6/Murap+J8peNCGsxS78radsavsIABzviZRpAVQc6I0mOgJSR fzD6+FTKBMOTFYfqeKoKv62f/M6K/kpLSymnTs9J6G5sQRUjqv+65GcpRS2muLlFZMKu 292USSdhJO2PmSLWigU3RmTYUBxVJoQvPyF1DOzBTEG+BtCtQKthr9NDjYykJA0p4giI ghfZlYEHv/0DMJDsubim7YrpWEgm9fBA6eKu0DByoAD6AUP9nnk2lN+unWBZaCVSWv+4 PD2A== X-Gm-Message-State: AOUpUlGHrxzYiJp+sH2OgEZ/nnFfk6kCeytZrLtS3jH9BXJ6vU4hPMOY ckiCuLuNsqtHGIoan2fo3js= X-Google-Smtp-Source: AAOMgpcKepa9pi3fg+XalEmzifS8bsj6vATyGspVsuY8HkoNhS0hAnFY39aU65MfpBzXR1HOLCmK1g== X-Received: by 2002:a1c:b84e:: with SMTP id i75-v6mr3872309wmf.158.1532200266631; Sat, 21 Jul 2018 12:11:06 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.11.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:11:06 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Maxime Ripard , Chen-Yu Tsai , Andi Shyti , Simon Budig , Luca Ceresoli , Julia Lawall , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/11] touchscreen: sun4i_ts: Use octal permissions Date: Sun, 22 Jul 2018 00:39:50 +0530 Message-Id: <20180721191029.25658-9-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/sun4i-ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c index d2e14d9e5975..78960961a524 100644 --- a/drivers/input/touchscreen/sun4i-ts.c +++ b/drivers/input/touchscreen/sun4i-ts.c @@ -230,8 +230,8 @@ static ssize_t show_temp_label(struct device *dev, return sprintf(buf, "SoC temperature\n"); } -static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL); -static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL); +static DEVICE_ATTR(temp1_input, 0444, show_temp, NULL); +static DEVICE_ATTR(temp1_label, 0444, show_temp_label, NULL); static struct attribute *sun4i_ts_attrs[] = { &dev_attr_temp1_input.attr, From patchwork Sat Jul 21 19:09:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539095 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0651EA6F2 for ; Sun, 22 Jul 2018 00:57:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B18E2892E for ; Sat, 21 Jul 2018 19:11:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4EDE928942; Sat, 21 Jul 2018 19:11:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 068502892E for ; Sat, 21 Jul 2018 19:11:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728156AbeGUUE6 (ORCPT ); Sat, 21 Jul 2018 16:04:58 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44626 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUE6 (ORCPT ); Sat, 21 Jul 2018 16:04:58 -0400 Received: by mail-wr1-f68.google.com with SMTP id r16-v6so14098598wrt.11; Sat, 21 Jul 2018 12:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Sl+s3hBPqjopTCQADLj9mbVwdM7xh5MKSKS3p+FB1sA=; b=OhaFkeimJHC4ZvLwwvGGCdCBNDvXcp9Keiz7eEdCjBMZK0RKh6i08ArTd2xKZRU6hu ug9HWRmtx1xP1WG8W077k23Oe4cwq0Gs87LlsyEN9WZUL0eMw9Mc5u1jWt4qfKI/vzNG FUsAgFGTGXcQFnKaB9CZH+e/8K/A8POecw4lwgpxUWQaey31NlF1dWjHjZphk8DfMUrI 9heanN/dtRDUvYzJWvRTHSYI89SNYIAvHaEm/bSDp9vB9Xgwt987QZebn++js/xjzzPg FCy07wwUrgkbDt9qwhSaPMSNCBPtl+ylwHbQL2jJhRWbdIkUJQPJupuYo7r+0+QBkWN2 q7ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Sl+s3hBPqjopTCQADLj9mbVwdM7xh5MKSKS3p+FB1sA=; b=RPb0dxMmH1K0iLM4nXcBVuvTkUqmrBONSz3s6j7LPSrx+Yh8DUDUeOjEiZ2S+ZcWL0 BZKnwsxKotFVU72ghNLPeFf3UkuDOilHYdCAsWXpX72k5u1jxVW/XtTXZCEMrBFhlSbU X66pP9P94O+mFr15l/4FQiokk/z07mlt7rjjAzbWWzqhEWR+FROsIkyDSnbUfV4XHtom jcmCQtaRHi+Ei0NHCXRZNlugl9ZPSat9vjcusZBaHPkida3lWUw8hIaKsbHfeAcgj2Ok fHJ0ilrMa45hf1GAKiy8uwXQ21+OX5U5LofsF1VBefUoPR4qR/LAuLJiEKOIorz5w8DE z4nw== X-Gm-Message-State: AOUpUlFZR2V9HhUDYnkT3m1UxUOBrpFhESbdEq8RlY2l5ROWhCOVI8hK mIpi4oI7izNc5QBPKxMe2xtGFBOvvBZlnOYU8vk= X-Google-Smtp-Source: AAOMgpfOeRulexFGxICcwu3ebWns7McUxLPF7Jpk6oRk7y539kmGInbLIJwb4jutOAnC6YFpCRHnYw== X-Received: by 2002:a5d:480d:: with SMTP id l13-v6mr4808524wrq.234.1532200271016; Sat, 21 Jul 2018 12:11:11 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.11.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:11:10 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , Martin Kepplinger , Kees Cook , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] touchscreen: tsc200x: Use octal permissions Date: Sun, 22 Jul 2018 00:39:51 +0530 Message-Id: <20180721191029.25658-10-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(selftest, S_IRUGO, tsc200x_selftest_show, NULL); Signed-off-by: dev-harsh1998 Acked-by: Martin Kepplinger --- drivers/input/touchscreen/tsc200x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/tsc200x-core.c b/drivers/input/touchscreen/tsc200x-core.c index e0fde590df8e..daefeca101ff 100644 --- a/drivers/input/touchscreen/tsc200x-core.c +++ b/drivers/input/touchscreen/tsc200x-core.c @@ -336,7 +336,7 @@ static ssize_t tsc200x_selftest_show(struct device *dev, return sprintf(buf, "%d\n", success); } -static DEVICE_ATTR(selftest, S_IRUGO, tsc200x_selftest_show, NULL); +static DEVICE_ATTR(selftest, 0444, tsc200x_selftest_show, NULL); static struct attribute *tsc200x_attrs[] = { &dev_attr_selftest.attr,