From patchwork Thu Jun 13 11:42:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10991609 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2EA89924 for ; Thu, 13 Jun 2019 11:42:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19B6C28B73 for ; Thu, 13 Jun 2019 11:42:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0DD2228B80; Thu, 13 Jun 2019 11:42:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BCE7328B73 for ; Thu, 13 Jun 2019 11:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6PsIggNNW/VYWSPjFOP/htSLVkEBLwEQS0e2gIHqaXU=; b=SsjabNAuFRJfwP ntvVorcfSyEXzr+vcAvz3/+3kCYjtnBYphwo6jbxJckueXIanA7355RuSPEyxdcdXCXCHHZy+ND2o dKbi8IknwhKOrMm22ISHITMQX9Wgi3VI+Jlw0W7qMwrc01GS55sMC7Qay5I6FBWGSNLHco+fQZ1jC JIjPM7YMpuUoqG/aEF3AMJRi7J0R4B2UjoE+qGPA+w9QNOVwaOYYnPsTOpF/sZal82CnEbT8bSNEj lrGYScjm3W3k6ZN34gPTdcppfh60/nQwL5TW/m76/WLCMKndQs0DW0BrOcR0wacqdiFaBiHP2rTWs SgAhoodRUIQTuRF9xZ3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbO7z-0008WU-6a; Thu, 13 Jun 2019 11:42:47 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbO7t-0008Ta-J8 for linux-amlogic@lists.infradead.org; Thu, 13 Jun 2019 11:42:42 +0000 Received: by mail-wm1-x344.google.com with SMTP id z23so9764259wma.4 for ; Thu, 13 Jun 2019 04:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ct4dk4GNCZZpVBLlWG9IpyH3sVkXJaOUvUrsuvrJN7k=; b=t8gsBpvVYiQYc5Cn+QwlQpiY7tEcHBk2PiEx7Mm99YPiqUHhaR1qhC0wYPkrGD4SHH AeMv6d+++LORjfxG0hocO0hAVvVWjfgFXU7DUebAhDowZP5pxIZyokfKWuCJzU8ptVhs QTgFlBriQSaGZrLhOrDLhAUzOUWa2IZ20zuUZUL7kLXsMMqv8CincQItL92lCi5QYDLp yO8rK8tCPUVh0fCCcPIWZsvG5XWSoviGFdcRgDhPtSwdgQT738Uv3cgVBbCBZVsW2SCz ENsPDyh/zm4wAkf0I4yvwFPYHgBcqLTLWSYk/hhtUFHz1WUfsbUpGdYYMdpUXFx89UY4 6JIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ct4dk4GNCZZpVBLlWG9IpyH3sVkXJaOUvUrsuvrJN7k=; b=eJWSs5Lm9ISiYdZyaSoirKwScMePk66UIXcsZG+Zv9gYTEMocTPWw8NJo2vC892MJx iyKDzRltC+VK4lqQpMrsJgGrLPpE+Oiarhh+n9Z+uFqblHhg0v92E4UoDYbBfR2fX15n KX7XuL+fcfBHULrXDK2jI+7VKOmdQwglRF4FjV5NpcphY+qN2zoiotsz/z3IZK+E4+oF c0LEhYPm/RgcIkRorNhPCmJnhvpeIctYYrDGGdS4WUah6AgvVpWd856ZZjd3aDJytRzr iEe0WK+P9SoSKxgi61ykm5TFx5SUgwOwyyLDr4unLXnGeHiT77mXVLdh4xg0/zxjhcKK EnIA== X-Gm-Message-State: APjAAAWZoAXy9fF2g4+9M4NE7rEqKiFqn7X979Gf4J1ZVB/+IqVqfe1w yDolXaOD4iu0KXNFej9F7subjg== X-Google-Smtp-Source: APXvYqwqh3apCFq8wjX/n7GQ82ee2GciU3Q+2n5x2zCfXMbElFvgw/Kli69Hg3m7WsELb0p2+ZsBpA== X-Received: by 2002:a05:600c:254b:: with SMTP id e11mr3135082wma.171.1560426159921; Thu, 13 Jun 2019 04:42:39 -0700 (PDT) Received: from boomer.local (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id b5sm2598490wru.69.2019.06.13.04.42.39 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 04:42:39 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood , Kevin Hilman Subject: [PATCH 1/4] ASoC: meson: axg-tdmin: right_j is not supported Date: Thu, 13 Jun 2019 13:42:30 +0200 Message-Id: <20190613114233.21130-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613114233.21130-1-jbrunet@baylibre.com> References: <20190613114233.21130-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_044241_628123_A0529F86 X-CRM114-Status: UNSURE ( 7.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Right justified format is actually not supported by the amlogic tdm input decoder. Fixes: 13a22e6a98f8 ("ASoC: meson: add tdm input driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdmin.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/meson/axg-tdmin.c b/sound/soc/meson/axg-tdmin.c index a790f925a4ef..cb87f17f3e95 100644 --- a/sound/soc/meson/axg-tdmin.c +++ b/sound/soc/meson/axg-tdmin.c @@ -121,7 +121,6 @@ static int axg_tdmin_prepare(struct regmap *map, break; case SND_SOC_DAIFMT_LEFT_J: - case SND_SOC_DAIFMT_RIGHT_J: case SND_SOC_DAIFMT_DSP_B: break; From patchwork Thu Jun 13 11:42:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10991611 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4057014BB for ; Thu, 13 Jun 2019 11:42:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2BF3B28B73 for ; Thu, 13 Jun 2019 11:42:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2079928B80; Thu, 13 Jun 2019 11:42:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C966A28B73 for ; Thu, 13 Jun 2019 11:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S/FQKT2W9EzHY3wrw+KBofOfmFgoeXcIsW1qLuBzo3c=; b=Zhv0PnsPZ5u2AO jNj+QH/SZRmuKtTTB65sXzUTOpvilg1szZH+o+9T6vKMgT7qinRNbRuVccARLyeXlVP3jwbXa9YLb FKE2tE+dIW2MhTmcv3+hh1HA8w85YeN8j1Uzodyv1K2hNwvoblYegscA18msBqLrqCQ2FlVkxgvi1 nMwjUN3H0Ui/80CaggXBBQbtiExvwAI6YtXGlbCWvnSH8UUm4GUXw9GTT4E4mDDd9bHiMoO+GEK7G k3t68ElnLD/4uyYZzLyIuQVOCCxOqH16cMQED2KZ5rpDCnmTMzNawxdT0ZacIjt23yOvYKqVefTzx blPUAils4U4mq/hcMeHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbO81-00006u-FI; Thu, 13 Jun 2019 11:42:49 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbO7u-0008Tt-Pa for linux-amlogic@lists.infradead.org; Thu, 13 Jun 2019 11:42:44 +0000 Received: by mail-wm1-x342.google.com with SMTP id v19so9760735wmj.5 for ; Thu, 13 Jun 2019 04:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wxfr2UqrJP7k7q7uBFspyYkIYB+P3tVp1PAw4xsHiNQ=; b=aIGGQGLj/J0XH6peWf/aEST4UK1CqwMrpUkQjobNWMtvBILe/l8TNhNg5Gzc41WnWL F4hhER2TzHu8OTkgAHyLHRi0LjDuY1KEpg2IqFxv/igN0L1QST+UPKkVOO+GzkHAd7sn e1cBnlrPNcVUOmgYhgm4ADGOlRHXukuC1YbQPIpd5si/3/GpQxqW8/lzKwooILMTP1gg Snh1Fa/jMuc54U8S27WXRam9qRpA8iIkVHWWGd00/2fyhA/4yJRJZ6wH7dcwSbw3b/PW QWEv9MpalZosI8UghJPlwZeX5KAmerfAuTq5rFurUSeyS/aRtX2aztvMj6zTHq/9r25V q4nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wxfr2UqrJP7k7q7uBFspyYkIYB+P3tVp1PAw4xsHiNQ=; b=QPplrZktErWbFP5pPaNRqVxMXms50UmyqcYPDA7qi3d7Em1Ma9ovQoWlwPwhZjAXeJ JtHYIh1c9AK2m3z+j/DClm/cHVPUqM37D7WJHkd4rZUqOZ9rEw+ewyIVEdcKoG5nECoX jaNT7uknmdPLX1c6zQtmqd/8mA845TAbGPCBQUUMo9wRHlzCKY8Zx4jljvbTaVxK5Rxb Dx0nr7/L12DtUoM+YeOLymem2oWQW31MwswHNELkv+3M9sGHLTFz0nEtkjBxmymKu4FK L3T2Iib18PQzRS07jcE2Py+x/0s/FoRwZslMRkncFzBVfoYnPqGefP6sZoQK5GKYGrpV H9ZQ== X-Gm-Message-State: APjAAAUF6CRoCQbUMxxT8b8qBNtkaUgh/KHWFUrnKvrVChZodC7yCRZ2 ltKoIWxZ6EvTpsyDw4hxtst+qA== X-Google-Smtp-Source: APXvYqw3l8gXPruJhWBk60j/WsaoYnaNmb1Oiya7p9axR4/l3hNwB1waenTIOkkffv+68dM5m29SWw== X-Received: by 2002:a1c:4956:: with SMTP id w83mr3327094wma.67.1560426161191; Thu, 13 Jun 2019 04:42:41 -0700 (PDT) Received: from boomer.local (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id b5sm2598490wru.69.2019.06.13.04.42.39 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 04:42:40 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood , Kevin Hilman Subject: [PATCH 2/4] ASoC: meson: axg-tdmout: right_j is not supported Date: Thu, 13 Jun 2019 13:42:31 +0200 Message-Id: <20190613114233.21130-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613114233.21130-1-jbrunet@baylibre.com> References: <20190613114233.21130-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_044242_921944_32B425E2 X-CRM114-Status: UNSURE ( 7.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Right justified format is actually not supported by the amlogic tdm output encoder. Fixes: c41c2a355b86 ("ASoC: meson: add tdm output driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdmout.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/meson/axg-tdmout.c b/sound/soc/meson/axg-tdmout.c index 527bfc4487e0..86537fc0ecb5 100644 --- a/sound/soc/meson/axg-tdmout.c +++ b/sound/soc/meson/axg-tdmout.c @@ -137,7 +137,6 @@ static int axg_tdmout_prepare(struct regmap *map, break; case SND_SOC_DAIFMT_LEFT_J: - case SND_SOC_DAIFMT_RIGHT_J: case SND_SOC_DAIFMT_DSP_B: skew += 1; break; From patchwork Thu Jun 13 11:42:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10991613 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DC92014BB for ; Thu, 13 Jun 2019 11:42:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C9DF928B73 for ; Thu, 13 Jun 2019 11:42:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE55B28B83; Thu, 13 Jun 2019 11:42:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 73FA728B73 for ; Thu, 13 Jun 2019 11:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eBVo1Nt3J+WE2xpPORWZqqWmI/hN0EclKILpNGM2dY8=; b=hcJMSmipsv+sxa LcDEUG1P5ETNDNa2a64I/xqG6707xPIQk4plHKz0Pq4ze/Fw3QS/fo1B9PL+bjmEF15DcUXRHnSry JNKPkPw2iqBc/FUBXwFCPK16z6nkvnbpNWipr1zJ7JhVvwu+FQ0MVvgRdjF4VkRhJmYNSwvHaw6tl 3g2JwzcnXw6kRrOR/OHMUH3g4LyNmGGenOeopouYoY/SwnuT7zcNgrf3tfOu/HGUAKMgBYzzX/dq/ 7741HY9YiuvV6f4dxUHhaAZpeDfXZVToY83PAhfPE4ePCBVw8xIdIUDZsBiJtZCy1qxce80antxtK fXjwpyN1lFFKY84EpZGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbO83-00008V-0V; Thu, 13 Jun 2019 11:42:51 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbO7v-0008Tz-M6 for linux-amlogic@lists.infradead.org; Thu, 13 Jun 2019 11:42:44 +0000 Received: by mail-wr1-x443.google.com with SMTP id x4so17758844wrt.6 for ; Thu, 13 Jun 2019 04:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TExrEtVR1Qp+m2eA960X7wRJwZP76vaDnZqCemHrZMo=; b=ARq6OKiJiNJ8rcawe7B7CKa+kO25GegV4OLzlT2aC16bZB7ZbGOeh4KfbetAfkiOk3 YmtzX9XOJh2s/leNI5KQNSwKtxxkdQjzpdv8KAotEvXsQ7oqgwqaUX6IhwnhwJULiEzw HQINex/o0ZH99njmn2fOFSgGPlL6gLGHjJxPe1kpQMtpPZAoo0d79nsOVRjthp0VlL/6 exoH2sc5NANWn1mm4wVjEwCcQknz0R7B57hFUlVQDaYC8nALkbz73efD7CqPRVL9NhQ1 XRALVm86xKQJFghDjinxQgkadLhBSdqqAw2EQXBtQw/hKgK7S1lvbkzlqzbIo6KxT59B aS9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TExrEtVR1Qp+m2eA960X7wRJwZP76vaDnZqCemHrZMo=; b=YuDy9kIX2yU+C0fI+tx+M12ie4z9OjeylDxpKo9AXlIVRnPLgaJlKjEtLbKkMxC1sy y6kYsX95G57bdOLYsFsRxP/RDbJ+enZySMSLPsRJ3u6gS0h5uuymHg2xGC5LCe1EDxiB kRrPmUEG+nCj7Jp8Ue8RL19xK3HGbCAYqgqcHGjmqfXsoyeaLdsohuQp+vRMg7GRCUOR Ijdbs4OAZv291JMD3H9KOzw6HeghWhKOaGpCwLaMnsjgVDg+zSy5E2Vx8HOim0tXTkEl OTxsVtDJogWhAltrN/01KP2Echlxd/iolgxqc8cOR2DwP6/UslHq7FtHL5GW2v9wAdI0 GqYA== X-Gm-Message-State: APjAAAX+OzwPHTk3frQpNMwXKCcML0bXQF/6ylZcSblyzQk065wmaeCH 0egaHes248kBwF7UsfWa4wttFQ== X-Google-Smtp-Source: APXvYqz/BTbpTahJKuFfHLaXnGe/ye7zKjSH9AReM7p3t9Gmxi21Yj4MpRdaVoBmNQqviV7TOcVAMQ== X-Received: by 2002:adf:eb09:: with SMTP id s9mr57922277wrn.127.1560426162128; Thu, 13 Jun 2019 04:42:42 -0700 (PDT) Received: from boomer.local (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id b5sm2598490wru.69.2019.06.13.04.42.41 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 04:42:41 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood , Kevin Hilman Subject: [PATCH 3/4] ASoC: meson: axg-tdm: fix sample clock inversion Date: Thu, 13 Jun 2019 13:42:32 +0200 Message-Id: <20190613114233.21130-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613114233.21130-1-jbrunet@baylibre.com> References: <20190613114233.21130-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_044243_720791_4946ADB3 X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The content of SND_SOC_DAIFMT_FORMAT_MASK is a number, not a bitfield, so the test to check if the format is i2s is wrong. Because of this the clock setting may be wrong. For example, the sample clock gets inverted in DSP B mode, when it should not. Fix the lrclk invert helper function Fixes: 1a11d88f499c ("ASoC: meson: add tdm formatter base driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/meson/axg-tdm.h b/sound/soc/meson/axg-tdm.h index e578b6f40a07..5774ce0916d4 100644 --- a/sound/soc/meson/axg-tdm.h +++ b/sound/soc/meson/axg-tdm.h @@ -40,7 +40,7 @@ struct axg_tdm_iface { static inline bool axg_tdm_lrclk_invert(unsigned int fmt) { - return (fmt & SND_SOC_DAIFMT_I2S) ^ + return ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) == SND_SOC_DAIFMT_I2S) ^ !!(fmt & (SND_SOC_DAIFMT_IB_IF | SND_SOC_DAIFMT_NB_IF)); } From patchwork Thu Jun 13 11:42:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10991615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DF0EB924 for ; Thu, 13 Jun 2019 11:42:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB25128B73 for ; Thu, 13 Jun 2019 11:42:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BFAD928B80; Thu, 13 Jun 2019 11:42:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7B20428B7F for ; Thu, 13 Jun 2019 11:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q9+KJJlO/qhAxYaDZjFW2luhCinASQcLqiXNyrmH95A=; b=DiDsdiqEkLyG/F 0Lvhll+/cgzm0ZqcerWTCsv9nNPM8Scw7yQ/OXx4KSv+7gnPvy+ireK6KPxAGgf4FTMExgiuLXMyB ziN4qN04ibyBJqqhkPRaGQCjJwKclwgeK6JxYy1AT6z92P7DCPFyJUVojqPB0CQFr2a3hj+ZFcfnC K/hVruIphji5qHd8NIcMXFwfIXS81XB1OkCy6cf0H9q2yuIXHVfcHpE8xBH9XOwop+k2C8YjpFw3H r2VKrDeXyj8vD7l0qjWDGj/zUHmFYSYhwwMp1vpoYdX1Y1bqPcvM8B4RFgLbIA5F4Fj2rMTPqLhX3 usGjSqxhx5zwnOYkXxDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbO85-0000Ag-0A; Thu, 13 Jun 2019 11:42:53 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbO7w-0008UN-7r for linux-amlogic@lists.infradead.org; Thu, 13 Jun 2019 11:42:45 +0000 Received: by mail-wm1-x344.google.com with SMTP id 207so1973493wma.1 for ; Thu, 13 Jun 2019 04:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Tw+9nr0k/SQ4+6C+T7NQWdtgxVemIU5O6qgx24DY8vo=; b=Ok5DOoG/v42T5p/NULeH/QnUtOj3y3bgwt/tHoF5P/QfLizFjo2FteTJhShh/SJZlr Nmlqr3KRJRhMsWo6pVvAXVbul1OayENODZ5gcGgO5C7JDGHK9U+PzWdA/jg93WjfgrBX 3aPLgeJJNFVLG2B/rgjiiSmhS+VPDiaQJtZu9Yj5qNZsnJJwZOWKrk3hKiDrwVwOJa46 DJ8yGbCY355E06ytD2Ad5rB+zWuOJWxU5VFLulOd9U0WSoao+makMDcH1cw103nSXVwm WvwvNjZS5YfcP6dgfELXmWKxdmNFba7TWuBCTXVwsvhillQ7D9Jrl3egEbQtgmyPgiVH 5Z9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Tw+9nr0k/SQ4+6C+T7NQWdtgxVemIU5O6qgx24DY8vo=; b=Bgfpa/Cu+USMLYCYV61hX18VcYE4zDmVLALl19DjwX+qnXQxKZqKgHEmV/UvP37z3f TTtnZ0dcDDUSILxT54RqmXIPdkCGsEJaIAHF7jhvhn395IJ3Uu9MDx1KqENBYK48cDWW W+N1+rmipzztRnW8otbteqsseNpW4S3AK0GYT7D9T07ydzo5uAwPDDb7sEK0ZwhbsmQO 4NhOMuPYRq6pFB00njIEtg8OMz4lFLrSJd/cDTugVB5t26tP2pShRPcebJ7Xoxf6U5WS w3f326/Cv7xm4TfOeZzknyQonsbTXuAAZ0oUWCLqxp3nQAQXySlCJ3/GAU16S2W6jTh0 xrtA== X-Gm-Message-State: APjAAAUCHbFGNZERd9eEm0w32jd2uSj9XtziBbD1cWNlPRFo12Y63PMp WSPC+KdqK3k7eM8+5e7pdBT8BA== X-Google-Smtp-Source: APXvYqzEpIcfbKY9VmOQOlh4gHR44pyPiRNjVhiHDFIUMTdcrq2NBX4iOv+SXfr3SjTejuF07/m1hA== X-Received: by 2002:a1c:9cd1:: with SMTP id f200mr3280189wme.157.1560426163056; Thu, 13 Jun 2019 04:42:43 -0700 (PDT) Received: from boomer.local (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id b5sm2598490wru.69.2019.06.13.04.42.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 04:42:42 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood , Kevin Hilman Subject: [PATCH 4/4] ASoC: meson: axg-tdm: consistently use SND_SOC_DAIFMT defines Date: Thu, 13 Jun 2019 13:42:33 +0200 Message-Id: <20190613114233.21130-5-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613114233.21130-1-jbrunet@baylibre.com> References: <20190613114233.21130-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_044244_276205_03ED6E4B X-CRM114-Status: UNSURE ( 8.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP There a mix of SND_SOC_DAIFMT_ and SND_SOC_DAI_FORMAT_ in axg-tdm-interface.c. Even, if this is currently the same thing, lets use the same group consistently. Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdm-interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/meson/axg-tdm-interface.c b/sound/soc/meson/axg-tdm-interface.c index 585ce030b79b..d51f3344be7c 100644 --- a/sound/soc/meson/axg-tdm-interface.c +++ b/sound/soc/meson/axg-tdm-interface.c @@ -306,8 +306,8 @@ static int axg_tdm_iface_hw_params(struct snd_pcm_substream *substream, } break; - case SND_SOC_DAI_FORMAT_DSP_A: - case SND_SOC_DAI_FORMAT_DSP_B: + case SND_SOC_DAIFMT_DSP_A: + case SND_SOC_DAIFMT_DSP_B: break; default: