From patchwork Fri Jun 28 09:50:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivasharan Srikanteshwara X-Patchwork-Id: 11021871 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 32AC11708 for ; Fri, 28 Jun 2019 09:51:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2125428800 for ; Fri, 28 Jun 2019 09:51:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 12A6C28763; Fri, 28 Jun 2019 09:51:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFFE128763 for ; Fri, 28 Jun 2019 09:51:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbfF1JvY (ORCPT ); Fri, 28 Jun 2019 05:51:24 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:43821 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726431AbfF1JvY (ORCPT ); Fri, 28 Jun 2019 05:51:24 -0400 Received: by mail-pl1-f195.google.com with SMTP id cl9so2945100plb.10 for ; Fri, 28 Jun 2019 02:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iEe+w5Cw7Mj27LFlss4tg4ixW0DJ3Q671c2PpFiw87E=; b=ThVFYzzaZ+9mY8v6q9AHzWfSogfzdl3H2gVvL5gtP+LkAyoe+h4EbmhAHg0K99fN7r Qj7LecniTPlO387P9wT5J7BgeqeD38AnVOJIillUrA2M5ytHPEIx3jAz3eqCbtLzYyij xtM68aKJ10113zo8/VYEj5aypr5O7aQzvX/fE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iEe+w5Cw7Mj27LFlss4tg4ixW0DJ3Q671c2PpFiw87E=; b=YErQUXvwYlSgHzOT3Nfw8rNlwD5aHg6dfT0uEJR+vwISr20+OyrKMQdq1EUkMRz/FR 8FM93vAy2IMEdA0z7TinDRqn3pKl0zmfEKwEWdvdBfUuXnva9tfjlw75Su4syyIrcXmG k3GeQ6hTjAIMDOeLRDq1NTIsaggNj5wNSJ6HOEQ3h7sWZz4fp30OJzoJZAxztQ3DUdoR jNAhkv78JXDSmHkJAnsIzEhwYLjs6yuE8FplE2RzpzKAwx19Yg4qzBPXjK4xjQCb+i2J kk7mQ8Xt2F8wThksnu2+Wd/vVZ9uKzHNHgrLRzGsNF/9Uunu2XL4cuVNirugiP86ObQv RW8Q== X-Gm-Message-State: APjAAAXPX/pCBF26J7VS2U8UkZ8SpoS3mAbFT5kO19S1V1BeyKIA/Z+K 3lkKL1XV7Pqm3O8Iavj3tJz7xLkKuW4eqqGWCbnNHvMs7FQuZHxB3Dlex5pftH7WVegczXQIJNR XGDPzdFuro2dcVfLnUmUwyuHbc1YxBht0s4nfTMaqoILCvNjmrS9/XqZyEJhT9JzEpk6aPern7L GyA+3NbCf0i/MOGy3KxZl7cGo= X-Google-Smtp-Source: APXvYqzjfeHUp4huZALan4bLaIp6YLtROFU0RAXH9kWOEQDTDnn/EpzvhQkkxUGxJ9CLC6hARN+vNQ== X-Received: by 2002:a17:902:2ae8:: with SMTP id j95mr9613213plb.276.1561715482920; Fri, 28 Jun 2019 02:51:22 -0700 (PDT) Received: from dhcp-135-24-192-142.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id q19sm2096975pfc.62.2019.06.28.02.51.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2019 02:51:22 -0700 (PDT) From: Shivasharan S To: linux-scsi@vger.kernel.org, martin.petersen@oracle.com Cc: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, kiran-kumar.kasturi@broadcom.com, sankar.patra@broadcom.com, sasikumar.pc@broadcom.com, chandrakanth.patil@broadcom.com, Shivasharan S Subject: [PATCH 2/4] megaraid_sas: Enable msix_load_balance for Invader and later controllers Date: Fri, 28 Jun 2019 02:50:39 -0700 Message-Id: <1561715441-1428-3-git-send-email-shivasharan.srikanteshwara@broadcom.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1561715441-1428-1-git-send-email-shivasharan.srikanteshwara@broadcom.com> References: <1561715441-1428-1-git-send-email-shivasharan.srikanteshwara@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Load balancing IO completions across all available MSI-X vectors should be enabled for Invader and later generation controllers only. This needs to be disabled for older controllers. Add an adapter type check before setting msix_load_balance flag. Fixes: 1d15d9098ad1 ("scsi: megaraid_sas: Load balance completions across all MSI-X") Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 9321878..96b6510 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -5945,7 +5945,8 @@ static int megasas_init_fw(struct megasas_instance *instance) instance->is_rdpq = (scratch_pad_1 & MR_RDPQ_MODE_OFFSET) ? 1 : 0; - if (!instance->msix_combined) { + if (instance->adapter_type >= INVADER_SERIES && + !instance->msix_combined) { instance->msix_load_balance = true; instance->smp_affinity_enable = false; } From patchwork Fri Jun 28 09:50:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivasharan Srikanteshwara X-Patchwork-Id: 11021873 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3FA3676 for ; Fri, 28 Jun 2019 09:51:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FC7D28723 for ; Fri, 28 Jun 2019 09:51:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 240F5283C5; Fri, 28 Jun 2019 09:51:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1200287A5 for ; Fri, 28 Jun 2019 09:51:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726653AbfF1Jv1 (ORCPT ); Fri, 28 Jun 2019 05:51:27 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:42409 "EHLO mail-pl1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726431AbfF1Jv1 (ORCPT ); Fri, 28 Jun 2019 05:51:27 -0400 Received: by mail-pl1-f181.google.com with SMTP id ay6so2935507plb.9 for ; Fri, 28 Jun 2019 02:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=T/mZXL8M+UQCk9oP+hzmcx6Ryi1tWi6WEqvKWBJb9TQ=; b=ecp+RSC2BEW7epG+um3Ks/X0QAp/1nBfRX7tf7zDbLkJ3faxxYhAUxlBNEDCLxsedd G1l0AKOf1jCAfqrBFcSEfpID/ped8KPDXw/EBomWVY2YRyg3Fkn9gDam3IUoZOuUTN3E DY1Xjzo/J/7lrdB0eknyxapnpORQuGQibAyqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=T/mZXL8M+UQCk9oP+hzmcx6Ryi1tWi6WEqvKWBJb9TQ=; b=hLvSQeW2gjiQdvng5aOX/XJq4/w85m564pF/nqqigOTnlUY4+rxyJpjWvZX4qi26fM n9q/gdCNYd7HjQfNqvbUbfmqxceOsCuM0SwM6nk63dH4YGzogSC/k5xh91PoIR6i0y7s gFONB4bxKolHlQvIbfV6eX2vn9bTcrMrEf23oY9FO4tHAv6Dddm/800e+uvcYSy6pLE0 A7UCsAq4+SivLD9D4E8y1QVrvVwR8kBsvYkLNjgn4gHKaXaTlBDF/l2xkXzhOfmukiwH Wmg5kvcXxy4xcV9GQUSWyhu1QcKhafxe4amq72dMvvWckCEX8yobDBCA1OvClhJLTSm0 8jew== X-Gm-Message-State: APjAAAVHNM3gDSm0nkSD99MkwnOqtkwXV3Az9tza0qORws0Gx5AAFl1R P2KHqkvl09yRrtX7ZAyc7dk7iQrFa9Lx8qxeV1LiLzLiFL2jbtrcZ4taJb5QsOMlmolZEvrGnw5 sD8Q9SE79OcOGNDQUcb7+jFn7+E3IYSOVyXKTR2TncRPSPzPJx+guxtPjsqoOveA7HmdU4AaLQ6 iQIItw0GCCxRSPyuoQTueRo0o= X-Google-Smtp-Source: APXvYqy13i6zSOjSEhqXY2qBuZTHa3hTIyoeiEvNVtOts9Lr3exJYsx/LV1GTsTN/V5XohYTIXUC0Q== X-Received: by 2002:a17:902:9a49:: with SMTP id x9mr10557171plv.282.1561715486209; Fri, 28 Jun 2019 02:51:26 -0700 (PDT) Received: from dhcp-135-24-192-142.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id q19sm2096975pfc.62.2019.06.28.02.51.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2019 02:51:25 -0700 (PDT) From: Shivasharan S To: linux-scsi@vger.kernel.org, martin.petersen@oracle.com Cc: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, kiran-kumar.kasturi@broadcom.com, sankar.patra@broadcom.com, sasikumar.pc@broadcom.com, chandrakanth.patil@broadcom.com, Shivasharan S Subject: [PATCH 3/4] megaraid_sas: Add module parameter for FW Async event logging Date: Fri, 28 Jun 2019 02:50:40 -0700 Message-Id: <1561715441-1428-4-git-send-email-shivasharan.srikanteshwara@broadcom.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1561715441-1428-1-git-send-email-shivasharan.srikanteshwara@broadcom.com> References: <1561715441-1428-1-git-send-email-shivasharan.srikanteshwara@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add module parameter to control logging levels of async event notifications from firmware that get logged to system log. Also, allow changing the value from sysfs after driver load. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_base.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 96b6510..4b3f2f80 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -117,6 +117,10 @@ MODULE_PARM_DESC(perf_mode, "Performance mode (only for Aero adapters), options: "default mode is 'balanced'" ); +int event_log_level = MFI_EVT_CLASS_CRITICAL; +module_param(event_log_level, int, 0644); +MODULE_PARM_DESC(event_log_level, "Asynchronous event logging level- range is: -2(CLASS_DEBUG) to 4(CLASS_DEAD), Default: 2(CLASS_CRITICAL)"); + MODULE_LICENSE("GPL"); MODULE_VERSION(MEGASAS_VERSION); MODULE_AUTHOR("megaraidlinux.pdl@broadcom.com"); @@ -416,7 +420,13 @@ megasas_decode_evt(struct megasas_instance *instance) union megasas_evt_class_locale class_locale; class_locale.word = le32_to_cpu(evt_detail->cl.word); - if (class_locale.members.class >= MFI_EVT_CLASS_CRITICAL) + if ((event_log_level < MFI_EVT_CLASS_DEBUG) || + (event_log_level > MFI_EVT_CLASS_DEAD)) { + printk(KERN_WARNING "megaraid_sas: provided event log level is out of range, setting it to default 2(CLASS_CRITICAL), permissible range is: -2 to 4\n"); + event_log_level = MFI_EVT_CLASS_CRITICAL; + } + + if (class_locale.members.class >= event_log_level) dev_info(&instance->pdev->dev, "%d (%s/0x%04x/%s) - %s\n", le32_to_cpu(evt_detail->seq_num), format_timestamp(le32_to_cpu(evt_detail->time_stamp)), @@ -8762,6 +8772,12 @@ static int __init megasas_init(void) goto err_pcidrv; } + if ((event_log_level < MFI_EVT_CLASS_DEBUG) || + (event_log_level > MFI_EVT_CLASS_DEAD)) { + printk(KERN_WARNING "megarid_sas: provided event log level is out of range, setting it to default 2(CLASS_CRITICAL), permissible range is: -2 to 4\n"); + event_log_level = MFI_EVT_CLASS_CRITICAL; + } + rval = driver_create_file(&megasas_pci_driver.driver, &driver_attr_version); if (rval) From patchwork Fri Jun 28 09:50:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivasharan Srikanteshwara X-Patchwork-Id: 11021875 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E370613B4 for ; Fri, 28 Jun 2019 09:51:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D36C5283B2 for ; Fri, 28 Jun 2019 09:51:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C751F28802; Fri, 28 Jun 2019 09:51:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 823DF283C5 for ; Fri, 28 Jun 2019 09:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726672AbfF1Jvb (ORCPT ); Fri, 28 Jun 2019 05:51:31 -0400 Received: from mail-pf1-f175.google.com ([209.85.210.175]:44013 "EHLO mail-pf1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726431AbfF1Jvb (ORCPT ); Fri, 28 Jun 2019 05:51:31 -0400 Received: by mail-pf1-f175.google.com with SMTP id i189so2698020pfg.10 for ; Fri, 28 Jun 2019 02:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GX5CPy6rqO1lv6QwD/x6+Dzmm0AV8dmr3hh1Og/9uF4=; b=ftz5C0HxkkD93oi3LiZOMMWnIVYCb5evcOyptvqG94Uc/BngQof7R25LeAzoIO8EKx O05WYgbZunidoq8z2p27moR2OuJEffIwknK/b68XsRee+d7+Z0zyuqX2kkzUxfG1mtzk 5uzBfSbr3AeheJm5baLdcqm7R7SUOOYh3wz1Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GX5CPy6rqO1lv6QwD/x6+Dzmm0AV8dmr3hh1Og/9uF4=; b=CIqYTNHE0u195OOiFBVR046N5lNIet3VmqOoSVGIjULnPZmBAPkR360kZPVlJN4iSa /gRCL5rFZLEIJt1zZ6cnZ/6QwW4hS3kHLS0Tf8R5vnWTIMBPR/iQEkLFKa2uGAlbptbm MCazUnhvKAByjRgHQemhgLpOWhzVCo5aDIV4fBHRcXDTPIufIMzmtRUVKB8KO4bWGnBT 87FiM1ei/4pl+PwtIoAL236BTLra+pLr7Q6Vyntm8JBuiTmZvKZtFXZJ2quPS+g10IQ1 eDKbivLoLuXZm9+x364gLl30qRehKQPpHXNdUpzEz7Rjl9tS3T427PBm4frr7AhyZCcp Yong== X-Gm-Message-State: APjAAAWyt2ufGoF7UfooBPqN6X07KR/YHxZ73t6FLy7xZZBzKpGnVlqI oZyGOWd2GYFEjRFQp8+mrVRNc+z2fT6jiB6eQSc/QaUPVZjHq7nKVxNbbzPMTfEjKRIUZ6VdA8b nBSp7ALm6PZvpJ+HOzACYC6hv2G1gSCfy693+Qf8NJak1Uud+v+Boj5FP4JajcAHf9r5ehRahXE 2f+sGTnWP/0AW/QcDOJa0hiCg= X-Google-Smtp-Source: APXvYqxZB25yaEmqUjcIsReJ1buvvIBTKfxNyasc6Ai78llSenfP85wzcUSNDaZIZimEREy8+m8KSg== X-Received: by 2002:a65:5c88:: with SMTP id a8mr8233232pgt.388.1561715489505; Fri, 28 Jun 2019 02:51:29 -0700 (PDT) Received: from dhcp-135-24-192-142.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id q19sm2096975pfc.62.2019.06.28.02.51.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2019 02:51:28 -0700 (PDT) From: Shivasharan S To: linux-scsi@vger.kernel.org, martin.petersen@oracle.com Cc: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, kiran-kumar.kasturi@broadcom.com, sankar.patra@broadcom.com, sasikumar.pc@broadcom.com, chandrakanth.patil@broadcom.com, Shivasharan S Subject: [PATCH 4/4] megaraid_sas: Update driver version to 07.710.50.00 Date: Fri, 28 Jun 2019 02:50:41 -0700 Message-Id: <1561715441-1428-5-git-send-email-shivasharan.srikanteshwara@broadcom.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1561715441-1428-1-git-send-email-shivasharan.srikanteshwara@broadcom.com> References: <1561715441-1428-1-git-send-email-shivasharan.srikanteshwara@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index dc0f71f..a6037db 100644 --- a/drivers/scsi/megaraid/megaraid_sas.h +++ b/drivers/scsi/megaraid/megaraid_sas.h @@ -33,8 +33,8 @@ /* * MegaRAID SAS Driver meta data */ -#define MEGASAS_VERSION "07.710.06.00-rc1" -#define MEGASAS_RELDATE "June 18, 2019" +#define MEGASAS_VERSION "07.710.50.00-rc1" +#define MEGASAS_RELDATE "June 28, 2019" /* * Device IDs