From patchwork Fri Jul 5 15:11:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 11034679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6B3C4138D for ; Mon, 8 Jul 2019 07:13:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A5D228385 for ; Mon, 8 Jul 2019 07:13:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4F0D328397; Mon, 8 Jul 2019 07:13:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 177E228385 for ; Mon, 8 Jul 2019 07:13:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD08E89B66; Mon, 8 Jul 2019 07:12:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20E3C6E4E6 for ; Fri, 5 Jul 2019 15:12:09 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id h28so2221068lfj.5 for ; Fri, 05 Jul 2019 08:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+UJP5d8d4R7j2ybp/z262FGakRH0zeassz+JZDSgOkc=; b=evA9TWGVarx0GC79lhpgfmi1n9HVKYCaQ07QmWNmUGlTkWxhA/pvxroI4GOdsC6unj uhjTuuDRwovlIuvumTwe6tdJ0KGnZ/kWPNnMKzQ+y3toVvqL62hd6+viwYjCjNofGnKa 25bvjHUSaPvW26kkaQs8GIiWCZiuAnkywgaUB+AIhHO3XvwgilFTRrkzssE1ldWE36fU K0mmOjTdWez7K53t9c2v5e81CC7AorArDPNeB8VYVfObCnPWb8CADUzPt7ef6TIdH1YZ NEOryBPyQNN0/FEEmiJ4KaiPw8wbcRNOUGS91/U3UyUctdyRv7nu/fhhijW95UYo0Gdb tXTw== X-Gm-Message-State: APjAAAUbTZz1eGFBVavyJHZrX6lkEotz0nn7DXRmuw1dDQhWXVti46YF se9WxFe3Uw+p8yqxRfKQoII= X-Google-Smtp-Source: APXvYqzz63aFUveYFlYoX/IDK56bwneXg5+8snrrvQOzJrfb+MCKJiREOCmTeOHOkD+rM81Dlf/heg== X-Received: by 2002:a19:7110:: with SMTP id m16mr2270647lfc.4.1562339527654; Fri, 05 Jul 2019 08:12:07 -0700 (PDT) Received: from localhost.localdomain (ppp79-139-233-208.pppoe.spdop.ru. [79.139.233.208]) by smtp.gmail.com with ESMTPSA id r17sm1851253ljb.77.2019.07.05.08.12.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 08:12:07 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter Subject: [PATCH v1] drm/tegra: Fix gpiod_get_from_of_node() regression Date: Fri, 5 Jul 2019 18:11:39 +0300 Message-Id: <20190705151139.19032-1-digetx@gmail.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 08 Jul 2019 07:11:53 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+UJP5d8d4R7j2ybp/z262FGakRH0zeassz+JZDSgOkc=; b=hbUbsiXNaQz36B81KUhBjhvIUIfzHd8SYh1zWb7ZPNb2g/Hi9y3Bo/STNk2vlm7M/Z aPk4HnZReVoh3mUTjzWMPES5BJoQETWYE0PsO+59zkZ4WIZT5rT+ULo7fKCNZEdjMXXP BRLbv+7I6xhwAWYUIAw0qwvV9wV9rRBbyO+GjKtXbiBeVQHzkdQBgbnQ+IwPorCFCuTB SPRYph/EJX6rhbHDxLPmNnF/BpRasHhCDZBmRvPGNTldaygtPDv/Q/7gefmzkviKyH+8 +Qo3knHieQex0gZ1TuxMY3uq/Rre0HiiM+m8dtgi/no7bQjt/61IUO/0oTMcC19J7k9a 38sg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP That function now returns ERR_PTR instead of NULL if "hpd-gpio" is not present in device-tree. The offending patch missed to adapt the Tegra's DRM driver for the API change. Fixes: 025bf37725f1 ("gpio: Fix return value mismatch of function gpiod_get_from_of_node()") Signed-off-by: Dmitry Osipenko Acked-by: Jon Hunter --- drivers/gpu/drm/tegra/output.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index 274cb955e2e1..471d33809cd4 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c @@ -126,8 +126,12 @@ int tegra_output_probe(struct tegra_output *output) "nvidia,hpd-gpio", 0, GPIOD_IN, "HDMI hotplug detect"); - if (IS_ERR(output->hpd_gpio)) - return PTR_ERR(output->hpd_gpio); + if (IS_ERR(output->hpd_gpio)) { + if (PTR_ERR(output->hpd_gpio) == -ENOENT) + output->hpd_gpio = NULL; + else + return PTR_ERR(output->hpd_gpio); + } if (output->hpd_gpio) { err = gpiod_to_irq(output->hpd_gpio);