From patchwork Thu Jul 18 02:06:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yue Haibing X-Patchwork-Id: 11048429 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F4132746 for ; Thu, 18 Jul 2019 02:07:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF73B1FF82 for ; Thu, 18 Jul 2019 02:07:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D360B22AFC; Thu, 18 Jul 2019 02:07:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7B4AE1FF82 for ; Thu, 18 Jul 2019 02:07:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727851AbfGRCH0 (ORCPT ); Wed, 17 Jul 2019 22:07:26 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2676 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727541AbfGRCH0 (ORCPT ); Wed, 17 Jul 2019 22:07:26 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 615E2D74EC604C7DB965; Thu, 18 Jul 2019 10:07:24 +0800 (CST) Received: from localhost (10.133.213.239) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Thu, 18 Jul 2019 10:07:18 +0800 From: YueHaibing To: , , , , , CC: , , YueHaibing Subject: [PATCH] Input: applespi: Fix build error without CONFIG_PCI Date: Thu, 18 Jul 2019 10:06:54 +0800 Message-ID: <20190718020654.39860-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If CONFIG_KEYBOARD_APPLESPI is set to y, but CONFIG_PCI is not set, building will fails: drivers/spi/spi-pxa2xx-pci.c: In function pxa2xx_spi_pci_probe: drivers/spi/spi-pxa2xx-pci.c:208:8: error: implicit declaration of function pcim_enable_device; did you mean pci_enable_device? [-Werror=implicit-function-declaration] ret = pcim_enable_device(dev); ^~~~~~~~~~~~~~~~~~ pci_enable_device drivers/spi/spi-pxa2xx-pci.c:239:8: error: implicit declaration of function pci_alloc_irq_vectors; did you mean pci_alloc_consistent? [-Werror=implicit-function-declaration] ret = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_ALL_TYPES); ^~~~~~~~~~~~~~~~~~~~~ Make CONFIG_KEYBOARD_APPLESPI depends on CONFIG_PCI to fix this. Reported-by: Hulk Robot Fixes: b426ac045209 ("Input: add Apple SPI keyboard and trackpad driver") Signed-off-by: YueHaibing Acked-by: Randy Dunlap # build-tested --- drivers/input/keyboard/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index dd934c4..fefcc46 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -74,7 +74,7 @@ config ATARI_KBD_CORE config KEYBOARD_APPLESPI tristate "Apple SPI keyboard and trackpad" depends on ACPI && EFI - depends on SPI + depends on SPI && PCI depends on X86 || COMPILE_TEST imply SPI_PXA2XX imply SPI_PXA2XX_PCI