From patchwork Mon Jul 22 17:40:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 11053199 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D99D213AC for ; Mon, 22 Jul 2019 17:40:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5372285AF for ; Mon, 22 Jul 2019 17:40:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B657F285C8; Mon, 22 Jul 2019 17:40:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 63291285AF for ; Mon, 22 Jul 2019 17:40:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8384789D66; Mon, 22 Jul 2019 17:40:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0099089D66 for ; Mon, 22 Jul 2019 17:40:45 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id u25so25788159wmc.4 for ; Mon, 22 Jul 2019 10:40:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6WLXf/VCXC4rlq9YhY4PmzJ42e/EBWSBPmZlwxVdmWQ=; b=O6zWc+qtpfK3HmYe41czfRjZwy2r8hIKE79IIn1sh+S+RWK2f1nTsJ5Kv2+n0ywWJF tq+l4CcSYuhKVatnVQit3axAZbWPxFhNcEAmH0PmEntCnXre8q5uBQoi6qLUjgTKQTCV prLHo6N83WKnNquiQ37P2jZmXEKNTVDhaCx5LDkxY/2NJUobyhGRz6ObhR19Ywhybnul aXmhB02hnmxUEaK4ZfcdokQszYx5yOGKwdaBUir+viD/K+b6xHVinBYc2ll57Sjj+ZB5 Xmfrob4oOB8PXskjuD0PXkpUHmQ8V5zMBFFSCXkyrg67n6v6UYsX7JIrBLBMd1eqJhqT EzGA== X-Gm-Message-State: APjAAAU036xD+RC7LzZvQmBiGT+E0jRxMbLRNUyg/zK8zFePgeq+CHsg zwFuP6jrK3bLo587Wso7byvVA7S+ X-Google-Smtp-Source: APXvYqxBUemj0LfPW0SuEbZhAVOevBPBvt4wWKQu9tsovyvWhb9M5FC7amw9aXU4d/PzPA+m8jFJUg== X-Received: by 2002:a7b:c748:: with SMTP id w8mr61458994wmk.36.1563817244249; Mon, 22 Jul 2019 10:40:44 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id b2sm51844663wrp.72.2019.07.22.10.40.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 10:40:43 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/3] drm/vmwgfx: check master authentication in surface_ref ioctls Date: Mon, 22 Jul 2019 18:40:23 +0100 Message-Id: <20190722174025.9830-1-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6WLXf/VCXC4rlq9YhY4PmzJ42e/EBWSBPmZlwxVdmWQ=; b=Q+dES5Pmm2j56Y+dHXJC0nMRCyVvY5BK8u8+qr9pXVgNGJ3jMH/BMsEiSKRTWsymr1 8DBSvIKkHZlah+zjf4eWx/xe+pYrWZPWBZ0AX3lyt2ImciDpFW8pWQ29sRugnvN5BAh/ k/cjYltD3pWJBk9n6/K7wNQk8D+4VUQ7DOpMdS9b6PnZH9P2cthSfq02GBIHi99qWOG9 /Ka9cf41LKbdJ8c/SAP6SZOJl9Xhkb8uCUKG3KUMEsF3Lz6K/Jts1bm3O9Fdrn0DJtDD l4n+Cq6McvMhVcX5bAYDfdFTfOuzQLexXXrvF7G/3W2Fgi7z0aaPNhcj+qZaR8qcRsUO EG6w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: VMware Graphics , Thomas Hellstrom , emil.l.velikov@gmail.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov With later commit we'll rework DRM core authentication handling. Namely unauthenticated master will be allowed with, DRM_AUTH ioctls. Since vmwgfx does additional master locking and DRM_AUTH handling, this will not matter almost all cases. The only exception being using the legacy handle type in the family of surface_reference iocts - all handled by vmw_surface_handle_reference(). Add the check to ensure such clients do not access more than they should Cc: VMware Graphics Cc: Thomas Hellstrom Signed-off-by: Emil Velikov --- I'd like to merge this through the drm-misc tree. Ack and rb are appreciated. Thanks Emil Unrelated: worth moving the is_render_client check alongside the is_primary_client one. --- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c index 219471903bc1..1f5146c95785 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c @@ -940,6 +940,13 @@ vmw_surface_handle_reference(struct vmw_private *dev_priv, user_srf = container_of(base, struct vmw_user_surface, prime.base); + /* Error out if we are unauthenticated master */ + if (drm_is_primary_client(file_priv) && + !file_priv->authenticated) { + ret = -EACCES; + goto out_bad_resource; + } + /* * Make sure the surface creator has the same * authenticating master, or is already registered with us. From patchwork Mon Jul 22 17:40:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 11053201 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9103B13AC for ; Mon, 22 Jul 2019 17:40:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7FF36285C8 for ; Mon, 22 Jul 2019 17:40:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71AE0285CD; Mon, 22 Jul 2019 17:40:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2448F285C8 for ; Mon, 22 Jul 2019 17:40:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4729289D67; Mon, 22 Jul 2019 17:40:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id D357189D66 for ; Mon, 22 Jul 2019 17:40:46 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id r1so40295166wrl.7 for ; Mon, 22 Jul 2019 10:40:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2eEadTDICSV2Qk9KPFsrvesCyzVBF6U7MCfRL010Yfg=; b=jsxK10yYxjwDWHjyAfiengBL4wS/goYq4C017k6W3h2X6fp/DlXGmpiDQp6PJUwxEU z0hnMX+5lLwpe8lwA1GYqdabDERgxCsO+0lTVvo9uD3WB2rQhuyTDiZkQkyNzTwImIEQ qNru45Eae9R37SE3X2jaLDtiEmjxzZMX3e/k2X0iZ7jmkFw/cj2LiXF7ESQckQM95fTV yMUjo57qKeDUUK9gaYEjvV+ZmgeFLfIa2qHMNl9HqPln0nFxknpsrRJUvdcVHz63L5uM 0CdXLBMlhk7HeDEPsRxjmxL6dH0OZOsq2BHtCwZRAS+PTYnrKt/ASzwJdzPADbXjc9gP UwBA== X-Gm-Message-State: APjAAAXJl5lDVubRxS0tVbw+JEIQ2uFBKV+M1sNi2Heu/35VYXe6qbwH r5N472T1H86TKWV0o50ctQQhwYLY X-Google-Smtp-Source: APXvYqzsYe1fiNN5Y+OBY9yE/3oilj5VIwYccdEACEOkoMKiJ/WUtBQxKfofJUuWjIgkbnvRMMqtsQ== X-Received: by 2002:adf:f042:: with SMTP id t2mr75332033wro.139.1563817245275; Mon, 22 Jul 2019 10:40:45 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id b2sm51844663wrp.72.2019.07.22.10.40.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 10:40:44 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/3] drm/vmwgfx: add local DRM_AUTH check for PRIME TO/FROM HANDLE Date: Mon, 22 Jul 2019 18:40:24 +0100 Message-Id: <20190722174025.9830-2-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190722174025.9830-1-emil.l.velikov@gmail.com> References: <20190722174025.9830-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2eEadTDICSV2Qk9KPFsrvesCyzVBF6U7MCfRL010Yfg=; b=r1x46qxMy+B7s22f/bJBQqPHRXfsswbsLgZ4t+dP6XggTg6i8nL07kMhlZ+ranmj2L ut+gvP2eZEUXXETYkojH/qBZaHisMUmIMPcPMsQMMsgs1LpwhGw7RWW7jhcFBwVTQkFZ dt+z7EPUU1C13/u1sdh3zWP1/p9pmr5NM7AZ5Lv20/Pzj76QM1Ohs3MdGuoho/WToGEy W0O39PA5udyYNFVuafDyApoSWb7ICFGSydts62Y7OVR7bV51I/QimAXfWqoVGh63Naus Kzi2aJ9ek2rW806MPgy5ErjDwexKk68HyHZgMxkqBbRudzWQWJzdMkHIjhm5e4hauarN mrvw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: VMware Graphics , Thomas Hellstrom , emil.l.velikov@gmail.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov Realistically no drivers, but vmwgfx care about the DRM_AUTH flag here. Follow-up work in this driver will properly isolate primary clients from different master realms, thus we'll no longer need to parse _any_ ioctl flags. Until that work lands, add a local workaround. Cc: VMware Graphics Cc: Thomas Hellstrom Signed-off-by: Emil Velikov --- I'd like to merge this through the drm-misc tree. Ack and rb are appreciated. Thanks Emil --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 275d90fe2a25..32c18bb482a6 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -1131,6 +1131,15 @@ static long vmw_generic_ioctl(struct file *filp, unsigned int cmd, } else if (!drm_ioctl_flags(nr, &flags)) return -EINVAL; + /* + * Little workaround until the vmwgfx patches providing isolation of + * primary clients from different master realms lands. + * With that work, we'll no longer need to parse _any_ ioctl flags. + */ + if (nr == 0x2d /* DRM_IOCTL_PRIME_HANDLE_TO_FD */ || + nr == 0x2e /* DRM_IOCTL_PRIME_FD_TO_HANDLE */) + flags != DRM_AUTH; + vmaster = vmw_master_check(dev, file_priv, flags); if (IS_ERR(vmaster)) { ret = PTR_ERR(vmaster); From patchwork Mon Jul 22 17:40:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 11053203 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B9F67912 for ; Mon, 22 Jul 2019 17:40:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9331285AF for ; Mon, 22 Jul 2019 17:40:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9D73D285C8; Mon, 22 Jul 2019 17:40:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 39EA3285AF for ; Mon, 22 Jul 2019 17:40:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B241789D73; Mon, 22 Jul 2019 17:40:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0393689D7B; Mon, 22 Jul 2019 17:40:47 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id 31so40344483wrm.1; Mon, 22 Jul 2019 10:40:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P2u3WVZOxoMXROYBMO+U2l2dAHqPfXIiodrmDPuBaoA=; b=oYy8pYNNA5qaGEXt5oCZIAdqr3gX4rwW+bIQ6ZEwGrel2GlK4OzTbP1PvPDDoPkvI+ yyu+XGFUNa+b9qhanBvm+6mXgq1Gcb8ZHeOwXwhUdhmjk/8qeZfJckzCacR8C/GJZIb/ NZwkqQSdbAlYrBkmTrjeEjMF4el9hBSBLgKsT/U0HElusrUK173L9k12uPeflhZRodLS QUBDHCIDyfqFSJNb+gWc87UrZKMlFRymkRdAa/fT+Y09mmm9ac/1vXi3BxUCXrYDDmEo +oh+eI0U2Cp8fN02NugQ4o6rr2nIZg11CTM0dN4gLOFiV7jf6TJimLOoWNbovEj0FUYF CC2g== X-Gm-Message-State: APjAAAU2bOtBM4y6XyJQ6Tj/cy5dVx/NQrix/+Y1flbbvgyYj+YI6NQp r1Pq/ybwBN7AU2o0vUNBPgS+gK+I X-Google-Smtp-Source: APXvYqxSLq/ocfFfhMUu5nqgr0BqkvzKMrs5ZR52W57Xr5BXHVHN9FqUuvXYxiOGauC4rz0tq4f/Xg== X-Received: by 2002:a5d:63c8:: with SMTP id c8mr35001176wrw.21.1563817246400; Mon, 22 Jul 2019 10:40:46 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id b2sm51844663wrp.72.2019.07.22.10.40.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 10:40:45 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 3/3] drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls Date: Mon, 22 Jul 2019 18:40:25 +0100 Message-Id: <20190722174025.9830-3-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190722174025.9830-1-emil.l.velikov@gmail.com> References: <20190722174025.9830-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P2u3WVZOxoMXROYBMO+U2l2dAHqPfXIiodrmDPuBaoA=; b=m21nKWQoaigxHufx4Hivx5CoDlffm/jmEZSRsvfMtxG2Nr1ChMONnuQVPO2zsPZlsa K5ESmEugZyuJjBzYwYDsfdneOILGmQdawcATeSwz7k67U3fiFmU6K3s/s9Hk8GHYCsNs ceQDBm65b475IHLY9YzU6xBi4kV2v+X5FXHMFQPZlX7RqcGjW8b+tRu/GygKyHZGO2qT +XoXiMOolNLATxqKUC5jYTw+VEbneqWssGxGpHQlmYCoEntRjO8ElM4+f0Vh+MyupNd/ AaLJH9YAZyvWKX+Wo98Q2kGkngu32V6wJX5hV3RH2t45KwXK9rROVkxFAdiLdPELbjw1 rKHA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Deucher , emil.l.velikov@gmail.com, =?utf-8?q?Christian_K=C3=B6nig?= , amd-gfx@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov As mentioned by Christian, for drivers which support only primary nodes this changes the returned error from -EACCES into -EOPNOTSUPP/-ENOSYS. For others, this check in particular will be a noop. So let's remove it as suggested by Christian. Cc: Alex Deucher Cc: Christian König Cc: amd-gfx@lists.freedesktop.org Cc: Daniel Vetter Signed-off-by: Emil Velikov --- drivers/gpu/drm/drm_ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 09f7f8e33fa3..a397177af369 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -647,8 +647,8 @@ static const struct drm_ioctl_desc drm_ioctls[] = { DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETRESOURCES, drm_mode_getresources, 0), - DRM_IOCTL_DEF(DRM_IOCTL_PRIME_HANDLE_TO_FD, drm_prime_handle_to_fd_ioctl, DRM_AUTH|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF(DRM_IOCTL_PRIME_FD_TO_HANDLE, drm_prime_fd_to_handle_ioctl, DRM_AUTH|DRM_RENDER_ALLOW), + DRM_IOCTL_DEF(DRM_IOCTL_PRIME_HANDLE_TO_FD, drm_prime_handle_to_fd_ioctl, DRM_RENDER_ALLOW), + DRM_IOCTL_DEF(DRM_IOCTL_PRIME_FD_TO_HANDLE, drm_prime_fd_to_handle_ioctl, DRM_RENDER_ALLOW), DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETPLANERESOURCES, drm_mode_getplane_res, 0), DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETCRTC, drm_mode_getcrtc, 0),