From patchwork Mon Jul 22 18:24:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 11053259 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6FA6E13AC for ; Mon, 22 Jul 2019 18:25:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6263C2821F for ; Mon, 22 Jul 2019 18:25:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 567612845C; Mon, 22 Jul 2019 18:25:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 065802821F for ; Mon, 22 Jul 2019 18:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731757AbfGVSZF (ORCPT ); Mon, 22 Jul 2019 14:25:05 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:42526 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731812AbfGVSZF (ORCPT ); Mon, 22 Jul 2019 14:25:05 -0400 Received: by mail-pl1-f194.google.com with SMTP id ay6so19553533plb.9 for ; Mon, 22 Jul 2019 11:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gkGn8pX+SnGbncQZILWgKTNC3yYNo8zAMY1G6oxP7Bk=; b=kODRaWBKJXyuIRTX369dvcz8KsHsvOXWSPRckcRa6ktNtHmxUsikmQlXEMgVRiPoeq x7NoYUYH8Oo67zCDzUZ7wEDv9Hzk/Sk5FxtB3AcougBOrP4zw/IuxrqGJXNSUKywLpqf SqCtChZV6KHIRQ+rM0myXRa1+dwp1B6eBHx64= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gkGn8pX+SnGbncQZILWgKTNC3yYNo8zAMY1G6oxP7Bk=; b=TqlHXJJYgfxz5XKP3qSeruESFhDAbdCRvsAE9Z2k3r+b4surM6ZMxWUiR0Hs5szqq8 rz43Yl1Ahu0KvmjRQcbnJJcVI0T+ZhwRatDjuC5ZbhEL88NxESaJPyHoK1g+WLQOKbLj 1kFdRuwEjAkrur7HADI+isGMD9OOqKcPTJoN3vMRWT4nSJe5Lic3muW3YmwC+AHhMGWJ FKPAMmQrnaVPqOCMOZFAUGAFypSv2V9OqzW9GfxyPEpYQ+EJJU1n5uRM1SS37r637LzX 6a8cfXJq+AOIm8cDv7ZYZG2ZLgvmBT0dQ+xBoK34SALXwPbUE61bfU00Mkv98aDn3ZXr YKMQ== X-Gm-Message-State: APjAAAWSDD74x/bV/qAmpEG0qbwc6xL4YEg+o+smBHWVLTfyvmVS/5lK qYmFNxvjbB1qapJj1h/j0D6R7Q== X-Google-Smtp-Source: APXvYqwt8O0L83AANnlACuiSZO0y3AW9dmuUUC7ooEfiwSxSjS1wz+BGd5M4s1GjUn44c68TKPzdkg== X-Received: by 2002:a17:902:9688:: with SMTP id n8mr75084152plp.227.1563819904526; Mon, 22 Jul 2019 11:25:04 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id a3sm36117683pfl.145.2019.07.22.11.25.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 11:25:04 -0700 (PDT) From: Douglas Anderson To: Bartlomiej Zolnierkiewicz , Thierry Reding , Sam Ravnborg Cc: David Airlie , linux-fbdev@vger.kernel.org, Philipp Zabel , Tomi Valkeinen , dri-devel@lists.freedesktop.org, Laurent Pinchart , Russell King , Daniel Vetter , Douglas Anderson , linux-kernel@vger.kernel.org Subject: [PATCH 1/4] video: of: display_timing: Add of_node_put() in of_get_display_timing() Date: Mon, 22 Jul 2019 11:24:36 -0700 Message-Id: <20190722182439.44844-2-dianders@chromium.org> X-Mailer: git-send-email 2.22.0.657.g960e92d24f-goog In-Reply-To: <20190722182439.44844-1-dianders@chromium.org> References: <20190722182439.44844-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From code inspection it can be seen that of_get_display_timing() is lacking an of_node_put(). Add it. Fixes: ffa3fd21de8a ("videomode: implement public of_get_display_timing()") Signed-off-by: Douglas Anderson Reviewed-by: Laurent Pinchart --- drivers/video/of_display_timing.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index f5c1c469c0af..5eedae0799f0 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -119,6 +119,7 @@ int of_get_display_timing(const struct device_node *np, const char *name, struct display_timing *dt) { struct device_node *timing_np; + int ret; if (!np) return -EINVAL; @@ -129,7 +130,11 @@ int of_get_display_timing(const struct device_node *np, const char *name, return -ENOENT; } - return of_parse_display_timing(timing_np, dt); + ret = of_parse_display_timing(timing_np, dt); + + of_node_put(timing_np); + + return ret; } EXPORT_SYMBOL_GPL(of_get_display_timing); From patchwork Mon Jul 22 18:24:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 11053257 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E0F1713AC for ; Mon, 22 Jul 2019 18:25:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D23C42821F for ; Mon, 22 Jul 2019 18:25:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C693A2845C; Mon, 22 Jul 2019 18:25:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5B9428434 for ; Mon, 22 Jul 2019 18:25:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731963AbfGVSZH (ORCPT ); Mon, 22 Jul 2019 14:25:07 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37862 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731905AbfGVSZG (ORCPT ); Mon, 22 Jul 2019 14:25:06 -0400 Received: by mail-pf1-f193.google.com with SMTP id 19so17774386pfa.4 for ; Mon, 22 Jul 2019 11:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=phxXam+NzCk41fkXQIfIPhu7NO3JuGp0Zqj7GYLvO5g=; b=VORIvKvZyl9su9iT0PV3CqryHSefcsep6woCoAACriNyyj1wpAq19jNBW1BYF5IpQo US79nuEXwDfYRquImLevsgou9blTecCzbQdIRW8MvRGuCKdw8QN2iYCtNEWGFwhJ26xY CNEJ+PxvFxXS8ph5Wzk31pOD2MWnCapWoZQok= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=phxXam+NzCk41fkXQIfIPhu7NO3JuGp0Zqj7GYLvO5g=; b=EyrYzZi7+1chfjhlqueaqPlADO4k12H4b9aR0ZIONyLGit7dWpal0uhoRepEjhefdu UjNJFhEfsJHGat4JLtvBP/n6T1MPpznh2qd/8WRxSsqWwUoXWjYvx1aFna8/gmZHDb52 pfTBl8HpkwdR1tYIeae4Wi6viPP+BRUkjbQGEev8ytYZoncmZ0JJAhc1EuYkZsssSceP sqkh0g4mA9uiCQABxnKQ5amJYHlwPR12sZJikaAiKmVmhixj39FWTTvXWkhP7RTmYTdL HSmzSwIwUsNpq0CMA1e3dnA5vUfYDI6YUgyjwazOMcuKtvf3LlAg42y0hQaDM0hSPsC0 EcQA== X-Gm-Message-State: APjAAAXoz5KRReWJpeV3t5a/nKKM/8z2x71yRTdVqEmfpkE+yC3PQsLd aGaF/E2sFm9JCZYobtLbwKMwTQ== X-Google-Smtp-Source: APXvYqxIok6j9SpyTOOUPPOSMw74gGma9eXYYBqZ20kYDDJq6S+wqATyE6oe5vdgxNJaBlFiNXuY1g== X-Received: by 2002:a62:1883:: with SMTP id 125mr1535738pfy.178.1563819905974; Mon, 22 Jul 2019 11:25:05 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id a3sm36117683pfl.145.2019.07.22.11.25.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 11:25:05 -0700 (PDT) From: Douglas Anderson To: Bartlomiej Zolnierkiewicz , Thierry Reding , Sam Ravnborg Cc: David Airlie , linux-fbdev@vger.kernel.org, Philipp Zabel , Tomi Valkeinen , dri-devel@lists.freedesktop.org, Laurent Pinchart , Russell King , Daniel Vetter , Douglas Anderson , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] video: of: display_timing: Don't yell if no timing node is present Date: Mon, 22 Jul 2019 11:24:37 -0700 Message-Id: <20190722182439.44844-3-dianders@chromium.org> X-Mailer: git-send-email 2.22.0.657.g960e92d24f-goog In-Reply-To: <20190722182439.44844-1-dianders@chromium.org> References: <20190722182439.44844-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There may be cases (like in panel-simple.c) where we have a sane fallback if no timings are specified in the device tree. Let's get rid of the unconditional pr_err(). We can add error messages in individual drivers if it makes sense. NOTE: we'll still print errors if the node is present but there are problems parsing the timings. Fixes: b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical timing") Reported-by: Sam Ravnborg Signed-off-by: Douglas Anderson --- drivers/video/of_display_timing.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index 5eedae0799f0..abc9ada798ee 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -125,10 +125,8 @@ int of_get_display_timing(const struct device_node *np, const char *name, return -EINVAL; timing_np = of_get_child_by_name(np, name); - if (!timing_np) { - pr_err("%pOF: could not find node '%s'\n", np, name); + if (!timing_np) return -ENOENT; - } ret = of_parse_display_timing(timing_np, dt); From patchwork Mon Jul 22 18:24:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 11053253 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B208713AC for ; Mon, 22 Jul 2019 18:25:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A50A32845C for ; Mon, 22 Jul 2019 18:25:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 995E928434; Mon, 22 Jul 2019 18:25:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4826C2845C for ; Mon, 22 Jul 2019 18:25:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731880AbfGVSZK (ORCPT ); Mon, 22 Jul 2019 14:25:10 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:38480 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731943AbfGVSZH (ORCPT ); Mon, 22 Jul 2019 14:25:07 -0400 Received: by mail-pf1-f194.google.com with SMTP id y15so17777643pfn.5 for ; Mon, 22 Jul 2019 11:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qfwsnuJ0Fo+yki7MwdfIhdjj83zSVUakcOxDUEqYWuw=; b=BMAJB7zCPWaxxlsIZhliKtF/Of3RCfBU19X2PdSfplILj6yScV53dJKd9GpZMW00sX 21AvgBuU29a+7Tczy51BqeRf390trbirmAtQOeTwHaDaAgO71WXOqgW9qVG4I/0QwhsF fHbjC8EReFF044ivDo+ipVHhRsr2EV6EnYpNY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qfwsnuJ0Fo+yki7MwdfIhdjj83zSVUakcOxDUEqYWuw=; b=laTT5AEYi2zzpK4lxr15AXcC0Z5ZRXb/zQhC5CZPVTCPhPl1w7MDIKyg8GdTYYhz4X dKMAr+yDIj3Zve+n0g4fKjUPcqdh0Bkby/WVbuRmTexUL9bLJmUNSx4ISj1r+jBOmfMv RpKcxrTtQ/l8kyYweYZVmaudbpVUFrj5gCYPtrDmQyppedEGbDoDXnqR9bPlfrsDTPtv zG29SUzrl8dHLfaQP+9jTvfptvjcHC/5dYum8q/RF2FH9FcaS9nZk6o8M7kmCfNwW78J pF3/slETJSm/bERtmNI9Ck2X+HO9m1N61j3515ATnlyoM5N8DgBp4TCKOELvlnCYhTQI MLig== X-Gm-Message-State: APjAAAUMN6CMWbr7f6OReNRCTWunbHgASZ/WPJmvaSO/X9Av4r9HHqOq WoidaS0R/ZN6o8x3M0KSbYpGgg== X-Google-Smtp-Source: APXvYqyEp+PIjudMUc2kzpn+Zl2EC+eIJeevs//E8DRu5CFrWzPYRAgF8677H9fM7Q0RWCkvTACSQA== X-Received: by 2002:a17:90a:23ce:: with SMTP id g72mr47354809pje.77.1563819906950; Mon, 22 Jul 2019 11:25:06 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id a3sm36117683pfl.145.2019.07.22.11.25.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 11:25:06 -0700 (PDT) From: Douglas Anderson To: Bartlomiej Zolnierkiewicz , Thierry Reding , Sam Ravnborg Cc: David Airlie , linux-fbdev@vger.kernel.org, Philipp Zabel , Tomi Valkeinen , dri-devel@lists.freedesktop.org, Laurent Pinchart , Russell King , Daniel Vetter , Douglas Anderson , linux-kernel@vger.kernel.org Subject: [PATCH 3/4] drm: panel-lvds: Spout an error if of_get_display_timing() gives an error Date: Mon, 22 Jul 2019 11:24:38 -0700 Message-Id: <20190722182439.44844-4-dianders@chromium.org> X-Mailer: git-send-email 2.22.0.657.g960e92d24f-goog In-Reply-To: <20190722182439.44844-1-dianders@chromium.org> References: <20190722182439.44844-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In the patch ("video: of: display_timing: Don't yell if no timing node is present") we'll stop spouting an error directly in of_get_display_timing() if no node is present. Presumably panel-lvds should take charge of spouting its own error now. NOTE: we'll print two errors if the node was present but there were problems parsing the timing node (one in of_parse_display_timing() and this new one). Since this is a fatal error for the driver's probe (and presumably someone will be debugging), this should be OK. Signed-off-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-lvds.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index 1ec57d0806a8..ad47cc95459e 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -147,8 +147,11 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) int ret; ret = of_get_display_timing(np, "panel-timing", &timing); - if (ret < 0) + if (ret < 0) { + dev_err(lvds->dev, "%pOF: problems parsing panel-timing (%d)\n", + np, ret); return ret; + } videomode_from_timing(&timing, &lvds->video_mode); From patchwork Mon Jul 22 18:24:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 11053247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 70F8513AC for ; Mon, 22 Jul 2019 18:25:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 133922845C for ; Mon, 22 Jul 2019 18:25:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06258284AF; Mon, 22 Jul 2019 18:25:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8C6382845C for ; Mon, 22 Jul 2019 18:25:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731995AbfGVSZJ (ORCPT ); Mon, 22 Jul 2019 14:25:09 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37866 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731813AbfGVSZI (ORCPT ); Mon, 22 Jul 2019 14:25:08 -0400 Received: by mail-pf1-f193.google.com with SMTP id 19so17774446pfa.4 for ; Mon, 22 Jul 2019 11:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6lPTFkPAyVmuitAa4mWi4F3NQrNbt8SbSytM3vpn0a4=; b=HbRHDvfM0apfHIujyRj3077zDqjerxdCRfAZo6YgD6vz6Zsc15GjN+7nPgKerlEBLN 4yAfZGf9Wq/qgGh8pvCNUq3+QtBcnC3ykrSvr7kATX6tqP81wL1yoSc8P/qF2fL4tWaR hi05VT7unfKPLXhDchw25LWu4Cufs7dF1a/eM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6lPTFkPAyVmuitAa4mWi4F3NQrNbt8SbSytM3vpn0a4=; b=QHDgLh0MDMcB1gzQSGjI3TNMGThYgP22F9gkZyQXIK+xU7RmALVjYiNM0YzZ/7wuvq LGGhI4j4zUcYDyKk2YClEdU6hHJAxEakuHFu2AwwI6mF43USOUr7SnrntLx7+ltHFjhc N13xlQtDX5q411XrHzDjTU8y3avc3+zyd+bEx1auFQsG2gMYDsGqBW3HSqTEr3nUghNX 10A0JyLCEVC7GYAE5zVJq5AmiNaWklodetIgLrhH3HzA6WQYBc4DlnJUn1sDkMEXa7ti qDggdcpJ2vX4O5JWWByWyuXplVfPVOQEHlu/OvtwhUGl2st/4zq2BJQQJMTSqzEDLWvk p42Q== X-Gm-Message-State: APjAAAX+g0CpxFxldV7bVMdgVM3Cv1nZ99OHtzCzfcCgHxY+RTQBagjI OZTNYatjuuP0QbqhE0Z5y3E+vw== X-Google-Smtp-Source: APXvYqwI+vy0ViASrIf3xCLwt0/dbuCnHEOUXK68q+q6D/Uk77Ehyv/s9HJa76vJ9R6YVsvovtfFjg== X-Received: by 2002:a63:5a4b:: with SMTP id k11mr13577531pgm.143.1563819907864; Mon, 22 Jul 2019 11:25:07 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id a3sm36117683pfl.145.2019.07.22.11.25.07 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 11:25:07 -0700 (PDT) From: Douglas Anderson To: Bartlomiej Zolnierkiewicz , Thierry Reding , Sam Ravnborg Cc: David Airlie , linux-fbdev@vger.kernel.org, Philipp Zabel , Tomi Valkeinen , dri-devel@lists.freedesktop.org, Laurent Pinchart , Russell King , Daniel Vetter , Douglas Anderson , Linus Walleij , linux-kernel@vger.kernel.org Subject: [PATCH 4/4] video: amba-clcd: Spout an error if of_get_display_timing() gives an error Date: Mon, 22 Jul 2019 11:24:39 -0700 Message-Id: <20190722182439.44844-5-dianders@chromium.org> X-Mailer: git-send-email 2.22.0.657.g960e92d24f-goog In-Reply-To: <20190722182439.44844-1-dianders@chromium.org> References: <20190722182439.44844-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In the patch ("video: of: display_timing: Don't yell if no timing node is present") we'll stop spouting an error directly in of_get_display_timing() if no node is present. Presumably amba-clcd should take charge of spouting its own error now. NOTE: we'll print two errors if the node was present but there were problems parsing the timing node (one in of_parse_display_timing() and this new one). Since this is a fatal error for the driver's probe (and presumably someone will be debugging), this should be OK. Signed-off-by: Douglas Anderson Acked-by: Linus Walleij --- drivers/video/fbdev/amba-clcd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c index 89324e42a033..7de43be6ef2c 100644 --- a/drivers/video/fbdev/amba-clcd.c +++ b/drivers/video/fbdev/amba-clcd.c @@ -561,8 +561,10 @@ static int clcdfb_of_get_dpi_panel_mode(struct device_node *node, struct videomode video; err = of_get_display_timing(node, "panel-timing", &timing); - if (err) + if (err) { + pr_err("%pOF: problems parsing panel-timing (%d)\n", node, err); return err; + } videomode_from_timing(&timing, &video);