From patchwork Fri Aug 9 03:12:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 11085247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C8A214DB for ; Fri, 9 Aug 2019 03:12:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E8C428C1C for ; Fri, 9 Aug 2019 03:12:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0CE3F28C21; Fri, 9 Aug 2019 03:12:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5E30D28C1C for ; Fri, 9 Aug 2019 03:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=9/HQDtr9RgTmkqKZ0SzF4InkYrewcT6dIZ1PQcwxsWc=; b=Ap2bCl5MIXM/gl kkTqgo1X6xJunutExOCSKqb8eBF6MNqm8l9Wt1P1arKwSnHWT97Q0yaEr9JIO9T4a3NBPXkk0NRA3 Z1WqGrbzMWXQca3NgBfOZMaCU5UpvNW59Qt0nMmQ3d6EszuaE074pLYT8jjZTw46yi1DaWa0bz59w n3F5DGnMEf/t+KI3ZqcEsJ6+mcAcfbFnN97tvLCLWol7dtf9XYHe/OsA0vMj7hP6qVZIJ5zIqoAMr 58gkfCNAvv49EXzlShnUtlnNFGk8z4MKBRfF6nSWq0EmXfBqNMcYNLUY02d1s831hhrzfdZuf3UDs P9vHc76pNLjtvXPWTC6w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvvKb-0006zv-S0; Fri, 09 Aug 2019 03:12:41 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvvKX-0006yz-W8 for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2019 03:12:40 +0000 Received: by mail-wr1-f67.google.com with SMTP id b16so124405wrq.9 for ; Thu, 08 Aug 2019 20:12:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EGHNJ41q8Xk+rxqslkgHM8iSCXHrbORbX9tN8p2H7Dg=; b=H2+X/EwchOlwlH4oWoXvtNvt7pcUBQ4nln5x420Pi9G+376yzGY7Vv4sM9d7lq4jn8 //p9peL5NHILvUsQrjWKHxRAkXVA/8QqWCxerQC2BZjot7covvO3MCpcnWE2Fny2V45N 85w6bjPR3rD9ac0PIX2ZerAI4hMr4917cIagXpqSNUtQqnLznSElh8UD9LHTuE/mH/L8 uXyoODW+4ZSYYxjmAQdgJ5NhvUucjeB04JG1IA+1sGAn1Szyu1LKUkdFQ8texJyv5V91 D8tCVbvXN9uUyiolLudtMb/53dWu/iwGkPFQQj3W0BNJtJz5O1JIp8yQsGJvFrJj1Fps 5Tow== X-Gm-Message-State: APjAAAUKMEYoU7QpdJQT9GG8tqGUuFH+VTRcUlR7YTI9Bk/SkN12tQmW fr0vfU0+hSKw8ufOgLbRVX4= X-Google-Smtp-Source: APXvYqyEWcvAnhF4Ue9wN4qIrQ6LTTi30ZSRVlF3B9zoC2iuTwaAv0Ylfl09QVksRxGknvXGG4p0/A== X-Received: by 2002:a5d:46d1:: with SMTP id g17mr7959113wrs.131.1565320353238; Thu, 08 Aug 2019 20:12:33 -0700 (PDT) Received: from tfsielt31850.garage.tyco.com ([79.97.20.138]) by smtp.gmail.com with ESMTPSA id t19sm4798565wmi.29.2019.08.08.20.12.31 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 08 Aug 2019 20:12:32 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: linux-kernel@vger.kernel.org Subject: [PATCH] ARM: dts: imx7d: cl-som-imx7: make ethernet work again Date: Fri, 9 Aug 2019 04:12:27 +0100 Message-Id: <20190809031227.3319-1-git@andred.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_201238_037037_18CE77D9 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Sascha Hauer , Rob Herring , Igor Grinberg , Pengutronix Kernel Team , Shawn Guo , Ilya Ledvich , NXP Linux Team Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Recent changes to the atheros at803x driver caused ethernet to stop working on this board. In particular commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") and commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") fix the AR8031 driver to configure the phy's (RX/TX) delays as per the 'phy-mode' in the device tree. This now prevents ethernet from working on this board. It used to work before those commits, because the AR8031 comes out of reset with RX delay enabled, and the at803x driver didn't touch the delay configuration at all when "rgmii" mode was selected, and because arch/arm/mach-imx/mach-imx7d.c:ar8031_phy_fixup() unconditionally enables TX delay. Since above commits ar8031_phy_fixup() also has no effect anymore, and the end-result is that all delays are disabled in the phy, no ethernet. Update the device tree to restore functionality. Signed-off-by: AndrĂ© Draszik CC: Ilya Ledvich CC: Igor Grinberg CC: Rob Herring CC: Mark Rutland CC: Shawn Guo CC: Sascha Hauer CC: Pengutronix Kernel Team CC: Fabio Estevam CC: NXP Linux Team CC: devicetree@vger.kernel.org CC: linux-arm-kernel@lists.infradead.org --- arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts index e61567437d73..62d5e9a4a781 100644 --- a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts @@ -44,7 +44,7 @@ <&clks IMX7D_ENET1_TIME_ROOT_CLK>; assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; assigned-clock-rates = <0>, <100000000>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <ðphy0>; fsl,magic-packet; status = "okay"; @@ -70,7 +70,7 @@ <&clks IMX7D_ENET2_TIME_ROOT_CLK>; assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; assigned-clock-rates = <0>, <100000000>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <ðphy1>; fsl,magic-packet; status = "okay";