From patchwork Mon Aug 12 14:01:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 11089921 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 170D413AC for ; Mon, 12 Aug 2019 14:01:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2EBF27F2B for ; Mon, 12 Aug 2019 14:01:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E598D28113; Mon, 12 Aug 2019 14:01:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E47F127F2B for ; Mon, 12 Aug 2019 14:01:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E956F6E526; Mon, 12 Aug 2019 14:01:16 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yw1-xc43.google.com (mail-yw1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23A066E526 for ; Mon, 12 Aug 2019 14:01:15 +0000 (UTC) Received: by mail-yw1-xc43.google.com with SMTP id z63so38697547ywz.9 for ; Mon, 12 Aug 2019 07:01:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ai1Rl9oj0oMVkYrxaL5hytId3XTSGm7gfkH3PvP/dOg=; b=gqbQa/spaVjLBjZd8x7CkwtNm/+ZKEclNc4bWbSCe8T5C3nDiZtI71/jkxGmk6kTp3 WVgtjcjGxD6ywUxFQFqa9a2oJaoHf/jblHKFYHUzB/dchYPqN+7E9JjHnwdZ3FrlpCEh ypT7ObGt4QC+QujBEpqpUpMA6Y2QnxAvXvTYwPyB7XtKBpjiudub2pmxAp/2l1bcBIIN 9PjXK9sNX6tLC4LjWIT0twhni+Jf7rbhyMxkFIIGOJn5/+9sye/sKlZ7XWLXK+aymqKF WeI9cpP/zAAKqzAXfpnv7PKh/MqbRnbVdJzEA9gzvyxef5LzMxPt1SUocQ+SMb/SxKLu MnDw== X-Gm-Message-State: APjAAAUNUdE/9MlDeTOtG6dJtV8ZKe7gsZR3w+EZGMHUbJcRZlndR0N6 M1AHMHVVmzhyK5x5BXq+65ARhGKBg2o= X-Google-Smtp-Source: APXvYqxQwW4TRzymSqHE6XhgjZnuQiXVGtJwytbe50smIpvxrA1s9xn1EMrE26bLCO02e547zRrX+A== X-Received: by 2002:a0d:ff05:: with SMTP id p5mr20666700ywf.499.1565618474750; Mon, 12 Aug 2019 07:01:14 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id n29sm259944ywh.77.2019.08.12.07.01.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 07:01:13 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH v2] drm: Fix kerneldoc warns in connector-related docs Date: Mon, 12 Aug 2019 10:01:03 -0400 Message-Id: <20190812140112.6702-1-sean@poorly.run> X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog In-Reply-To: <20190809210607.GA852@ravnborg.org> References: <20190809210607.GA852@ravnborg.org> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ai1Rl9oj0oMVkYrxaL5hytId3XTSGm7gfkH3PvP/dOg=; b=GNddhMQlX8U+fiohCCz2u6ARd4F1LFMEFGBxxI+Cyo/7AQwxmcn11tCOn7uPZ5LAUK KhruCBLHqKrW9TbZ5CIQ54kbBREdYfxdbz/f/cTcI4okM/ppYrgdztlM86+3YwJAdwVg QrwMRfZdUxWhIOZ8giwL/8vuh+GYVciuEghiDgCWfaZs1ACyM6GqZcp5CYlq+l87yvQS 73HhyUNlzn7/QMfDTs0SC1SpqxA5c6p9roFm2C2jFzx25OixYoXtqwlljl9iIOEP8nzg mEMUdHMJ3q355P53ra7n97UQ/nqORQvN1v7tnXCigNAEGnh6agbQVYAciENodDdV3HiW EByg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , Pekka Paalanen , Jani Nikula , David Airlie , Maxime Ripard , Sean Paul , Laurent Pinchart , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Sean Paul Fixes the following warnings: ../drivers/gpu/drm/drm_connector.c:989: WARNING: Unexpected indentation. ../drivers/gpu/drm/drm_connector.c:993: WARNING: Unexpected indentation. ../include/drm/drm_connector.h:544: WARNING: Inline interpreted text or phrase reference start-string without end-string. ../include/drm/drm_connector.h:544: WARNING: Inline interpreted text or phrase reference start-string without end-string. Changes in v2: - Use () instead of & for functions (Sam) Fixes: 1b27fbdde1df ("drm: Add drm_atomic_get_(old|new)_connector_for_encoder() helpers") Fixes: bb5a45d40d50 ("drm/hdcp: update content protection property with uevent") Cc: Ramalingam C Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: Jani Nikula Cc: Sean Paul Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: David Airlie Cc: dri-devel@lists.freedesktop.org Reviewed-by: Sam Ravnborg Signed-off-by: Sean Paul --- Sending out for completeness, will apply to drm-misc-next. drivers/gpu/drm/drm_connector.c | 10 ++++++---- include/drm/drm_connector.h | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 354798bad576..4c766624b20d 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -986,12 +986,14 @@ static const struct drm_prop_enum_list hdmi_colorspaces[] = { * - Kernel sends uevent with the connector id and property id through * @drm_hdcp_update_content_protection, upon below kernel triggered * scenarios: - * DESIRED -> ENABLED (authentication success) - * ENABLED -> DESIRED (termination of authentication) + * + * - DESIRED -> ENABLED (authentication success) + * - ENABLED -> DESIRED (termination of authentication) * - Please note no uevents for userspace triggered property state changes, * which can't fail such as - * DESIRED/ENABLED -> UNDESIRED - * UNDESIRED -> DESIRED + * + * - DESIRED/ENABLED -> UNDESIRED + * - UNDESIRED -> DESIRED * - Userspace is responsible for polling the property or listen to uevents * to determine when the value transitions from ENABLED to DESIRED. * This signifies the link is no longer protected and userspace should diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 0b9997e27689..681cb590f952 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -543,8 +543,8 @@ struct drm_connector_state { * * This is also used in the atomic helpers to map encoders to their * current and previous connectors, see - * &drm_atomic_get_old_connector_for_encoder() and - * &drm_atomic_get_new_connector_for_encoder(). + * drm_atomic_get_old_connector_for_encoder() and + * drm_atomic_get_new_connector_for_encoder(). * * NOTE: Atomic drivers must fill this out (either themselves or through * helpers), for otherwise the GETCONNECTOR and GETENCODER IOCTLs will