From patchwork Thu Sep 6 13:27:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rakesh Pillai X-Patchwork-Id: 10590623 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B9AB2139B for ; Thu, 6 Sep 2018 13:27:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B18F629CDA for ; Thu, 6 Sep 2018 13:27:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4A782A7B0; Thu, 6 Sep 2018 13:27:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4349329CDA for ; Thu, 6 Sep 2018 13:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Gdcqm/HtXQzxxy1ymZ1wuG+rZa4+1U9qtrjhC/1nUIg=; b=hYn DD8KeDGo6q1zBpv6aXJdDJfbB7kKusp3gaoUrFeUp2+8i1NZQ8KMZSg0ywW9h/B6jukDFZVaG644L db0YL35g4uzEtRIoc7UWrNc63jN4FGBsPMpyUmkTuQ1nB8HnRK+oy8i2R+Ae9En7HJy1IYI/K/k5w hus2IQud33A2t5yQP3xnEb0yRnI8LPiNGj4W/oq28ZHWz9EpHaSRLUjnmCVGQMS0l6l9rMggi3ZpX XVZ/UAU7Oe4z8D+CZDt+rPpHgNAoLIzGzKZRbjH8BEIPLO15u88l76lVmKgUkLyEqidtv+7NuixpG +rv7gqBE588MMLKGZu9LpRTUp4YNTAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fxuK3-0002BT-OB; Thu, 06 Sep 2018 13:27:47 +0000 Received: from alexa-out-blr-02.qualcomm.com ([103.229.18.198] helo=alexa-out-blr.qualcomm.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fxuK0-0002AF-Uz for ath10k@lists.infradead.org; Thu, 06 Sep 2018 13:27:46 +0000 X-IronPort-AV: E=Sophos;i="5.53,338,1531765800"; d="scan'208";a="158762" Received: from ironmsg04-blr.qualcomm.com ([10.86.208.133]) by alexa-out-blr.qualcomm.com with ESMTP/TLS/AES256-SHA; 06 Sep 2018 18:57:33 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9007"; a="1249354" Received: from pillair-linux.qualcomm.com ([10.204.116.193]) by ironmsg04-blr.qualcomm.com with ESMTP; 06 Sep 2018 18:57:32 +0530 Received: by pillair-linux.qualcomm.com (Postfix, from userid 452944) id 8D25A25BF; Thu, 6 Sep 2018 18:57:31 +0530 (IST) From: Rakesh Pillai To: ath10k@lists.infradead.org Subject: [PATCH v2] ath10k: Fix tx status flag setting for management frames Date: Thu, 6 Sep 2018 18:57:27 +0530 Message-Id: <1536240447-14841-1-git-send-email-pillair@codeaurora.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180906_062745_481350_18CE2C2C X-CRM114-Status: UNSURE ( 6.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rakesh Pillai , linux-wireless@vger.kernel.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The tx_status for management frames is being filled incorrectly in the flags of skb_cb. This incorrect flag setting causes the upper layers to consider that the particular frame was not transmitted properly, leading to improper behavior. Set the IEEE80211_TX_STAT_ACK flag in the info flags of skb_cb, to indicate the successful transmission of the management frame. Fixes: dc405152bb64d4ae01c9ac669de25b2d1fb6fc2d Tested HW: WCN3990 Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1 Signed-off-by: Rakesh Pillai --- drivers/net/wireless/ath/ath10k/wmi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index fd612d2..1dced0d 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2336,7 +2336,12 @@ static int wmi_process_mgmt_tx_comp(struct ath10k *ar, u32 desc_id, dma_unmap_single(ar->dev, pkt_addr->paddr, msdu->len, DMA_FROM_DEVICE); info = IEEE80211_SKB_CB(msdu); - info->flags |= status; + + if (status) + info->flags &= ~IEEE80211_TX_STAT_ACK; + else + info->flags |= IEEE80211_TX_STAT_ACK; + ieee80211_tx_status_irqsafe(ar->hw, msdu); ret = 0;