From patchwork Thu Aug 29 16:50:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Denis Efremov (Oracle)" X-Patchwork-Id: 11121907 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 07A4A13B1 for ; Thu, 29 Aug 2019 16:51:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E31BC2189D for ; Thu, 29 Aug 2019 16:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727364AbfH2Quy (ORCPT ); Thu, 29 Aug 2019 12:50:54 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38855 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfH2Qux (ORCPT ); Thu, 29 Aug 2019 12:50:53 -0400 Received: by mail-wm1-f67.google.com with SMTP id o184so4553699wme.3; Thu, 29 Aug 2019 09:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EAPNXwtNcvomkAv43HK7BcSQSi3ID9bH+hr63tWVdSI=; b=B5HGm8Y0d+BC3TOmZ23uuf+WqGqYOV7ombVlzG70cKlsV5JRtEvvNhzfPX4mECWFhx u5j/9cXAx5IqdKYxp7N//EOr02YdCxMO9TImOTBYGSfNXGWuDvoj6pJX11SgB//Tt5im yYal4ni8RQu92gT5EGlqUSz2C0ZgmGFTTf+a6stQq6hqSBqIOsB4/FaV7WQu1kPe6C3X +xLocX36sKRkLLs3x2PB2D+myD7iamK/wRKiMKBKp2+VCm7/qCDUbUDyTARThORMu67E QuOMPvFXZtlfAMMmQxgNFbLz16ewEqahiYYT8vzew1IHcjJ1Y165M5UTbENb5n3dJ24k kxqA== X-Gm-Message-State: APjAAAX+kGHw6qYwNcIPCIAbgM17lyiHVPh/qD8mC15U8cFFX3Ij61QJ D4+f5ZSeYUoFEP3fmz575wgwXYvwuHo= X-Google-Smtp-Source: APXvYqyG8Uv9qqAEzfuwRYVShx38vJV1pUSPq3W7ZBAlPx5+N1oEiU4zijmswr1WDwZJj2S7mhEW8w== X-Received: by 2002:a1c:f704:: with SMTP id v4mr361727wmh.90.1567097450438; Thu, 29 Aug 2019 09:50:50 -0700 (PDT) Received: from green.intra.ispras.ru (bran.ispras.ru. [83.149.199.196]) by smtp.googlemail.com with ESMTPSA id o14sm8340770wrg.64.2019.08.29.09.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 09:50:49 -0700 (PDT) From: Denis Efremov To: linux-kernel@vger.kernel.org Cc: Denis Efremov , Alexander Viro , Anton Altaparmakov , Boris Ostrovsky , Boris Pismenny , "Darrick J. Wong" , "David S. Miller" , Dennis Dalessandro , Dmitry Torokhov , Inaky Perez-Gonzalez , Juergen Gross , Leon Romanovsky , Mike Marciniszyn , =?utf-8?q?Pali_Roh=C3=A1r?= , Rob Clark , Saeed Mahameed , Sean Paul , linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-input@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-rdma@vger.kernel.org, linux-wimax@intel.com, linux-xfs@vger.kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Joe Perches , Andrew Morton , Andy Whitcroft Subject: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls Date: Thu, 29 Aug 2019 19:50:15 +0300 Message-Id: <20190829165025.15750-1-efremov@linux.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org IS_ERR(), IS_ERR_OR_NULL(), IS_ERR_VALUE() and WARN*() already contain unlikely() optimization internally. Thus, there is no point in calling these functions and defines under likely()/unlikely(). This check is based on the coccinelle rule developed by Enrico Weigelt https://lore.kernel.org/lkml/1559767582-11081-1-git-send-email-info@metux.net/ Signed-off-by: Denis Efremov Cc: Joe Perches Cc: Andrew Morton Cc: Andy Whitcroft --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 93a7edfe0f05..56969ce06df4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6480,6 +6480,12 @@ sub process { "Using $1 should generally have parentheses around the comparison\n" . $herecurr); } +# nested likely/unlikely calls + if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { + WARN("LIKELY_MISUSE", + "nested (un)?likely() calls, $1 already uses unlikely() internally\n" . $herecurr); + } + # whine mightly about in_atomic if ($line =~ /\bin_atomic\s*\(/) { if ($realfile =~ m@^drivers/@) { From patchwork Thu Aug 29 16:50:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Denis Efremov (Oracle)" X-Patchwork-Id: 11121919 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CC92E14E5 for ; Thu, 29 Aug 2019 16:51:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B30B42077B for ; Thu, 29 Aug 2019 16:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727344AbfH2Qvo (ORCPT ); Thu, 29 Aug 2019 12:51:44 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:39136 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728161AbfH2Qvh (ORCPT ); Thu, 29 Aug 2019 12:51:37 -0400 Received: by mail-wm1-f68.google.com with SMTP id n2so3165494wmk.4; Thu, 29 Aug 2019 09:51:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ga+XMFiFry9YiHyXr2eap6q73l3MbDmaJElZidrxT1c=; b=Uly+OWR6uY2dDl3aasBq9oAfVvAMFsNaILQM78roRCRzmvO626dk4NpscajCeryt7f uG1YrrUSPfcj7RodP26+jn4QoAN4nh/KyL4SAus7T7nPCMJe72bx1NgWGWT2sTxcA4IS TFvD+DQXiQ3KTm76eZVRMlWmFAstBKF22E0pWDZCvo9q4pk2tHHMf2soornIeqhgBSsl 9JUarQzT35NkmrMBYhp98BP8Svo2kxfSr4pFgPBFaTwQ2H6nW+NCeG3fhFC81z6rPjqN v5OsboGI2Nhxejl4qDWN9e7GSn+Rb3OIR1MUCS9TnlNV/e/J93K90F36Pmk1kJ99zXQQ 9VgQ== X-Gm-Message-State: APjAAAXjZJXrv/SMKVeSvkuzlgH/B1espaZm9VdWMlslo1UOLLwl34u1 EJbgxvCsnFVVkE3OZzPiOXywcIJ7Vnk= X-Google-Smtp-Source: APXvYqyuRGgjumaKuo9LKUtTe2GVwiwRDCPAhwD1EdZaxDw8hHFa503mAIqp7DuHTHEoKl0fYRjzLw== X-Received: by 2002:a1c:750f:: with SMTP id o15mr13309528wmc.67.1567097495899; Thu, 29 Aug 2019 09:51:35 -0700 (PDT) Received: from green.intra.ispras.ru (bran.ispras.ru. [83.149.199.196]) by smtp.googlemail.com with ESMTPSA id o14sm8340770wrg.64.2019.08.29.09.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 09:51:35 -0700 (PDT) From: Denis Efremov To: linux-kernel@vger.kernel.org Cc: Denis Efremov , =?utf-8?q?Pali_Roh=C3=A1r?= , Dmitry Torokhov , Joe Perches , Andrew Morton , linux-input@vger.kernel.org Subject: [PATCH v3 09/11] Input: alps - remove unlikely() from IS_ERR*() condition Date: Thu, 29 Aug 2019 19:50:23 +0300 Message-Id: <20190829165025.15750-9-efremov@linux.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190829165025.15750-1-efremov@linux.com> References: <20190829165025.15750-1-efremov@linux.com> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org "unlikely(IS_ERR_OR_NULL(x))" is excessive. IS_ERR_OR_NULL() already uses unlikely() internally. Signed-off-by: Denis Efremov Cc: "Pali Rohár" Cc: Dmitry Torokhov Cc: Joe Perches Cc: Andrew Morton Cc: linux-input@vger.kernel.org --- drivers/input/mouse/alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 34700eda0429..ed1661434899 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c @@ -1476,7 +1476,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse, /* On V2 devices the DualPoint Stick reports bare packets */ dev = priv->dev2; dev2 = psmouse->dev; - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) { + } else if (IS_ERR_OR_NULL(priv->dev3)) { /* Register dev3 mouse if we received PS/2 packet first time */ if (!IS_ERR(priv->dev3)) psmouse_queue_work(psmouse, &priv->dev3_register_work,