From patchwork Tue Sep 3 09:18:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Popa X-Patchwork-Id: 11127463 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E803F15E9 for ; Tue, 3 Sep 2019 09:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD20022D6D for ; Tue, 3 Sep 2019 09:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="UoK2bbD6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726946AbfICJSx (ORCPT ); Tue, 3 Sep 2019 05:18:53 -0400 Received: from mx0b-00128a01.pphosted.com ([148.163.139.77]:53806 "EHLO mx0b-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726936AbfICJSx (ORCPT ); Tue, 3 Sep 2019 05:18:53 -0400 Received: from pps.filterd (m0167090.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8398Fe8010804; Tue, 3 Sep 2019 05:18:14 -0400 Received: from nam04-sn1-obe.outbound.protection.outlook.com (mail-sn1nam04lp2055.outbound.protection.outlook.com [104.47.44.55]) by mx0b-00128a01.pphosted.com with ESMTP id 2uqnh5cqh4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 03 Sep 2019 05:18:14 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C24mB7ln/01aRT3jSmT/X2a+01AdNa7pR6tGLaRHehr9NJJ5rMfd8lX2Cau9Ooma8rjbMdnoS5v8AHg0dhZM0wp3Th+s/el+evhojJWzsJIJhQ4wLrZGKNBymA8lb0LPcmByXEAOuQZu4I3EzUKsLRvh1ZWMy6sz3RIP6JiACTsmG9731KrXV85n0xcmWAKLvTtvQ9h+tGMIVR0itbSph3Evaq05bvu4G441j5Od+e3Nw2v2VGRaseQrObjq+18us74hv4QXMeUPuYgncFjpXpH6WB40dVebTCRMyPLmtJlTE1hjFzMiJRHGgmDbxeB+Lmpmq+Y6fFB+Cuz0J3L8iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U4SbAbb/5ac23tfajDupE2sj7N1q54dXurpgP+cOvos=; b=mSQjUflZaT6ALjyVu08PA6MrY6/W7G+0JuIIdDgvpWdQG3ZKQTx7Go0XEcvgibXldyLVMbXJX1RMI4lAB/h7ZV5AO8LCwu2aO1KgqZq+yiP7YdjxQCPFl2nNlqVhgnF6gx7BBf4nWIXiUmRc4k002HHGmytO/r4f6QUZtIDrXxFfTplxVxaRLgm0JKc0bY/gi7tbY9usUdt6cfysgKWzODluuQHSj2bXW7eKy8lzNeD+58PY/m3fNwrUrsENfSdTJYLBPqe6ogEaDsNoPPkjVrPWteXxU9MN9iniafUEZ5WS65hW+wDSCrFoMTZRPAwXVdSbEreG2YYswtl2LEqzCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.55) smtp.rcpttodomain=gmx.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U4SbAbb/5ac23tfajDupE2sj7N1q54dXurpgP+cOvos=; b=UoK2bbD6uWNSG9VA96Y3tPFAsfzdr18DokWYZnFwN84BhdDuGhrrEobIZeCDq/R+FggUxsa2uU9MWrLo2TN+1BL+O77AUiswEtEx3/j8e/1R7Q4xvO6gIXow4e/izO2x+zckiJOfQT1ORZfYAhT18hleRBrSogy3k4jVduqSIro= Received: from BN3PR03CA0052.namprd03.prod.outlook.com (2a01:111:e400:7a4d::12) by CY4PR03MB3223.namprd03.prod.outlook.com (2603:10b6:910:51::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.21; Tue, 3 Sep 2019 09:18:12 +0000 Received: from BL2NAM02FT056.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::206) by BN3PR03CA0052.outlook.office365.com (2a01:111:e400:7a4d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19 via Frontend Transport; Tue, 3 Sep 2019 09:18:12 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.55 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.55; helo=nwd2mta1.analog.com; Received: from nwd2mta1.analog.com (137.71.25.55) by BL2NAM02FT056.mail.protection.outlook.com (10.152.77.221) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2220.16 via Frontend Transport; Tue, 3 Sep 2019 09:18:12 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta1.analog.com (8.13.8/8.13.8) with ESMTP id x839I7NB003244 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Tue, 3 Sep 2019 02:18:07 -0700 Received: from linux.ad.analog.com (10.32.226.41) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Tue, 3 Sep 2019 05:18:11 -0400 From: Stefan Popa To: CC: , , , , , , Subject: [PATCH 1/3] iio: accel: adxl372: Fix/remove limitation for FIFO samples Date: Tue, 3 Sep 2019 12:18:07 +0300 Message-ID: <1567502287-10199-1-git-send-email-stefan.popa@analog.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.55;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(136003)(39860400002)(376002)(396003)(2980300002)(189003)(199004)(5660300002)(50466002)(51416003)(486006)(126002)(107886003)(478600001)(70586007)(48376002)(4326008)(70206006)(316002)(336012)(44832011)(186003)(47776003)(7696005)(6916009)(50226002)(356004)(6666004)(16586007)(8936002)(2616005)(476003)(8676002)(54906003)(246002)(36756003)(2906002)(106002)(2351001)(305945005)(426003)(26005)(7636002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR03MB3223;H:nwd2mta1.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail10.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f12e936-502e-4949-bce6-08d7304fa508 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(4709080)(1401327)(4618075)(2017052603328);SRVR:CY4PR03MB3223; X-MS-TrafficTypeDiagnostic: CY4PR03MB3223: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-Forefront-PRVS: 01494FA7F7 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: x9TH+ypzILRiZ4j5vq263OwwmxZ9H4Yg0J0BG4hNNaHyL2riwElyEZhbPKgz5jqKCyHhZHD6KrcJJ8KLW6Y5Xm7E+/M/1WXX8Z0zpTgc5YQB6XRrBsPRLtXAkjJcqMda22Fp082kuQX2KrbSIje1EggMahtuFkQxRnpm9TO+tQGnbSU/D/Ud3MxFOjoIIgqM5P4hxSCe3Q9dhsS1IFOB8TZ+wWtVIGBSIIguvLdK7la+rq7q+CycLCHvcuUeYeuRNyb6T8vOpWuzMXFTgroqyTj4XBe7D3n86DRmJiePPzx0BBtGU4TNewrtNYmFd4C8aBC2sa0VqzAvM0QCrwrR5Ql3EweOaAXMcMnQEikmOvbYCnBRq2jaZi4fqqzypazCSNd0DzAdvTY5F04qFxRSeJ6Uhs94Mks+EcKXHbPdCK8= X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2019 09:18:12.4656 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f12e936-502e-4949-bce6-08d7304fa508 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3223 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-03_01:2019-09-03,2019-09-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 suspectscore=1 mlxscore=0 adultscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 mlxlogscore=772 spamscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1909030097 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Currently, the driver sets the FIFO_SAMPLES register with the number of sample sets (maximum of 170 for 3 axis data, 256 for 2-axis and 512 for single axis). However, the FIFO_SAMPLES register should store the number of samples, regardless of how the FIFO format is configured. Signed-off-by: Stefan Popa --- drivers/iio/accel/adxl372.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c index 055227cb..adec37b 100644 --- a/drivers/iio/accel/adxl372.c +++ b/drivers/iio/accel/adxl372.c @@ -805,15 +805,6 @@ static int adxl372_buffer_postenable(struct iio_dev *indio_dev) st->fifo_format = adxl372_axis_lookup_table[i].fifo_format; st->fifo_set_size = bitmap_weight(indio_dev->active_scan_mask, indio_dev->masklength); - /* - * The 512 FIFO samples can be allotted in several ways, such as: - * 170 sample sets of concurrent 3-axis data - * 256 sample sets of concurrent 2-axis data (user selectable) - * 512 sample sets of single-axis data - */ - if ((st->watermark * st->fifo_set_size) > ADXL372_FIFO_SIZE) - st->watermark = (ADXL372_FIFO_SIZE / st->fifo_set_size); - st->fifo_mode = ADXL372_FIFO_STREAMED; ret = adxl372_configure_fifo(st); From patchwork Tue Sep 3 09:18:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Popa X-Patchwork-Id: 11127465 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F04C615E9 for ; Tue, 3 Sep 2019 09:19:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C85CB22D6D for ; Tue, 3 Sep 2019 09:19:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="JEBcIFwd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbfICJTR (ORCPT ); Tue, 3 Sep 2019 05:19:17 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:63972 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbfICJTR (ORCPT ); Tue, 3 Sep 2019 05:19:17 -0400 Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8398Cdn028538; Tue, 3 Sep 2019 05:18:45 -0400 Received: from nam03-co1-obe.outbound.protection.outlook.com (mail-co1nam03lp2054.outbound.protection.outlook.com [104.47.40.54]) by mx0a-00128a01.pphosted.com with ESMTP id 2uqnt8cd82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Sep 2019 05:18:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xvl1etb3ovAD2zWRAbsNxSPntOf9Avmmfj1POGoX7j4kgHU2VQKK73NUgYryw1CFcl2k21ZZWgHffgNEPk7YiHSkHUH7KZFrE9w+Gju+NfrBEcFxG8V6e0ruuvQcK2agQHQ/6d8wbelBynqDFMx+vE8b+hRicgL0KjtFxH02CdkybIYMSH3lD+W5IuHq0P6PhqfyXACIJbeOTNHSxeMRj4rFASohwP6lvdKdSRXKGnAPXa9PBdBfqWjSDzlU4xv1DeYqgHt5TOc5a5Rh3wki8YggF9W1JHmpvBr8JrndT5xkArpGsQd88aENx5kzcM0oA2mGXaKmiAdJYPu+aLWNMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DF+YBXfbVxO15DQNsbmgUvsYSYE1/GXMwO8lfTGwhzI=; b=ebVvI5URziS7wWa8cHcs3IP4b+1wIalPOnJWmh7Qe9T1fWcVhT5irHaivezI78+RZ8ghmFCq2HbCH3+zHZ+iHVCmtHBWDCF+B+dCEJ07Ta4drhLQLHW6W1J+Ta0w0oE0cf5UUaHj6/rbqBf+A2Uz1C451SEuoHmlXLDGnIil3IoWW8y3wcdcc+KyKF5JCoKaRkpZ5nQ2tT2u4+6JJkbdzbSR+E1FMDEOAhV27Rsx075EQyg38slTqyloqx+sisKddhCg9H6/lIgswa3djSRwANxfcJTlLXtW0P99F7fnCdFg9MSNJEFN0IgU4z2cH5N5+GLGSFIj5DNt23/ipD+kJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.55) smtp.rcpttodomain=gmx.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DF+YBXfbVxO15DQNsbmgUvsYSYE1/GXMwO8lfTGwhzI=; b=JEBcIFwdk1+fUMqF5hkEIJfj0xk8jjy4K5YW4cB2WqdKDYMekuvBWZnZWgA7zy8E+I9HkssGZmKSqmMG13KuyzfCJId8T+keu8zBxz/LrKIqfavgJdlcr/qR8xSiT8XhJsjREhy3holSkJuzQ0tCV1vAaQ30enD4NL9gFfX7Prk= Received: from BN3PR03CA0087.namprd03.prod.outlook.com (2a01:111:e400:7a4d::47) by CY4PR03MB3048.namprd03.prod.outlook.com (2603:10b6:903:137::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.18; Tue, 3 Sep 2019 09:18:39 +0000 Received: from CY1NAM02FT028.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::200) by BN3PR03CA0087.outlook.office365.com (2a01:111:e400:7a4d::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19 via Frontend Transport; Tue, 3 Sep 2019 09:18:39 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.55 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.55; helo=nwd2mta1.analog.com; Received: from nwd2mta1.analog.com (137.71.25.55) by CY1NAM02FT028.mail.protection.outlook.com (10.152.75.132) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2220.16 via Frontend Transport; Tue, 3 Sep 2019 09:18:38 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta1.analog.com (8.13.8/8.13.8) with ESMTP id x839IXTM003317 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Tue, 3 Sep 2019 02:18:33 -0700 Received: from linux.ad.analog.com (10.32.226.41) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Tue, 3 Sep 2019 05:18:37 -0400 From: Stefan Popa To: CC: , , , , , , Subject: [PATCH 2/3] iio: accel: adxl372: Fix push to buffers lost samples Date: Tue, 3 Sep 2019 12:18:33 +0300 Message-ID: <1567502313-10314-1-git-send-email-stefan.popa@analog.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.55;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(39850400004)(396003)(136003)(346002)(2980300002)(189003)(199004)(305945005)(7636002)(5660300002)(36756003)(246002)(8676002)(51416003)(7696005)(356004)(2351001)(50226002)(4326008)(107886003)(8936002)(6666004)(50466002)(48376002)(4744005)(478600001)(70586007)(54906003)(316002)(70206006)(2906002)(106002)(16586007)(47776003)(186003)(336012)(26005)(44832011)(486006)(476003)(426003)(126002)(2616005)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR03MB3048;H:nwd2mta1.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail10.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ab396802-aefa-4780-4e6a-08d7304fb4ab X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(4709080)(1401327)(4618075)(2017052603328);SRVR:CY4PR03MB3048; X-MS-TrafficTypeDiagnostic: CY4PR03MB3048: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-Forefront-PRVS: 01494FA7F7 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: dyzZsrESR5AgfSPOCevwW83uRHjZNiaXe7SKgfU4bhkPN0QOxlwDve1fjY+60CA2wqzzKaLJhseKIhR4U+QdcTWWIHGF/ujRLhKEUjt8W7lzJGDMJRjEUX7wsNMDS1YorGzTz8HdhoGMaEKAMgk1uEdtZzaz9KISQ/KR5ahBK2txW0gJQhWSwsKUrlkt5Y2h+mbk+L4HTCg4hAT3N38QS6kePjTzkaYWcHIWoFjnwxsRRbG3iYWQBxyR4nh6HB/UVH3GMUtzxlD7VHQ+IQ05k1uy2BkaUx1/aszLZcxpxmeE1Shh8w04kYvp9cmlTSP43eY2D4Vymz0Al8dofHlTDGmPYzdw2X84n4Q2W1JwGLk3D4+gID/x8QQ2ZSmuuwm6pHfxO/wEU7QWXEIMP6AeNf1u9kJVEdSi6VnRNfcHnmc= X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2019 09:18:38.3806 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab396802-aefa-4780-4e6a-08d7304fb4ab X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3048 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-03_01:2019-09-03,2019-09-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 suspectscore=1 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=963 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1909030097 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org One in two sample sets was lost by multiplying fifo_set_size with sizeof(u16). Also, the double number of available samples were pushed to the iio buffers. Signed-off-by: Stefan Popa --- drivers/iio/accel/adxl372.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c index adec37b..72d3f45 100644 --- a/drivers/iio/accel/adxl372.c +++ b/drivers/iio/accel/adxl372.c @@ -548,8 +548,7 @@ static irqreturn_t adxl372_trigger_handler(int irq, void *p) goto err; /* Each sample is 2 bytes */ - for (i = 0; i < fifo_entries * sizeof(u16); - i += st->fifo_set_size * sizeof(u16)) + for (i = 0; i < fifo_entries; i += st->fifo_set_size) iio_push_to_buffers(indio_dev, &st->fifo_buf[i]); } err: From patchwork Tue Sep 3 09:19:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Popa X-Patchwork-Id: 11127467 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 307F413B1 for ; Tue, 3 Sep 2019 09:19:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 049C622DBF for ; Tue, 3 Sep 2019 09:19:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="lBWR0cDZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728129AbfICJTp (ORCPT ); Tue, 3 Sep 2019 05:19:45 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:16682 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbfICJTp (ORCPT ); Tue, 3 Sep 2019 05:19:45 -0400 Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8398BLd001712; Tue, 3 Sep 2019 05:19:20 -0400 Received: from nam03-dm3-obe.outbound.protection.outlook.com (mail-dm3nam03lp2055.outbound.protection.outlook.com [104.47.41.55]) by mx0a-00128a01.pphosted.com with ESMTP id 2uqjracjjj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 03 Sep 2019 05:19:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jwjNTCSt33aSC2fqAVCMO96h1oD5PUpJFFprofFdkmtgVKlnUqBJdxhYNiZps72I+J6/UsHObgi1oJACOK6XFhKLdJfZf1PRVX/h/2ZGUj4pzXE3eN8lcugUMFm8wr76vnCdqs+FnCZpA6p7gjpq13n558J0z7ByPLOi7ejgLS+o/8VMSPQJFfWd1CN4gVvtmpRFgdR9MxkuZPuzkfZN8EKGWOXCutFLT4EHqI3b2o3pLvZcdtzhier9h43xrJZlpr9PhHcnXy76lkSy60Flx//di++ksfgJscJRRGQyIXq2V/TmjloK+/agJPZ9e7P3GSf4+By16l7OCNvrm6uVOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dBxbXDIOuQXSkj/V107YId0xpDme+WSzPVM0VbmN3TA=; b=Va7nIOanZxixUaXr2xO8y5NwCsZ32s8nt0QenYBFFVxZjITyfDyEHBXSmI5lBD6XfuN/x4BEUOSyn4E93//5bZwmYoDSkOgpPPIk1UBuuRcS29wvBwM6hZYhl4ktNjfpRae2fDO5vtpHTvsCVG3tM1JVtbUo5I8RhixmgeItEBnVau8oItcigHsqOqOglmTKR2BNGjGL4t+UCS8ZmcCksh98fp+Mpzcmaljd+1f+pEk7U3WXVNT2Tp75G5pPZvACv7WI8aCxQjsqZfiwLu9O82MZg8NGF6WvwkkGkujE1liVAwCW4VBwni+1NCbGzD6ghNzFkZNrjkYZ5//qm/N7nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.55) smtp.rcpttodomain=gmx.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dBxbXDIOuQXSkj/V107YId0xpDme+WSzPVM0VbmN3TA=; b=lBWR0cDZv2y7/sPWL9ivsmrhtIguWPqWHfKYb42li6LNr2Z5Q4cxfvLRCxKGx0nG+lHVy6ts8D5NsJpGSxoP6CVpJ+r3XiHEFxUnrWa1kdqn7q38/fVqd9PjM6epdLH42HTEUp+5EKZwo+NdIFdvQLhFPPDFOd6wJfF3IWuqc6k= Received: from CY4PR03CA0105.namprd03.prod.outlook.com (2603:10b6:910:4d::46) by MWHPR03MB3040.namprd03.prod.outlook.com (2603:10b6:300:11c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19; Tue, 3 Sep 2019 09:19:17 +0000 Received: from SN1NAM02FT043.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::207) by CY4PR03CA0105.outlook.office365.com (2603:10b6:910:4d::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19 via Frontend Transport; Tue, 3 Sep 2019 09:19:17 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.55 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.55; helo=nwd2mta1.analog.com; Received: from nwd2mta1.analog.com (137.71.25.55) by SN1NAM02FT043.mail.protection.outlook.com (10.152.72.184) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2220.16 via Frontend Transport; Tue, 3 Sep 2019 09:19:16 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta1.analog.com (8.13.8/8.13.8) with ESMTP id x839JBd4003500 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Tue, 3 Sep 2019 02:19:11 -0700 Received: from linux.ad.analog.com (10.32.226.41) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Tue, 3 Sep 2019 05:19:15 -0400 From: Stefan Popa To: CC: , , , , , , Subject: [PATCH 3/3] iio: accel: adxl372: Make sure interrupts are disabled Date: Tue, 3 Sep 2019 12:19:11 +0300 Message-ID: <1567502351-10429-1-git-send-email-stefan.popa@analog.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.55;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(39860400002)(136003)(346002)(396003)(2980300002)(199004)(189003)(476003)(2616005)(126002)(7636002)(5660300002)(54906003)(486006)(426003)(6916009)(356004)(6666004)(47776003)(107886003)(106002)(44832011)(36756003)(50226002)(316002)(305945005)(186003)(16586007)(70206006)(70586007)(4326008)(8676002)(48376002)(8936002)(4744005)(51416003)(246002)(7696005)(50466002)(26005)(478600001)(336012)(2906002)(2351001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR03MB3040;H:nwd2mta1.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail10.analog.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8c5e0a5-2d60-436c-c05a-08d7304fcb6f X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(4709080)(1401327)(4618075)(2017052603328);SRVR:MWHPR03MB3040; X-MS-TrafficTypeDiagnostic: MWHPR03MB3040: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-Forefront-PRVS: 01494FA7F7 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: hqbR+Ld0FiLmVEqOnqs03e/QE8y936wpLLikWwrnijYZZyExkOSx2LqFI3uaJ3FoIT4lpBlpto+vHVfM7YEdzcMJ0ZMssEP15U3NPLd2OwC5NVPhAn25Oh/tDXhBTj2lIep3dWk8F5ZVWAKqLPeIIFh5DikMKQHCKZViP2WkPAb/TsnsgsvClffqesYhJ8h2jSo17W/SB+J/1qeXh2cX1w4zOLGbctyaJDQXMx1udZtBvfKIJwxeHKznwBb2lfAXJsVcf67g6CVgti6ljx7ZD6uSZhYU8c1QiBnXK14Zp16hVAQFH0crVl2na1VYfyVgKSWAzCSjykpHl5nEv59gssLqCPGwTvsFRZYsEPq+zYpHUp773TdRFbYuQ1tNB/qV0oYLJHaf7TT/wdTT5pCCzLkYZT6WmPY1K+ayDuZZKJQ= X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2019 09:19:16.6429 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e8c5e0a5-2d60-436c-c05a-08d7304fcb6f X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3040 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-03_01:2019-09-03,2019-09-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=651 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 mlxscore=0 suspectscore=1 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1909030097 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This patch disables the adxl372 interrupts at setup. The interrupts should be enabled together with the iio buffer. Not doing this, might cause an unwanted interrupt to trigger without being able to properly clear it. Signed-off-by: Stefan Popa --- drivers/iio/accel/adxl372.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c index 72d3f45..77651f4 100644 --- a/drivers/iio/accel/adxl372.c +++ b/drivers/iio/accel/adxl372.c @@ -609,6 +609,10 @@ static int adxl372_setup(struct adxl372_state *st) if (ret < 0) return ret; + ret = adxl372_set_interrupts(st, 0, 0); + if (ret < 0) + return ret; + /* Set the mode of operation to full bandwidth measurement mode */ return adxl372_set_op_mode(st, ADXL372_FULL_BW_MEASUREMENT); }