From patchwork Fri Sep 6 14:20:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislav Lisovskiy X-Patchwork-Id: 11135367 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 839D81708 for ; Fri, 6 Sep 2019 14:23:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B9D7205ED for ; Fri, 6 Sep 2019 14:23:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B9D7205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FD3D6E2BD; Fri, 6 Sep 2019 14:23:06 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id A74A06E2BD for ; Fri, 6 Sep 2019 14:23:05 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2019 07:23:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,473,1559545200"; d="scan'208";a="213159196" Received: from slisovsk-lenovo-ideapad-720s-13ikb.fi.intel.com ([10.237.72.89]) by fmsmga002.fm.intel.com with ESMTP; 06 Sep 2019 07:23:04 -0700 From: Stanislav Lisovskiy To: intel-gfx@lists.freedesktop.org Date: Fri, 6 Sep 2019 17:20:54 +0300 Message-Id: <20190906142054.32717-1-stanislav.lisovskiy@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [Intel-gfx] [PATCH v1] drm/i915: Add more debug information to dp aux code X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quite many issues currently happen during intel_dp_detect during dpcd read. Sometimes we can only see that it had failed in the logs, while no actual reason is available. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 5673ed75e428..2bf0451b3568 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -1256,6 +1256,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp, last_status = status; } + WARN(1, "prev chan activity not finished after 3 retries"); ret = -EBUSY; goto out; } @@ -1336,6 +1337,9 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp, goto out; } + if (!(status & DP_AUX_CH_CTL_DONE)) + DRM_ERROR("Unknown dp aux ctl error status 0x%08x\n", status); + /* Unload any bytes sent back from the other side */ recv_bytes = ((status & DP_AUX_CH_CTL_MESSAGE_SIZE_MASK) >> DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT); @@ -1452,6 +1456,7 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) break; default: + WARN(1, "Unknown request type %d", msg->request & ~DP_AUX_I2C_MOT); ret = -EINVAL; break; } @@ -5028,8 +5033,10 @@ intel_dp_detect_dpcd(struct intel_dp *intel_dp) if (lspcon->active) lspcon_resume(lspcon); - if (!intel_dp_get_dpcd(intel_dp)) + if (!intel_dp_get_dpcd(intel_dp)) { + DRM_DEBUG_KMS("Could not get dpcd!"); return connector_status_disconnected; + } /* if there's no downstream port, we're done */ if (!drm_dp_is_branch(dpcd))