From patchwork Mon Sep 23 13:44:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11156959 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D46C176 for ; Mon, 23 Sep 2019 13:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B279620665 for ; Mon, 23 Sep 2019 13:45:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gYnxWxDz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730903AbfIWNpH (ORCPT ); Mon, 23 Sep 2019 09:45:07 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:46023 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbfIWNpG (ORCPT ); Mon, 23 Sep 2019 09:45:06 -0400 Received: by mail-io1-f65.google.com with SMTP id c25so1312026iot.12; Mon, 23 Sep 2019 06:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=8gJJO39rFvRPC27Eg6HXHKJTgns+bBIO2jkPaH1hgc4=; b=gYnxWxDzYUW5wn60fhXJrrdD/bHxTVKwpKATR5CRZEQcYGvXyNPjvq4hzHLvfaf5Qn HLcQUGjw/5+RhsF9F2VVpXwAiTSkvIWCGnJo+3s8xZjyaV9ZfeUxBFlwP7KzOZAiIPTC T6j7b4NdQ//XRSTLKNKUQrQtMi5hhBgDwKp0tt0msVN9MHViDBJTcaUFdlXxZR90ujcH 4PYYFitroKR3Jc9v8E9sNobSwr3+LrMmKvS3jUjbM2Tt3xXNwVsdeb7M+QmK+83NBXfS LzBnzOTk9WrX+w3N0JyHc/MPaPt0Ej4YzZq5CAGpOPoSrTgEdQwTidx0M4upHPwcTPxH 3IJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8gJJO39rFvRPC27Eg6HXHKJTgns+bBIO2jkPaH1hgc4=; b=Yj4ZTcj/kA+Tp7HziU4XFUU3RjxMw1ipehnjFdijpgvcy9d5VirFF9uKH5yStefzSN q8fj648/091mqtNYWcBjfqF2Pb4CA9SLT4wt4SyKWIPoG/MxFwB4A6mpahdPXC5+9Uh1 PCkw8nMeZTckxIVsFuOk0yOpLZW1fOVf430pih7SyU9PU8a9pWir8FkocqtqjOUBiSgR DkcRCMEJHa2qy1bTKglERR11I10mi2P8DyKmCrq9sii8Ec0GsyOpzlzWp1T/QOLD4L4G u06adWW/Q5XPus5YwtVFSJDYPBanmDgf48WquLvndnmGSQn8QOII6eMs0Hunjcqx3ww1 yGQw== X-Gm-Message-State: APjAAAVvubTPzdtSKu5CxDDLE/4orwmNMtSOP7ljgjxNMx+3jG8x6ih+ Q8IT57iuEMWdrCG3Ja03Cws= X-Google-Smtp-Source: APXvYqzJ5o3V+xw8Vo6YavSbpE/G0mrA+1QvHonDZaHomPezsl9Rg4ZVusHEe89mStO7TrQUS+BgXA== X-Received: by 2002:a6b:c895:: with SMTP id y143mr14632059iof.271.1569246305617; Mon, 23 Sep 2019 06:45:05 -0700 (PDT) Received: from aford-OptiPlex-7050.logicpd.com ([174.46.170.158]) by smtp.gmail.com with ESMTPSA id x2sm8844474iob.74.2019.09.23.06.44.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 06:44:59 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Cc: linux-omap@vger.kernel.org, adam.ford@logicpd.com, Adam Ford , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 1/3] drm/panel: simple: Add Logic PD Type 28 display support Date: Mon, 23 Sep 2019 08:44:47 -0500 Message-Id: <20190923134449.22326-1-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg --- V2: No change diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5a93c4edf1e4..c86c30f3a8a1 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1900,6 +1900,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock = 9000, + .hdisplay = 480, + .hsync_start = 480 + 3, + .hsync_end = 480 + 3 + 42, + .htotal = 480 + 3 + 42 + 2, + + .vdisplay = 272, + .vsync_start = 272 + 2, + .vsync_end = 272 + 2 + 11, + .vtotal = 272 + 2 + 11 + 3, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 105, + .height = 67, + }, + .delay = { + .prepare = 200, + .enable = 200, + .unprepare = 200, + .disable = 200, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | + DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, +}; + static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes = 1, @@ -2948,6 +2982,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01, From patchwork Mon Sep 23 13:44:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11156961 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06E2976 for ; Mon, 23 Sep 2019 13:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA1532168B for ; Mon, 23 Sep 2019 13:45:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="apaI9MYT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730987AbfIWNpP (ORCPT ); Mon, 23 Sep 2019 09:45:15 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:38587 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbfIWNpP (ORCPT ); Mon, 23 Sep 2019 09:45:15 -0400 Received: by mail-io1-f68.google.com with SMTP id u8so12196196iom.5; Mon, 23 Sep 2019 06:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6KEVbOMgmT7rRfn/GiQXZyuHVfsA7+ZXr3TLsE1ZKxg=; b=apaI9MYT4uF2EnxCrwNl6kE1+1obRxTSGNBCmUc1fv82RV20hwMgb0DelnRGQBg/0r /eUkkz48X0hfIPKZ2N2DmbN5oKZobno+nbjeT4eeskVcepR8ap4NOLPh5/jA0JggX023 xvJlUduAlc51f9v/RV2Bus8bcJJDY9yzItUSL7KWtJoJ/CObfC3BXBagk07kE4SAp7lX oU1df9YcLYKKdlWkMv+q5oms96DMigH/BvWFYs4/vFBV65Fq4vJ42EPFpG6DLEPcXP2L pRleMG7p84G+AXDbphrjFJl4MKLA9TSjeWjZu8plF4AKoet8cbrxTyq459qEcWKEXVH4 FE1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6KEVbOMgmT7rRfn/GiQXZyuHVfsA7+ZXr3TLsE1ZKxg=; b=nS9hkI703DPHKBowwMUEFqJwgtcmCtZQ/9uk8sN1gH+AkA+2OCkg97tfpYoPjo47a6 G+aD3CrTKKw8pmPbnsbNcr/saGiErbG1sp6e+sZPr7/FnFidTwMScpvuCRXbHU4btSpu DmOMAVl+386vcydFoXcZPR7zqQmhXGoPHs23pC5ZIDf4sfBFs+2hpmTnzNpDzKbmqc8I TYBBLI921WvLEFaRTh4G2ef/r8htkuedGOvcb7PVtUedeRsHw2Z0vdhSdxgikeg/8HcI nWaOsAWZd0yPQiYmnzJt/8foHAxXIPwELE8/w72LRFnI4HBQ65D9pPAtfdNmZGpQlIFu +G/Q== X-Gm-Message-State: APjAAAW9DiPI7vIKv7etiR/F8ZI3dUsk6V8FrfwWdbWvQSefkXhR30xz WTdj/SDjxsE8wWvoc/0gR4c= X-Google-Smtp-Source: APXvYqyRhc1UYpQc17s5gFWSBKWFMsHMrfOoJgvXh4s0LmVVLySIdfue6aQFT09HebdqP+/6iH4Gzw== X-Received: by 2002:a6b:e302:: with SMTP id u2mr2267525ioc.135.1569246313939; Mon, 23 Sep 2019 06:45:13 -0700 (PDT) Received: from aford-OptiPlex-7050.logicpd.com ([174.46.170.158]) by smtp.gmail.com with ESMTPSA id x2sm8844474iob.74.2019.09.23.06.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 06:45:08 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Cc: linux-omap@vger.kernel.org, adam.ford@logicpd.com, Adam Ford , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 2/3] dt-bindings: Add Logic PD Type 28 display panel Date: Mon, 23 Sep 2019 08:44:48 -0500 Message-Id: <20190923134449.22326-2-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190923134449.22326-1-aford173@gmail.com> References: <20190923134449.22326-1-aford173@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V2: Use YAML instead of TXT for binding diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file mode 100644 index 000000000000..707e2a17c8c2 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0+ OR X11) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/ronbo,rb070d30.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel + +properties: + compatible: + const: logicpd,type28 + + power-supply: + description: Regulator to provide the supply voltage + maxItems: 1 + + enable-gpios: + description: GPIO pin to enable or disable the panel + maxItems: 1 + + backlight: + description: Backlight used by the panel + $ref: "/schemas/types.yaml#/definitions/phandle" + +required: + - compatible + +additionalProperties: false + +examples: + lcd0: display { + compatible = "logicpd,type28"; + enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + }; From patchwork Mon Sep 23 13:44:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11156965 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C33A476 for ; Mon, 23 Sep 2019 13:45:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1DD220820 for ; Mon, 23 Sep 2019 13:45:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LRIxgemC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732363AbfIWNpT (ORCPT ); Mon, 23 Sep 2019 09:45:19 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:44454 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbfIWNpS (ORCPT ); Mon, 23 Sep 2019 09:45:18 -0400 Received: by mail-io1-f65.google.com with SMTP id j4so33441064iog.11; Mon, 23 Sep 2019 06:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=II3Z/ePw+kluHJAh79jkfAHhBKN0+PEn+7sKnI4/9O4=; b=LRIxgemCeo1xWi9guI7emc3IqoiMCWFHvsGEbD3szsHx+S8v43Ax2NGNrtoREyn2Bz vhnkmPK37M8KzQsgFNpeQ+BcY5h/4VC72ASTQkmKZFETngnZgV1M86XBfzG60leuCeYs 563KI6gOtg2Ce7d1NMNGrrAYJiU2WaB9WV23rE+x6LA9JhY1eytJKSG14aTC/KvjYA1n gjRa5pf0opTGYsQOJAhOHxgr15AJXj9sfeSKMd5XroMv52TCQgRkb0VoaDoZ7IBXq97v aw8aj0jbzaySkiFHq/CcsyQl8tAs8gEdCDPa3DgVSik6vPjiWbrz6fWg/2rzp9h/8uh8 vXNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=II3Z/ePw+kluHJAh79jkfAHhBKN0+PEn+7sKnI4/9O4=; b=oyjP3LRkn7nNKmgUOrO7+GXZ6vxuENB69sBmQwtY2qDhndRXN2Ky7ZusxRm/GJXiYK 4ZI1pSFcxov6/J07ygYTxEtQWeFlM3+6eCRm/dvuCvlRnF/cV1tNv8sXDJrgL6qtfZ4g 0ggPU3o/15M7+5HgPhpTbcPdBgdfeBklWxUjMvbMfXRi8akaasuLtJOI1EKPr/SDeqfK wsd6RHD6B9dV6AZDdHiWyeYpVtcSmVHzTWb5++vyjYucXeTARx1Mz2fdB0ufSckDyDUq ivKeOsEgTf+ho7yldU0riDZSWRB3QbCdRnA7gN5hA7J12IY1JlYTLCkECR9YNsvFc9xp 9Ejw== X-Gm-Message-State: APjAAAX2Hmfn4JJz0+xxq5NRVvmEjRV21DHjLPg5PxPRB8+4t0eTxf1h q4J31JaogcGn7MOGqlN4ErE= X-Google-Smtp-Source: APXvYqyL7wQoJ473oflZEdH5F1MQH5u5UVaHY3bRwruszPd0fFxVNFp6Y7enr88bqIkoM2DZxCPn8Q== X-Received: by 2002:a6b:7509:: with SMTP id l9mr127293ioh.34.1569246317680; Mon, 23 Sep 2019 06:45:17 -0700 (PDT) Received: from aford-OptiPlex-7050.logicpd.com ([174.46.170.158]) by smtp.gmail.com with ESMTPSA id x2sm8844474iob.74.2019.09.23.06.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 06:45:15 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Cc: linux-omap@vger.kernel.org, adam.ford@logicpd.com, Adam Ford , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel Date: Mon, 23 Sep 2019 08:44:49 -0500 Message-Id: <20190923134449.22326-3-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190923134449.22326-1-aford173@gmail.com> References: <20190923134449.22326-1-aford173@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg --- V2: Remove legacy 'label' from binding diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts index 07ac99b9cda6..cdb89b3e2a9b 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts @@ -11,22 +11,6 @@ #include "logicpd-torpedo-37xx-devkit.dts" &lcd0 { - - label = "28"; - - panel-timing { - clock-frequency = <9000000>; - hactive = <480>; - vactive = <272>; - hfront-porch = <3>; - hback-porch = <2>; - hsync-len = <42>; - vback-porch = <3>; - vfront-porch = <2>; - vsync-len = <11>; - hsync-active = <1>; - vsync-active = <1>; - de-active = <1>; - pixelclk-active = <0>; - }; + /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */ + compatible = "logicpd,type28"; };