From patchwork Tue Sep 11 20:06:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Blain via GitGitGadget X-Patchwork-Id: 10596231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3766B14E0 for ; Tue, 11 Sep 2018 20:06:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2204629DE6 for ; Tue, 11 Sep 2018 20:06:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1453D29DF3; Tue, 11 Sep 2018 20:06:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D9C7829CE2 for ; Tue, 11 Sep 2018 20:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727409AbeILBG4 (ORCPT ); Tue, 11 Sep 2018 21:06:56 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:43408 "EHLO mail-pf1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbeILBGz (ORCPT ); Tue, 11 Sep 2018 21:06:55 -0400 Received: by mail-pf1-f178.google.com with SMTP id j26-v6so12753063pfi.10 for ; Tue, 11 Sep 2018 13:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:in-reply-to:references:from:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=8DeR8mfKxdGNHuVI4yZjPCpc4dM/U91ZPGF8eizlR4A=; b=XGDhy+am6sRG5tAYNDybFZ/4Zop5qj9YB9tt4Xn77JPHi1qRGmpIxf5RFAsbEp0+Ce ysAuH5dZdCf6rTv86xGUq+jgcj6xpgDPJMccqskV0fOxNX4KicJkSmXEJLTvsmMFYgzV WaWIB/DpeFDwSrdAoC1nQgKdD+ed+WJV+d/1r0tDJuuFUgL4BeM5YF7g2s+oCpLH4XSM K4DeCC/r31RBThQLt1Ba0bIAMtDH6ydOXdu9agX7Bl05tFE6ULFFrVLx9dBeysysfiyU xvKz3bIlHMeEvD6Da6MFW5ZkzSWjBkxXl9rWyRNtmZXER7HbJPxZzXTPCs9p9ApPotr4 jBkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:in-reply-to:references:from :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=8DeR8mfKxdGNHuVI4yZjPCpc4dM/U91ZPGF8eizlR4A=; b=S4zfyobpWNDiX0n3spV9nifIwyMy5zaNHIiPYW7ddDIRB6h/g2KbXlW6Skk32rE4/4 DhRENW8Tazl/V63p0W0abKP2ykidrjQp4wMIxvepEYA7hxbjCWRY4B02uiJ/DqnbNJi2 ZdFcTEjdnwuKIbT3Sexy/5w0asnte9PgQ9Q5vIOqgGGnFKlFnI0ye3IUcyPGW+dAAvWX Ze9sjOFfxnlgUHzsFC7U3QCLzVAFvpWlc+m9RFzTa4xOL6JAX7aXzS2TxhgOexRTCYxa v14/dqYcD9xp2ZG8UA+E+PJEVDkASy6+5XjxFvCVljpxenCefpML4Rw8WesBZzHABqLt AUiw== X-Gm-Message-State: APzg51CIFDvM0JKIwKmN4Trx1E6Z7ZRT3m9dGTAQKq37FgJpLMUMh4z5 uZgWZUnvmVUit7mZSQN4Cbu0vqES X-Google-Smtp-Source: ANB0VdY+TpayvEaTD/8esogpuKnd7NkuZ4vFcV2g7TLzmmldCfMk58dvnw0FAoRdqsj6jIEyIfwQ2g== X-Received: by 2002:a62:8186:: with SMTP id t128-v6mr30754259pfd.192.1536696362297; Tue, 11 Sep 2018 13:06:02 -0700 (PDT) Received: from [127.0.0.1] ([40.112.142.204]) by smtp.gmail.com with ESMTPSA id a72-v6sm37971126pge.85.2018.09.11.13.06.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Sep 2018 13:06:01 -0700 (PDT) Date: Tue, 11 Sep 2018 13:06:01 -0700 (PDT) X-Google-Original-Date: Tue, 11 Sep 2018 20:05:56 GMT Message-Id: In-Reply-To: References: From: "Jeff Hostetler via GitGitGadget" Subject: [PATCH v3 1/2] t0051: test GIT_TRACE to a windows named pipe Fcc: Sent MIME-Version: 1.0 To: git@vger.kernel.org Cc: jeffhost@microsoft.com, Junio C Hamano , Jeff Hostetler Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jeff Hostetler Create a test-tool helper to create the server side of a windows named pipe, wait for a client connection, and copy data written to the pipe to stdout. Create t0051 test to route GIT_TRACE output of a command to a named pipe using the above test-tool helper. Signed-off-by: Jeff Hostetler --- Makefile | 1 + t/helper/test-tool.c | 3 ++ t/helper/test-tool.h | 3 ++ t/helper/test-windows-named-pipe.c | 72 ++++++++++++++++++++++++++++++ t/t0051-windows-named-pipe.sh | 17 +++++++ 5 files changed, 96 insertions(+) create mode 100644 t/helper/test-windows-named-pipe.c create mode 100755 t/t0051-windows-named-pipe.sh diff --git a/Makefile b/Makefile index e4b503d259..b1b934d295 100644 --- a/Makefile +++ b/Makefile @@ -731,6 +731,7 @@ TEST_BUILTINS_OBJS += test-submodule-config.o TEST_BUILTINS_OBJS += test-subprocess.o TEST_BUILTINS_OBJS += test-urlmatch-normalization.o TEST_BUILTINS_OBJS += test-wildmatch.o +TEST_BUILTINS_OBJS += test-windows-named-pipe.o TEST_BUILTINS_OBJS += test-write-cache.o TEST_PROGRAMS_NEED_X += test-dump-fsmonitor diff --git a/t/helper/test-tool.c b/t/helper/test-tool.c index 805a45de9c..7a9764cd5c 100644 --- a/t/helper/test-tool.c +++ b/t/helper/test-tool.c @@ -41,6 +41,9 @@ static struct test_cmd cmds[] = { { "subprocess", cmd__subprocess }, { "urlmatch-normalization", cmd__urlmatch_normalization }, { "wildmatch", cmd__wildmatch }, +#ifdef GIT_WINDOWS_NATIVE + { "windows-named-pipe", cmd__windows_named_pipe }, +#endif { "write-cache", cmd__write_cache }, }; diff --git a/t/helper/test-tool.h b/t/helper/test-tool.h index 7116ddfb94..01c34fe5e7 100644 --- a/t/helper/test-tool.h +++ b/t/helper/test-tool.h @@ -35,6 +35,9 @@ int cmd__submodule_config(int argc, const char **argv); int cmd__subprocess(int argc, const char **argv); int cmd__urlmatch_normalization(int argc, const char **argv); int cmd__wildmatch(int argc, const char **argv); +#ifdef GIT_WINDOWS_NATIVE +int cmd__windows_named_pipe(int argc, const char **argv); +#endif int cmd__write_cache(int argc, const char **argv); #endif diff --git a/t/helper/test-windows-named-pipe.c b/t/helper/test-windows-named-pipe.c new file mode 100644 index 0000000000..b4b752b01a --- /dev/null +++ b/t/helper/test-windows-named-pipe.c @@ -0,0 +1,72 @@ +#include "test-tool.h" +#include "git-compat-util.h" +#include "strbuf.h" + +#ifdef GIT_WINDOWS_NATIVE +static const char *usage_string = ""; + +#define TEST_BUFSIZE (4096) + +int cmd__windows_named_pipe(int argc, const char **argv) +{ + const char *filename; + struct strbuf pathname = STRBUF_INIT; + int err; + HANDLE h; + BOOL connected; + char buf[TEST_BUFSIZE + 1]; + + if (argc < 2) + goto print_usage; + filename = argv[1]; + if (strchr(filename, '/') || strchr(filename, '\\')) + goto print_usage; + strbuf_addf(&pathname, "//./pipe/%s", filename); + + /* + * Create a single instance of the server side of the named pipe. + * This will allow exactly one client instance to connect to it. + */ + h = CreateNamedPipeA( + pathname.buf, + PIPE_ACCESS_INBOUND | FILE_FLAG_FIRST_PIPE_INSTANCE, + PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT, + PIPE_UNLIMITED_INSTANCES, + TEST_BUFSIZE, TEST_BUFSIZE, 0, NULL); + if (h == INVALID_HANDLE_VALUE) { + err = err_win_to_posix(GetLastError()); + fprintf(stderr, "CreateNamedPipe failed: %s\n", + strerror(err)); + return err; + } + + connected = ConnectNamedPipe(h, NULL) + ? TRUE + : (GetLastError() == ERROR_PIPE_CONNECTED); + if (!connected) { + err = err_win_to_posix(GetLastError()); + fprintf(stderr, "ConnectNamedPipe failed: %s\n", + strerror(err)); + CloseHandle(h); + return err; + } + + while (1) { + DWORD nbr; + BOOL success = ReadFile(h, buf, TEST_BUFSIZE, &nbr, NULL); + if (!success || nbr == 0) + break; + buf[nbr] = 0; + + write(1, buf, nbr); + } + + DisconnectNamedPipe(h); + CloseHandle(h); + return 0; + +print_usage: + fprintf(stderr, "usage: %s %s\n", argv[0], usage_string); + return 1; +} +#endif diff --git a/t/t0051-windows-named-pipe.sh b/t/t0051-windows-named-pipe.sh new file mode 100755 index 0000000000..e3c36341a0 --- /dev/null +++ b/t/t0051-windows-named-pipe.sh @@ -0,0 +1,17 @@ +#!/bin/sh + +test_description='Windows named pipes' + +. ./test-lib.sh + +test_expect_failure MINGW 'o_append write to named pipe' ' + GIT_TRACE="$(pwd)/expect" git status >/dev/null 2>&1 && + { test-tool windows-named-pipe t0051 >actual 2>&1 & } && + pid=$! && + sleep 1 && + GIT_TRACE=//./pipe/t0051 git status >/dev/null 2>warning && + wait $pid && + test_cmp expect actual +' + +test_done From patchwork Tue Sep 11 20:06:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Blain via GitGitGadget X-Patchwork-Id: 10596233 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4BA8414E5 for ; Tue, 11 Sep 2018 20:06:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3771429CE2 for ; Tue, 11 Sep 2018 20:06:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2BD9829E02; Tue, 11 Sep 2018 20:06:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7965E29D75 for ; Tue, 11 Sep 2018 20:06:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728198AbeILBG6 (ORCPT ); Tue, 11 Sep 2018 21:06:58 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:39687 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbeILBG5 (ORCPT ); Tue, 11 Sep 2018 21:06:57 -0400 Received: by mail-pl1-f194.google.com with SMTP id w14-v6so11818182plp.6 for ; Tue, 11 Sep 2018 13:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:in-reply-to:references:from:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=Agjw7Y9zGnVQmRvQGkvEZo0zdVClO8jtCf/ymvKo1wM=; b=oQ49JCHjJElDiaxgmDl3UmbA/IgvxkEtTFNgu62vt9LuqdzF5jzFBR6HcC7bS1Y3a1 8YfHL7f5Ix2vjLYpFUFhFJn+1j3zlIUA32LhoJ6pPLtdlpcuJe7dOQk4YkCLThkMry6z vVtUI6SkJdH1dlvJhuxLi5oLyWxr5aTCibxBzua0CHCp3dKdavk6nNfMUKn/XCvklSoW zwGEkcupxR+kNZQJcpvBLcHfqAohVRp6fxbhciXzN1jkNGJaj938jCMXvakbujzS+9AW G8fBd0PSyO2r+OAYz0WKN90UgZ9LRVDB4o0DSHaDbYSdLgk7D5MEzEUq8obFTrva06ts 6jHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:in-reply-to:references:from :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=Agjw7Y9zGnVQmRvQGkvEZo0zdVClO8jtCf/ymvKo1wM=; b=HGo3PmBIGFwWHjZCGLr6EPh8t/7b6JoRawPPuoEwpGMez6kSX7P/LrmH+R0JPR9HvC DPdi5x8LSkUaoXaL5IpUTqa9bLaTFR+yjnOUVtZH/abVO559Qvz9WpSAVyLmqgyfyujk QnIpw6aZAAWSE8lYPGPwMprifhZbGozoQlAPAcHQwVtGtDeuZyuEyZUbBxSwJFvjPHIK GELt5jLmIRib0qfJSUbFkNY51hDMqXk3F3k6nEKNmMh8zPRjIA1R57CLmAxqCjoyl3tn LdKcG8OFcgf7PwEmhKuHeqqt1LKZBhR+KSPGCydP/MHEM7i54jd6RNw/RHYRbhJ6bJwU 8myw== X-Gm-Message-State: APzg51DMq0ttoPQDuwzDTPl8Yrv+K58VFeXY1J/H798hlA03W+zfCkFK yWhAj3UjT1g1bTfCKyZh8fWCukxe X-Google-Smtp-Source: ANB0VdYZuUnhi+aep0sZK9Ub5+QOL8ZGPSJuMaFBnpYL7kDYLmxhxYboXVBolW0+0dKR6FJ6iyfa7Q== X-Received: by 2002:a17:902:2f43:: with SMTP id s61-v6mr28426771plb.176.1536696364009; Tue, 11 Sep 2018 13:06:04 -0700 (PDT) Received: from [127.0.0.1] ([40.112.142.204]) by smtp.gmail.com with ESMTPSA id t1-v6sm20788904pgp.32.2018.09.11.13.06.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Sep 2018 13:06:02 -0700 (PDT) Date: Tue, 11 Sep 2018 13:06:02 -0700 (PDT) X-Google-Original-Date: Tue, 11 Sep 2018 20:05:57 GMT Message-Id: <5592300ca526422ed3a5cf000e9e574cc97b252d.1536696358.git.gitgitgadget@gmail.com> In-Reply-To: References: From: "Jeff Hostetler via GitGitGadget" Subject: [PATCH v3 2/2] mingw: fix mingw_open_append to work with named pipes Fcc: Sent MIME-Version: 1.0 To: git@vger.kernel.org Cc: jeffhost@microsoft.com, Junio C Hamano , Jeff Hostetler Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- compat/mingw.c | 36 ++++++++++++++++++++++++++++++++--- t/t0051-windows-named-pipe.sh | 2 +- 2 files changed, 34 insertions(+), 4 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..18caf21969 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -341,6 +341,19 @@ int mingw_mkdir(const char *path, int mode) return ret; } +/* + * Calling CreateFile() using FILE_APPEND_DATA and without FILE_WRITE_DATA + * is documented in [1] as opening a writable file handle in append mode. + * (It is believed that) this is atomic since it is maintained by the + * kernel unlike the O_APPEND flag which is racily maintained by the CRT. + * + * [1] https://docs.microsoft.com/en-us/windows/desktop/fileio/file-access-rights-constants + * + * This trick does not appear to work for named pipes. Instead it creates + * a named pipe client handle that cannot be written to. Callers should + * just use the regular _wopen() for them. (And since client handle gets + * bound to a unique server handle, it isn't really an issue.) + */ static int mingw_open_append(wchar_t const *wfilename, int oflags, ...) { HANDLE handle; @@ -360,10 +373,12 @@ static int mingw_open_append(wchar_t const *wfilename, int oflags, ...) NULL, create, FILE_ATTRIBUTE_NORMAL, NULL); if (handle == INVALID_HANDLE_VALUE) return errno = err_win_to_posix(GetLastError()), -1; + /* * No O_APPEND here, because the CRT uses it only to reset the - * file pointer to EOF on write(); but that is not necessary - * for a file created with FILE_APPEND_DATA. + * file pointer to EOF before each write(); but that is not + * necessary (and may lead to races) for a file created with + * FILE_APPEND_DATA. */ fd = _open_osfhandle((intptr_t)handle, O_BINARY); if (fd < 0) @@ -371,6 +386,21 @@ static int mingw_open_append(wchar_t const *wfilename, int oflags, ...) return fd; } +/* + * Does the pathname map to the local named pipe filesystem? + * That is, does it have a "//./pipe/" prefix? + */ +static int is_local_named_pipe_path(const char *filename) +{ + return (is_dir_sep(filename[0]) && + is_dir_sep(filename[1]) && + filename[2] == '.' && + is_dir_sep(filename[3]) && + !strncasecmp(filename+4, "pipe", 4) && + is_dir_sep(filename[8]) && + filename[9]); +} + int mingw_open (const char *filename, int oflags, ...) { typedef int (*open_fn_t)(wchar_t const *wfilename, int oflags, ...); @@ -387,7 +417,7 @@ int mingw_open (const char *filename, int oflags, ...) if (filename && !strcmp(filename, "/dev/null")) filename = "nul"; - if (oflags & O_APPEND) + if ((oflags & O_APPEND) && !is_local_named_pipe_path(filename)) open_fn = mingw_open_append; else open_fn = _wopen; diff --git a/t/t0051-windows-named-pipe.sh b/t/t0051-windows-named-pipe.sh index e3c36341a0..10ac92d225 100755 --- a/t/t0051-windows-named-pipe.sh +++ b/t/t0051-windows-named-pipe.sh @@ -4,7 +4,7 @@ test_description='Windows named pipes' . ./test-lib.sh -test_expect_failure MINGW 'o_append write to named pipe' ' +test_expect_success MINGW 'o_append write to named pipe' ' GIT_TRACE="$(pwd)/expect" git status >/dev/null 2>&1 && { test-tool windows-named-pipe t0051 >actual 2>&1 & } && pid=$! &&